73828 2011-12-05 07:02:22 -0800 [Qt] Remove viewModeChanged() from QQuickWebView 2011-12-05 08:18:12 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 laszlo.gombos webkit-unassigned hausmann laszlo.gombos vestbo webkit.review.bot zoltan oldest_to_newest 515057 0 laszlo.gombos 2011-12-05 07:02:22 -0800 It seems that viewModeChanged() is a leftover from a recent refactoring and we should not want to expose it in QQuickWebView. 515060 1 117873 laszlo.gombos 2011-12-05 07:15:25 -0800 Created attachment 117873 proposed change 515094 2 117873 webkit.review.bot 2011-12-05 08:18:08 -0800 Comment on attachment 117873 proposed change Clearing flags on attachment: 117873 Committed r102002: <http://trac.webkit.org/changeset/102002> 515095 3 webkit.review.bot 2011-12-05 08:18:12 -0800 All reviewed patches have been landed. Closing bug. 117873 2011-12-05 07:15:25 -0800 2011-12-05 08:18:07 -0800 proposed change 73828.patch text/plain 1188 laszlo.gombos ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwOTVjMjVkLi5mNzBiMTRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMTItMDUgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29t PgorCisgICAgICAgIFtRdF0gUmVtb3ZlIHZpZXdNb2RlQ2hhbmdlZCgpIGZyb20gUVF1aWNrV2Vi VmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM4 MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wLmg6IHZpZXdNb2RlQ2hhbmdlZCBpcyBub3Qg dXNlZAorICAgICAgICBhbmQgd2Ugc2hvdWxkIG5vdCBleHBvc2UgaXQuCisKIDIwMTEtMTItMDUg IEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViS2l0 MiBwYXJ0IG9mOiBBZGQgV2ViS2l0IHByZWZlcmVuY2VzIGZvciB0ZXh0IHRyYWNrIHNldHRpbmdz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZp ZXdfcC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3Au aAppbmRleCA5YTFjODQyLi42N2IwOGZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wLmgKQEAgLTExMSw3ICsxMTEsNiBAQCBRX1NJR05B TFM6CiAgICAgdm9pZCB1cmxDaGFuZ2VkKGNvbnN0IFFVcmwmIHVybCk7CiAgICAgdm9pZCBtZXNz YWdlUmVjZWl2ZWQoY29uc3QgUVZhcmlhbnRNYXAmIG1lc3NhZ2UpOwogICAgIHZvaWQgbGlua0hv dmVyZWQoY29uc3QgUVVybCYgdXJsLCBjb25zdCBRU3RyaW5nJiB0aXRsZSk7Ci0gICAgdm9pZCB2 aWV3TW9kZUNoYW5nZWQoKTsKICAgICB2b2lkIG5hdmlnYXRpb25TdGF0ZUNoYW5nZWQoKTsKICAg ICB2b2lkIG5hdmlnYXRpb25SZXF1ZXN0ZWQoUU9iamVjdCogcmVxdWVzdCk7CiAK