73813 2011-12-05 03:03:02 -0800 [Qt] Rename QQuickWebView::canStop property to just loading 2012-02-20 02:57:53 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 hausmann michael.bruning cmarcelo dglazkov gopal.1.raghavan jesus laszlo.gombos menard vestbo webkit.review.bot zoltan oldest_to_newest 514998 0 hausmann 2011-12-05 03:03:02 -0800 See summary, I think "loading" is a better name than "canStop" Let the bike-shedding begin :) 515093 1 117882 michael.bruning 2011-12-05 08:15:20 -0800 Created attachment 117882 Patch Proposed patch based on summary. 515177 2 117882 jesus 2011-12-05 10:38:22 -0800 Comment on attachment 117882 Patch LGTM. Perhaps you forgot to ask for a proper review, Michael? Changing flags for the patch. 515237 3 117882 webkit.review.bot 2011-12-05 11:25:21 -0800 Comment on attachment 117882 Patch Attachment 117882 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10689688 New failing tests: svg/custom/linking-uri-01-b.svg 515273 4 117882 kenneth 2011-12-05 12:17:12 -0800 Comment on attachment 117882 Patch This is all in wb2 so the chromium error must be due to flakiness 515338 5 117882 webkit.review.bot 2011-12-05 13:16:17 -0800 Comment on attachment 117882 Patch Clearing flags on attachment: 117882 Committed r102035: <http://trac.webkit.org/changeset/102035> 515339 6 webkit.review.bot 2011-12-05 13:16:22 -0800 All reviewed patches have been landed. Closing bug. 515732 7 hausmann 2011-12-06 01:51:48 -0800 I was serious about the bike-shedding. We should discuss the options here. It _may_ seem that loading is a better name, but there are also arguments against it. Tor Arne is looking into what we did in Grob and what fits best there. Michael not setting r? was intentional. 515757 8 jesus 2011-12-06 02:35:49 -0800 (In reply to comment #7) > I was serious about the bike-shedding. We should discuss the options here. It _may_ seem that loading is a better name, but there are also arguments against it. Tor Arne is looking into what we did in Grob and what fits best there. > When I looked at the patch "loading" made way more sense than "canStop". Plus, I remember seeing "loading" as property on other mobile webview APIs before, perhaps on the iOS one, and that also motivated me. > Michael not setting r? was intentional. I'm truly sorry, Simon, I didn't realize it. It was a legitimate mistake. Whatever we decide here, I will make the needed changes. 560137 9 hausmann 2012-02-20 02:57:53 -0800 As part of the API review session at the meeting in Szeged we decided to keep "loading". See also bug #78820 for related changes. 117882 2011-12-05 08:15:20 -0800 2011-12-05 13:16:17 -0800 Patch patch.txt text/plain 8470 michael.bruning RnJvbSAwMjBlNTYxNTFiNDNiZTc5NzI2NzMxNzUzODQ4NDU3ZDIwN2RjYjM0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/TWljaGFlbD0yMEJyPUMzPUJDbmluZz89IDxt aWNoYWVsLmJydW5pbmdAbm9raWEuY29tPgpEYXRlOiBNb24sIDUgRGVjIDIwMTEgMTc6MTA6MjAg KzAxMDAKU3ViamVjdDogW1BBVENIXSBbUXRdIFJlbmFtZSBRUXVpY2tXZWJWaWV3OjpjYW5TdG9w IHByb3BlcnR5IHRvIGp1c3QgbG9hZGluZwogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTczODEzCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KClJlbmFtZWQgY2Fu U3RvcCBwcm9wZXJ0eSBvZiBRUXVpY2tXZWJWaWV3IGFuZCBRdFdlYlBhZ2VQcm94eQp0byBsb2Fk aW5nIGFuZCB1cGRhdGVkIEFQSSB0ZXN0cy4KClJlcGxhY2VkIHJlZmVyZW5jZXMgdG8gV2ViVmll dy5jYW5TdG9wIGluIE1pbmlCcm93c2VyCndpdGggV2ViVmlldy5sb2FkaW5nLgoKU291cmNlcy9X ZWJLaXQyOgoqIFVJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHA6CihRUXVpY2tXZWJW aWV3Ojpsb2FkaW5nKToKKiBVSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcC5oOgoqIFVJ UHJvY2Vzcy9BUEkvcXQvdGVzdHMvcXF1aWNrd2Vidmlldy90c3RfcXF1aWNrd2Vidmlldy5jcHA6 Cih0c3RfUVF1aWNrV2ViVmlldzo6bmF2aWdhdGlvblN0YXR1c0F0U3RhcnR1cCk6CihMb2FkU3Rh cnRlZENhdGNoZXI6Om9uTG9hZFN0YXJ0ZWQpOgoodHN0X1FRdWlja1dlYlZpZXc6OnN0b3BFbmFi bGVkQWZ0ZXJMb2FkU3RhcnRlZCk6CiogVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVByb3h5LmNwcDoK KFF0V2ViUGFnZVByb3h5Ojpsb2FkaW5nKToKKiBVSVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHku aDoKClRvb2xzOgoqIE1pbmlCcm93c2VyL3F0L3FtbC9Ccm93c2VyV2luZG93LnFtbDoKLS0tCiBT b3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMjEg KysrKysrKysrKysrKysrKysrKysKIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1 aWNrd2Vidmlldy5jcHAgIHwgICAgNCArLQogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9x dC9xcXVpY2t3ZWJ2aWV3X3AuaCAgfCAgICA0ICstCiAuLi4vcXQvdGVzdHMvcXF1aWNrd2Vidmll dy90c3RfcXF1aWNrd2Vidmlldy5jcHAgICB8ICAgIDggKysrLS0tCiBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHkuY3BwICAgICB8ICAgIDIgKy0KIFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VQcm94eS5oICAgICAgIHwgICAgMiArLQogVG9vbHMv Q2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDExICsrKysr KysrKysKIFRvb2xzL01pbmlCcm93c2VyL3F0L3FtbC9Ccm93c2VyV2luZG93LnFtbCAgICAgICAg IHwgICAgNCArLQogOCBmaWxlcyBjaGFuZ2VkLCA0NCBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDk1YzI1ZC4uODMyNDljNiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDI0IEBACisyMDExLTEyLTA1ICBNaWNoYWVsIEJyw7xuaW5nICA8bWljaGFlbC5icnVuaW5n QG5va2lhLmNvbT4KKworICAgICAgICBbUXRdIFJlbmFtZSBRUXVpY2tXZWJWaWV3OjpjYW5TdG9w IHByb3BlcnR5IHRvIGp1c3QgbG9hZGluZyAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTczODEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUmVuYW1lZCBjYW5TdG9wIHByb3BlcnR5IG9mIFFRdWlja1dlYlZp ZXcgYW5kIFF0V2ViUGFnZVByb3h5CisgICAgICAgIHRvIGxvYWRpbmcgYW5kIHVwZGF0ZWQgdGVz dHMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwOgorICAg ICAgICAoUVF1aWNrV2ViVmlldzo6bG9hZGluZyk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9x dC9xcXVpY2t3ZWJ2aWV3X3AuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3Fx dWlja3dlYnZpZXcvdHN0X3FxdWlja3dlYnZpZXcuY3BwOgorICAgICAgICAodHN0X1FRdWlja1dl YlZpZXc6Om5hdmlnYXRpb25TdGF0dXNBdFN0YXJ0dXApOgorICAgICAgICAoTG9hZFN0YXJ0ZWRD YXRjaGVyOjpvbkxvYWRTdGFydGVkKToKKyAgICAgICAgKHRzdF9RUXVpY2tXZWJWaWV3OjpzdG9w RW5hYmxlZEFmdGVyTG9hZFN0YXJ0ZWQpOgorICAgICAgICAqIFVJUHJvY2Vzcy9xdC9RdFdlYlBh Z2VQcm94eS5jcHA6CisgICAgICAgIChRdFdlYlBhZ2VQcm94eTo6bG9hZGluZyk6CisgICAgICAg ICogVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVByb3h5Lmg6CisKIDIwMTEtMTItMDUgIEVyaWMgQ2Fy bHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViS2l0MiBwYXJ0IG9m OiBBZGQgV2ViS2l0IHByZWZlcmVuY2VzIGZvciB0ZXh0IHRyYWNrIHNldHRpbmdzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAppbmRleCAz YTBmOWRlLi5iMTQ3ODgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L3F0L3FxdWlja3dlYnZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv cXQvcXF1aWNrd2Vidmlldy5jcHAKQEAgLTU3NiwxMCArNTc2LDEwIEBAIGJvb2wgUVF1aWNrV2Vi Vmlldzo6Y2FuR29Gb3J3YXJkKCkgY29uc3QKICAgICByZXR1cm4gZC0+cGFnZVByb3h5LT5jYW5H b0ZvcndhcmQoKTsKIH0KIAotYm9vbCBRUXVpY2tXZWJWaWV3OjpjYW5TdG9wKCkgY29uc3QKK2Jv b2wgUVF1aWNrV2ViVmlldzo6bG9hZGluZygpIGNvbnN0CiB7CiAgICAgUV9EKGNvbnN0IFFRdWlj a1dlYlZpZXcpOwotICAgIHJldHVybiBkLT5wYWdlUHJveHktPmNhblN0b3AoKTsKKyAgICByZXR1 cm4gZC0+cGFnZVByb3h5LT5sb2FkaW5nKCk7CiB9CiAKIGJvb2wgUVF1aWNrV2ViVmlldzo6Y2Fu UmVsb2FkKCkgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv cXQvcXF1aWNrd2Vidmlld19wLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Fx dWlja3dlYnZpZXdfcC5oCmluZGV4IDlhMWM4NDIuLjQ4MzU5MDQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wLmgKKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3AuaApAQCAtNTMsNyArNTMs NyBAQCBjbGFzcyBRV0VCS0lUX0VYUE9SVCBRUXVpY2tXZWJWaWV3IDogcHVibGljIFFRdWlja0l0 ZW0gewogICAgIFFfUFJPUEVSVFkoaW50IGxvYWRQcm9ncmVzcyBSRUFEIGxvYWRQcm9ncmVzcyBO T1RJRlkgbG9hZFByb2dyZXNzQ2hhbmdlZCkKICAgICBRX1BST1BFUlRZKGJvb2wgY2FuR29CYWNr IFJFQUQgY2FuR29CYWNrIE5PVElGWSBuYXZpZ2F0aW9uU3RhdGVDaGFuZ2VkIEZJTkFMKQogICAg IFFfUFJPUEVSVFkoYm9vbCBjYW5Hb0ZvcndhcmQgUkVBRCBjYW5Hb0ZvcndhcmQgTk9USUZZIG5h dmlnYXRpb25TdGF0ZUNoYW5nZWQgRklOQUwpCi0gICAgUV9QUk9QRVJUWShib29sIGNhblN0b3Ag UkVBRCBjYW5TdG9wIE5PVElGWSBuYXZpZ2F0aW9uU3RhdGVDaGFuZ2VkIEZJTkFMKQorICAgIFFf UFJPUEVSVFkoYm9vbCBsb2FkaW5nIFJFQUQgbG9hZGluZyBOT1RJRlkgbmF2aWdhdGlvblN0YXRl Q2hhbmdlZCBGSU5BTCkKICAgICBRX1BST1BFUlRZKGJvb2wgY2FuUmVsb2FkIFJFQUQgY2FuUmVs b2FkIE5PVElGWSBuYXZpZ2F0aW9uU3RhdGVDaGFuZ2VkIEZJTkFMKQogICAgIFFfUFJPUEVSVFko UVdlYlByZWZlcmVuY2VzKiBwcmVmZXJlbmNlcyBSRUFEIHByZWZlcmVuY2VzIENPTlNUQU5UIEZJ TkFMKQogICAgIFFfUFJPUEVSVFkoUVF1aWNrV2ViUGFnZSogcGFnZSBSRUFEIHBhZ2UgQ09OU1RB TlQgRklOQUwpCkBAIC04Miw3ICs4Miw3IEBAIHB1YmxpYzoKIAogICAgIGJvb2wgY2FuR29CYWNr KCkgY29uc3Q7CiAgICAgYm9vbCBjYW5Hb0ZvcndhcmQoKSBjb25zdDsKLSAgICBib29sIGNhblN0 b3AoKSBjb25zdDsKKyAgICBib29sIGxvYWRpbmcoKSBjb25zdDsKICAgICBib29sIGNhblJlbG9h ZCgpIGNvbnN0OwogCiAgICAgUVdlYlByZWZlcmVuY2VzKiBwcmVmZXJlbmNlcygpIGNvbnN0Owpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xcXVpY2t3 ZWJ2aWV3L3RzdF9xcXVpY2t3ZWJ2aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvcXQvdGVzdHMvcXF1aWNrd2Vidmlldy90c3RfcXF1aWNrd2Vidmlldy5jcHAKaW5kZXggN2Y0 MTM3OC4uMmVmOWQxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9x dC90ZXN0cy9xcXVpY2t3ZWJ2aWV3L3RzdF9xcXVpY2t3ZWJ2aWV3LmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FxdWlja3dlYnZpZXcvdHN0X3FxdWlja3dl YnZpZXcuY3BwCkBAIC05Miw3ICs5Miw3IEBAIHZvaWQgdHN0X1FRdWlja1dlYlZpZXc6Om5hdmln YXRpb25TdGF0dXNBdFN0YXJ0dXAoKQogCiAgICAgUUNPTVBBUkUod2ViVmlldygpLT5jYW5Hb0Zv cndhcmQoKSwgZmFsc2UpOwogCi0gICAgUUNPTVBBUkUod2ViVmlldygpLT5jYW5TdG9wKCksIGZh bHNlKTsKKyAgICBRQ09NUEFSRSh3ZWJWaWV3KCktPmxvYWRpbmcoKSwgZmFsc2UpOwogCiAgICAg UUNPTVBBUkUod2ViVmlldygpLT5jYW5SZWxvYWQoKSwgZmFsc2UpOwogfQpAQCAtMTExLDcgKzEx MSw3IEBAIHB1YmxpYyBzbG90czoKICAgICB7CiAgICAgICAgIFFNZXRhT2JqZWN0OjppbnZva2VN ZXRob2QodGhpcywgImZpbmlzaGVkIiwgUXQ6OlF1ZXVlZENvbm5lY3Rpb24pOwogCi0gICAgICAg IFFDT01QQVJFKG1fd2ViVmlldy0+Y2FuU3RvcCgpLCB0cnVlKTsKKyAgICAgICAgUUNPTVBBUkUo bV93ZWJWaWV3LT5sb2FkaW5nKCksIHRydWUpOwogICAgIH0KIAogc2lnbmFsczoKQEAgLTEyMywx MyArMTIzLDEzIEBAIHByaXZhdGU6CiAKIHZvaWQgdHN0X1FRdWlja1dlYlZpZXc6OnN0b3BFbmFi bGVkQWZ0ZXJMb2FkU3RhcnRlZCgpCiB7Ci0gICAgUUNPTVBBUkUod2ViVmlldygpLT5jYW5TdG9w KCksIGZhbHNlKTsKKyAgICBRQ09NUEFSRSh3ZWJWaWV3KCktPmxvYWRpbmcoKSwgZmFsc2UpOwog CiAgICAgTG9hZFN0YXJ0ZWRDYXRjaGVyIGNhdGNoZXIod2ViVmlldygpKTsKICAgICB3ZWJWaWV3 KCktPmxvYWQoUVVybDo6ZnJvbUxvY2FsRmlsZShRTGF0aW4xU3RyaW5nKFRFU1RTX1NPVVJDRV9E SVIgIi9odG1sL2Jhc2ljX3BhZ2UuaHRtbCIpKSk7CiAgICAgd2FpdEZvclNpZ25hbCgmY2F0Y2hl ciwgU0lHTkFMKGZpbmlzaGVkKCkpKTsKIAotICAgIFFDT01QQVJFKHdlYlZpZXcoKS0+Y2FuU3Rv cCgpLCB0cnVlKTsKKyAgICBRQ09NUEFSRSh3ZWJWaWV3KCktPmxvYWRpbmcoKSwgdHJ1ZSk7CiAK ICAgICB3YWl0Rm9yU2lnbmFsKHdlYlZpZXcoKSwgU0lHTkFMKGxvYWRTdWNjZWVkZWQoKSkpOwog fQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVByb3h5 LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VQcm94eS5jcHAKaW5k ZXggYWIxZGI0Ny4uM2QxZDJiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L3F0L1F0V2ViUGFnZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQv UXRXZWJQYWdlUHJveHkuY3BwCkBAIC0yMTksNyArMjE5LDcgQEAgdm9pZCBRdFdlYlBhZ2VQcm94 eTo6Z29Gb3J3YXJkKCkKICAgICBtX3dlYlBhZ2VQcm94eS0+Z29Gb3J3YXJkKCk7CiB9CiAKLWJv b2wgUXRXZWJQYWdlUHJveHk6OmNhblN0b3AoKSBjb25zdAorYm9vbCBRdFdlYlBhZ2VQcm94eTo6 bG9hZGluZygpIGNvbnN0CiB7CiAgICAgUmVmUHRyPFdlYktpdDo6V2ViRnJhbWVQcm94eT4gbWFp bkZyYW1lID0gbV93ZWJQYWdlUHJveHktPm1haW5GcmFtZSgpOwogICAgIHJldHVybiBtYWluRnJh bWUgJiYgIShXZWJGcmFtZVByb3h5OjpMb2FkU3RhdGVGaW5pc2hlZCA9PSBtYWluRnJhbWUtPmxv YWRTdGF0ZSgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdl YlBhZ2VQcm94eS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVByb3h5 LmgKaW5kZXggMmU2YmU1Ni4uMWU0NTgwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL3F0L1F0V2ViUGFnZVByb3h5LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L3F0L1F0V2ViUGFnZVByb3h5LmgKQEAgLTEwMCw3ICsxMDAsNyBAQCBwdWJsaWM6CiAgICAgdm9p ZCBnb0JhY2soKTsKICAgICBib29sIGNhbkdvRm9yd2FyZCgpIGNvbnN0OwogICAgIHZvaWQgZ29G b3J3YXJkKCk7Ci0gICAgYm9vbCBjYW5TdG9wKCkgY29uc3Q7CisgICAgYm9vbCBsb2FkaW5nKCkg Y29uc3Q7CiAgICAgdm9pZCBzdG9wKCk7CiAgICAgYm9vbCBjYW5SZWxvYWQoKSBjb25zdDsKICAg ICB2b2lkIHJlbG9hZCgpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hh bmdlTG9nCmluZGV4IDFkNDE2MTAuLjlkMTc1NGUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxv ZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMS0xMi0wNSAgTWlj aGFlbCBCcsO8bmluZyAgPG1pY2hhZWwuYnJ1bmluZ0Bub2tpYS5jb20+CisKKyAgICAgICAgW1F0 XSBSZW5hbWUgUVF1aWNrV2ViVmlldzo6Y2FuU3RvcCBwcm9wZXJ0eSB0byBqdXN0IGxvYWRpbmcg CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzgxMwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlcGxhY2Vk IHJlZmVyZW5jZXMgdG8gV2ViVmlldy5jYW5TdG9wIHdpdGggV2ViVmlldy5sb2FkaW5nLgorCisg ICAgICAgICogTWluaUJyb3dzZXIvcXQvcW1sL0Jyb3dzZXJXaW5kb3cucW1sOgorCiAyMDExLTEy LTA1ICBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KIAog ICAgICAgICBbUXRdIE1ha2UgdGhlIFVJIG9mIHRoZSBNaW5pQnJvd3NlciBzbGlnaHRseSBuaWNl cgpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvcXQvcW1sL0Jyb3dzZXJXaW5kb3cucW1s IGIvVG9vbHMvTWluaUJyb3dzZXIvcXQvcW1sL0Jyb3dzZXJXaW5kb3cucW1sCmluZGV4IDIyMDJh ZmQuLjA0ODBhMjYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL3F0L3FtbC9Ccm93c2Vy V2luZG93LnFtbAorKysgYi9Ub29scy9NaW5pQnJvd3Nlci9xdC9xbWwvQnJvd3NlcldpbmRvdy5x bWwKQEAgLTE0MSw3ICsxNDEsNyBAQCBSZWN0YW5nbGUgewogCiAgICAgICAgICAgICAgICAgSW1h Z2UgewogICAgICAgICAgICAgICAgICAgICBhbmNob3JzLmNlbnRlckluOiBwYXJlbnQKLSAgICAg ICAgICAgICAgICAgICAgc291cmNlOiB3ZWJWaWV3LmNhblN0b3AgPyAiLi4vaWNvbnMvc3RvcC5w bmciIDogIi4uL2ljb25zL3JlZnJlc2gucG5nIgorICAgICAgICAgICAgICAgICAgICBzb3VyY2U6 IHdlYlZpZXcubG9hZGluZyA/ICIuLi9pY29ucy9zdG9wLnBuZyIgOiAiLi4vaWNvbnMvcmVmcmVz aC5wbmciCiAgICAgICAgICAgICAgICAgfQogCiAgICAgICAgICAgICAgICAgTW91c2VBcmVhIHsK QEAgLTE0OSw3ICsxNDksNyBAQCBSZWN0YW5nbGUgewogICAgICAgICAgICAgICAgICAgICBvblBy ZXNzZWQ6IHsgcGFyZW50LmNvbG9yID0gIiNjZmNmY2YiIH0KICAgICAgICAgICAgICAgICAgICAg b25SZWxlYXNlZDogeyBwYXJlbnQuY29sb3IgPSAiI2VmZWZlZiIgfQogICAgICAgICAgICAgICAg ICAgICBvbkNsaWNrZWQ6IHsKLSAgICAgICAgICAgICAgICAgICAgICAgIGlmICh3ZWJWaWV3LmNh blN0b3ApIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIGlmICh3ZWJWaWV3LmxvYWRpbmcpIHsK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zb2xlLmxvZygic3RvcCBsb2FkaW5nIikK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB3ZWJWaWV3LnN0b3AoKQogICAgICAgICAgICAg ICAgICAgICAgICAgfSBlbHNlIHsKLS0gCjEuNy41LjQKCg==