73797 2011-12-04 21:29:35 -0800 Update String::containsOnlyLatin1() to avoid converting to 16 bits 2011-12-05 12:28:08 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin kling webkit.review.bot oldest_to_newest 514892 0 benjamin 2011-12-04 21:29:35 -0800 Update String::containsOnlyLatin1() to avoid converting to 16 bits 514896 1 117839 benjamin 2011-12-04 21:44:59 -0800 Created attachment 117839 Patch 515157 2 117839 kling 2011-12-05 09:58:31 -0800 Comment on attachment 117839 Patch Delightful! 515186 3 117839 darin 2011-12-05 10:44:05 -0800 Comment on attachment 117839 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117839&action=review > Source/JavaScriptCore/wtf/text/WTFString.h:-479 > -inline bool charactersAreAllLatin1(const UChar* characters, size_t length) Why remove this? Why not just call it? 515194 4 benjamin 2011-12-05 10:48:17 -0800 > > Source/JavaScriptCore/wtf/text/WTFString.h:-479 > > -inline bool charactersAreAllLatin1(const UChar* characters, size_t length) > > Why remove this? Why not just call it? I thought removing it would reduce the complexity here since it is never used. 515199 5 benjamin 2011-12-05 10:52:26 -0800 (In reply to comment #4) > > > Source/JavaScriptCore/wtf/text/WTFString.h:-479 > > > -inline bool charactersAreAllLatin1(const UChar* characters, size_t length) > > > > Why remove this? Why not just call it? > > I thought removing it would reduce the complexity here since it is never used. Do you want me to add it back? I don't mind. 515290 6 117839 webkit.review.bot 2011-12-05 12:28:03 -0800 Comment on attachment 117839 Patch Clearing flags on attachment: 117839 Committed r102028: <http://trac.webkit.org/changeset/102028> 515291 7 webkit.review.bot 2011-12-05 12:28:08 -0800 All reviewed patches have been landed. Closing bug. 117839 2011-12-04 21:44:59 -0800 2011-12-05 12:28:03 -0800 Patch bug-73797-20111204214458.patch text/plain 3449 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxOTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 YzY3MWZhNTcxZGViMzY5ZGQ1MjkwYmI3N2ExM2JmMjUzOGVkNWU5Li45MjBhNThmYjZmMTQxYzFh N2Q5YThjNDRlMzFkMzE4MGQxMmZlOTY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxMS0xMi0wNCAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtp dC5vcmc+CisKKyAgICAgICAgVXBkYXRlIFN0cmluZzo6Y29udGFpbnNPbmx5TGF0aW4xKCkgdG8g YXZvaWQgY29udmVydGluZyB0byAxNiBiaXRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03Mzc5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdoZW4gdGhlIFN0cmluZyB1c2UgOGJpdHMgU3RyaW5nSW1wbCwg dGhlcmUgaXMgbm8gbmVlZCB0byBpdGVyYXRlCisgICAgICAgIG92ZXIgdGhlIHN0cmluZy4KKwor ICAgICAgICBUaGUgZnVuY3Rpb24gY2hhcmFjdGVyc0FyZUFsbExhdGluMSgpIGlzIHJlbW92ZWQg YmVjYXVzZSBpdCBpcyBub3QKKyAgICAgICAgdXNlZCBhbnl3aGVyZS4KKworICAgICAgICAqIHd0 Zi90ZXh0L1dURlN0cmluZy5oOgorICAgICAgICAoV1RGOjpTdHJpbmc6OmNvbnRhaW5zT25seUxh dGluMSk6CisKIDIwMTEtMTItMDQgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAog ICAgICAgICBERkcgc2hvdWxkIG9wdGltaXplIHN0cmljdCBlcXVhbGl0eQpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1dURlN0cmluZy5oIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3d0Zi90ZXh0L1dURlN0cmluZy5oCmluZGV4IDU4Y2UxMjY0ZjAzM2Y4YmNkMzY4 OTNjNTE2MzNlMjZjZmEzN2EwOTkuLmJjNWViZGJkOTdiODVlM2FmODZjMGI2MDU4NWRlOGZmOGI4 OGU5YmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9XVEZTdHJp bmcuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL3RleHQvV1RGU3RyaW5nLmgKQEAg LTYyLDcgKzYyLDYgQEAgc3RydWN0IFN0cmluZ0hhc2g7CiAvLyBEZWNsYXJhdGlvbnMgb2Ygc3Ry aW5nIG9wZXJhdGlvbnMKIAogYm9vbCBjaGFyYWN0ZXJzQXJlQWxsQVNDSUkoY29uc3QgVUNoYXIq LCBzaXplX3QpOwotYm9vbCBjaGFyYWN0ZXJzQXJlQWxsTGF0aW4xKGNvbnN0IFVDaGFyKiwgc2l6 ZV90KTsKIFdURl9FWFBPUlRfUFJJVkFURSBpbnQgY2hhcmFjdGVyc1RvSW50U3RyaWN0KGNvbnN0 IExDaGFyKiwgc2l6ZV90LCBib29sKiBvayA9IDAsIGludCBiYXNlID0gMTApOwogV1RGX0VYUE9S VF9QUklWQVRFIGludCBjaGFyYWN0ZXJzVG9JbnRTdHJpY3QoY29uc3QgVUNoYXIqLCBzaXplX3Qs IGJvb2wqIG9rID0gMCwgaW50IGJhc2UgPSAxMCk7CiBXVEZfRVhQT1JUX1BSSVZBVEUgdW5zaWdu ZWQgY2hhcmFjdGVyc1RvVUludFN0cmljdChjb25zdCBMQ2hhciosIHNpemVfdCwgYm9vbCogb2sg PSAwLCBpbnQgYmFzZSA9IDEwKTsKQEAgLTM3NSw3ICszNzQsNyBAQCBwdWJsaWM6CiAgICAgfQog CiAgICAgYm9vbCBjb250YWluc09ubHlBU0NJSSgpIGNvbnN0IHsgcmV0dXJuIGNoYXJhY3RlcnNB cmVBbGxBU0NJSShjaGFyYWN0ZXJzKCksIGxlbmd0aCgpKTsgfQotICAgIGJvb2wgY29udGFpbnNP bmx5TGF0aW4xKCkgY29uc3QgeyByZXR1cm4gY2hhcmFjdGVyc0FyZUFsbExhdGluMShjaGFyYWN0 ZXJzKCksIGxlbmd0aCgpKTsgfQorICAgIGJvb2wgY29udGFpbnNPbmx5TGF0aW4xKCkgY29uc3Q7 CiAgICAgYm9vbCBjb250YWluc09ubHlXaGl0ZXNwYWNlKCkgY29uc3QgeyByZXR1cm4gIW1faW1w bCB8fCBtX2ltcGwtPmNvbnRhaW5zT25seVdoaXRlc3BhY2UoKTsgfQogCiAgICAgLy8gSGFzaCB0 YWJsZSBkZWxldGVkIHZhbHVlcywgd2hpY2ggYXJlIG9ubHkgY29uc3RydWN0ZWQgYW5kIG5ldmVy IGNvcGllZCBvciBkZXN0cm95ZWQuCkBAIC00NjAsNiArNDU5LDIxIEBAIGlubGluZSBjb25zdCBV Q2hhciogU3RyaW5nOjpnZXRDaGFyYWN0ZXJzPFVDaGFyPigpIGNvbnN0CiAgICAgcmV0dXJuIGNo YXJhY3RlcnMxNigpOwogfQogCitpbmxpbmUgYm9vbCBTdHJpbmc6OmNvbnRhaW5zT25seUxhdGlu MSgpIGNvbnN0Cit7CisgICAgaWYgKGlzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuIHRydWU7CisK KyAgICBpZiAoaXM4Qml0KCkpCisgICAgICAgIHJldHVybiB0cnVlOworCisgICAgY29uc3QgVUNo YXIqIGNoYXJhY3RlcnMgPSBjaGFyYWN0ZXJzMTYoKTsKKyAgICBVQ2hhciBvcmVkID0gMDsKKyAg ICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1faW1wbC0+bGVuZ3RoKCk7ICsraSkKKyAgICAgICAg b3JlZCB8PSBjaGFyYWN0ZXJzW2ldOworICAgIHJldHVybiAhKG9yZWQgJiAweEZGMDApOworfQor CiAKICNpZmRlZiBfX09CSkNfXwogLy8gVGhpcyBpcyBmb3Igc2l0dWF0aW9ucyBpbiBXZWJLaXQg d2hlcmUgdGhlIGxvbmcgc3RhbmRpbmcgYmVoYXZpb3IgaGFzIGJlZW4KQEAgLTQ3NiwxNCArNDkw LDYgQEAgaW5saW5lIGJvb2wgY2hhcmFjdGVyc0FyZUFsbEFTQ0lJKGNvbnN0IFVDaGFyKiBjaGFy YWN0ZXJzLCBzaXplX3QgbGVuZ3RoKQogICAgIHJldHVybiAhKG9yZWQgJiAweEZGODApOwogfQog Ci1pbmxpbmUgYm9vbCBjaGFyYWN0ZXJzQXJlQWxsTGF0aW4xKGNvbnN0IFVDaGFyKiBjaGFyYWN0 ZXJzLCBzaXplX3QgbGVuZ3RoKQotewotICAgIFVDaGFyIG9yZWQgPSAwOwotICAgIGZvciAoc2l6 ZV90IGkgPSAwOyBpIDwgbGVuZ3RoOyArK2kpCi0gICAgICAgIG9yZWQgfD0gY2hhcmFjdGVyc1tp XTsKLSAgICByZXR1cm4gIShvcmVkICYgMHhGRjAwKTsKLX0KLQogV1RGX0VYUE9SVF9QUklWQVRF IGludCBjb2RlUG9pbnRDb21wYXJlKGNvbnN0IFN0cmluZyYsIGNvbnN0IFN0cmluZyYpOwogCiBp bmxpbmUgc2l6ZV90IGZpbmQoY29uc3QgTENoYXIqIGNoYXJhY3RlcnMsIHVuc2lnbmVkIGxlbmd0 aCwgTENoYXIgbWF0Y2hDaGFyYWN0ZXIsIHVuc2lnbmVkIGluZGV4ID0gMCkKQEAgLTYxMCw3ICs2 MTYsNiBAQCB1c2luZyBXVEY6OmVtcHR5U3RyaW5nOwogdXNpbmcgV1RGOjphcHBlbmQ7CiB1c2lu ZyBXVEY6OmFwcGVuZE51bWJlcjsKIHVzaW5nIFdURjo6Y2hhcmFjdGVyc0FyZUFsbEFTQ0lJOwot dXNpbmcgV1RGOjpjaGFyYWN0ZXJzQXJlQWxsTGF0aW4xOwogdXNpbmcgV1RGOjpjaGFyYWN0ZXJz VG9JbnRTdHJpY3Q7CiB1c2luZyBXVEY6OmNoYXJhY3RlcnNUb1VJbnRTdHJpY3Q7CiB1c2luZyBX VEY6OmNoYXJhY3RlcnNUb0ludDY0U3RyaWN0Owo=