73795 2011-12-04 20:29:28 -0800 Remove methods declared but never implemented with GOOGLEURL 2011-12-05 17:10:41 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin webkit.review.bot oldest_to_newest 514853 0 117830 benjamin 2011-12-04 20:29:28 -0800 Created attachment 117830 Patch Reviewed by NOBODY (OOPS!). * platform/KURL.h: --- 2 files changed, 8 insertions(+), 3 deletions(-) 514857 1 117831 benjamin 2011-12-04 20:31:48 -0800 Created attachment 117831 Patch 514860 2 webkit.review.bot 2011-12-04 20:33:49 -0800 Attachment 117831 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style. 514864 3 benjamin 2011-12-04 20:39:55 -0800 Why didn't webkit patch send the right diff? :( 514865 4 117833 benjamin 2011-12-04 20:40:19 -0800 Created attachment 117833 Patch 515518 5 benjamin 2011-12-05 17:10:41 -0800 Committed r102073: <http://trac.webkit.org/changeset/102073> 117830 2011-12-04 20:29:28 -0800 2011-12-04 20:31:45 -0800 Patch 20111204202926.patch text/plain 1373 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxOTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjEyYWM2MmIyMjNiN2M4 NWI5YjQ2MjNkODFiYmNmMDU0ZjZkNDg2My4uYTcyODYzYjk5Y2I0MmJiODRiZjkyYjkyY2RkNmMx YmVhOTQ1MDMzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDExIEBACisyMDExLTEyLTA0ICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBtZXRo b2RzIGRlY2xhcmVkIGJ1dCBuZXZlciBpbXBsZW1lbnRlZCB3aXRoIEdPT0dMRVVSTAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vS1VS TC5oOgorCiAyMDExLTEyLTA0ICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9y Zz4KIAogICAgICAgICBHZXQgcmlkIG9mIEtVUkw6OktVUkwoUGFyc2VkVVJMU3RyaW5nVGFnLCBj b25zdCBjaGFyKik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9LVVJMLmgg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9LVVJMLmgKaW5kZXggN2E2ZjgwZGM4NTQ5M2NmZmRl YTNiMTY4ZWNiZGJiMjgwMWQxYzhhYy4uZjdkZWRhYjBkNTZlMjEwMDAzZGFiMTFlMGZkMDY1OWUx MWJhNDIwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vS1VSTC5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0tVUkwuaApAQCAtMjM1LDkgKzIzNSw2IEBAIHByaXZh dGU6CiAgICAgc3RhdGljIGJvb2wgcHJvdG9jb2xJcyhjb25zdCBTdHJpbmcmLCBjb25zdCBjaGFy Kik7CiAjaWYgVVNFKEdPT0dMRVVSTCkKICAgICBmcmllbmQgY2xhc3MgS1VSTEdvb2dsZVByaXZh dGU7Ci0gICAgdm9pZCBwYXJzZShjb25zdCBjaGFyKiB1cmwsIGNvbnN0IFN0cmluZyYgb3JpZ2lu YWxTdHJpbmcgPSBTdHJpbmcoKSkgeyBwYXJzZSh1cmwsICZvcmlnaW5hbFN0cmluZyk7IH07Ci0g ICAgdm9pZCBwYXJzZShjb25zdCBjaGFyKiB1cmwsIGNvbnN0IFN0cmluZyogb3JpZ2luYWxTdHJp bmcpOyAgLy8gS1VSTE1hYyBjYWxscyB0aGlzLgotICAgIHZvaWQgY29weVRvQnVmZmVyKFZlY3Rv cjxjaGFyLCA1MTI+JiBidWZmZXIpIGNvbnN0OyAgLy8gS1VSTENGTmV0IHVzZXMgdGhpcy4KICAg ICBLVVJMR29vZ2xlUHJpdmF0ZSBtX3VybDsKICNlbHNlICAvLyAhVVNFKEdPT0dMRVVSTCkKICAg ICB2b2lkIGluaXQoY29uc3QgS1VSTCYsIGNvbnN0IFN0cmluZyYsIGNvbnN0IFRleHRFbmNvZGlu ZyYpOwo= 117831 2011-12-04 20:31:48 -0800 2011-12-04 20:40:16 -0800 Patch bug-73795-20111204203147.patch text/plain 1431 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxOTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjEyYWM2MmIyMjNiN2M4 NWI5YjQ2MjNkODFiYmNmMDU0ZjZkNDg2My4uNzczOTc2NjEwY2MxOWRhNDdmYWRhYTViM2YzZjhh ZTlhYjM1ZDIyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDEzIEBACiAyMDExLTEyLTA0ICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KIAorICAgICAgICBSZW1vdmUgbWV0 aG9kcyBkZWNsYXJlZCBidXQgbmV2ZXIgaW1wbGVtZW50ZWQgd2l0aCBHT09HTEVVUkwKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL0tV UkwuaDoKKworMjAxMS0xMi0wNCAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5v cmc+CisKICAgICAgICAgR2V0IHJpZCBvZiBLVVJMOjpLVVJMKFBhcnNlZFVSTFN0cmluZ1RhZywg Y29uc3QgY2hhciopOwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzM3OTIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vS1VSTC5o IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vS1VSTC5oCmluZGV4IDdhNmY4MGRjODU0OTNjZmZk ZWEzYjE2OGVjYmRiYjI4MDFkMWM4YWMuLmY3ZGVkYWIwZDU2ZTIxMDAwM2RhYjExZTBmZDA2NTll MTFiYTQyMDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0tVUkwuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9LVVJMLmgKQEAgLTIzNSw5ICsyMzUsNiBAQCBwcml2 YXRlOgogICAgIHN0YXRpYyBib29sIHByb3RvY29sSXMoY29uc3QgU3RyaW5nJiwgY29uc3QgY2hh ciopOwogI2lmIFVTRShHT09HTEVVUkwpCiAgICAgZnJpZW5kIGNsYXNzIEtVUkxHb29nbGVQcml2 YXRlOwotICAgIHZvaWQgcGFyc2UoY29uc3QgY2hhciogdXJsLCBjb25zdCBTdHJpbmcmIG9yaWdp bmFsU3RyaW5nID0gU3RyaW5nKCkpIHsgcGFyc2UodXJsLCAmb3JpZ2luYWxTdHJpbmcpOyB9Owot ICAgIHZvaWQgcGFyc2UoY29uc3QgY2hhciogdXJsLCBjb25zdCBTdHJpbmcqIG9yaWdpbmFsU3Ry aW5nKTsgIC8vIEtVUkxNYWMgY2FsbHMgdGhpcy4KLSAgICB2b2lkIGNvcHlUb0J1ZmZlcihWZWN0 b3I8Y2hhciwgNTEyPiYgYnVmZmVyKSBjb25zdDsgIC8vIEtVUkxDRk5ldCB1c2VzIHRoaXMuCiAg ICAgS1VSTEdvb2dsZVByaXZhdGUgbV91cmw7CiAjZWxzZSAgLy8gIVVTRShHT09HTEVVUkwpCiAg ICAgdm9pZCBpbml0KGNvbnN0IEtVUkwmLCBjb25zdCBTdHJpbmcmLCBjb25zdCBUZXh0RW5jb2Rp bmcmKTsK 117833 2011-12-04 20:40:19 -0800 2011-12-05 16:57:40 -0800 Patch bug-73795-20111204204018.patch text/plain 1486 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxOTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjEyYWM2MmIyMjNiN2M4 NWI5YjQ2MjNkODFiYmNmMDU0ZjZkNDg2My4uNzc4N2FkNzQ0NTEyM2JjOTBmNTMzMTEwNzEyNjg4 NzNhMzkyN2RiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDExLTEyLTA0ICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KIAorICAgICAgICBSZW1vdmUgbWV0 aG9kcyBkZWNsYXJlZCBidXQgbmV2ZXIgaW1wbGVtZW50ZWQgd2l0aCBHT09HTEVVUkwKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczNzk1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9LVVJM Lmg6CisKKzIwMTEtMTItMDQgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbkB3ZWJraXQub3Jn PgorCiAgICAgICAgIEdldCByaWQgb2YgS1VSTDo6S1VSTChQYXJzZWRVUkxTdHJpbmdUYWcsIGNv bnN0IGNoYXIqKTsKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTczNzkyCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0tVUkwuaCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0tVUkwuaAppbmRleCA3YTZmODBkYzg1NDkzY2ZmZGVh M2IxNjhlY2JkYmIyODAxZDFjOGFjLi5mN2RlZGFiMGQ1NmUyMTAwMDNkYWIxMWUwZmQwNjU5ZTEx YmE0MjAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9LVVJMLmgKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vS1VSTC5oCkBAIC0yMzUsOSArMjM1LDYgQEAgcHJpdmF0 ZToKICAgICBzdGF0aWMgYm9vbCBwcm90b2NvbElzKGNvbnN0IFN0cmluZyYsIGNvbnN0IGNoYXIq KTsKICNpZiBVU0UoR09PR0xFVVJMKQogICAgIGZyaWVuZCBjbGFzcyBLVVJMR29vZ2xlUHJpdmF0 ZTsKLSAgICB2b2lkIHBhcnNlKGNvbnN0IGNoYXIqIHVybCwgY29uc3QgU3RyaW5nJiBvcmlnaW5h bFN0cmluZyA9IFN0cmluZygpKSB7IHBhcnNlKHVybCwgJm9yaWdpbmFsU3RyaW5nKTsgfTsKLSAg ICB2b2lkIHBhcnNlKGNvbnN0IGNoYXIqIHVybCwgY29uc3QgU3RyaW5nKiBvcmlnaW5hbFN0cmlu Zyk7ICAvLyBLVVJMTWFjIGNhbGxzIHRoaXMuCi0gICAgdm9pZCBjb3B5VG9CdWZmZXIoVmVjdG9y PGNoYXIsIDUxMj4mIGJ1ZmZlcikgY29uc3Q7ICAvLyBLVVJMQ0ZOZXQgdXNlcyB0aGlzLgogICAg IEtVUkxHb29nbGVQcml2YXRlIG1fdXJsOwogI2Vsc2UgIC8vICFVU0UoR09PR0xFVVJMKQogICAg IHZvaWQgaW5pdChjb25zdCBLVVJMJiwgY29uc3QgU3RyaW5nJiwgY29uc3QgVGV4dEVuY29kaW5n Jik7Cg==