73782 2011-12-04 14:55:30 -0800 Make ~CSSParserSelector use Vector<OwnPtr> 2011-12-21 23:41:34 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 darin darin ap macpherson webkit.review.bot oldest_to_newest 514772 0 darin 2011-12-04 14:55:30 -0800 Make ~CSSParserSelector use Vector<OwnPtr> 514773 1 117810 darin 2011-12-04 14:56:41 -0800 Created attachment 117810 Patch 514856 2 117810 ap 2011-12-04 20:30:55 -0800 Comment on attachment 117810 Patch This looks like it was meant for review, so r=me. 515250 3 darin 2011-12-05 11:51:31 -0800 I uploaded with with --no-review because I was seeing test failures with some other patches that adopt Vector<OwnPtr>. I think I need to do more Vector<OwnPtr> testing before landing this. 526059 4 117810 webkit.review.bot 2011-12-21 23:41:29 -0800 Comment on attachment 117810 Patch Clearing flags on attachment: 117810 Committed r103498: <http://trac.webkit.org/changeset/103498> 526060 5 webkit.review.bot 2011-12-21 23:41:34 -0800 All reviewed patches have been landed. Closing bug. 117810 2011-12-04 14:56:41 -0800 2011-12-21 23:41:29 -0800 Patch bug-73782-20111204145640.patch text/plain 1786 darin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMTk2OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDExLTEyLTA0ICBEYXJpbiBB ZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIH5DU1NQYXJzZXJTZWxlY3Rv ciB1c2UgVmVjdG9yPE93blB0cj4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTczNzgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBjc3MvQ1NTUGFyc2VyVmFsdWVzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkNTU1BhcnNlclNlbGVjdG9yOjp+Q1NTUGFyc2VyU2VsZWN0b3IpOiBVc2UgVmVjdG9yPE93blB0 cj4KKyAgICAgICAgc28gd2UgZG9uJ3QgaGF2ZSB0byBjYWxsIGxlYWtQdHIgb3IgZGVsZXRlQWxs VmFsdWVzLgorCiAyMDExLTEyLTA0ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgog CiAgICAgICAgIEhJRVJBUkNIWV9SRVFVRVNUX0VSUiBjaGVjayBpbiBjaGVja0FjY2VwdENoaWxk IHNob3VsZCBiZSBvcHRpbWl6ZWQgZm9yIG5ld0NoaWxkIHdpdGhvdXQgY2hpbGRyZW4KSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXJWYWx1ZXMuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXJWYWx1ZXMuY3BwCShyZXZpc2lvbiAxMDE5NjcpCisr KyBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyVmFsdWVzLmNwcAkod29ya2luZyBjb3B5KQpA QCAtOTUsMTYgKzk1LDE1IEBAIENTU1BhcnNlclNlbGVjdG9yOjp+Q1NTUGFyc2VyU2VsZWN0b3Io KQogewogICAgIGlmICghbV90YWdIaXN0b3J5KQogICAgICAgICByZXR1cm47Ci0gICAgVmVjdG9y PENTU1BhcnNlclNlbGVjdG9yKiwgMTY+IHRvRGVsZXRlOwotICAgIENTU1BhcnNlclNlbGVjdG9y KiBzZWxlY3RvciA9IG1fdGFnSGlzdG9yeS5sZWFrUHRyKCk7CisgICAgVmVjdG9yPE93blB0cjxD U1NQYXJzZXJTZWxlY3Rvcj4sIDE2PiB0b0RlbGV0ZTsKKyAgICBPd25QdHI8Q1NTUGFyc2VyU2Vs ZWN0b3I+IHNlbGVjdG9yID0gbV90YWdIaXN0b3J5LnJlbGVhc2UoKTsKICAgICB3aGlsZSAodHJ1 ZSkgewotICAgICAgICB0b0RlbGV0ZS5hcHBlbmQoc2VsZWN0b3IpOwotICAgICAgICBDU1NQYXJz ZXJTZWxlY3RvciogbmV4dCA9IHNlbGVjdG9yLT5tX3RhZ0hpc3RvcnkubGVha1B0cigpOworICAg ICAgICBPd25QdHI8Q1NTUGFyc2VyU2VsZWN0b3I+IG5leHQgPSBzZWxlY3Rvci0+bV90YWdIaXN0 b3J5LnJlbGVhc2UoKTsKKyAgICAgICAgdG9EZWxldGUuYXBwZW5kKHNlbGVjdG9yLnJlbGVhc2Uo KSk7CiAgICAgICAgIGlmICghbmV4dCkKICAgICAgICAgICAgIGJyZWFrOwotICAgICAgICBzZWxl Y3RvciA9IG5leHQ7CisgICAgICAgIHNlbGVjdG9yID0gbmV4dC5yZWxlYXNlKCk7CiAgICAgfQot ICAgIGRlbGV0ZUFsbFZhbHVlcyh0b0RlbGV0ZSk7CiB9CiAKIHZvaWQgQ1NTUGFyc2VyU2VsZWN0 b3I6OmFkb3B0U2VsZWN0b3JWZWN0b3IoVmVjdG9yPE93blB0cjxDU1NQYXJzZXJTZWxlY3Rvcj4g PiYgc2VsZWN0b3JWZWN0b3IpCg==