73718 2011-12-02 16:16:02 -0800 [Qt] cleanup qmltests.pro 2011-12-04 12:42:26 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 gopal.1.raghavan webkit-unassigned ostap73 webkit.review.bot zoltan oldest_to_newest 514264 0 gopal.1.raghavan 2011-12-02 16:16:02 -0800 Remove unused file WebView/tst_loadZeroSizeView.qml 514266 1 117710 gopal.1.raghavan 2011-12-02 16:22:07 -0800 Created attachment 117710 cleanup patch Removed unused file WebView/tst_loadZeroSizeView.qml and reordered file list. 514270 2 117710 ostap73 2011-12-02 16:41:22 -0800 Comment on attachment 117710 cleanup patch View in context: https://bugs.webkit.org/attachment.cgi?id=117710&action=review > Source/WebKit2/UIProcess/API/qt/tests/qmltests/qmltests.pro:NaN > DEFINES += QUICK_TEST_SOURCE_DIR=\"\\\"$ You've also removed QUICK_TEST_SOURCE_DIR . Should it be removed? It is not mentioned in ChangeLog. 514272 3 ostap73 2011-12-02 16:45:29 -0800 (In reply to comment #2) > (From update of attachment 117710 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=117710&action=review > > > Source/WebKit2/UIProcess/API/qt/tests/qmltests/qmltests.pro:NaN > > DEFINES += QUICK_TEST_SOURCE_DIR=\"\\\"$ > > You've also removed QUICK_TEST_SOURCE_DIR . > Should it be removed? It is not mentioned in ChangeLog. Never mind. Was confused by review page highlighting. 514739 4 117710 webkit.review.bot 2011-12-04 12:42:21 -0800 Comment on attachment 117710 cleanup patch Clearing flags on attachment: 117710 Committed r101963: <http://trac.webkit.org/changeset/101963> 514740 5 webkit.review.bot 2011-12-04 12:42:26 -0800 All reviewed patches have been landed. Closing bug. 117710 2011-12-02 16:22:07 -0800 2011-12-04 12:42:21 -0800 cleanup patch 73718.patch text/plain 2053 gopal.1.raghavan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMTg3NikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDExLTEyLTAyICBHb3BhbCBS YWdoYXZhbiAgPGdvcGFsLjEucmFnaGF2YW5Abm9raWEuY29tPgorCisgICAgICAgIFtRdF0gY2xl YW51cCBxbWx0ZXN0cy5wcm8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTczNzE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUmVtb3ZlZCB1bnVzZWQgZmlsZSBXZWJWaWV3L3RzdF9sb2FkWmVyb1NpemVWaWV3 LnFtbCBhbmQgcmVvcmRlcmVkIGZpbGUgbGlzdC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv cXQvdGVzdHMvcW1sdGVzdHMvcW1sdGVzdHMucHJvOgorCiAyMDExLTEyLTAyICBGYWR5IFNhbXVl bCAgPGZzYW11ZWxAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdoZW4gcGFnZSBzY2FsaW5nIGlz IGluIHVzZSBwb3NpdGlvbjpmaXhlZCBoYXMgaW5jb3JyZWN0IHJlc3VsdHMKSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvcW1sdGVzdHMucHJvCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVz dHMvcW1sdGVzdHMucHJvCShyZXZpc2lvbiAxMDE4NjUpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL3FtbHRlc3RzLnBybwkod29ya2luZyBjb3B5KQpA QCAtMTYsMTggKzE2LDE3IEBAIERFRklORVMgKz0gUVVJQ0tfVEVTVF9TT1VSQ0VfRElSPVwiXFxc IiQKIERFRklORVMgKz0gSU1QT1JUX0RJUj1cIlxcXCIkJHtST09UX0JVSUxEX0RJUn0kJHtRTUFL RV9ESVJfU0VQfWltcG9ydHNcXFwiXCIKIAogT1RIRVJfRklMRVMgKz0gXAorICAgIERlc2t0b3BC ZWhhdmlvci9EZXNrdG9wV2ViVmlldy5xbWwgXAorICAgIERlc2t0b3BCZWhhdmlvci90c3RfbGlu a0hvdmVyZWQucW1sIFwKKyAgICBEZXNrdG9wQmVoYXZpb3IvdHN0X2xvYWRIdG1sLnFtbCBcCisg ICAgRGVza3RvcEJlaGF2aW9yL3RzdF9tZXNzYWdpbmcucW1sIFwKKyAgICBEZXNrdG9wQmVoYXZp b3IvdHN0X25hdmlnYXRpb25SZXF1ZXN0ZWQucW1sIFwKKyAgICBXZWJWaWV3L3RzdF9kb3dubG9h ZC5xbWwgXAorICAgIFdlYlZpZXcvdHN0X2dlb3Blcm1pc3Npb24ucW1sIFwKICAgICBXZWJWaWV3 L3RzdF9qYXZhU2NyaXB0RGlhbG9ncy5xbWwgXAotICAgIFdlYlZpZXcvdHN0X3Byb3BlcnRpZXMu cW1sIFwKICAgICBXZWJWaWV3L3RzdF9sb2FkRmFpbC5xbWwgXAorICAgIFdlYlZpZXcvdHN0X2xv YWRIdG1sLnFtbCBcCiAgICAgV2ViVmlldy90c3RfbG9hZFByb2dyZXNzLnFtbCBcCiAgICAgV2Vi Vmlldy90c3RfbG9hZFByb2dyZXNzU2lnbmFsLnFtbCBcCi0gICAgV2ViVmlldy90c3RfbG9hZFpl cm9TaXplVmlldy5xbWwgXAogICAgIFdlYlZpZXcvdHN0X3ByZWZlcmVuY2VzLnFtbCBcCi0gICAg V2ViVmlldy90c3RfbG9hZEh0bWwucW1sIFwKLSAgICBXZWJWaWV3L3RzdF9kb3dubG9hZC5xbWwg XAotICAgIFdlYlZpZXcvdHN0X2dlb3Blcm1pc3Npb24ucW1sIFwKLSAgICBEZXNrdG9wQmVoYXZp b3IvdHN0X2xpbmtIb3ZlcmVkLnFtbCBcCi0gICAgRGVza3RvcEJlaGF2aW9yL3RzdF9tZXNzYWdp bmcucW1sIFwKLSAgICBEZXNrdG9wQmVoYXZpb3IvdHN0X25hdmlnYXRpb25SZXF1ZXN0ZWQucW1s IFwKLSAgICBEZXNrdG9wQmVoYXZpb3IvdHN0X2xvYWRIdG1sLnFtbCBcCi0gICAgRGVza3RvcEJl aGF2aW9yL0Rlc2t0b3BXZWJWaWV3LnFtbAorICAgIFdlYlZpZXcvdHN0X3Byb3BlcnRpZXMucW1s Cg==