73687 2011-12-02 13:31:37 -0800 [chromium] Separate setFocus() and setActive() in WebViewImpl 2011-12-02 21:51:22 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 japhet japhet eric fishd webkit.review.bot oldest_to_newest 514064 0 japhet 2011-12-02 13:31:37 -0800 See: http://code.google.com/p/chromium/issues/detail?id=101455 http://trac.webkit.org/changeset/96912 Historically, chromium has only explicitly sent IPCs for setting a WebView as active on mac. http://src.chromium.org/viewvc/chrome?view=rev&revision=108392 changed this. Now, WebViewImpl::setFocus() shouldn't need to call FocusController::setActive() to get proper behavior. 514162 1 117692 japhet 2011-12-02 14:32:31 -0800 Created attachment 117692 patch 514185 2 117692 eric 2011-12-02 14:48:52 -0800 Comment on attachment 117692 patch seems reasonable. 514186 3 eric 2011-12-02 14:49:09 -0800 CCing fishd as it's API related. 514221 4 117692 fishd 2011-12-02 15:19:47 -0800 Comment on attachment 117692 patch OK 514410 5 117692 webkit.review.bot 2011-12-02 21:51:18 -0800 Comment on attachment 117692 patch Clearing flags on attachment: 117692 Committed r101905: <http://trac.webkit.org/changeset/101905> 514411 6 webkit.review.bot 2011-12-02 21:51:22 -0800 All reviewed patches have been landed. Closing bug. 117692 2011-12-02 14:32:31 -0800 2011-12-02 21:51:18 -0800 patch focus.txt text/plain 2686 japhet SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViVmlld1Rlc3QuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViVmlld1Rlc3QuY3BwCShy ZXZpc2lvbiAxMDE2ODQpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dlYlZpZXdU ZXN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjYsMTUgKzY2LDI0IEBACiAgICAgV2ViVmlldyog d2ViVmlldyA9IEZyYW1lVGVzdEhlbHBlcnM6OmNyZWF0ZVdlYlZpZXdBbmRMb2FkKG1fYmFzZVVS TCArICJ2aXNpYmxlX2lmcmFtZS5odG1sIik7CiAKICAgICB3ZWJWaWV3LT5zZXRGb2N1cyh0cnVl KTsKKyAgICB3ZWJWaWV3LT5zZXRJc0FjdGl2ZSh0cnVlKTsKICAgICBXZWJGcmFtZUltcGwqIGZy YW1lID0gc3RhdGljX2Nhc3Q8V2ViRnJhbWVJbXBsKj4od2ViVmlldy0+bWFpbkZyYW1lKCkpOwog ICAgIEVYUEVDVF9UUlVFKGZyYW1lLT5mcmFtZSgpLT5kb2N1bWVudCgpLT5pc0hUTUxEb2N1bWVu dCgpKTsKIAogICAgIFdlYkNvcmU6OkhUTUxEb2N1bWVudCogZG9jdW1lbnQgPSBzdGF0aWNfY2Fz dDxXZWJDb3JlOjpIVE1MRG9jdW1lbnQqPihmcmFtZS0+ZnJhbWUoKS0+ZG9jdW1lbnQoKSk7CiAg ICAgRVhQRUNUX1RSVUUoZG9jdW1lbnQtPmhhc0ZvY3VzKCkpOwogICAgIHdlYlZpZXctPnNldEZv Y3VzKGZhbHNlKTsKKyAgICB3ZWJWaWV3LT5zZXRJc0FjdGl2ZShmYWxzZSk7CiAgICAgRVhQRUNU X0ZBTFNFKGRvY3VtZW50LT5oYXNGb2N1cygpKTsKICAgICB3ZWJWaWV3LT5zZXRGb2N1cyh0cnVl KTsKKyAgICB3ZWJWaWV3LT5zZXRJc0FjdGl2ZSh0cnVlKTsKICAgICBFWFBFQ1RfVFJVRShkb2N1 bWVudC0+aGFzRm9jdXMoKSk7CisgICAgd2ViVmlldy0+c2V0Rm9jdXModHJ1ZSk7CisgICAgd2Vi Vmlldy0+c2V0SXNBY3RpdmUoZmFsc2UpOworICAgIEVYUEVDVF9GQUxTRShkb2N1bWVudC0+aGFz Rm9jdXMoKSk7CisgICAgd2ViVmlldy0+c2V0Rm9jdXMoZmFsc2UpOworICAgIHdlYlZpZXctPnNl dElzQWN0aXZlKHRydWUpOworICAgIEVYUEVDVF9UUlVFKGRvY3VtZW50LT5oYXNGb2N1cygpKTsK IAogICAgIHdlYlZpZXctPmNsb3NlKCk7CiB9CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJWaWV3SW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViVmlld0ltcGwuY3BwCShyZXZpc2lvbiAxMDE2ODQpCisrKyBTb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0MjEsNyAr MTQyMSw2IEBACiB2b2lkIFdlYlZpZXdJbXBsOjpzZXRGb2N1cyhib29sIGVuYWJsZSkKIHsKICAg ICBtX3BhZ2UtPmZvY3VzQ29udHJvbGxlcigpLT5zZXRGb2N1c2VkKGVuYWJsZSk7Ci0gICAgbV9w YWdlLT5mb2N1c0NvbnRyb2xsZXIoKS0+c2V0QWN0aXZlKGVuYWJsZSk7CiAgICAgaWYgKGVuYWJs ZSkgewogICAgICAgICBSZWZQdHI8RnJhbWU+IGZvY3VzZWRGcmFtZSA9IG1fcGFnZS0+Zm9jdXND b250cm9sbGVyKCktPmZvY3VzZWRGcmFtZSgpOwogICAgICAgICBpZiAoZm9jdXNlZEZyYW1lKSB7 CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gMTAxODQ0KQorKysgU291 cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx OSBAQAorMjAxMS0xMi0wMiAgTmF0ZSBDaGFwaW4gIDxqYXBoZXRAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIERvbid0IGNhbGwgRm9jdXNDb250cm9sbGVyOnNldEFjdGl2ZSgpIGluIAorICAgICAg ICBXZWJWaWV3SW1wbDo6c2V0Rm9jdXMoKSwgc2luY2UgYmVpbmcgYWN0aXZlIGFuZAorICAgICAg ICBiZWluZyBmb2N1c2VkIGFyZSBkaWZmZXJlbnQgY29uY2VwdHMgYW5kIGNocm9taXVtCisgICAg ICAgIG5vdyBwcm9wZXJseSBzZW5kcyBzZXRBY3RpdmUgSVBDcyBvbiBhbGwgcGxhdGZvcm1zLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM2ODcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHNyYy9XZWJW aWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjpzZXRGb2N1cyk6Cisg ICAgICAgICogdGVzdHMvV2ViVmlld1Rlc3QuY3BwOiBUZXN0IGhvdyBkaWZmZXJlbnQgY29tYmlu YXRpb25zIG9mCisgICAgICAgICAgICBzZXRJc0FjdGl2ZSgpIGFuZCBzZXRGb2N1cygpIGFmZmVj dCB3aGV0aGVyIHRoZSBkb2N1bWVudAorICAgICAgICAgICAgaGFzIGZvY3VzLgorCiAyMDExLTEy LTAxICBBbG9rIFByaXlhZGFyc2hpICA8YWxva3BAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtj aHJvbWl1bV0gQ0NMYXllclF1YWQgZG9lcyBub3QgcmV0dXJuIEZsb2F0UXVhZCBpbiBjb3JyZWN0 IG9yZGVyCg==