73666 2011-12-02 08:57:41 -0800 [GTK] http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html fails 2011-12-08 02:45:10 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand toyoshim svillar tkent toyoshim webkit.review.bot yutak oldest_to_newest 513810 0 pnormand 2011-12-02 08:57:41 -0800 --- /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy-expected.txt +++ /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy-actual.txt @@ -1,3 +1,4 @@ +CONSOLE MESSAGE: line 0: WebSocket network error: error code 0 Web Socket bufferedAmount after closed in busy On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". Not sure what to do here. Any hint? Takashi? 516093 1 toyoshim 2011-12-06 11:37:24 -0800 Thank you for letting me know. This new test closes WebSocket connection when sending buffer is not empty. In this situation, platformSend will be called after connection start to close, or is in CLOSING state. I think this console message is related to the case. I'll investigate it. 517244 2 118345 toyoshim 2011-12-08 01:10:56 -0800 Created attachment 118345 Patch 517245 3 toyoshim 2011-12-08 01:14:53 -0800 Sorry, the reason was in my test. Server side handler began server initiated closing handshake unexpectedly. Anyway, current SocketStreamHandlerError doesn't contain message to show in log. I'll also post a patch to improve it soon. Thanks 517264 4 118345 tkent 2011-12-08 02:06:07 -0800 Comment on attachment 118345 Patch ok 517277 5 118345 webkit.review.bot 2011-12-08 02:45:06 -0800 Comment on attachment 118345 Patch Clearing flags on attachment: 118345 Committed r102327: <http://trac.webkit.org/changeset/102327> 517278 6 webkit.review.bot 2011-12-08 02:45:10 -0800 All reviewed patches have been landed. Closing bug. 118345 2011-12-08 01:10:56 -0800 2011-12-08 02:45:06 -0800 Patch bug-73666-20111208181057.patch text/plain 2417 toyoshim U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMTgyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNGUxNDU5MTExZWFjN2IxMTAwYzBh NjA3MWZhNWVkODI2YzJlZWI2Ni4uNTg2ZWYzMmU1ZjAyMjZhZmFhMzNiMTE4MDk5MzA0MThhMWQz ZWMwNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDExLTEyLTA4ICBUYWthc2hpIFRveW9zaGlt YSAgPHRveW9zaGltQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggZmFpbGVkIGxheW91dCB0 ZXN0LCBidWZmZXJlZEFtb3VudC1hZnRlci1jbG9zZS1pbi1idXN5Lmh0bWwKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczNjY2CisKKyAgICAgICAgT3Jp Z2luYWxseSB0aGUgZmFpbGVkIGxheW91dCB0ZXN0IHVzZSBzaW1wbGVfd3NoIHNlcnZlciBzaWRl IFdlYlNvY2tldAorICAgICAgICBoYW5kbGVyLiBCdXQgdGhpcyBoYW5kbGVyIHN0YXJ0cyBjbG9z aW5nIGhhbmRzaGFrZSBhZnRlciBhIHdoaWxlIGFuZAorICAgICAgICBpdCBicmluZyBmbGFraW5l c3Mgb24gdGhlIHRlc3QuCisgICAgICAgIE5vdyB0aGUgdGVzdCB1c2UgZWNob193c2ggaW5zdGVh ZCBvZiBzaW1wbGVfd3NoLiBJdCBuZXZlciBwZXJmb3JtCisgICAgICAgIHNlcnZlciBpbml0aWF0 ZWQgY2xvc2luZyBoYW5kc2hha2UuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oeWJpL2J1ZmZlcmVk QW1vdW50LWFmdGVyLWNsb3NlLWluLWJ1c3kuaHRtbDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsv U2tpcHBlZDoKKwogMjAxMS0xMi0wNiAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAK ICAgICAgICAgR2VuZXJhdGVkIHNvbWUgbmV3IGV4cGVjdGVkIHJlc3VsdHMgZm9yIExpb24uCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oeWJpL2J1 ZmZlcmVkQW1vdW50LWFmdGVyLWNsb3NlLWluLWJ1c3kuaHRtbCBiL0xheW91dFRlc3RzL2h0dHAv dGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5YmkvYnVmZmVyZWRBbW91bnQtYWZ0ZXItY2xvc2UtaW4t YnVzeS5odG1sCmluZGV4IDYzNzUyOGJmM2ZkMzA1YzNmYjAyNWI2ZGE2MjY0MTA1MzEyNzBkMjMu LmFjMTdlMDE0Y2VhMGUzZjNhYjQ0MTk5NzhlMWFlM2VkZGRjY2UyNDUgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5YmkvYnVmZmVyZWRBbW91bnQt YWZ0ZXItY2xvc2UtaW4tYnVzeS5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vi c29ja2V0L3Rlc3RzL2h5YmkvYnVmZmVyZWRBbW91bnQtYWZ0ZXItY2xvc2UtaW4tYnVzeS5odG1s CkBAIC0yOCw3ICsyOCw3IEBAIGZ1bmN0aW9uIGNyZWF0ZUJsb2JXaXRoTGVuZ3RoKGxlbmd0aCkK ICAgICByZXR1cm4gYnVpbGRlci5nZXRCbG9iKCk7CiB9CiAKLXZhciB3cyA9IG5ldyBXZWJTb2Nr ZXQoIndzOi8vbG9jYWxob3N0Ojg4ODAvd2Vic29ja2V0L3Rlc3RzL2h5Ymkvc2ltcGxlIik7Cit2 YXIgd3MgPSBuZXcgV2ViU29ja2V0KCJ3czovL2xvY2FsaG9zdDo4ODgwL3dlYnNvY2tldC90ZXN0 cy9oeWJpL2VjaG8iKTsKIAogdmFyIGJ1ZmZlcmVkQW1vdW50QmVmb3JlQ2xvc2UgPSAwOwogdmFy IGJ1ZmZlcmVkQW1vdW50QWZ0ZXJDbG9zZSA9IDA7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9ndGsvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCmlu ZGV4IDIzYmM4MjIxMzBiNDg0N2JjMTAxYjkzMDUwYTA5ZWUzMDZkOTllOWEuLjJiNzYyMzBjMWVj ZGQ3MTE1YjI3OGM2ZTExZWRlM2ExZjAwOTBiYTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL2d0ay9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVk CkBAIC0xNTg3LDkgKzE1ODcsNiBAQCBmYXN0L2V2ZW50cy9vZmZzZXRYLW9mZnNldFkuaHRtbAog ZmFzdC9mb3Jtcy9udW1iZXIvc3Bpbi1pbi1tdWx0aS1jb2x1bW4uaHRtbAogZmFzdC9mb3Jtcy9y YW5nZS9zbGlkZXItaW4tbXVsdGktY29sdW1uLmh0bWwKIAotIyBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM2NjYKLWh0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5 YmkvYnVmZmVyZWRBbW91bnQtYWZ0ZXItY2xvc2UtaW4tYnVzeS5odG1sCi0KICMgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczNTgzCiBmdWxsc2NyZWVuL3ZpZGVvLWNv bnRyb2xzLW92ZXJyaWRlLmh0bWwKIAo=