73649 2011-12-02 05:38:34 -0800 [Chromium] [WebSocket] Add binary support in echo test server 2011-12-04 23:42:40 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 toyoshim toyoshim abarth ap tkent webkit.review.bot yutak oldest_to_newest 513697 0 toyoshim 2011-12-02 05:38:34 -0800 For now, LayoutTests/http/tests/websocket/tests/hybi/echo_wsh.py supports only text frames. This must support binary frames for chromium side tests. 513700 1 117612 toyoshim 2011-12-02 05:44:22 -0800 Created attachment 117612 Patch 513714 2 117612 yutak 2011-12-02 06:16:15 -0800 Comment on attachment 117612 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117612&action=review Looks fine. (Note: I'm not a WebKit reviewer yet) > LayoutTests/http/tests/websocket/tests/hybi/echo_wsh.py:1 > +# Copyright 2009, 2011, Google Inc. Just replace the old year to the new one instead of appending. (I assume Chromium's copyright year rule applies here as well: http://dev.chromium.org/developers/coding-style#TOC-File-headers) 513814 3 117612 toyoshim 2011-12-02 09:02:51 -0800 Comment on attachment 117612 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117612&action=review >> LayoutTests/http/tests/websocket/tests/hybi/echo_wsh.py:1 >> +# Copyright 2009, 2011, Google Inc. > > Just replace the old year to the new one instead of appending. > > (I assume Chromium's copyright year rule applies here as well: http://dev.chromium.org/developers/coding-style#TOC-File-headers) Another reviewer suggest me adding new year instead of replacing one as a WebKit style. Any guideline to know which file follows which rule? 514271 4 toyoshim 2011-12-02 16:41:43 -0800 FYI; this echo_wsh.py is totally based on pywebsocket example. Old echo_wsh.py come from old pywebsocket, and new echo_wsh.py after this change com from the latest pywebsocket. 514571 5 117612 eric 2011-12-03 13:29:54 -0800 Comment on attachment 117612 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117612&action=review Seems reasonable. >>> LayoutTests/http/tests/websocket/tests/hybi/echo_wsh.py:1 >>> +# Copyright 2009, 2011, Google Inc. >> >> Just replace the old year to the new one instead of appending. >> >> (I assume Chromium's copyright year rule applies here as well: http://dev.chromium.org/developers/coding-style#TOC-File-headers) > > Another reviewer suggest me adding new year instead of replacing one as a WebKit style. > Any guideline to know which file follows which rule? It doesn't matter. :) Anyone who feels it matters should fix check-webkit-style to enforce one or the other. :) Until then, I would tell you not to worry about it. 514904 6 toyoshim 2011-12-04 21:59:02 -0800 Eric, Thank you for an advice on copyright, and r+. 514935 7 117612 webkit.review.bot 2011-12-04 23:42:35 -0800 Comment on attachment 117612 Patch Clearing flags on attachment: 117612 Committed r101974: <http://trac.webkit.org/changeset/101974> 514936 8 webkit.review.bot 2011-12-04 23:42:40 -0800 All reviewed patches have been landed. Closing bug. 117612 2011-12-02 05:44:22 -0800 2011-12-04 23:42:35 -0800 Patch bug-73649-20111202224421.patch text/plain 2025 toyoshim U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxNjgxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODc1YmJmNzJkNTY2MGIxYzI0ZWQ4 NmY1YzY2Nzc3MmNlMTE3MDZhMC4uYWFhOTNkMWE3YmRjMjI2NDU3MWNiYWZkOTk4NTYxNWRiMDEy ZDg5NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDExLTEyLTAyICBUYWthc2hpIFRveW9zaGlt YSAgPHRveW9zaGltQGNocm9taXVtLm9yZz4KKworICAgICAgICBBZGQgYmluYXJ5IHN1cHBvcnQg aW4gV2ViU29ja2V0IHRlc3Qgc2VydmVyJ3MgZWNobyBoYW5kbGVyLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM2NDkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0dHAvdGVzdHMvd2Vic29ja2V0L3Rl c3RzL2h5YmkvZWNob193c2gucHk6IFN1cHBvcnQgYmluYXJ5IGZyYW1lcy4KKwogMjAxMS0xMi0w MSAgVmluY2VudCBTY2hlaWIgIDxzY2hlaWJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJv bWl1bV0gVGVzdCBleHBlY3RhdGlvbnM6CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rl c3RzL3dlYnNvY2tldC90ZXN0cy9oeWJpL2VjaG9fd3NoLnB5IGIvTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy93ZWJzb2NrZXQvdGVzdHMvaHliaS9lY2hvX3dzaC5weQppbmRleCA3OWMzZjEwNTc1YTJm MjgxYjU0MmFlMWFjOWRiZmNlNDQ5YTBjOTcwLi45ODUxZDI2YjM3YjRjOWE3MmNlYWMxNGQ1ODY2 ZGYzYzYxZTllZTYwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tl dC90ZXN0cy9oeWJpL2VjaG9fd3NoLnB5CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vi c29ja2V0L3Rlc3RzL2h5YmkvZWNob193c2gucHkKQEAgLTEsNCArMSw0IEBACi0jIENvcHlyaWdo dCAyMDA5LCBHb29nbGUgSW5jLgorIyBDb3B5cmlnaHQgMjAwOSwgMjAxMSwgR29vZ2xlIEluYy4K ICMgQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMKICMgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBz b3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CkBAIC0yOCwxMCArMjgsNyBA QAogIyBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZ IE9GIFNVQ0ggREFNQUdFLgogCiAKLWZyb20gbW9kX3B5d2Vic29ja2V0IGltcG9ydCBtc2d1dGls Ci0KLQotX0dPT0RCWUVfTUVTU0FHRSA9ICdHb29kYnllJworX0dPT0RCWUVfTUVTU0FHRSA9IHUn R29vZGJ5ZScKIAogCiBkZWYgd2ViX3NvY2tldF9kb19leHRyYV9oYW5kc2hha2UocmVxdWVzdCk6 CkBAIC00MCw3ICszNywxMiBAQCBkZWYgd2ViX3NvY2tldF9kb19leHRyYV9oYW5kc2hha2UocmVx dWVzdCk6CiAKIGRlZiB3ZWJfc29ja2V0X3RyYW5zZmVyX2RhdGEocmVxdWVzdCk6CiAgICAgd2hp bGUgVHJ1ZToKLSAgICAgICAgbGluZSA9IG1zZ3V0aWwucmVjZWl2ZV9tZXNzYWdlKHJlcXVlc3Qp Ci0gICAgICAgIG1zZ3V0aWwuc2VuZF9tZXNzYWdlKHJlcXVlc3QsIGxpbmUpCi0gICAgICAgIGlm IGxpbmUgPT0gX0dPT0RCWUVfTUVTU0FHRToKKyAgICAgICAgbGluZSA9IHJlcXVlc3Qud3Nfc3Ry ZWFtLnJlY2VpdmVfbWVzc2FnZSgpCisgICAgICAgIGlmIGxpbmUgaXMgTm9uZToKICAgICAgICAg ICAgIHJldHVybgorICAgICAgICBpZiBpc2luc3RhbmNlKGxpbmUsIHVuaWNvZGUpOgorICAgICAg ICAgICAgcmVxdWVzdC53c19zdHJlYW0uc2VuZF9tZXNzYWdlKGxpbmUsIGJpbmFyeT1GYWxzZSkK KyAgICAgICAgICAgIGlmIGxpbmUgPT0gX0dPT0RCWUVfTUVTU0FHRToKKyAgICAgICAgICAgICAg ICByZXR1cm4KKyAgICAgICAgZWxzZToKKyAgICAgICAgICAgIHJlcXVlc3Qud3Nfc3RyZWFtLnNl bmRfbWVzc2FnZShsaW5lLCBiaW5hcnk9VHJ1ZSkK