73630 2011-12-01 23:44:41 -0800 [Qt] Change default WebSocket protocol to the latest one 2012-03-15 16:17:54 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED Qt P3 Normal --- 1 yutak yutak ahf cmarcelo hausmann jesus jturcotte kenneth laszlo.gombos ossy webkit.review.bot oldest_to_newest 513562 0 yutak 2011-12-01 23:44:41 -0800 Currently, WebKitQt only supports the old WebSocket protocol (hixie-76). The old protocol is known to have a security defect, and should be phased out into the new protocol. The new protocol (hybi-17, which is going to be published as RFC6455 soon) is already implemented in WebCore and we can switch to the new protocol using WebCore::Settings. LayoutTests for hybi-17 are running fine on Qt bots, hence we essentially just need to switch the default value of a Settings flag. Qt folks, are you happy with this change? Maybe I should bring up this topic on webkit-qt list? (Note: the old protocol and the new one are incompatible; if there's any existing service depending on the old protocol, it will break.) 516557 1 ahf 2011-12-07 02:23:16 -0800 Sure, we would be happy with that change :) 518152 2 hausmann 2011-12-09 00:06:02 -0800 I'd say go for it. I'm not aware of anyone using the Qt port and relying on a particular web socket protocol version. I'm inclined to say that our interest is to follow the majority of the other ports in this regards and if there was a "project default" (that ports _may_ optionally deviate from), then I think we'd be in the group interested in following the default, at this point. 518178 3 jturcotte 2011-12-09 01:31:32 -0800 We never officially supported the InspectorServerQt in WebKit/qt but this will break the support for QtWebKit clients with it. On the other hand I need this to be switched on to support the new remote inspector in WebKit2, so I'm looking forward to this :) 523850 4 yutak 2011-12-19 05:30:15 -0800 (In reply to comment #2) > I'd say go for it. I'm not aware of anyone using the Qt port and relying on a particular web socket protocol version. I'm inclined to say that our interest is to follow the majority of the other ports in this regards and if there was a "project default" (that ports _may_ optionally deviate from), then I think we'd be in the group interested in following the default, at this point. I'm fine with either following the project default or switching right now. Before switching the project default, I'd like to confirm the hybi tests run fine on WebKit2 bots (and fix any issues if found). The tests aren't run at this moment as WebKitTestRunner lacks LayoutTestController.overridePreference() implementation. 578546 5 jesus 2012-03-14 10:38:32 -0700 What is the status of this? 578566 6 yutak 2012-03-14 11:05:48 -0700 GTK already transitioned (bug 74064), Mac/Win/WK2 also transitioned (bug 78541). So I think, among the ports I'm aware of, Qt is the only one left on the old protocol. Sounds like it's time to switch the flag for Qt, and also flip the WebCore-global default value. I'd like to make the transition two-fold: 1) Complete the transition on Qt and make sure things are fine. 2) Flip the global default value and remove port-specific defaults. Does this make sense? If so, I'm going to upload a patch that just changes Qt's default. 578568 7 yutak 2012-03-14 11:06:53 -0700 (In reply to comment #6) > I'd like to make the transition two-fold: > 1) Complete the transition on Qt and make sure things are fine. 1.9) Announce webkit-dev about the transition. > 2) Flip the global default value and remove port-specific defaults. 578574 8 jesus 2012-03-14 11:13:44 -0700 (In reply to comment #6) > Does this make sense? If so, I'm going to upload a patch that just changes Qt's default. I'm fine with it and according to previous comments here I believe the others also are. 578579 9 131887 yutak 2012-03-14 11:20:02 -0700 Created attachment 131887 Patch 579696 10 131887 hausmann 2012-03-15 13:43:33 -0700 Comment on attachment 131887 Patch rs=me 579708 11 131887 yutak 2012-03-15 13:58:39 -0700 Comment on attachment 131887 Patch Thanks! 579861 12 131887 webkit.review.bot 2012-03-15 16:17:49 -0700 Comment on attachment 131887 Patch Clearing flags on attachment: 131887 Committed r110905: <http://trac.webkit.org/changeset/110905> 579862 13 webkit.review.bot 2012-03-15 16:17:54 -0700 All reviewed patches have been landed. Closing bug. 131887 2012-03-14 11:20:02 -0700 2012-03-15 16:17:49 -0700 Patch bug-73630-20120314112001.patch text/plain 1363 yutak U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDY0Y2I2NWQzMWU5 NjEyYWZhNWNkMzkwNjA1M2YwYTliYWQ0ZGE2MzguLjI4Y2M2NTRjNmQzN2IyZDZmMDMxNjEyYTQ1 M2YyOGExMWY2MTc3ZjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDMt MTQgIFl1dGEgS2l0YW11cmEgIDx5dXRha0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW1F0XSBD aGFuZ2UgZGVmYXVsdCBXZWJTb2NrZXQgcHJvdG9jb2wgdG8gdGhlIGxhdGVzdCBvbmUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczNjMwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBBcGkvcXdlYnBhZ2Uu Y3BwOgorICAgICAgICAoUVdlYlBhZ2VQcml2YXRlOjpRV2ViUGFnZVByaXZhdGUpOgorICAgICAg ICBVc2UgUkZDNjQ1NSBXZWJTb2NrZXQgcHJvdG9jb2wgYnkgZGVmYXVsdC4KKwogMjAxMi0wMy0x MyAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBBdHRl bXB0IHRvIGZpeCBRdE1pbmltYWwgYm90IGFmdGVyIHIxMTA1OTUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJw YWdlLmNwcAppbmRleCAzY2ZiOWIxY2M1ZTUyNzU5ZWZjZjQ4ZTg5NGEwMjE5NDcxOWVlMjQ1Li5k NDZjZmM2MGRjOGZhMDZkYjc2YzNlZTQ5NTVmMGY3MmM0NTVkYTM2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9xdC9BcGkv cXdlYnBhZ2UuY3BwCkBAIC0zNTYsNiArMzU2LDEwIEBAIFFXZWJQYWdlUHJpdmF0ZTo6UVdlYlBh Z2VQcml2YXRlKFFXZWJQYWdlICpxcSkKICNlbmRpZgogICAgIHNldHRpbmdzID0gbmV3IFFXZWJT ZXR0aW5ncyhwYWdlLT5zZXR0aW5ncygpKTsKIAorI2lmIEVOQUJMRShXRUJfU09DS0VUUykKKyAg ICBwYWdlLT5zZXR0aW5ncygpLT5zZXRVc2VIaXhpZTc2V2ViU29ja2V0UHJvdG9jb2woZmFsc2Up OworI2VuZGlmCisKICAgICBoaXN0b3J5LmQgPSBuZXcgUVdlYkhpc3RvcnlQcml2YXRlKHN0YXRp Y19jYXN0PFdlYkNvcmU6OkJhY2tGb3J3YXJkTGlzdEltcGwqPihwYWdlLT5iYWNrRm9yd2FyZExp c3QoKSkpOwogICAgIG1lbXNldChhY3Rpb25zLCAwLCBzaXplb2YoYWN0aW9ucykpOwogCg==