73629 2011-12-01 23:30:39 -0800 [Chromium] Show placeholder even if the element is focused 2011-12-14 23:52:02 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 73615 1 tkent tkent dglazkov gordeon mathias morrita oldest_to_newest 513552 0 tkent 2011-12-01 23:30:39 -0800 Follows the behavior of Apple ports. The new behavior is allowed by the standard. http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#the-placeholder-attribute 513556 1 117578 tkent 2011-12-01 23:34:32 -0800 Created attachment 117578 Patch 513560 2 117578 tkent 2011-12-01 23:38:01 -0800 Comment on attachment 117578 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117578&action=review > Source/WebCore/ChangeLog:8 > + No new tests. Need to update some existing placeholder tests. Affected tests were already marked as FAIL in http://trac.webkit.org/changeset/101742. > Source/WebCore/rendering/RenderThemeChromiumSkia.h:160 > + int menuListInternalPadding(RenderStyle*, int paddingType) const; > + bool paintMediaButtonInternal(GraphicsContext*, const IntRect&, Image*); > + IntRect convertToPaintingRect(RenderObject* inputRenderer, const RenderObject* partRenderer, IntRect partRect, const IntRect& localOffset) const; > +}; Note: The declaration of RenderThemeChromiumSkia starts at the first column. The current indentation of these functions and '};' are wrong. 513569 3 tkent 2011-12-01 23:54:21 -0800 Chromium bug: http://code.google.com/p/chromium/issues/detail?id=103025 514097 4 117578 tkent 2011-12-02 13:56:00 -0800 Comment on attachment 117578 Patch Clearing flags on attachment: 117578 Committed r101848: <http://trac.webkit.org/changeset/101848> 514098 5 tkent 2011-12-02 13:56:06 -0800 All reviewed patches have been landed. Closing bug. 117578 2011-12-01 23:34:32 -0800 2011-12-02 13:56:00 -0800 Patch bug-73629-20111202163431.patch text/plain 4348 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxNzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTllMWVkZTU2OTAwMTEy MjIyYmYwMmU5OTE3YjBlYzFmZjFhM2FjZS4uYWVjNDZiNWQyOTQxNWVmYjQxYzExNDdlYjdlM2Yx NDBiYjM4NDE2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDExLTEyLTAyICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIFNob3cg cGxhY2Vob2xkZXIgZXZlbiBpZiB0aGUgZWxlbWVudCBpcyBmb2N1c2VkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzYyOQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gTmVlZCB0byB1 cGRhdGUgc29tZSBleGlzdGluZyBwbGFjZWhvbGRlciB0ZXN0cy4KKworICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJUaGVtZUNocm9taXVtTWFjLmg6IEFkZCBzaG91bGRTaG93UGxhY2Vob2xkZXJX aGVuRm9jdXNlZCgpLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtTWFj Lm1tOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVDaHJvbWl1bU1hYzo6c2hvdWxkU2hv d1BsYWNlaG9sZGVyV2hlbkZvY3VzZWQpOgorICAgICAgICBSZXR1cm5zIHRydWUuCisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1Ta2lhLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlclRoZW1lQ2hyb21pdW1Ta2lhOjpzaG91bGRTaG93UGxhY2Vob2xkZXJXaGVuRm9j dXNlZCk6IGRpdHRvLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tp YS5oOiBBZGQgc2hvdWxkU2hvd1BsYWNlaG9sZGVyV2hlbkZvY3VzZWQoKS4KKwogMjAxMS0xMi0w MSAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lP TihyOTA5NzEpOiBQbGFjZWhvbGRlciB0ZXh0IG9mIGlucHV0IGNvbnRyb2wgaXMgcmVuZGVyZWQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVt TWFjLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bU1hYy5o CmluZGV4IDE1ZDg4NWIwNDZmZmE0N2IyNjhlYzZhODU4NDZhMzMxMzI0NGM0ODEuLjg3ZDAyYzBk NDk1OGEwMDc1ZDg4NjIyMDBiMWFkMzYyNGE1ODA1ZmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtTWFjLmgKKysrIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1NYWMuaApAQCAtNTcsOSArNTcsMTEgQEAg cHJvdGVjdGVkOgogCiAgICAgdmlydHVhbCBpbnQgcG9wdXBJbnRlcm5hbFBhZGRpbmdMZWZ0KFJl bmRlclN0eWxlKikgY29uc3Q7CiAgICAgdmlydHVhbCBpbnQgcG9wdXBJbnRlcm5hbFBhZGRpbmdS aWdodChSZW5kZXJTdHlsZSopIGNvbnN0OworCiBwcml2YXRlOgogICAgIHZpcnR1YWwgdm9pZCB1 cGRhdGVBY3RpdmVTdGF0ZShOU0NlbGwqLCBjb25zdCBSZW5kZXJPYmplY3QqKTsKICAgICB2aXJ0 dWFsIFN0cmluZyBleHRyYURlZmF1bHRTdHlsZVNoZWV0KCk7CisgICAgdmlydHVhbCBib29sIHNo b3VsZFNob3dQbGFjZWhvbGRlcldoZW5Gb2N1c2VkKCkgY29uc3QgT1ZFUlJJREU7CiB9OwogCiB9 IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyVGhlbWVDaHJvbWl1bU1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJUaGVtZUNocm9taXVtTWFjLm1tCmluZGV4IDYwMjQyNTQ0MTgxOGM2YjFhMDkzMDlhZmQz ZjIxYTk4MjIyY2MyNzIuLjExYmJhZmUyMDgyODdkMjgwM2JlNGEyMTNjNDUyZTZjMGFlMjQxMTkg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVt TWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVt TWFjLm1tCkBAIC0xMjAsNiArMTIwLDExIEBAIHZvaWQgUmVuZGVyVGhlbWVDaHJvbWl1bU1hYzo6 dXBkYXRlQWN0aXZlU3RhdGUoTlNDZWxsKiBjZWxsLCBjb25zdCBSZW5kZXJPYmplY3QqCiAgICAg ICAgIFtjZWxsIHNldENvbnRyb2xUaW50OnRpbnRdOwogfQogCitib29sIFJlbmRlclRoZW1lQ2hy b21pdW1NYWM6OnNob3VsZFNob3dQbGFjZWhvbGRlcldoZW5Gb2N1c2VkKCkgY29uc3QKK3sKKyAg ICByZXR1cm4gdHJ1ZTsKK30KKwogI2lmIEVOQUJMRShWSURFTykKIAogdm9pZCBSZW5kZXJUaGVt ZUNocm9taXVtTWFjOjphZGp1c3RNZWRpYVNsaWRlclRodW1iU2l6ZShSZW5kZXJTdHlsZSogc3R5 bGUpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhl bWVDaHJvbWl1bVNraWEuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1l Q2hyb21pdW1Ta2lhLmNwcAppbmRleCAzZjNjNmFlZTgyZjQyZTMxMWI4ZWEwYzhkZTE1MzczZDY4 ZmViYjJiLi4wMzBhYzM1YWVhMjAyZDc1NzI5YWMxNWM2NGY4Mjc4ZTNiNzMxMmFjIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tpYS5j cHAKQEAgLTU0MCw2ICs1NDAsMTEgQEAgaW50IFJlbmRlclRoZW1lQ2hyb21pdW1Ta2lhOjptZW51 TGlzdEludGVybmFsUGFkZGluZyhSZW5kZXJTdHlsZSogc3R5bGUsIGludCBwYWQKICAgICByZXR1 cm4gcGFkZGluZzsKIH0KIAorYm9vbCBSZW5kZXJUaGVtZUNocm9taXVtU2tpYTo6c2hvdWxkU2hv d1BsYWNlaG9sZGVyV2hlbkZvY3VzZWQoKSBjb25zdAoreworICAgIHJldHVybiB0cnVlOworfQor CiAjaWYgRU5BQkxFKFBST0dSRVNTX1RBRykKIAogLy8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tpYS5oIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1Ta2lhLmgKaW5kZXggMGM5OThiMzI2NTQxZmRh YzQ5YjgyZWNiNDU0ZjkwOGU5OTgzZGFiYi4uZDBkZDQyNGFhMTk3NGY5ZDNjNTI2MGE3MjFlNDA5 MTkxZTNkYmFkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRo ZW1lQ2hyb21pdW1Ta2lhLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRo ZW1lQ2hyb21pdW1Ta2lhLmgKQEAgLTE1MSwxMSArMTUxLDEzIEBAIGNsYXNzIFJlbmRlclRoZW1l Q2hyb21pdW1Ta2lhIDogcHVibGljIFJlbmRlclRoZW1lIHsKICAgICAgICAgSW50UmVjdCBwcm9n cmVzc1ZhbHVlUmVjdEZvcihSZW5kZXJQcm9ncmVzcyosIGNvbnN0IEludFJlY3QmKSBjb25zdDsK ICNlbmRpZgogCi0gICAgcHJpdmF0ZToKLSAgICAgICAgaW50IG1lbnVMaXN0SW50ZXJuYWxQYWRk aW5nKFJlbmRlclN0eWxlKiwgaW50IHBhZGRpbmdUeXBlKSBjb25zdDsKLSAgICAgICAgYm9vbCBw YWludE1lZGlhQnV0dG9uSW50ZXJuYWwoR3JhcGhpY3NDb250ZXh0KiwgY29uc3QgSW50UmVjdCYs IEltYWdlKik7Ci0gICAgICAgIEludFJlY3QgY29udmVydFRvUGFpbnRpbmdSZWN0KFJlbmRlck9i amVjdCogaW5wdXRSZW5kZXJlciwgY29uc3QgUmVuZGVyT2JqZWN0KiBwYXJ0UmVuZGVyZXIsIElu dFJlY3QgcGFydFJlY3QsIGNvbnN0IEludFJlY3QmIGxvY2FsT2Zmc2V0KSBjb25zdDsKLSAgICB9 OworcHJpdmF0ZToKKyAgICB2aXJ0dWFsIGJvb2wgc2hvdWxkU2hvd1BsYWNlaG9sZGVyV2hlbkZv Y3VzZWQoKSBjb25zdCBPVkVSUklERTsKKworICAgIGludCBtZW51TGlzdEludGVybmFsUGFkZGlu ZyhSZW5kZXJTdHlsZSosIGludCBwYWRkaW5nVHlwZSkgY29uc3Q7CisgICAgYm9vbCBwYWludE1l ZGlhQnV0dG9uSW50ZXJuYWwoR3JhcGhpY3NDb250ZXh0KiwgY29uc3QgSW50UmVjdCYsIEltYWdl Kik7CisgICAgSW50UmVjdCBjb252ZXJ0VG9QYWludGluZ1JlY3QoUmVuZGVyT2JqZWN0KiBpbnB1 dFJlbmRlcmVyLCBjb25zdCBSZW5kZXJPYmplY3QqIHBhcnRSZW5kZXJlciwgSW50UmVjdCBwYXJ0 UmVjdCwgY29uc3QgSW50UmVjdCYgbG9jYWxPZmZzZXQpIGNvbnN0OworfTsKIAogfSAvLyBuYW1l c3BhY2UgV2ViQ29yZQogCg==