73625 2011-12-01 22:37:40 -0800 [EFL] Remove dangle entry pointer from matrix list 2011-12-02 18:00:08 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 jungjik.lee webkit-unassigned gyuyoung.kim gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 513512 0 jungjik.lee 2011-12-01 22:37:40 -0800 Before freeing the item, it also should be removed from the matrix list. so that it prevent leaving dangling pointer on the matrix list. 513523 1 117573 jungjik.lee 2011-12-01 22:48:07 -0800 Created attachment 117573 proposal_patch 513525 2 117574 jungjik.lee 2011-12-01 22:50:39 -0800 Created attachment 117574 add patch number 513526 3 webkit.review.bot 2011-12-01 22:50:48 -0800 Attachment 117573 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/efl/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 513549 4 117574 gyuyoung.kim 2011-12-01 23:25:07 -0800 Comment on attachment 117574 add patch number LGTM. 513640 5 117574 webkit.review.bot 2011-12-02 03:04:23 -0800 Comment on attachment 117574 add patch number Rejecting attachment 117574 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 10105 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 48>At revision 10105. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/10697000 513833 6 117636 jungjik.lee 2011-12-02 09:22:39 -0800 Created attachment 117636 rebased patch please land it manually. 514175 7 117636 webkit.review.bot 2011-12-02 14:44:44 -0800 Comment on attachment 117636 rebased patch Rejecting attachment 117636 from review queue. jungjik.lee@samsung.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 514207 8 gyuyoung.kim 2011-12-02 15:02:04 -0800 (In reply to comment #6) > Created an attachment (id=117636) [details] > rebased patch > > please land it manually. Jung Jik, Do not set r+ after now. Reviewer is only able to set r+. In this case, you just need to request for cq?. 514292 9 jungjik.lee 2011-12-02 17:18:01 -0800 (In reply to comment #8) > (In reply to comment #6) > > Created an attachment (id=117636) [details] [details] > > rebased patch > > > > please land it manually. > > Jung Jik, Do not set r+ after now. Reviewer is only able to set r+. In this case, you just need to request for cq?. Now I know, Thanks gyuyoung. 514320 10 117636 webkit.review.bot 2011-12-02 18:00:03 -0800 Comment on attachment 117636 rebased patch Clearing flags on attachment: 117636 Committed r101887: <http://trac.webkit.org/changeset/101887> 514321 11 webkit.review.bot 2011-12-02 18:00:08 -0800 All reviewed patches have been landed. Closing bug. 117573 2011-12-01 22:48:07 -0800 2011-12-01 22:50:39 -0800 proposal_patch proposal.patch text/plain 1427 jungjik.lee ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAyZTllYmMwLi5jZjA4OTM3IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMTItMDEgIEp1bmdKaWsgTGVlICA8anVuZ2ppay5sZWVAc2Ft c3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gUmVtb3ZlIGVudHJ5IHBvaW50ZXIgYmVmb3JlIGZy ZWVpbmcgaXQgZnJvbSBtYXRyaXguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD1YWFhYWAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRvIHByZXZlbnQgbGVhdmluZyBkYW5nbGluZyBwb2ludGVyIG9uIHRoZSBt YXRyaXgsIHJlbW92ZSB0aGUgZW50cnkgYmVmb3JlIGZyZWVpbmcgaXQuCisKKyAgICAgICAgKiBl d2svZXdrX3RpbGVkX21hdHJpeC5jcHA6CisgICAgICAgIChld2tfdGlsZV9tYXRyaXhfZnJlZSk6 CisKIDIwMTEtMTItMDEgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1v Ymk+CiAKICAgICAgICAgW0VGTF0gUmVtb3ZlIHRoZSBld2tfcHJvdG9jb2xfaGFuZGxlci1yZWxh dGVkIGNvZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfbWF0 cml4LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfbWF0cml4LmNwcAppbmRl eCBjM2E1OTZkLi42OTIzNmI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdr X3RpbGVkX21hdHJpeC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxlZF9t YXRyaXguY3BwCkBAIC0zMDIsNyArMzAyLDggQEAgdm9pZCBld2tfdGlsZV9tYXRyaXhfZnJlZShF d2tfVGlsZV9NYXRyaXgqIHRpbGVNYXRyaXgpCiAgICAgZXdrX3RpbGVfdW51c2VkX2NhY2hlX2Zy ZWV6ZSh0aWxlTWF0cml4LT50aWxpZVVudXNlZENhY2hlKTsKICAgICBld2tfdGlsZV9tYXRyaXhf aW52YWxpZGF0ZSh0aWxlTWF0cml4KTsKICAgICBlbnRyeSA9IEVJTkFfSU5MSVNUX0NPTlRBSU5F Ul9HRVQodGlsZU1hdHJpeC0+bWF0cmljZXMsIEV3a19UaWxlX01hdHJpeF9FbnRyeSk7Ci0gICAg ZWluYV9tYXRyaXhzcGFyc2VfZnJlZShlbnRyeS0+bWF0cml4KTsgICAgCisgICAgdGlsZU1hdHJp eC0+bWF0cmljZXMgPSBlaW5hX2lubGlzdF9yZW1vdmUodGlsZU1hdHJpeC0+bWF0cmljZXMsIChF aW5hX0lubGlzdCAqKWVudHJ5KTsKKyAgICBlaW5hX21hdHJpeHNwYXJzZV9mcmVlKGVudHJ5LT5t YXRyaXgpOwogICAgIGZyZWUoZW50cnkpOwogICAgIHRpbGVNYXRyaXgtPm1hdHJpY2VzID0gMDsK IAo= 117574 2011-12-01 22:50:39 -0800 2011-12-02 09:22:39 -0800 add patch number minor_fix.patch text/plain 1427 jungjik.lee ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAyZTllYmMwLi5lOThkYTEwIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMTItMDEgIEp1bmdKaWsgTGVlICA8anVuZ2ppay5sZWVAc2Ft c3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gUmVtb3ZlIGVudHJ5IHBvaW50ZXIgYmVmb3JlIGZy ZWVpbmcgaXQgZnJvbSBtYXRyaXguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD03MzYyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRvIHByZXZlbnQgbGVhdmluZyBkYW5nbGluZyBwb2ludGVyIG9uIHRoZSBt YXRyaXgsIHJlbW92ZSB0aGUgZW50cnkgYmVmb3JlIGZyZWVpbmcgaXQuCisKKyAgICAgICAgKiBl d2svZXdrX3RpbGVkX21hdHJpeC5jcHA6CisgICAgICAgIChld2tfdGlsZV9tYXRyaXhfZnJlZSk6 CisKIDIwMTEtMTItMDEgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1v Ymk+CiAKICAgICAgICAgW0VGTF0gUmVtb3ZlIHRoZSBld2tfcHJvdG9jb2xfaGFuZGxlci1yZWxh dGVkIGNvZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfbWF0 cml4LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfbWF0cml4LmNwcAppbmRl eCBjM2E1OTZkLi42OTIzNmI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdr X3RpbGVkX21hdHJpeC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxlZF9t YXRyaXguY3BwCkBAIC0zMDIsNyArMzAyLDggQEAgdm9pZCBld2tfdGlsZV9tYXRyaXhfZnJlZShF d2tfVGlsZV9NYXRyaXgqIHRpbGVNYXRyaXgpCiAgICAgZXdrX3RpbGVfdW51c2VkX2NhY2hlX2Zy ZWV6ZSh0aWxlTWF0cml4LT50aWxpZVVudXNlZENhY2hlKTsKICAgICBld2tfdGlsZV9tYXRyaXhf aW52YWxpZGF0ZSh0aWxlTWF0cml4KTsKICAgICBlbnRyeSA9IEVJTkFfSU5MSVNUX0NPTlRBSU5F Ul9HRVQodGlsZU1hdHJpeC0+bWF0cmljZXMsIEV3a19UaWxlX01hdHJpeF9FbnRyeSk7Ci0gICAg ZWluYV9tYXRyaXhzcGFyc2VfZnJlZShlbnRyeS0+bWF0cml4KTsgICAgCisgICAgdGlsZU1hdHJp eC0+bWF0cmljZXMgPSBlaW5hX2lubGlzdF9yZW1vdmUodGlsZU1hdHJpeC0+bWF0cmljZXMsIChF aW5hX0lubGlzdCAqKWVudHJ5KTsKKyAgICBlaW5hX21hdHJpeHNwYXJzZV9mcmVlKGVudHJ5LT5t YXRyaXgpOwogICAgIGZyZWUoZW50cnkpOwogICAgIHRpbGVNYXRyaXgtPm1hdHJpY2VzID0gMDsK IAo= 117636 2011-12-02 09:22:39 -0800 2011-12-02 18:00:03 -0800 rebased patch rebase.patch text/plain 1416 jungjik.lee ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBkYzE3YWIxLi5mNDlmYzYxIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMTItMDIgIEp1bmdKaWsgTGVlICA8anVuZ2ppay5sZWVAc2Ft c3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gUmVtb3ZlIGVudHJ5IHBvaW50ZXIgYmVmb3JlIGZy ZWVpbmcgaXQgZnJvbSBtYXRyaXguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD03MzYyNQorCisgICAgICAgIFJldmlld2VkIGJ5IFJ5b3N1a2UgTml3YS4K KworICAgICAgICBUbyBwcmV2ZW50IGxlYXZpbmcgZGFuZ2xpbmcgcG9pbnRlciBvbiB0aGUgbWF0 cml4LCByZW1vdmUgdGhlIGVudHJ5IGJlZm9yZSBmcmVlaW5nIGl0LgorCisgICAgICAgICogZXdr L2V3a190aWxlZF9tYXRyaXguY3BwOgorICAgICAgICAoZXdrX3RpbGVfbWF0cml4X2ZyZWUpOgor CiAyMDExLTEyLTAxICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KIAogICAg ICAgICBbRUZMXSBDbGVhbnVwIGluY2x1ZGVzIHRvIHJlZHVjZSBjb2RlIGNvbXBsZXhpdHkuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX21hdHJpeC5jcHAgYi9T b3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX21hdHJpeC5jcHAKaW5kZXggYzNhNTk2ZC4u NjkyMzZiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxlZF9tYXRy aXguY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfbWF0cml4LmNwcApA QCAtMzAyLDcgKzMwMiw4IEBAIHZvaWQgZXdrX3RpbGVfbWF0cml4X2ZyZWUoRXdrX1RpbGVfTWF0 cml4KiB0aWxlTWF0cml4KQogICAgIGV3a190aWxlX3VudXNlZF9jYWNoZV9mcmVlemUodGlsZU1h dHJpeC0+dGlsaWVVbnVzZWRDYWNoZSk7CiAgICAgZXdrX3RpbGVfbWF0cml4X2ludmFsaWRhdGUo dGlsZU1hdHJpeCk7CiAgICAgZW50cnkgPSBFSU5BX0lOTElTVF9DT05UQUlORVJfR0VUKHRpbGVN YXRyaXgtPm1hdHJpY2VzLCBFd2tfVGlsZV9NYXRyaXhfRW50cnkpOwotICAgIGVpbmFfbWF0cml4 c3BhcnNlX2ZyZWUoZW50cnktPm1hdHJpeCk7ICAgIAorICAgIHRpbGVNYXRyaXgtPm1hdHJpY2Vz ID0gZWluYV9pbmxpc3RfcmVtb3ZlKHRpbGVNYXRyaXgtPm1hdHJpY2VzLCAoRWluYV9Jbmxpc3Qg KillbnRyeSk7CisgICAgZWluYV9tYXRyaXhzcGFyc2VfZnJlZShlbnRyeS0+bWF0cml4KTsKICAg ICBmcmVlKGVudHJ5KTsKICAgICB0aWxlTWF0cml4LT5tYXRyaWNlcyA9IDA7CiAK