73623 2011-12-01 22:18:30 -0800 [Chromium] Fix compilation warnings for ASSERT() 2011-12-02 14:42:44 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other All RESOLVED FIXED P2 Minor --- 69997 1 tkent tkent tony webkit.review.bot zhenghao oldest_to_newest 513485 0 tkent 2011-12-01 22:18:30 -0800 /Volumes/d2/WebKit/Source/WebKit/chromium/../../../Tools/DumpRenderTree/chromium/ImageDiff.cpp:155:9: warning: conversion specifies type 'char *' but the argument has type 'int' [-Wformat] /Volumes/d2/WebKit/Source/WebKit/chromium/../../../Tools/DumpRenderTree/chromium/ImageDiff.cpp:55:47: note: expanded from macro 'ASSERT' 513487 1 117566 tkent 2011-12-01 22:20:35 -0800 Created attachment 117566 Patch 513899 2 117566 tony 2011-12-02 10:24:41 -0800 Comment on attachment 117566 Patch Thanks! 514173 3 117566 webkit.review.bot 2011-12-02 14:42:40 -0800 Comment on attachment 117566 Patch Clearing flags on attachment: 117566 Committed r101857: <http://trac.webkit.org/changeset/101857> 514174 4 webkit.review.bot 2011-12-02 14:42:44 -0800 All reviewed patches have been landed. Closing bug. 117566 2011-12-01 22:20:35 -0800 2011-12-02 14:42:40 -0800 Patch bug-73623-20111202152033.patch text/plain 1510 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxNzQwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzVjMDVkNjg2YTIxYjBmZGZlNjFkODM5OWQ3NjFhMTFl NTAzODRkZi4uZDc0MjJlYWVmMjhjMjc3MGVmNjZjZjFhOGVmZDE1YmJjYTMyN2FmYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDExLTEyLTAxICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAg ICAgICBbQ2hyb21pdW1dIEZpeCBjb21waWxhdGlvbiB3YXJuaW5ncyBmb3IgQVNTRVJUKCkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczNjIzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVy VHJlZS9jaHJvbWl1bS9JbWFnZURpZmYuY3BwOgorICAgICAgICAgLSBGaXggZnByaW50ZiBmb3Jt YXQ6ICVzIC0+ICVkIGZvciBfX0xJTkVfXworICAgICAgICAgLSBEbyBub3RoaW5nIGZvciBBU1NF UlQoKSBpZiBOREVCVUcuCisKIDIwMTEtMTItMDEgIEhheWF0byBJdG8gIDxoYXlhdG9AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIEV4cGxpY2l0bHkgcGFzcyB0b2xlcmFuY2U9MCB0byBwb3J0LmRp ZmZfaW1hZ2UgaW4gY2FzZSBvZiBSZWZUZXN0TWlzbWF0Y2ggZmFpbHVyZS4KZGlmZiAtLWdpdCBh L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0ltYWdlRGlmZi5jcHAgYi9Ub29scy9EdW1w UmVuZGVyVHJlZS9jaHJvbWl1bS9JbWFnZURpZmYuY3BwCmluZGV4IDgwMWVhOWZlOWRmYTU2ZmQw MTU1MGQ2YjNiOTdkNDgyYjNmNWYxNzUuLjk2NjU1NGJhYmIyYWM4ZmQ5ZTU0OGM3MGFhODA2OTNh YTM1MGE5NWEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0ltYWdl RGlmZi5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vSW1hZ2VEaWZmLmNw cApAQCAtNTAsMTIgKzUwLDE2IEBACiAjZW5kaWYKIAogLy8gRGVmaW5lIG1hY3JvIGhlcmUgdG8g bWFrZSBJbWFnZURpZmYgaW5kZXBlbmRlbnQgb2YgSmF2YVNjcmlwdENvcmUuCisjaWZkZWYgTkRF QlVHCisjZGVmaW5lIEFTU0VSVChhc3NlcnRpb24pIGRvIHsgfSB3aGlsZSAoMCkKKyNlbHNlCiAj ZGVmaW5lIEFTU0VSVChhc3NlcnRpb24pIGRvIFwKICAgICBpZiAoIShhc3NlcnRpb24pKSB7IFwK LSAgICAgICAgZnByaW50ZihzdGRlcnIsICJBU1NFUlQgZmFpbGVkIGF0ICVzOiVzOiAiICNhc3Nl cnRpb24gIi4iLCBfX0ZJTEVfXywgX19MSU5FX18pOyBcCisgICAgICAgIGZwcmludGYoc3RkZXJy LCAiQVNTRVJUIGZhaWxlZCBhdCAlczolZDogIiAjYXNzZXJ0aW9uICIuIiwgX19GSUxFX18sIF9f TElORV9fKTsgXAogICAgICAgICBleGl0KDEpOyBcCiAgICAgfSBcCiB3aGlsZSAoMCkKKyNlbmRp ZgogCiB1c2luZyBuYW1lc3BhY2Ugc3RkOwogCg==