73615 2011-12-01 20:25:51 -0800 [Lion][Windows] Both of placeholder and input text are shown in <input type=number> 2011-12-02 13:50:57 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Mac OS X 10.7 RESOLVED FIXED P2 Normal --- 73629 1 tkent tkent darin joepeck jonlee sam webkit.review.bot oldest_to_newest 513434 0 tkent 2011-12-01 20:25:51 -0800 This problem happens only OS X Lion and Windows, that is to say, RenderTheme*::shouldShowPlaceholderWhenFocused() returns true. How to reproduce: 1. Focus on a number input with a placeholder such as <input type=number placeholder=placeholder> 2. Type non-digit characters. e.g. 'aaa' Expected result: 3. The placeholder disappears. Actual result: 3. Both of the placeholder and 'aaa' are shown. 513464 1 117561 tkent 2011-12-01 21:22:11 -0800 Created attachment 117561 Patch 513910 2 117561 joepeck 2011-12-02 10:35:55 -0800 Comment on attachment 117561 Patch Oh nice, is this a ref test? Awesome! r=me 514091 3 117561 tkent 2011-12-02 13:50:51 -0800 Comment on attachment 117561 Patch Clearing flags on attachment: 117561 Committed r101847: <http://trac.webkit.org/changeset/101847> 514092 4 tkent 2011-12-02 13:50:57 -0800 All reviewed patches have been landed. Closing bug. 117561 2011-12-01 21:22:11 -0800 2011-12-02 13:50:51 -0800 Patch bug-73615-20111202142209.patch text/plain 6918 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxNzMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzgxY2I1MzIxOGM1MmVl OTFiZTIyMGRhNzI1MGM2ODQxNTY2NzM0Yy4uZDEzMDhkMGMxYWMzMDc0NTMxYjg4MmYwMzhjYzdh YzE3NDFhMWMzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDExLTEyLTAxICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBbTGlvbl1bV2luZG93c10g Qm90aCBvZiBwbGFjZWhvbGRlciBhbmQgaW5wdXQgdGV4dCBhcmUgc2hvd24gaW4gPGlucHV0IHR5 cGU9bnVtYmVyPgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzM2MTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBQbGFjZWhvbGRlciB2aXNpYmlsaXR5IHdhcyBjaGVja2VkIGJ5IEhUTUxJbnB1dEVsZW1lbnQ6 OnZhbHVlCisgICAgICAgIGVtcHRpbmVzcy4gSXQgc2hvdWxkIGJlIGlubmVyVGV4dFZhbHVlIGVt cHRpbmVzcyBiZWNhdXNlIGl0IGlzCisgICAgICAgIHBvc3NpYmxlIHRoYXQgYSBudW1iZXIgZmll bGQgaGFzIGVtcHR5IEhUTUxJbnB1dEVsZW1lbnQ6OnZhbHVlIGFuZAorICAgICAgICBub24tZW1w dHkgaW5uZXJUZXh0VmFsdWUuCisKKyAgICAgICAgVGVzdHM6IGZhc3QvZm9ybXMvbnVtYmVyL251 bWJlci1wbGFjZWhvbGRlci13aXRoLXVuYWNjZXB0YWJsZS12YWx1ZS5odG1sCisKKyAgICAgICAg KiBodG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTElucHV0 RWxlbWVudDo6dXBkYXRlSW5uZXJUZXh0VmFsdWUpOgorICAgICAgICBXZSBzaG91bGQgdXBkYXRl IHBsYWNlaG9sZGVyIHZpc2libGl0eSB3aGVuIHRoZSBpbm5lclRleHRWYWx1ZSBpcyB1cGRhdGVk LgorICAgICAgICAoV2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6c3VidHJlZUhhc0NoYW5nZWQp OiBkaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQ6OnNldFN1Z2dlc3Rl ZFZhbHVlKToKKyAgICAgICAgV2UgZG9uJ3QgbmVlZCB0byBjYWxsIHVwZGF0ZVBsYWNlaG9sZGVy VmlzaWJpbGl0eSgpIGJlY2F1c2UgdXBkYXRlSW5uZXJUZXh0VmFsdWUoKSBjYWxscyBpdC4KKyAg ICAgICAgKFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQ6OnNldFZhbHVlRnJvbVJlbmRlcmVyKToK KyAgICAgICAgV2UgZG9uJ3QgbmVlZCB0byBjYWxsIHVwZGF0ZVBsYWNlaG9sZGVyVmlzaWJpbGl0 eSgpIGJlY2F1c2Ugc3VidHJlZUhhc0NoYW5nZWQoKSBjYWxscyBpdC4KKyAgICAgICAgKiBodG1s L0hUTUxJbnB1dEVsZW1lbnQuaDogQ2hlY2tzIGlubmVyVGV4dFZhbHVlIGVtcHRpbmVzcy4KKyAg ICAgICAgKiBodG1sL1RleHRGaWVsZElucHV0VHlwZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpU ZXh0RmllbGRJbnB1dFR5cGU6OnNldFZhbHVlKToKKyAgICAgICAgV2UgZG9uJ3QgbmVlZCB0byBj YWxsIHVwZGF0ZVBsYWNlaG9sZGVyVmlzaWJpbGl0eSgpIGJlY2F1c2UgdXBkYXRlSW5uZXJUZXh0 VmFsdWUoKSBjYWxscyBpdC4KKwogMjAxMS0xMi0wMSAgVGFrYXNoaSBUb3lvc2hpbWEgIDx0b3lv c2hpbUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgYnVmZmVyZWRBbW91bnQgY2FsY3VsYXRpb24g aXMgd3JvbmcgaW4gQ0xPU0lORyBhbmQgQ0xPU0VEIHN0YXRlLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTElucHV0RWxlbWVudC5jcHAKaW5kZXggMDVhMDliOWNjN2E5ZDQ0ZDE3MTM0OGFiNjU4NDY3 MzA0Mzg4MGU3Mi4uMjhiMjg1ZmQzODVhYTEwN2NmNjAxODczN2YyMWY0MGJlMDk1YzIzMyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCkBAIC02MjIsMTIgKzYyMiwx NCBAQCB2b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OnVwZGF0ZUlubmVyVGV4dFZhbHVlKCkKICAgICBp ZiAoIWlzVGV4dEZpZWxkKCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIGlmICghc3VnZ2VzdGVk VmFsdWUoKS5pc051bGwoKSkKKyAgICBpZiAoIXN1Z2dlc3RlZFZhbHVlKCkuaXNOdWxsKCkpIHsK ICAgICAgICAgc2V0SW5uZXJUZXh0VmFsdWUoc3VnZ2VzdGVkVmFsdWUoKSk7Ci0gICAgZWxzZSBp ZiAoIWZvcm1Db250cm9sVmFsdWVNYXRjaGVzUmVuZGVyZXIoKSkgeworICAgICAgICB1cGRhdGVQ bGFjZWhvbGRlclZpc2liaWxpdHkoZmFsc2UpOworICAgIH0gZWxzZSBpZiAoIWZvcm1Db250cm9s VmFsdWVNYXRjaGVzUmVuZGVyZXIoKSkgewogICAgICAgICAvLyBVcGRhdGUgdGhlIHJlbmRlcmVy IHZhbHVlIGlmIHRoZSBmb3JtQ29udHJvbFZhbHVlTWF0Y2hlc1JlbmRlcmVyKCkgZmxhZyBpcyBm YWxzZS4KICAgICAgICAgLy8gSXQgcHJvdGVjdHMgYW4gdW5hY2NlcHRhYmxlIHJlbmRlcmVyIHZh bHVlIGZyb20gYmVpbmcgb3ZlcndyaXR0ZW4gd2l0aCB0aGUgRE9NIHZhbHVlLgogICAgICAgICBz ZXRJbm5lclRleHRWYWx1ZSh2aXNpYmxlVmFsdWUoKSk7CisgICAgICAgIHVwZGF0ZVBsYWNlaG9s ZGVyVmlzaWJpbGl0eShmYWxzZSk7CiAgICAgfQogfQogCkBAIC02NDcsNiArNjQ5LDcgQEAgdm9p ZCBIVE1MSW5wdXRFbGVtZW50OjpzdWJ0cmVlSGFzQ2hhbmdlZCgpCiAgICAgU3RyaW5nIHZhbHVl ID0gaW5uZXJUZXh0VmFsdWUoKTsKICAgICBpZiAoaXNBY2NlcHRhYmxlVmFsdWUodmFsdWUpKQog ICAgICAgICBzZXRWYWx1ZUZyb21SZW5kZXJlcihzYW5pdGl6ZVZhbHVlKGNvbnZlcnRGcm9tVmlz aWJsZVZhbHVlKHZhbHVlKSkpOworICAgIHVwZGF0ZVBsYWNlaG9sZGVyVmlzaWJpbGl0eShmYWxz ZSk7CiAgICAgLy8gUmVjYWxjIGZvciA6aW52YWxpZCBhbmQgaGFzVW5hY2NlcHRhYmxlVmFsdWUo KSBjaGFuZ2UuCiAgICAgc2V0TmVlZHNTdHlsZVJlY2FsYygpOwogCkBAIC0xMDczLDcgKzEwNzYs NiBAQCB2b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OnNldFN1Z2dlc3RlZFZhbHVlKGNvbnN0IFN0cmlu ZyYgdmFsdWUpCiAgICAgICAgIHJldHVybjsKICAgICBzZXRGb3JtQ29udHJvbFZhbHVlTWF0Y2hl c1JlbmRlcmVyKGZhbHNlKTsKICAgICBtX3N1Z2dlc3RlZFZhbHVlID0gc2FuaXRpemVWYWx1ZSh2 YWx1ZSk7Ci0gICAgdXBkYXRlUGxhY2Vob2xkZXJWaXNpYmlsaXR5KGZhbHNlKTsKICAgICBzZXRO ZWVkc1N0eWxlUmVjYWxjKCk7CiAgICAgdXBkYXRlSW5uZXJUZXh0VmFsdWUoKTsKIH0KQEAgLTEx NzQsNyArMTE3Niw2IEBAIHZvaWQgSFRNTElucHV0RWxlbWVudDo6c2V0VmFsdWVGcm9tUmVuZGVy ZXIoY29uc3QgU3RyaW5nJiB2YWx1ZSkKICAgICAgICAgZGlzcGF0Y2hJbnB1dEV2ZW50KCk7CiAg ICAgbm90aWZ5Rm9ybVN0YXRlQ2hhbmdlZCgpOwogCi0gICAgdXBkYXRlUGxhY2Vob2xkZXJWaXNp YmlsaXR5KGZhbHNlKTsKICAgICBzZXROZWVkc1ZhbGlkaXR5Q2hlY2soKTsKIAogICAgIC8vIENs ZWFyIGF1dG9maWxsIGZsYWcgKGFuZCB5ZWxsb3cgYmFja2dyb3VuZCkgb24gdXNlciBlZGl0Lgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmggYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaAppbmRleCA4ZWI2ZGZjZTc0NTYzOGQz MWI1Njc5ZWE3M2Q1YTlmYmFlNDMxOWYzLi5jZjlhYjVlMDlhYzljOGEwNTQxMTY4NGE0MzJiZjdk MzViZDA5OGE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1l bnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaApAQCAtMzEx LDcgKzMxMSw3IEBAIHByaXZhdGU6CiAKICAgICB2aXJ0dWFsIGJvb2wgc3VwcG9ydHNQbGFjZWhv bGRlcigpIGNvbnN0OwogICAgIHZpcnR1YWwgdm9pZCB1cGRhdGVQbGFjZWhvbGRlclRleHQoKTsK LSAgICB2aXJ0dWFsIGJvb2wgaXNFbXB0eVZhbHVlKCkgY29uc3QgeyByZXR1cm4gdmFsdWUoKS5p c0VtcHR5KCk7IH0KKyAgICB2aXJ0dWFsIGJvb2wgaXNFbXB0eVZhbHVlKCkgY29uc3QgT1ZFUlJJ REUgeyByZXR1cm4gaW5uZXJUZXh0VmFsdWUoKS5pc0VtcHR5KCk7IH0KICAgICB2aXJ0dWFsIGJv b2wgaXNFbXB0eVN1Z2dlc3RlZFZhbHVlKCkgY29uc3QgeyByZXR1cm4gc3VnZ2VzdGVkVmFsdWUo KS5pc0VtcHR5KCk7IH0KICAgICB2aXJ0dWFsIHZvaWQgaGFuZGxlRm9jdXNFdmVudCgpOwogICAg IHZpcnR1YWwgdm9pZCBoYW5kbGVCbHVyRXZlbnQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvVGV4 dEZpZWxkSW5wdXRUeXBlLmNwcAppbmRleCA3ZGFmZmQzNGU4ODEzZDM1ZTgwMTA1NjdiZGI2M2Q2 YTFjMGIxYTE1Li5jOWM5MDgzMzU3MjYzM2U4YzFmZDk0N2E3NTc4ZjMxNGIyMzcyOGU2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL1RleHRGaWVsZElucHV0VHlwZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvaHRtbC9UZXh0RmllbGRJbnB1dFR5cGUuY3BwCkBAIC04MCw3ICs4MCw2 IEBAIGJvb2wgVGV4dEZpZWxkSW5wdXRUeXBlOjpjYW5TZXRTdWdnZXN0ZWRWYWx1ZSgpCiB2b2lk IFRleHRGaWVsZElucHV0VHlwZTo6c2V0VmFsdWUoY29uc3QgU3RyaW5nJiBzYW5pdGl6ZWRWYWx1 ZSwgYm9vbCB2YWx1ZUNoYW5nZWQsIGJvb2wgc2VuZENoYW5nZUV2ZW50KQogewogICAgIElucHV0 VHlwZTo6c2V0VmFsdWUoc2FuaXRpemVkVmFsdWUsIHZhbHVlQ2hhbmdlZCwgc2VuZENoYW5nZUV2 ZW50KTsKLSAgICBlbGVtZW50KCktPnVwZGF0ZVBsYWNlaG9sZGVyVmlzaWJpbGl0eShmYWxzZSk7 CiAKICAgICBpZiAodmFsdWVDaGFuZ2VkKQogICAgICAgICBlbGVtZW50KCktPnVwZGF0ZUlubmVy VGV4dFZhbHVlKCk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKaW5kZXggOTAxNGE0M2I0YjhhZDM1MDRiY2YxYzVhOTE0Zjg4NjNkZDg5 MzUzZC4uZGRhYmI2OTMwYjEwNTJlYjAwNDAwZmE3ZDJjNzExNGZhZTZjMjQzMCAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDEzIEBACisyMDExLTEyLTAxICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9y Zz4KKworICAgICAgICBbTGlvbl1bV2luZG93c10gQm90aCBvZiBwbGFjZWhvbGRlciBhbmQgaW5w dXQgdGV4dCBhcmUgc2hvd24gaW4gPGlucHV0IHR5cGU9bnVtYmVyPgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM2MTUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvZm9ybXMvbnVtYmVyL251bWJl ci1wbGFjZWhvbGRlci13aXRoLXVuYWNjZXB0YWJsZS12YWx1ZS1leHBlY3RlZC5odG1sOiBBZGRl ZC4KKyAgICAgICAgKiBmYXN0L2Zvcm1zL251bWJlci9udW1iZXItcGxhY2Vob2xkZXItd2l0aC11 bmFjY2VwdGFibGUtdmFsdWUuaHRtbDogQWRkZWQuCisKIDIwMTEtMTItMDEgIFRha2FzaGkgVG95 b3NoaW1hICA8dG95b3NoaW1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIGJ1ZmZlcmVkQW1vdW50 IGNhbGN1bGF0aW9uIGlzIHdyb25nIGluIENMT1NJTkcgYW5kIENMT1NFRCBzdGF0ZS4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvbnVtYmVyL251bWJlci1wbGFjZWhvbGRlci13 aXRoLXVuYWNjZXB0YWJsZS12YWx1ZS1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9m b3Jtcy9udW1iZXIvbnVtYmVyLXBsYWNlaG9sZGVyLXdpdGgtdW5hY2NlcHRhYmxlLXZhbHVlLWV4 cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOWQ3ZTdiZGJlZTFjYWQyNGE2MzA1MDk5ODZkOGE5ZTNj MmYyYWU4NQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvbnVtYmVy L251bWJlci1wbGFjZWhvbGRlci13aXRoLXVuYWNjZXB0YWJsZS12YWx1ZS1leHBlY3RlZC5odG1s CkBAIC0wLDAgKzEsNCBAQAorPGlucHV0IHR5cGU9Im51bWJlciIgYXV0b2ZvY3VzPgorPHNjcmlw dD4KK2RvY3VtZW50LmV4ZWNDb21tYW5kKCdpbnNlcnR0ZXh0JywgZmFsc2UsICdhYWEnKTsKKzwv c2NyaXB0PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9udW1iZXIvbnVtYmVy LXBsYWNlaG9sZGVyLXdpdGgtdW5hY2NlcHRhYmxlLXZhbHVlLmh0bWwgYi9MYXlvdXRUZXN0cy9m YXN0L2Zvcm1zL251bWJlci9udW1iZXItcGxhY2Vob2xkZXItd2l0aC11bmFjY2VwdGFibGUtdmFs dWUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi5kYTM5MjRlYTFmMTVjZTFiN2Q5MTMzZWQ3MDkwNGViYzI3OTgy ZWVjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9udW1iZXIvbnVt YmVyLXBsYWNlaG9sZGVyLXdpdGgtdW5hY2NlcHRhYmxlLXZhbHVlLmh0bWwKQEAgLTAsMCArMSw0 IEBACis8aW5wdXQgdHlwZT0ibnVtYmVyIiBwbGFjZWhvbGRlcj0icGxhY2Vob2xkZXIiIGF1dG9m b2N1cz4KKzxzY3JpcHQ+Citkb2N1bWVudC5leGVjQ29tbWFuZCgnaW5zZXJ0dGV4dCcsIGZhbHNl LCAnYWFhJyk7Cis8L3NjcmlwdD4K