73601 2011-12-01 16:27:55 -0800 Make _build_path check more thoroughly that build paths exist. 2011-12-02 10:47:38 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboxhall aboxhall abarth ojan webkit.review.bot oldest_to_newest 513252 0 aboxhall 2011-12-01 16:27:55 -0800 Make _build_path check more thoroughly that build paths exist. 513253 1 117518 aboxhall 2011-12-01 16:28:44 -0800 Created attachment 117518 Patch 513382 2 117518 ojan 2011-12-01 18:47:53 -0800 Comment on attachment 117518 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117518&action=review > Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py:173 > + return self._filesystem.join(path) This should just be "return path", right? 513406 3 aboxhall 2011-12-01 19:36:59 -0800 (In reply to comment #2) > (From update of attachment 117518 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=117518&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py:173 > > + return self._filesystem.join(path) > > This should just be "return path", right? Oops, of course. 513409 4 117546 aboxhall 2011-12-01 19:40:14 -0800 Created attachment 117546 Patch 513920 5 117546 webkit.review.bot 2011-12-02 10:47:33 -0800 Comment on attachment 117546 Patch Clearing flags on attachment: 117546 Committed r101827: <http://trac.webkit.org/changeset/101827> 513921 6 webkit.review.bot 2011-12-02 10:47:38 -0800 All reviewed patches have been landed. Closing bug. 117518 2011-12-01 16:28:44 -0800 2011-12-01 19:40:06 -0800 Patch bug-73601-20111202112842.patch text/plain 2277 aboxhall U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMzE2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjQ5MGZjYzMwZGRmNWQ5OGMzYjg1OGU2ODZkNzBkOTIy Y2E4YWYxNy4uYjNlMmIxYmRmNGVlOWViMzg2Nzc0ZDc0ODI2MzFiMjBmZjNiOTZmZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDExLTEyLTAxICBBbGljZSBCb3hoYWxsICA8YWJveGhhbGxAY2hyb21pdW0ub3JnPgor CisgICAgICAgIE1ha2UgX2J1aWxkX3BhdGggY2hlY2sgbW9yZSB0aG9yb3VnaGx5IHRoYXQgYnVp bGQgcGF0aHMgZXhpc3QuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03MzYwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9tYWMu cHk6CisgICAgICAgIChDaHJvbWl1bU1hY1BvcnQuX2J1aWxkX3BhdGgpOgorCiAyMDExLTExLTI4 ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgZ3Rlc3Qgbm9ybWFs aXphdGlvbiBpbiB0aGUgdGVzdCByZXN1bHRzIHNlcnZlciBpcyBzb21ldGltZXMgd3JvbmcKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21p dW1fbWFjLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJv bWl1bV9tYWMucHkKaW5kZXggMGJiMzEyNzY4MzhlMTI0Yzg5MWZiNjE1MTNkNDAzMTgzMzJhOGVh Ni4uZmI0NmZlYjZjNWQ3MGY1NGNhZmI3MTA4NGQ3ZThmYzAxODJkYWFiOSAxMDA2NDQKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9tYWMucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9t YWMucHkKQEAgLTE1OSwxMyArMTU5LDE5IEBAIGNsYXNzIENocm9taXVtTWFjUG9ydChjaHJvbWl1 bS5DaHJvbWl1bVBvcnQpOgogICAgICAgICAgICAgcmV0dXJuIHNlbGYuX2ZpbGVzeXN0ZW0uam9p bihzZWxmLmdldF9vcHRpb24oJ2J1aWxkX2RpcmVjdG9yeScpLAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAqY29tcHMpCiAgICAgICAgIGJhc2UgPSBzZWxmLnBhdGhf ZnJvbV9jaHJvbWl1bV9iYXNlKCkKLSAgICAgICAgaWYgc2VsZi5fZmlsZXN5c3RlbS5leGlzdHMo c2VsZi5fZmlsZXN5c3RlbS5qb2luKGJhc2UsICdvdXQnKSk6Ci0gICAgICAgICAgICByZXR1cm4g c2VsZi5fZmlsZXN5c3RlbS5qb2luKGJhc2UsICdvdXQnLCAqY29tcHMpCi0gICAgICAgIGlmIHNl bGYuX2ZpbGVzeXN0ZW0uZXhpc3RzKHNlbGYuX2ZpbGVzeXN0ZW0uam9pbihiYXNlLCAneGNvZGVi dWlsZCcsICpjb21wcykpOgotICAgICAgICAgICAgcmV0dXJuIHNlbGYuX2ZpbGVzeXN0ZW0uam9p bihiYXNlLCAneGNvZGVidWlsZCcsICpjb21wcykKKyAgICAgICAgcGF0aCA9IHNlbGYuX2ZpbGVz eXN0ZW0uam9pbihiYXNlLCAnb3V0JywgKmNvbXBzKQorICAgICAgICBpZiBzZWxmLl9maWxlc3lz dGVtLmV4aXN0cyhwYXRoKToKKyAgICAgICAgICAgIHJldHVybiBwYXRoCisKKyAgICAgICAgcGF0 aCA9IHNlbGYuX2ZpbGVzeXN0ZW0uam9pbihiYXNlLCAneGNvZGVidWlsZCcsICpjb21wcykKKyAg ICAgICAgaWYgc2VsZi5fZmlsZXN5c3RlbS5leGlzdHMocGF0aCk6CisgICAgICAgICAgICByZXR1 cm4gcGF0aAorCiAgICAgICAgIGJhc2UgPSBzZWxmLnBhdGhfZnJvbV93ZWJraXRfYmFzZSgpCi0g ICAgICAgIGlmIHNlbGYuX2ZpbGVzeXN0ZW0uZXhpc3RzKHNlbGYuX2ZpbGVzeXN0ZW0uam9pbihi YXNlLCAnb3V0JykpOgotICAgICAgICAgICAgcmV0dXJuIHNlbGYuX2ZpbGVzeXN0ZW0uam9pbihi YXNlLCAnb3V0JywgKmNvbXBzKQorICAgICAgICBwYXRoID0gc2VsZi5fZmlsZXN5c3RlbS5qb2lu KGJhc2UsICdvdXQnLCAqY29tcHMpCisgICAgICAgIGlmIHNlbGYuX2ZpbGVzeXN0ZW0uZXhpc3Rz KHBhdGgpOgorICAgICAgICAgICAgcmV0dXJuIHNlbGYuX2ZpbGVzeXN0ZW0uam9pbihwYXRoKQor CiAgICAgICAgIHJldHVybiBzZWxmLl9maWxlc3lzdGVtLmpvaW4oYmFzZSwgJ3hjb2RlYnVpbGQn LCAqY29tcHMpCiAKICAgICBkZWYgY2hlY2tfd2RpZmYoc2VsZiwgbG9nZ2luZz1UcnVlKToK 117546 2011-12-01 19:40:14 -0800 2011-12-02 10:47:33 -0800 Patch bug-73601-20111202144012.patch text/plain 2254 aboxhall U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMzE2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjQ5MGZjYzMwZGRmNWQ5OGMzYjg1OGU2ODZkNzBkOTIy Y2E4YWYxNy4uYjNlMmIxYmRmNGVlOWViMzg2Nzc0ZDc0ODI2MzFiMjBmZjNiOTZmZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDExLTEyLTAxICBBbGljZSBCb3hoYWxsICA8YWJveGhhbGxAY2hyb21pdW0ub3JnPgor CisgICAgICAgIE1ha2UgX2J1aWxkX3BhdGggY2hlY2sgbW9yZSB0aG9yb3VnaGx5IHRoYXQgYnVp bGQgcGF0aHMgZXhpc3QuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03MzYwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9tYWMu cHk6CisgICAgICAgIChDaHJvbWl1bU1hY1BvcnQuX2J1aWxkX3BhdGgpOgorCiAyMDExLTExLTI4 ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgZ3Rlc3Qgbm9ybWFs aXphdGlvbiBpbiB0aGUgdGVzdCByZXN1bHRzIHNlcnZlciBpcyBzb21ldGltZXMgd3JvbmcKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21p dW1fbWFjLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJv bWl1bV9tYWMucHkKaW5kZXggMGJiMzEyNzY4MzhlMTI0Yzg5MWZiNjE1MTNkNDAzMTgzMzJhOGVh Ni4uZTgxNDRiOGU1NGExNTFhMTdmYzNkODdhZTEyNzRjNGNjNjYyOGQzZCAxMDA2NDQKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9tYWMucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9t YWMucHkKQEAgLTE1OSwxMyArMTU5LDE5IEBAIGNsYXNzIENocm9taXVtTWFjUG9ydChjaHJvbWl1 bS5DaHJvbWl1bVBvcnQpOgogICAgICAgICAgICAgcmV0dXJuIHNlbGYuX2ZpbGVzeXN0ZW0uam9p bihzZWxmLmdldF9vcHRpb24oJ2J1aWxkX2RpcmVjdG9yeScpLAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAqY29tcHMpCiAgICAgICAgIGJhc2UgPSBzZWxmLnBhdGhf ZnJvbV9jaHJvbWl1bV9iYXNlKCkKLSAgICAgICAgaWYgc2VsZi5fZmlsZXN5c3RlbS5leGlzdHMo c2VsZi5fZmlsZXN5c3RlbS5qb2luKGJhc2UsICdvdXQnKSk6Ci0gICAgICAgICAgICByZXR1cm4g c2VsZi5fZmlsZXN5c3RlbS5qb2luKGJhc2UsICdvdXQnLCAqY29tcHMpCi0gICAgICAgIGlmIHNl bGYuX2ZpbGVzeXN0ZW0uZXhpc3RzKHNlbGYuX2ZpbGVzeXN0ZW0uam9pbihiYXNlLCAneGNvZGVi dWlsZCcsICpjb21wcykpOgotICAgICAgICAgICAgcmV0dXJuIHNlbGYuX2ZpbGVzeXN0ZW0uam9p bihiYXNlLCAneGNvZGVidWlsZCcsICpjb21wcykKKyAgICAgICAgcGF0aCA9IHNlbGYuX2ZpbGVz eXN0ZW0uam9pbihiYXNlLCAnb3V0JywgKmNvbXBzKQorICAgICAgICBpZiBzZWxmLl9maWxlc3lz dGVtLmV4aXN0cyhwYXRoKToKKyAgICAgICAgICAgIHJldHVybiBwYXRoCisKKyAgICAgICAgcGF0 aCA9IHNlbGYuX2ZpbGVzeXN0ZW0uam9pbihiYXNlLCAneGNvZGVidWlsZCcsICpjb21wcykKKyAg ICAgICAgaWYgc2VsZi5fZmlsZXN5c3RlbS5leGlzdHMocGF0aCk6CisgICAgICAgICAgICByZXR1 cm4gcGF0aAorCiAgICAgICAgIGJhc2UgPSBzZWxmLnBhdGhfZnJvbV93ZWJraXRfYmFzZSgpCi0g ICAgICAgIGlmIHNlbGYuX2ZpbGVzeXN0ZW0uZXhpc3RzKHNlbGYuX2ZpbGVzeXN0ZW0uam9pbihi YXNlLCAnb3V0JykpOgotICAgICAgICAgICAgcmV0dXJuIHNlbGYuX2ZpbGVzeXN0ZW0uam9pbihi YXNlLCAnb3V0JywgKmNvbXBzKQorICAgICAgICBwYXRoID0gc2VsZi5fZmlsZXN5c3RlbS5qb2lu KGJhc2UsICdvdXQnLCAqY29tcHMpCisgICAgICAgIGlmIHNlbGYuX2ZpbGVzeXN0ZW0uZXhpc3Rz KHBhdGgpOgorICAgICAgICAgICAgcmV0dXJuIHBhdGgKKwogICAgICAgICByZXR1cm4gc2VsZi5f ZmlsZXN5c3RlbS5qb2luKGJhc2UsICd4Y29kZWJ1aWxkJywgKmNvbXBzKQogCiAgICAgZGVmIGNo ZWNrX3dkaWZmKHNlbGYsIGxvZ2dpbmc9VHJ1ZSk6Cg==