73592 2011-12-01 14:54:57 -0800 REGRESSION (r100483): Can’t drag out of background window 2011-12-01 15:33:01 -0800 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P2 Normal --- 1 bdakin bdakin bdakin oldest_to_newest 513156 0 bdakin 2011-12-01 14:54:57 -0800 * SUMMARY In recent builds trying to Command-drag a link or selected text from a background window fails. * STEPS TO REPRODUCE 1. Navigate to a webpage with links 2. Move Safari to the background 3. Command-drag a link out of the Safari window * RESULTS The link gets into the active state while being dragged, but isn’t dragged out. Similarly, selected text cannot be command-dragged. This is a regression from revision 100483. <rdar://problem/10508870> 513158 1 117496 bdakin 2011-12-01 14:58:28 -0800 Created attachment 117496 Patch 513163 2 117496 darin 2011-12-01 15:04:23 -0800 Comment on attachment 117496 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117496&action=review Is there a good way to regression-test this? > Source/WebKit2/ChangeLog:4 > + REGRESSION (r100483): Can’t drag out of background window Character encoding trouble here with the ’ character. > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1188 > + // We need to do a full, normal hit test during this mouse event if the page is active or if a mouse > + // button is currently pressed. It is possible that neither of those things will be true since on > + // Lion when legacy scrollbars are enabled, WebKit receives mouse events all the time. If it is one > + // of those cases where the page is not active and the mouse is not pressed, then we can fire a more > + // efficient scrollbars-only version of the event. > + bool mouseIsPressed = mouseEvent.button() != WebMouseEvent::NoButton; > + handled = handleMouseEvent(mouseEvent, m_page.get(), !(m_page->focusController()->isActive() || mouseIsPressed)); To make the code match the comment it would be better if the third argument was a named local variable called something like "useMoreEfficientScrollbarsOnlyVersion". 513196 3 bdakin 2011-12-01 15:29:14 -0800 (In reply to comment #2) > (From update of attachment 117496 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=117496&action=review > > Is there a good way to regression-test this? > I'm not sure there is. Our testing tools typically claim to be "key" windows all the time, so just getting a window to be inactive is not something we can replicate in a test (as far as I know) without enhancing the testing tool. Maybe that is worth doing actually, but then as far as I know there is also not a good way to test link dragging (but I am double-checking with Enrica on that). There are a number of unfortunate stumbling blocks here. > > Source/WebKit2/ChangeLog:4 > > + REGRESSION (r100483): Can’t drag out of background window > > Character encoding trouble here with the ’ character. > Oops! Will fix. > > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1188 > > + // We need to do a full, normal hit test during this mouse event if the page is active or if a mouse > > + // button is currently pressed. It is possible that neither of those things will be true since on > > + // Lion when legacy scrollbars are enabled, WebKit receives mouse events all the time. If it is one > > + // of those cases where the page is not active and the mouse is not pressed, then we can fire a more > > + // efficient scrollbars-only version of the event. > > + bool mouseIsPressed = mouseEvent.button() != WebMouseEvent::NoButton; > > + handled = handleMouseEvent(mouseEvent, m_page.get(), !(m_page->focusController()->isActive() || mouseIsPressed)); > > To make the code match the comment it would be better if the third argument was a named local variable called something like "useMoreEfficientScrollbarsOnlyVersion". Sounds good. 513199 4 bdakin 2011-12-01 15:33:01 -0800 Committed change with revision 101719. 117496 2011-12-01 14:58:28 -0800 2011-12-01 15:04:22 -0800 Patch for-review.txt text/plain 3124 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMTcxMykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDExLTEyLTAxICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzM1OTIKKyAgICAgICAgUkVHUkVTU0lPTiAocjEwMDQ4Myk6IENh buKAmXQgZHJhZyBvdXQgb2YgYmFja2dyb3VuZCB3aW5kb3cKKyAgICAgICAgLWFuZCBjb3JyZXNw b25kaW5nLQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTA1MDg4NzA+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgdGhlIG1vdXNlIGlzIHByZXNz ZWQgd2UgbmVlZCB0byBkbyBhIGZ1bGwsIG5vcm1hbCBoaXQgdGVzdCBldmVuIGlmIHRoZSB3aW5k b3cgCisgICAgICAgIGlzIG5vdCBhY3RpdmUuIAorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFn ZS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6bW91c2VFdmVudCk6Cisg ICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6Om1vdXNlRXZlbnRTeW5jRm9yVGVzdGluZyk6CisKIDIw MTEtMTItMDEgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFtHVEtdIEFkZCBhIGhlbHBlciBmdW5jdGlvbiB0byBmaW5kIHRoZSBjdXJyZW50IGV4ZWN1 dGFibGUncyBwYXRoCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L1dlYlBhZ2UuY3BwCShyZXZpc2lvbiAxMDE1MzIpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExNzksNyArMTE3OSwx MyBAQCB2b2lkIFdlYlBhZ2U6Om1vdXNlRXZlbnQoY29uc3QgV2ViTW91c2VFCiAgICAgaWYgKCFo YW5kbGVkKSB7CiAgICAgICAgIEN1cnJlbnRFdmVudCBjdXJyZW50RXZlbnQobW91c2VFdmVudCk7 CiAKLSAgICAgICAgaGFuZGxlZCA9IGhhbmRsZU1vdXNlRXZlbnQobW91c2VFdmVudCwgbV9wYWdl LmdldCgpLCAhbV9wYWdlLT5mb2N1c0NvbnRyb2xsZXIoKS0+aXNBY3RpdmUoKSk7CisgICAgICAg IC8vIFdlIG5lZWQgdG8gZG8gYSBmdWxsLCBub3JtYWwgaGl0IHRlc3QgZHVyaW5nIHRoaXMgbW91 c2UgZXZlbnQgaWYgdGhlIHBhZ2UgaXMgYWN0aXZlIG9yIGlmIGEgbW91c2UKKyAgICAgICAgLy8g YnV0dG9uIGlzIGN1cnJlbnRseSBwcmVzc2VkLiBJdCBpcyBwb3NzaWJsZSB0aGF0IG5laXRoZXIg b2YgdGhvc2UgdGhpbmdzIHdpbGwgYmUgdHJ1ZSBzaW5jZSBvbiAKKyAgICAgICAgLy8gTGlvbiB3 aGVuIGxlZ2FjeSBzY3JvbGxiYXJzIGFyZSBlbmFibGVkLCBXZWJLaXQgcmVjZWl2ZXMgbW91c2Ug ZXZlbnRzIGFsbCB0aGUgdGltZS4gSWYgaXQgaXMgb25lIAorICAgICAgICAvLyBvZiB0aG9zZSBj YXNlcyB3aGVyZSB0aGUgcGFnZSBpcyBub3QgYWN0aXZlIGFuZCB0aGUgbW91c2UgaXMgbm90IHBy ZXNzZWQsIHRoZW4gd2UgY2FuIGZpcmUgYSBtb3JlCisgICAgICAgIC8vIGVmZmljaWVudCBzY3Jv bGxiYXJzLW9ubHkgdmVyc2lvbiBvZiB0aGUgZXZlbnQuCisgICAgICAgIGJvb2wgbW91c2VJc1By ZXNzZWQgPSBtb3VzZUV2ZW50LmJ1dHRvbigpICE9IFdlYk1vdXNlRXZlbnQ6Ok5vQnV0dG9uOwor ICAgICAgICBoYW5kbGVkID0gaGFuZGxlTW91c2VFdmVudChtb3VzZUV2ZW50LCBtX3BhZ2UuZ2V0 KCksICEobV9wYWdlLT5mb2N1c0NvbnRyb2xsZXIoKS0+aXNBY3RpdmUoKSB8fCBtb3VzZUlzUHJl c3NlZCkpOwogICAgIH0KIAogICAgIHNlbmQoTWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6RGlkUmVj ZWl2ZUV2ZW50KHN0YXRpY19jYXN0PHVpbnQzMl90Pihtb3VzZUV2ZW50LnR5cGUoKSksIGhhbmRs ZWQpKTsKQEAgLTExOTcsNyArMTIwMywxNCBAQCB2b2lkIFdlYlBhZ2U6Om1vdXNlRXZlbnRTeW5j Rm9yVGVzdGluZyhjCiAKICAgICBpZiAoIWhhbmRsZWQpIHsKICAgICAgICAgQ3VycmVudEV2ZW50 IGN1cnJlbnRFdmVudChtb3VzZUV2ZW50KTsKLSAgICAgICAgaGFuZGxlZCA9IGhhbmRsZU1vdXNl RXZlbnQobW91c2VFdmVudCwgbV9wYWdlLmdldCgpLCAhbV9wYWdlLT5mb2N1c0NvbnRyb2xsZXIo KS0+aXNBY3RpdmUoKSk7CisKKyAgICAgICAgLy8gV2UgbmVlZCB0byBkbyBhIGZ1bGwsIG5vcm1h bCBoaXQgdGVzdCBkdXJpbmcgdGhpcyBtb3VzZSBldmVudCBpZiB0aGUgcGFnZSBpcyBhY3RpdmUg b3IgaWYgYSBtb3VzZQorICAgICAgICAvLyBidXR0b24gaXMgY3VycmVudGx5IHByZXNzZWQuIEl0 IGlzIHBvc3NpYmxlIHRoYXQgbmVpdGhlciBvZiB0aG9zZSB0aGluZ3Mgd2lsbCBiZSB0cnVlIHNp bmNlIG9uIAorICAgICAgICAvLyBMaW9uIHdoZW4gbGVnYWN5IHNjcm9sbGJhcnMgYXJlIGVuYWJs ZWQsIFdlYktpdCByZWNlaXZlcyBtb3VzZSBldmVudHMgYWxsIHRoZSB0aW1lLiBJZiBpdCBpcyBv bmUgCisgICAgICAgIC8vIG9mIHRob3NlIGNhc2VzIHdoZXJlIHRoZSBwYWdlIGlzIG5vdCBhY3Rp dmUgYW5kIHRoZSBtb3VzZSBpcyBub3QgcHJlc3NlZCwgdGhlbiB3ZSBjYW4gZmlyZSBhIG1vcmUK KyAgICAgICAgLy8gZWZmaWNpZW50IHNjcm9sbGJhcnMtb25seSB2ZXJzaW9uIG9mIHRoZSBldmVu dC4KKyAgICAgICAgYm9vbCBtb3VzZUlzUHJlc3NlZCA9IG1vdXNlRXZlbnQuYnV0dG9uKCkgIT0g V2ViTW91c2VFdmVudDo6Tm9CdXR0b247CisgICAgICAgIGhhbmRsZWQgPSBoYW5kbGVNb3VzZUV2 ZW50KG1vdXNlRXZlbnQsIG1fcGFnZS5nZXQoKSwgIShtX3BhZ2UtPmZvY3VzQ29udHJvbGxlcigp LT5pc0FjdGl2ZSgpIHx8IG1vdXNlSXNQcmVzc2VkKSk7CiAgICAgfQogfQogCg==