73583 2011-12-01 12:47:24 -0800 fullscreen/video-controls is too specific to the mac port 2012-03-06 23:46:48 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand pnormand dglazkov eric.carlson webkit.review.bot oldest_to_newest 513004 0 pnormand 2011-12-01 12:47:24 -0800 The test on the height should be relaxed. Eric Carlson suggested to simply output the height value on the console and update the platform results. 513007 1 117462 pnormand 2011-12-01 12:49:44 -0800 Created attachment 117462 proposed patch 513018 2 117462 darin 2011-12-01 13:01:13 -0800 Comment on attachment 117462 proposed patch It’s normally important to have failure vs. success in a test. Is there anything we can do to make this a pass/fail test instead of one that logs the height? 513078 3 pnormand 2011-12-01 14:03:56 -0800 Maybe we can test height >= 0. Would we reach concensus with this? :) 571646 4 pnormand 2012-03-06 01:45:37 -0800 (In reply to comment #3) > Maybe we can test height >= 0. Would we reach concensus with this? :) I'm willing to update the test if Eric agrees with this. 571831 5 eric.carlson 2012-03-06 07:17:54 -0800 "height >= 0" doesn't seem especially useful, can height ever be negative? I assume that a platform will have fullscreen controls if this test is now skipped, so how about testing that height is greater than a small but reasonable value (10?, 20?)? 571838 6 pnormand 2012-03-06 07:24:29 -0800 (In reply to comment #5) > "height >= 0" doesn't seem especially useful, can height ever be negative? I assume that a platform will have fullscreen controls if this test is now skipped, so how about testing that height is greater than a small but reasonable value (10?, 20?)? Alright, 20 seems good enough to me. I'll update the patch! 571931 7 130399 pnormand 2012-03-06 09:54:53 -0800 Created attachment 130399 Patch 572002 8 130399 webkit.review.bot 2012-03-06 11:10:12 -0800 Comment on attachment 130399 Patch Attachment 130399 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11833497 New failing tests: fullscreen/video-controls-override.html 572011 9 130415 pnormand 2012-03-06 11:16:06 -0800 Created attachment 130415 Patch 572598 10 pnormand 2012-03-06 23:46:48 -0800 Committed r110025: <http://trac.webkit.org/changeset/110025> 117462 2011-12-01 12:49:44 -0800 2012-03-06 09:54:36 -0800 proposed patch proposed-patch.patch text/plain 5534 pnormand RnJvbSA4YjRkZGViNzJlNDYxN2Q1ZTE5ZmNjZjdlZTQyOWQyZGMzODBlOGNjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUaHUsIDEgRGVjIDIwMTEgMjE6NDg6NDkgKzAxMDAKU3ViamVjdDogW1BBVENIXSBw cm9wb3NlZCBwYXRjaAoKLS0tCiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgMTUgKysrKysrKysrKysrKysrCiAuLi4vdmlkZW8tY29udHJvbHMt b3ZlcnJpZGUtZXhwZWN0ZWQudHh0ICAgICAgICAgICB8ICAgIDIgKy0KIC4uLi9mdWxsc2NyZWVu L3ZpZGVvLWNvbnRyb2xzLW92ZXJyaWRlLmh0bWwgICAgICAgIHwgICAgMyArKy0KIC4uLi92aWRl by1jb250cm9scy1vdmVycmlkZS1leHBlY3RlZC50eHQgICAgICAgICAgIHwgICAgMiArLQogLi4u L3ZpZGVvLWNvbnRyb2xzLW92ZXJyaWRlLWV4cGVjdGVkLnR4dCAgICAgICAgICAgfCAgIDEyICsr KysrKysrKysrKwogNSBmaWxlcyBjaGFuZ2VkLCAzMSBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9u cygtKQogY3JlYXRlIG1vZGUgMTAwNjQ0IExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9mdWxsc2Ny ZWVuL3ZpZGVvLWNvbnRyb2xzLW92ZXJyaWRlLWV4cGVjdGVkLnR4dAoKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBlMTE2Y2Iw Li4zYjIxZDQ1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMTItMDEgIFBoaWxpcHBlIE5v cm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIGZ1bGxzY3JlZW4vdmlkZW8t Y29udHJvbHMgaXMgdG9vIHNwZWNpZmljIHRvIHRoZSBtYWMgcG9ydAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM1ODMKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPdXRwdXQgY29udHJvbHMgaGVpZ2h0IGlu c3RlYWQgb2YgdGVzdGluZyBhbmQgY29tcGFyaW5nIGl0cyB2YWx1ZQorICAgICAgICB0byB0aGUg bWFjIGZ1bGxzY3JlZW4gdmlkZW8gY29udHJvbHMgaGVpZ2h0LgorCisgICAgICAgICogZnVsbHNj cmVlbi92aWRlby1jb250cm9scy1vdmVycmlkZS1leHBlY3RlZC50eHQ6CisgICAgICAgICogZnVs bHNjcmVlbi92aWRlby1jb250cm9scy1vdmVycmlkZS5odG1sOgorICAgICAgICAqIHBsYXRmb3Jt L2Nocm9taXVtL2Z1bGxzY3JlZW4vdmlkZW8tY29udHJvbHMtb3ZlcnJpZGUtZXhwZWN0ZWQudHh0 OgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9mdWxsc2NyZWVuL3ZpZGVvLWNvbnRyb2xzLW92ZXJy aWRlLWV4cGVjdGVkLnR4dDogQ29waWVkIGZyb20gTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi92aWRl by1jb250cm9scy1vdmVycmlkZS1leHBlY3RlZC50eHQuCisKIDIwMTEtMTEtMzAgIERtaXRyeSBM b21vdiAgPGRzbG9tb3ZAZ29vZ2xlLmNvbT4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM1MDMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Z1bGxz Y3JlZW4vdmlkZW8tY29udHJvbHMtb3ZlcnJpZGUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv ZnVsbHNjcmVlbi92aWRlby1jb250cm9scy1vdmVycmlkZS1leHBlY3RlZC50eHQKaW5kZXggOWUy ZjBhYi4uZjJlM2M4YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi92aWRlby1j b250cm9scy1vdmVycmlkZS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZnVsbHNjcmVl bi92aWRlby1jb250cm9scy1vdmVycmlkZS1leHBlY3RlZC50eHQKQEAgLTUsNyArNSw3IEBAIEVY UEVDVEVEIChzaGFkb3dSb290ID0gaW50ZXJuYWxzLnNoYWRvd1Jvb3QodmlkZW8pICE9ICdudWxs JykgT0sKIEVYUEVDVEVEIChwYW5lbCA9IHNoYWRvd1Jvb3QuZmlyc3RDaGlsZC5maXJzdENoaWxk ICE9ICdudWxsJykgT0sKIEVYUEVDVEVEIChpbnRlcm5hbHMuc2hhZG93UHNldWRvSWQocGFuZWwp ID09ICctd2Via2l0LW1lZGlhLWNvbnRyb2xzLXBhbmVsJykgT0sKIEVYUEVDVEVEIChkb2N1bWVu dC5kZWZhdWx0Vmlldy5nZXRDb21wdXRlZFN0eWxlKHBhbmVsKVsnZGlzcGxheSddICE9ICdub25l JykgT0sKLUVYUEVDVEVEIChkb2N1bWVudC5kZWZhdWx0Vmlldy5nZXRDb21wdXRlZFN0eWxlKHBh bmVsKVsnaGVpZ2h0J10gPT0gJzQ4cHgnKSBPSworZG9jdW1lbnQuZGVmYXVsdFZpZXcuZ2V0Q29t cHV0ZWRTdHlsZShwYW5lbClbJ2hlaWdodCddID0gNDhweAogRVZFTlQod2Via2l0ZnVsbHNjcmVl bmNoYW5nZSkKIEVYUEVDVEVEIChkb2N1bWVudC5kZWZhdWx0Vmlldy5nZXRDb21wdXRlZFN0eWxl KHBhbmVsKVsnZGlzcGxheSddID09ICdub25lJykgT0sKIEVORCBPRiBURVNUCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mdWxsc2NyZWVuL3ZpZGVvLWNvbnRyb2xzLW92ZXJyaWRlLmh0bWwgYi9M YXlvdXRUZXN0cy9mdWxsc2NyZWVuL3ZpZGVvLWNvbnRyb2xzLW92ZXJyaWRlLmh0bWwKaW5kZXgg ZWNiODY4Yi4uZjBjODllMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi92aWRl by1jb250cm9scy1vdmVycmlkZS5odG1sCisrKyBiL0xheW91dFRlc3RzL2Z1bGxzY3JlZW4vdmlk ZW8tY29udHJvbHMtb3ZlcnJpZGUuaHRtbApAQCAtMjIsNyArMjIsOCBAQAogICAgICAgICAgICAg ICAgIHRlc3RFeHBlY3RlZCgicGFuZWwgPSBzaGFkb3dSb290LmZpcnN0Q2hpbGQuZmlyc3RDaGls ZCIsIG51bGwsICIhPSIpOwogICAgICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgiaW50ZXJuYWxz LnNoYWRvd1BzZXVkb0lkKHBhbmVsKSIsICItd2Via2l0LW1lZGlhLWNvbnRyb2xzLXBhbmVsIik7 CiAgICAgICAgICAgICAgICAgdGVzdEV4cGVjdGVkKCJkb2N1bWVudC5kZWZhdWx0Vmlldy5nZXRD b21wdXRlZFN0eWxlKHBhbmVsKVsnZGlzcGxheSddIiwgJ25vbmUnLCAiIT0iKTsKLSAgICAgICAg ICAgICAgICB0ZXN0RXhwZWN0ZWQoImRvY3VtZW50LmRlZmF1bHRWaWV3LmdldENvbXB1dGVkU3R5 bGUocGFuZWwpWydoZWlnaHQnXSIsICc0OHB4Jyk7CisgICAgICAgICAgICAgICAgLy8gaGVpZ2h0 IGNhbiBiZSBwbGF0Zm9ybS1zcGVjaWZpYy4gSXQncyBiZXR0ZXIgdG8gc2ltcGx5IHByaW50IGl0 IGFuZCBsZXQgcG9ydHMgbWFuYWdlIHRoZSBiYXNlbGluZXMuCisgICAgICAgICAgICAgICAgY29u c29sZVdyaXRlKCJkb2N1bWVudC5kZWZhdWx0Vmlldy5nZXRDb21wdXRlZFN0eWxlKHBhbmVsKVsn aGVpZ2h0J10gPSAiICsgZG9jdW1lbnQuZGVmYXVsdFZpZXcuZ2V0Q29tcHV0ZWRTdHlsZShwYW5l bClbJ2hlaWdodCddKTsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIGVsc2UKICAgICAgICAg ICAgICAgICBsb2dSZXN1bHQoZmFsc2UsICJ3aW5kb3cuaW50ZXJuYWxzID09IHVuZGVmaW5lZCIp OwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vZnVsbHNjcmVlbi92 aWRlby1jb250cm9scy1vdmVycmlkZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9jaHJvbWl1bS9mdWxsc2NyZWVuL3ZpZGVvLWNvbnRyb2xzLW92ZXJyaWRlLWV4cGVjdGVkLnR4 dAppbmRleCAwMDM3NTgxLi44MjJiMGU3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9jaHJvbWl1bS9mdWxsc2NyZWVuL3ZpZGVvLWNvbnRyb2xzLW92ZXJyaWRlLWV4cGVjdGVkLnR4 dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9mdWxsc2NyZWVuL3ZpZGVvLWNv bnRyb2xzLW92ZXJyaWRlLWV4cGVjdGVkLnR4dApAQCAtNSw3ICs1LDcgQEAgRVhQRUNURUQgKHNo YWRvd1Jvb3QgPSBpbnRlcm5hbHMuc2hhZG93Um9vdCh2aWRlbykgIT0gJ251bGwnKSBPSwogRVhQ RUNURUQgKHBhbmVsID0gc2hhZG93Um9vdC5maXJzdENoaWxkLmZpcnN0Q2hpbGQgIT0gJ251bGwn KSBPSwogRVhQRUNURUQgKGludGVybmFscy5zaGFkb3dQc2V1ZG9JZChwYW5lbCkgPT0gJy13ZWJr aXQtbWVkaWEtY29udHJvbHMtcGFuZWwnKSBPSwogRVhQRUNURUQgKGRvY3VtZW50LmRlZmF1bHRW aWV3LmdldENvbXB1dGVkU3R5bGUocGFuZWwpWydkaXNwbGF5J10gIT0gJ25vbmUnKSBPSwotRVhQ RUNURUQgKGRvY3VtZW50LmRlZmF1bHRWaWV3LmdldENvbXB1dGVkU3R5bGUocGFuZWwpWydoZWln aHQnXSA9PSAnNDhweCcpLCBPQlNFUlZFRCAnMzJweCcgRkFJTAorZG9jdW1lbnQuZGVmYXVsdFZp ZXcuZ2V0Q29tcHV0ZWRTdHlsZShwYW5lbClbJ2hlaWdodCddID0gMzJweAogRVZFTlQod2Via2l0 ZnVsbHNjcmVlbmNoYW5nZSkKIEVYUEVDVEVEIChkb2N1bWVudC5kZWZhdWx0Vmlldy5nZXRDb21w dXRlZFN0eWxlKHBhbmVsKVsnZGlzcGxheSddID09ICdub25lJykgT0sKIEVORCBPRiBURVNUCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvZnVsbHNjcmVlbi92aWRlby1jb250 cm9scy1vdmVycmlkZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvZnVs bHNjcmVlbi92aWRlby1jb250cm9scy1vdmVycmlkZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMWFmYmY1MQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL2d0ay9mdWxsc2NyZWVuL3ZpZGVvLWNvbnRyb2xzLW92ZXJyaWRlLWV4 cGVjdGVkLnR4dApAQCAtMCwwICsxLDEyIEBACitUaGlzIHRlc3RzIHRoYXQgdGhlIHZpZGVvIGVs ZW1lbnQncyAiY29udHJvbHMiIGF0dHJpYnV0ZSBpcyBvdmVycmlkZGVuIGluIGZ1bGwgc2NyZWVu IG1vZGUsIGFuZCB0aGF0IHRoZSBjb250cm9scyBhcmUgY29ycmVjdGx5IGhpZGRlbiB1cG9uIGV4 aXRpbmcgZnVsbCBzY3JlZW4uIFByZXNzIGFueSBrZXkgdG8gY29udGludWUuCisKK0VWRU5UKHdl YmtpdGZ1bGxzY3JlZW5jaGFuZ2UpCitFWFBFQ1RFRCAoc2hhZG93Um9vdCA9IGludGVybmFscy5z aGFkb3dSb290KHZpZGVvKSAhPSAnbnVsbCcpIE9LCitFWFBFQ1RFRCAocGFuZWwgPSBzaGFkb3dS b290LmZpcnN0Q2hpbGQuZmlyc3RDaGlsZCAhPSAnbnVsbCcpIE9LCitFWFBFQ1RFRCAoaW50ZXJu YWxzLnNoYWRvd1BzZXVkb0lkKHBhbmVsKSA9PSAnLXdlYmtpdC1tZWRpYS1jb250cm9scy1wYW5l bCcpIE9LCitFWFBFQ1RFRCAoZG9jdW1lbnQuZGVmYXVsdFZpZXcuZ2V0Q29tcHV0ZWRTdHlsZShw YW5lbClbJ2Rpc3BsYXknXSAhPSAnbm9uZScpIE9LCitkb2N1bWVudC5kZWZhdWx0Vmlldy5nZXRD b21wdXRlZFN0eWxlKHBhbmVsKVsnaGVpZ2h0J10gPSA2MDBweAorRVZFTlQod2Via2l0ZnVsbHNj cmVlbmNoYW5nZSkKK0VYUEVDVEVEIChkb2N1bWVudC5kZWZhdWx0Vmlldy5nZXRDb21wdXRlZFN0 eWxlKHBhbmVsKVsnZGlzcGxheSddID09ICdub25lJykgT0sKK0VORCBPRiBURVNUCisKLS0gCjEu Ny43LjM= 130399 2012-03-06 09:54:53 -0800 2012-03-06 11:15:59 -0800 Patch bug-73583-20120306185450.patch text/plain 3407 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5OTI4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzNkMzNhMzhiYjNkYWZhNTUzNjNj NDE5NGZkMzEwNjA0MjEzNGU1Ni4uYTFhMGFmOTQ1ZDNjNmM2NWVjNWE5MDExYmY4Nzc5NDVhMGQ0 MmMxOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTAzLTA2ICBQaGlsaXBwZSBOb3JtYW5k ICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAorICAgICAgICBmdWxsc2NyZWVuL3ZpZGVvLWNvbnRy b2xzIGlzIHRvbyBzcGVjaWZpYyB0byB0aGUgbWFjIHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczNTgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVsYXggdGhlIHRlc3Qgb24gdGhlIGRvY3VtZW50 J3MgdmlldyBoZWlnaHQgdG8gbm90IGRlcGVuZCBvbiB0aGUKKyAgICAgICAgbWFjIHBvcnQgZnVs bHNjcmVlbiBjb250cm9scyBzdHlsZXNoZWV0LgorCisgICAgICAgICogZnVsbHNjcmVlbi92aWRl by1jb250cm9scy1vdmVycmlkZS1leHBlY3RlZC50eHQ6CisgICAgICAgICogZnVsbHNjcmVlbi92 aWRlby1jb250cm9scy1vdmVycmlkZS5odG1sOgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9Ta2lw cGVkOgorCisyMDEyLTAzLTA2ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNv bT4KKwogICAgICAgICBbR1RLXSBmdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLWlmcmFtZS1sZWdhY3ku aHRtbCBpcyBmbGFreQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzQyNzkKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi92aWRlby1j b250cm9scy1vdmVycmlkZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mdWxsc2NyZWVuL3Zp ZGVvLWNvbnRyb2xzLW92ZXJyaWRlLWV4cGVjdGVkLnR4dAppbmRleCA5ZTJmMGFiOTk5ZjM0NmFl ZGVjMTM1NzE5ZDE3N2ZhNDRjNjJjY2QwLi5mMTkyYTM5MTczZDU0ZDFkOWY1MWIxNDFkYWE0MWVi ZWExZjI4ZjJhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mdWxsc2NyZWVuL3ZpZGVvLWNvbnRy b2xzLW92ZXJyaWRlLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mdWxsc2NyZWVuL3Zp ZGVvLWNvbnRyb2xzLW92ZXJyaWRlLWV4cGVjdGVkLnR4dApAQCAtNSw3ICs1LDcgQEAgRVhQRUNU RUQgKHNoYWRvd1Jvb3QgPSBpbnRlcm5hbHMuc2hhZG93Um9vdCh2aWRlbykgIT0gJ251bGwnKSBP SwogRVhQRUNURUQgKHBhbmVsID0gc2hhZG93Um9vdC5maXJzdENoaWxkLmZpcnN0Q2hpbGQgIT0g J251bGwnKSBPSwogRVhQRUNURUQgKGludGVybmFscy5zaGFkb3dQc2V1ZG9JZChwYW5lbCkgPT0g Jy13ZWJraXQtbWVkaWEtY29udHJvbHMtcGFuZWwnKSBPSwogRVhQRUNURUQgKGRvY3VtZW50LmRl ZmF1bHRWaWV3LmdldENvbXB1dGVkU3R5bGUocGFuZWwpWydkaXNwbGF5J10gIT0gJ25vbmUnKSBP SwotRVhQRUNURUQgKGRvY3VtZW50LmRlZmF1bHRWaWV3LmdldENvbXB1dGVkU3R5bGUocGFuZWwp WydoZWlnaHQnXSA9PSAnNDhweCcpIE9LCitFWFBFQ1RFRCAoZG9jdW1lbnQuZGVmYXVsdFZpZXcu Z2V0Q29tcHV0ZWRTdHlsZShwYW5lbClbJ2hlaWdodCddID49ICcyMHB4JykgT0sKIEVWRU5UKHdl YmtpdGZ1bGxzY3JlZW5jaGFuZ2UpCiBFWFBFQ1RFRCAoZG9jdW1lbnQuZGVmYXVsdFZpZXcuZ2V0 Q29tcHV0ZWRTdHlsZShwYW5lbClbJ2Rpc3BsYXknXSA9PSAnbm9uZScpIE9LCiBFTkQgT0YgVEVT VApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi92aWRlby1jb250cm9scy1vdmVy cmlkZS5odG1sIGIvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi92aWRlby1jb250cm9scy1vdmVycmlk ZS5odG1sCmluZGV4IGVjYjg2OGJhMmM1NTA0MWViMDU4ZjU0NDAwMmQ0ZTJiMjk4Y2U2ZjYuLjcy MTRiYmEwN2ZkMzA3YzEyMjVmMmZlNWFmMWIzOGE1N2RiMjA0MjEgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL2Z1bGxzY3JlZW4vdmlkZW8tY29udHJvbHMtb3ZlcnJpZGUuaHRtbAorKysgYi9MYXlv dXRUZXN0cy9mdWxsc2NyZWVuL3ZpZGVvLWNvbnRyb2xzLW92ZXJyaWRlLmh0bWwKQEAgLTIyLDcg KzIyLDcgQEAKICAgICAgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoInBhbmVsID0gc2hhZG93Um9v dC5maXJzdENoaWxkLmZpcnN0Q2hpbGQiLCBudWxsLCAiIT0iKTsKICAgICAgICAgICAgICAgICB0 ZXN0RXhwZWN0ZWQoImludGVybmFscy5zaGFkb3dQc2V1ZG9JZChwYW5lbCkiLCAiLXdlYmtpdC1t ZWRpYS1jb250cm9scy1wYW5lbCIpOwogICAgICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgiZG9j dW1lbnQuZGVmYXVsdFZpZXcuZ2V0Q29tcHV0ZWRTdHlsZShwYW5lbClbJ2Rpc3BsYXknXSIsICdu b25lJywgIiE9Iik7Ci0gICAgICAgICAgICAgICAgdGVzdEV4cGVjdGVkKCJkb2N1bWVudC5kZWZh dWx0Vmlldy5nZXRDb21wdXRlZFN0eWxlKHBhbmVsKVsnaGVpZ2h0J10iLCAnNDhweCcpOworICAg ICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgiZG9jdW1lbnQuZGVmYXVsdFZpZXcuZ2V0Q29tcHV0 ZWRTdHlsZShwYW5lbClbJ2hlaWdodCddIiwgJzIwcHgnLCAiPj0iKTsKICAgICAgICAgICAgIH0K ICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICBsb2dSZXN1bHQoZmFsc2UsICJ3aW5k b3cuaW50ZXJuYWxzID09IHVuZGVmaW5lZCIpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZ3RrL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAppbmRl eCA2NGQ4ZmU1MWVhZjFkM2M2MGQ4Nzc3M2Q1ZmY2YmU5MTQ4Y2RiYzY3Li41ZjIxOTkzYmU5MTRk ZjA2YTQ0ODdiMjM5MzBhNWM3YTAzOTMyYTBiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9ndGsvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZApA QCAtMTUxMyw5ICsxNTEzLDYgQEAgZmFzdC9ldmVudHMvb2Zmc2V0WC1vZmZzZXRZLmh0bWwKIGZh c3QvZm9ybXMvbnVtYmVyL3NwaW4taW4tbXVsdGktY29sdW1uLmh0bWwKIGZhc3QvZm9ybXMvcmFu Z2Uvc2xpZGVyLWluLW11bHRpLWNvbHVtbi5odG1sCiAKLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTczNTgzCi1mdWxsc2NyZWVuL3ZpZGVvLWNvbnRyb2xzLW92ZXJy aWRlLmh0bWwKLQogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM3 NjkKIHN2Zy90ZXh0L3RleHQtc3R5bGUtcmVjYWxjLWNyYXNoLmh0bWwKIAo= 130415 2012-03-06 11:16:06 -0800 2012-03-06 11:21:56 -0800 Patch bug-73583-20120306201604.patch text/plain 4549 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5OTI4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzNkMzNhMzhiYjNkYWZhNTUzNjNj NDE5NGZkMzEwNjA0MjEzNGU1Ni4uYTFhMGFmOTQ1ZDNjNmM2NWVjNWE5MDExYmY4Nzc5NDVhMGQ0 MmMxOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTAzLTA2ICBQaGlsaXBwZSBOb3JtYW5k ICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAorICAgICAgICBmdWxsc2NyZWVuL3ZpZGVvLWNvbnRy b2xzIGlzIHRvbyBzcGVjaWZpYyB0byB0aGUgbWFjIHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczNTgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVsYXggdGhlIHRlc3Qgb24gdGhlIGRvY3VtZW50 J3MgdmlldyBoZWlnaHQgdG8gbm90IGRlcGVuZCBvbiB0aGUKKyAgICAgICAgbWFjIHBvcnQgZnVs bHNjcmVlbiBjb250cm9scyBzdHlsZXNoZWV0LgorCisgICAgICAgICogZnVsbHNjcmVlbi92aWRl by1jb250cm9scy1vdmVycmlkZS1leHBlY3RlZC50eHQ6CisgICAgICAgICogZnVsbHNjcmVlbi92 aWRlby1jb250cm9scy1vdmVycmlkZS5odG1sOgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9Ta2lw cGVkOgorCisyMDEyLTAzLTA2ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNv bT4KKwogICAgICAgICBbR1RLXSBmdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLWlmcmFtZS1sZWdhY3ku aHRtbCBpcyBmbGFreQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzQyNzkKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi92aWRlby1j b250cm9scy1vdmVycmlkZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mdWxsc2NyZWVuL3Zp ZGVvLWNvbnRyb2xzLW92ZXJyaWRlLWV4cGVjdGVkLnR4dAppbmRleCA5ZTJmMGFiOTk5ZjM0NmFl ZGVjMTM1NzE5ZDE3N2ZhNDRjNjJjY2QwLi5mMTkyYTM5MTczZDU0ZDFkOWY1MWIxNDFkYWE0MWVi ZWExZjI4ZjJhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mdWxsc2NyZWVuL3ZpZGVvLWNvbnRy b2xzLW92ZXJyaWRlLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mdWxsc2NyZWVuL3Zp ZGVvLWNvbnRyb2xzLW92ZXJyaWRlLWV4cGVjdGVkLnR4dApAQCAtNSw3ICs1LDcgQEAgRVhQRUNU RUQgKHNoYWRvd1Jvb3QgPSBpbnRlcm5hbHMuc2hhZG93Um9vdCh2aWRlbykgIT0gJ251bGwnKSBP SwogRVhQRUNURUQgKHBhbmVsID0gc2hhZG93Um9vdC5maXJzdENoaWxkLmZpcnN0Q2hpbGQgIT0g J251bGwnKSBPSwogRVhQRUNURUQgKGludGVybmFscy5zaGFkb3dQc2V1ZG9JZChwYW5lbCkgPT0g Jy13ZWJraXQtbWVkaWEtY29udHJvbHMtcGFuZWwnKSBPSwogRVhQRUNURUQgKGRvY3VtZW50LmRl ZmF1bHRWaWV3LmdldENvbXB1dGVkU3R5bGUocGFuZWwpWydkaXNwbGF5J10gIT0gJ25vbmUnKSBP SwotRVhQRUNURUQgKGRvY3VtZW50LmRlZmF1bHRWaWV3LmdldENvbXB1dGVkU3R5bGUocGFuZWwp WydoZWlnaHQnXSA9PSAnNDhweCcpIE9LCitFWFBFQ1RFRCAoZG9jdW1lbnQuZGVmYXVsdFZpZXcu Z2V0Q29tcHV0ZWRTdHlsZShwYW5lbClbJ2hlaWdodCddID49ICcyMHB4JykgT0sKIEVWRU5UKHdl YmtpdGZ1bGxzY3JlZW5jaGFuZ2UpCiBFWFBFQ1RFRCAoZG9jdW1lbnQuZGVmYXVsdFZpZXcuZ2V0 Q29tcHV0ZWRTdHlsZShwYW5lbClbJ2Rpc3BsYXknXSA9PSAnbm9uZScpIE9LCiBFTkQgT0YgVEVT VApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi92aWRlby1jb250cm9scy1vdmVy cmlkZS5odG1sIGIvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi92aWRlby1jb250cm9scy1vdmVycmlk ZS5odG1sCmluZGV4IGVjYjg2OGJhMmM1NTA0MWViMDU4ZjU0NDAwMmQ0ZTJiMjk4Y2U2ZjYuLjcy MTRiYmEwN2ZkMzA3YzEyMjVmMmZlNWFmMWIzOGE1N2RiMjA0MjEgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL2Z1bGxzY3JlZW4vdmlkZW8tY29udHJvbHMtb3ZlcnJpZGUuaHRtbAorKysgYi9MYXlv dXRUZXN0cy9mdWxsc2NyZWVuL3ZpZGVvLWNvbnRyb2xzLW92ZXJyaWRlLmh0bWwKQEAgLTIyLDcg KzIyLDcgQEAKICAgICAgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoInBhbmVsID0gc2hhZG93Um9v dC5maXJzdENoaWxkLmZpcnN0Q2hpbGQiLCBudWxsLCAiIT0iKTsKICAgICAgICAgICAgICAgICB0 ZXN0RXhwZWN0ZWQoImludGVybmFscy5zaGFkb3dQc2V1ZG9JZChwYW5lbCkiLCAiLXdlYmtpdC1t ZWRpYS1jb250cm9scy1wYW5lbCIpOwogICAgICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgiZG9j dW1lbnQuZGVmYXVsdFZpZXcuZ2V0Q29tcHV0ZWRTdHlsZShwYW5lbClbJ2Rpc3BsYXknXSIsICdu b25lJywgIiE9Iik7Ci0gICAgICAgICAgICAgICAgdGVzdEV4cGVjdGVkKCJkb2N1bWVudC5kZWZh dWx0Vmlldy5nZXRDb21wdXRlZFN0eWxlKHBhbmVsKVsnaGVpZ2h0J10iLCAnNDhweCcpOworICAg ICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgiZG9jdW1lbnQuZGVmYXVsdFZpZXcuZ2V0Q29tcHV0 ZWRTdHlsZShwYW5lbClbJ2hlaWdodCddIiwgJzIwcHgnLCAiPj0iKTsKICAgICAgICAgICAgIH0K ICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICBsb2dSZXN1bHQoZmFsc2UsICJ3aW5k b3cuaW50ZXJuYWxzID09IHVuZGVmaW5lZCIpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vY2hyb21pdW0vZnVsbHNjcmVlbi92aWRlby1jb250cm9scy1vdmVycmlkZS1leHBlY3Rl ZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9mdWxsc2NyZWVuL3ZpZGVvLWNv bnRyb2xzLW92ZXJyaWRlLWV4cGVjdGVkLnR4dApkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAzNzU4MTE3ZTljZDViY2FmOGEzODkyYzg4ZDUwNzRjMmNiYWZjNi4uMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9j aHJvbWl1bS9mdWxsc2NyZWVuL3ZpZGVvLWNvbnRyb2xzLW92ZXJyaWRlLWV4cGVjdGVkLnR4dAor KysgL2Rldi9udWxsCkBAIC0xLDEyICswLDAgQEAKLVRoaXMgdGVzdHMgdGhhdCB0aGUgdmlkZW8g ZWxlbWVudCdzICJjb250cm9scyIgYXR0cmlidXRlIGlzIG92ZXJyaWRkZW4gaW4gZnVsbCBzY3Jl ZW4gbW9kZSwgYW5kIHRoYXQgdGhlIGNvbnRyb2xzIGFyZSBjb3JyZWN0bHkgaGlkZGVuIHVwb24g ZXhpdGluZyBmdWxsIHNjcmVlbi4gUHJlc3MgYW55IGtleSB0byBjb250aW51ZS4KLQotRVZFTlQo d2Via2l0ZnVsbHNjcmVlbmNoYW5nZSkKLUVYUEVDVEVEIChzaGFkb3dSb290ID0gaW50ZXJuYWxz LnNoYWRvd1Jvb3QodmlkZW8pICE9ICdudWxsJykgT0sKLUVYUEVDVEVEIChwYW5lbCA9IHNoYWRv d1Jvb3QuZmlyc3RDaGlsZC5maXJzdENoaWxkICE9ICdudWxsJykgT0sKLUVYUEVDVEVEIChpbnRl cm5hbHMuc2hhZG93UHNldWRvSWQocGFuZWwpID09ICctd2Via2l0LW1lZGlhLWNvbnRyb2xzLXBh bmVsJykgT0sKLUVYUEVDVEVEIChkb2N1bWVudC5kZWZhdWx0Vmlldy5nZXRDb21wdXRlZFN0eWxl KHBhbmVsKVsnZGlzcGxheSddICE9ICdub25lJykgT0sKLUVYUEVDVEVEIChkb2N1bWVudC5kZWZh dWx0Vmlldy5nZXRDb21wdXRlZFN0eWxlKHBhbmVsKVsnaGVpZ2h0J10gPT0gJzQ4cHgnKSwgT0JT RVJWRUQgJzMycHgnIEZBSUwKLUVWRU5UKHdlYmtpdGZ1bGxzY3JlZW5jaGFuZ2UpCi1FWFBFQ1RF RCAoZG9jdW1lbnQuZGVmYXVsdFZpZXcuZ2V0Q29tcHV0ZWRTdHlsZShwYW5lbClbJ2Rpc3BsYXkn XSA9PSAnbm9uZScpIE9LCi1FTkQgT0YgVEVTVAotCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9ndGsvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCmlu ZGV4IDY0ZDhmZTUxZWFmMWQzYzYwZDg3NzczZDVmZjZiZTkxNDhjZGJjNjcuLjVmMjE5OTNiZTkx NGRmMDZhNDQ4N2IyMzkzMGE1YzdhMDM5MzJhMGIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL2d0ay9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVk CkBAIC0xNTEzLDkgKzE1MTMsNiBAQCBmYXN0L2V2ZW50cy9vZmZzZXRYLW9mZnNldFkuaHRtbAog ZmFzdC9mb3Jtcy9udW1iZXIvc3Bpbi1pbi1tdWx0aS1jb2x1bW4uaHRtbAogZmFzdC9mb3Jtcy9y YW5nZS9zbGlkZXItaW4tbXVsdGktY29sdW1uLmh0bWwKIAotIyBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM1ODMKLWZ1bGxzY3JlZW4vdmlkZW8tY29udHJvbHMtb3Zl cnJpZGUuaHRtbAotCiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03 Mzc2OQogc3ZnL3RleHQvdGV4dC1zdHlsZS1yZWNhbGMtY3Jhc2guaHRtbAogCg==