73577 2011-12-01 11:23:23 -0800 [GTK] scrollbars interfering with fullscreen (in-window) video rendering 2011-12-02 01:19:09 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://tiny.cc/wkmedia P2 Normal --- 66968 1 pnormand webkit-unassigned oldest_to_newest 512927 0 pnormand 2011-12-01 11:23:23 -0800 Enabling the fullscreen API and activating fullscreen display on the linked page shows scrollbars flickering with the video display. They need to be neutralized by the ChromeClieng GtkAdjustmentWatcher in that case. 513008 1 117463 pnormand 2011-12-01 12:50:19 -0800 Created attachment 117463 Disable scrollbars when switching to fullscreen 513046 2 117463 mrobinson 2011-12-01 13:27:52 -0800 Comment on attachment 117463 Disable scrollbars when switching to fullscreen View in context: https://bugs.webkit.org/attachment.cgi?id=117463&action=review Okay! > Source/WebKit/gtk/WebCoreSupport/GtkAdjustmentWatcher.cpp:55 > + Extra line here? 513611 3 pnormand 2011-12-02 01:19:09 -0800 Committed r101765: <http://trac.webkit.org/changeset/101765> 117463 2011-12-01 12:50:19 -0800 2011-12-01 13:27:52 -0800 Disable scrollbars when switching to fullscreen Disable-scrollbars-when-switching-to-fullscreen.patch text/plain 6473 pnormand RnJvbSAwNWY2MWM3OWU0YTI1NTIxNGRlOGNjMmRhMTI3NTQ3YzlmODY0NmM3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUaHUsIDEgRGVjIDIwMTEgMjA6Mjk6MDIgKzAxMDAKU3ViamVjdDogW1BBVENIXSBE aXNhYmxlIHNjcm9sbGJhcnMgd2hlbiBzd2l0Y2hpbmcgdG8gZnVsbHNjcmVlbgoKLS0tCiBTb3Vy Y2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMjYgKysr KysrKysrKysrKysrKysrKysKIC4uLi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNs aWVudEd0ay5jcHAgIHwgICAgNSArKysrCiAuLi4vZ3RrL1dlYkNvcmVTdXBwb3J0L0d0a0FkanVz dG1lbnRXYXRjaGVyLmNwcCAgICB8ICAgMTkgKysrKysrKysrKysrKy0KIC4uLi9ndGsvV2ViQ29y ZVN1cHBvcnQvR3RrQWRqdXN0bWVudFdhdGNoZXIuaCAgICAgIHwgICAgNCArKysKIDQgZmlsZXMg Y2hhbmdlZCwgNTMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggYjAwOTNhMi4uOTFhYjk4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBA CisyMDExLTEyLTAxICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKwor ICAgICAgICBbR1RLXSBzY3JvbGxiYXJzIGludGVyZmVyaW5nIHdpdGggZnVsbHNjcmVlbiAoaW4t d2luZG93KSB2aWRlbyByZW5kZXJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTczNTc3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRGlzYWJsZSBzY3JvbGxiYXJzIHdoZW4gc3dpdGNoaW5nIHRvIGZ1bGxz Y3JlZW4uCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3BwOgor ICAgICAgICAoV2ViS2l0OjpDaHJvbWVDbGllbnQ6OmNvbnRlbnRzU2l6ZUNoYW5nZWQpOiBJZ25v cmUgc2l6ZSBjaGFuZ2VzCisgICAgICAgIHdoZW4gYW4gZWxlbWVudCBpcyBiZWluZyBkaXNwbGF5 ZWQgZnVsbHNjcmVlbi4KKyAgICAgICAgKFdlYktpdDo6Q2hyb21lQ2xpZW50OjplbnRlckZ1bGxT Y3JlZW5Gb3JFbGVtZW50KTogRGlzYWJsZQorICAgICAgICBzY3JvbGxiYXJzIHdoZW4gZW50ZXJp bmcgZnVsbHNjcmVlbi4KKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9HdGtBZGp1c3RtZW50V2F0 Y2hlci5jcHA6IEFkZGVkIDIgbWV0aG9kcyB0bworICAgICAgICBlbmFibGUvZGlzYWJsZSBzY3Jv bGxiYXJzIGFuZCBvbmUgbWV0aG9kIHRvIGtub3cgd2hldGhlciB0aGV5IGFyZQorICAgICAgICBl bmFibGVkIG9yIG5vdC4KKyAgICAgICAgKFdlYktpdDo6R3RrQWRqdXN0bWVudFdhdGNoZXI6Okd0 a0FkanVzdG1lbnRXYXRjaGVyKToKKyAgICAgICAgKFdlYktpdDo6dXBkYXRlQWRqdXN0bWVudEZy b21TY3JvbGxiYXIpOgorICAgICAgICAoV2ViS2l0OjpHdGtBZGp1c3RtZW50V2F0Y2hlcjo6dXBk YXRlQWRqdXN0bWVudHNGcm9tU2Nyb2xsYmFycyk6CisgICAgICAgIChXZWJLaXQ6Okd0a0FkanVz dG1lbnRXYXRjaGVyOjp1cGRhdGVBZGp1c3RtZW50c0Zyb21TY3JvbGxiYXJzTGF0ZXIpOgorICAg ICAgICAoV2ViS2l0OjpHdGtBZGp1c3RtZW50V2F0Y2hlcjo6ZGlzYWJsZUFsbFNjcm9sbGJhcnMp OgorICAgICAgICAoV2ViS2l0OjpHdGtBZGp1c3RtZW50V2F0Y2hlcjo6ZW5hYmxlQWxsU2Nyb2xs YmFycyk6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvR3RrQWRqdXN0bWVudFdhdGNoZXIuaDoK KyAgICAgICAgKFdlYktpdDo6R3RrQWRqdXN0bWVudFdhdGNoZXI6OnNjcm9sbGJhcnNEaXNhYmxl ZCk6CisKIDIwMTEtMTEtMjEgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgogCiAgICAgICAgIFtHVEtdIGVuYWJsZS13ZWJhdWRpbyB3ZWJzZXR0aW5nCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3BwIGIv U291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNwcAppbmRl eCBmMjNlOGRiLi5hNDhjMDA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3Jl U3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNv cmVTdXBwb3J0L0Nocm9tZUNsaWVudEd0ay5jcHAKQEAgLTYzNiw2ICs2MzYsOSBAQCBQbGF0Zm9y bVBhZ2VDbGllbnQgQ2hyb21lQ2xpZW50OjpwbGF0Zm9ybVBhZ2VDbGllbnQoKSBjb25zdAogCiB2 b2lkIENocm9tZUNsaWVudDo6Y29udGVudHNTaXplQ2hhbmdlZChGcmFtZSogZnJhbWUsIGNvbnN0 IEludFNpemUmIHNpemUpIGNvbnN0CiB7CisgICAgaWYgKG1fYWRqdXN0bWVudFdhdGNoZXIuc2Ny b2xsYmFyc0Rpc2FibGVkKCkpCisgICAgICAgIHJldHVybjsKKwogICAgIC8vIFdlIG5lZWQgdG8g cXVldWUgYSByZXNpemUgcmVxdWVzdCBvbmx5IGlmIHRoZSBzaXplIGNoYW5nZWQsCiAgICAgLy8g b3RoZXJ3aXNlIHdlIGdldCBpbnRvIGFuIGluZmluaXRlIGxvb3AhCiAgICAgR3RrV2lkZ2V0KiB3 aWRnZXQgPSBHVEtfV0lER0VUKG1fd2ViVmlldyk7CkBAIC04ODYsMTIgKzg4OSwxNCBAQCBib29s IENocm9tZUNsaWVudDo6c3VwcG9ydHNGdWxsU2NyZWVuRm9yRWxlbWVudChjb25zdCBXZWJDb3Jl OjpFbGVtZW50KiBlbGVtZW50LAogdm9pZCBDaHJvbWVDbGllbnQ6OmVudGVyRnVsbFNjcmVlbkZv ckVsZW1lbnQoV2ViQ29yZTo6RWxlbWVudCogZWxlbWVudCkKIHsKICAgICBlbGVtZW50LT5kb2N1 bWVudCgpLT53ZWJraXRXaWxsRW50ZXJGdWxsU2NyZWVuRm9yRWxlbWVudChlbGVtZW50KTsKKyAg ICBtX2FkanVzdG1lbnRXYXRjaGVyLmRpc2FibGVBbGxTY3JvbGxiYXJzKCk7CiAgICAgZWxlbWVu dC0+ZG9jdW1lbnQoKS0+d2Via2l0RGlkRW50ZXJGdWxsU2NyZWVuRm9yRWxlbWVudChlbGVtZW50 KTsKIH0KIAogdm9pZCBDaHJvbWVDbGllbnQ6OmV4aXRGdWxsU2NyZWVuRm9yRWxlbWVudChXZWJD b3JlOjpFbGVtZW50KiBlbGVtZW50KQogewogICAgIGVsZW1lbnQtPmRvY3VtZW50KCktPndlYmtp dFdpbGxFeGl0RnVsbFNjcmVlbkZvckVsZW1lbnQoZWxlbWVudCk7CisgICAgbV9hZGp1c3RtZW50 V2F0Y2hlci5lbmFibGVBbGxTY3JvbGxiYXJzKCk7CiAgICAgZWxlbWVudC0+ZG9jdW1lbnQoKS0+ d2Via2l0RGlkRXhpdEZ1bGxTY3JlZW5Gb3JFbGVtZW50KGVsZW1lbnQpOwogfQogI2VuZGlmCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9HdGtBZGp1c3RtZW50 V2F0Y2hlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9HdGtBZGp1c3Rt ZW50V2F0Y2hlci5jcHAKaW5kZXggZWViNzc5Ni4uOWZmMWZhMyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvR3RrQWRqdXN0bWVudFdhdGNoZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0d0a0FkanVzdG1lbnRXYXRjaGVyLmNw cApAQCAtMzIsNiArMzIsNyBAQCBuYW1lc3BhY2UgV2ViS2l0IHsKIAogR3RrQWRqdXN0bWVudFdh dGNoZXI6Okd0a0FkanVzdG1lbnRXYXRjaGVyKFdlYktpdFdlYlZpZXcqIHdlYlZpZXcpCiAgICAg OiBtX3dlYlZpZXcod2ViVmlldykKKyAgICAsIG1fc2Nyb2xsYmFyc0Rpc2FibGVkKGZhbHNlKQog ICAgICwgbV9oYW5kbGluZ0d0a0FkanVzdG1lbnRDaGFuZ2UoZmFsc2UpCiAgICAgLCBtX3VwZGF0 ZUFkanVzdG1lbnRDYWxsYmFja0lkKDApCiB7CkBAIC01MSwxMiArNTIsMTUgQEAgc3RhdGljIHZv aWQgdXBkYXRlQWRqdXN0bWVudEZyb21TY3JvbGxiYXIoR3RrQWRqdXN0bWVudCogYWRqdXN0bWVu dCwgU2Nyb2xsYmFyKgogICAgICAgICBndGtfYWRqdXN0bWVudF9jb25maWd1cmUoYWRqdXN0bWVu dCwgMCwgMCwgMCwgMCwgMCwgMCk7IC8vIFRoZXNlIGFyZSB0aGUgc2V0dGluZ3Mgd2hpY2ggcmVt b3ZlIHRoZSBzY3JvbGxiYXIuCiAgICAgICAgIHJldHVybjsKICAgICB9CisKICAgICBndGtfYWRq dXN0bWVudF9jb25maWd1cmUoYWRqdXN0bWVudCwgc2Nyb2xsYmFyLT52YWx1ZSgpLCAwLCBzY3Jv bGxiYXItPnRvdGFsU2l6ZSgpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzY3JvbGxi YXItPmxpbmVTdGVwKCksIHNjcm9sbGJhci0+cGFnZVN0ZXAoKSwgc2Nyb2xsYmFyLT52aXNpYmxl U2l6ZSgpKTsKIH0KIAogdm9pZCBHdGtBZGp1c3RtZW50V2F0Y2hlcjo6dXBkYXRlQWRqdXN0bWVu dHNGcm9tU2Nyb2xsYmFycygpCiB7CisgICAgaWYgKG1fc2Nyb2xsYmFyc0Rpc2FibGVkKQorICAg ICAgICByZXR1cm47CiAgICAgaWYgKG1faGFuZGxpbmdHdGtBZGp1c3RtZW50Q2hhbmdlKQogICAg ICAgICByZXR1cm47CiAgICAgaWYgKCFjb3JlKG1fd2ViVmlldykgfHwgIWNvcmUobV93ZWJWaWV3 KS0+bWFpbkZyYW1lKCkpCkBAIC03Nyw3ICs4MSw3IEBAIHN0YXRpYyBnYm9vbGVhbiB1cGRhdGVB ZGp1c3RtZW50Q2FsbGJhY2soR3RrQWRqdXN0bWVudFdhdGNoZXIqIHdhdGNoZXIpCiB2b2lkIEd0 a0FkanVzdG1lbnRXYXRjaGVyOjp1cGRhdGVBZGp1c3RtZW50c0Zyb21TY3JvbGxiYXJzTGF0ZXIo KSBjb25zdAogewogICAgIC8vIFdlJ3ZlIGFscmVhZHkgc2NoZWR1bGVkIGFuIHVwZGF0ZS4gTm8g bmVlZCB0byBzY2hlZHVsZSBhbm90aGVyLgotICAgIGlmIChtX3VwZGF0ZUFkanVzdG1lbnRDYWxs YmFja0lkKQorICAgIGlmIChtX3VwZGF0ZUFkanVzdG1lbnRDYWxsYmFja0lkIHx8IG1fc2Nyb2xs YmFyc0Rpc2FibGVkKQogICAgICAgICByZXR1cm47CiAKICAgICAvLyBUaGUgZmFjdCB0aGF0IHRo aXMgbWV0aG9kIHdhcyBjYWxsZWQgbWVhbnMgdGhhdCB3ZSBuZWVkIHRvIHVwZGF0ZSB0aGUgc2Ny b2xsYmFycywgYnV0IGF0IHRoZQpAQCAtMTMwLDUgKzEzNCwxOCBAQCB2b2lkIEd0a0FkanVzdG1l bnRXYXRjaGVyOjphZGp1c3RtZW50VmFsdWVDaGFuZ2VkKEd0a0FkanVzdG1lbnQqIGFkanVzdG1l bnQpCiAgICAgfQogfQogCit2b2lkIEd0a0FkanVzdG1lbnRXYXRjaGVyOjpkaXNhYmxlQWxsU2Ny b2xsYmFycygpCit7CisgICAgdXBkYXRlQWRqdXN0bWVudEZyb21TY3JvbGxiYXIobV9ob3Jpem9u dGFsQWRqdXN0bWVudC5nZXQoKSwgMCk7CisgICAgdXBkYXRlQWRqdXN0bWVudEZyb21TY3JvbGxi YXIobV92ZXJ0aWNhbEFkanVzdG1lbnQuZ2V0KCksIDApOworICAgIG1fc2Nyb2xsYmFyc0Rpc2Fi bGVkID0gdHJ1ZTsKK30KKwordm9pZCBHdGtBZGp1c3RtZW50V2F0Y2hlcjo6ZW5hYmxlQWxsU2Ny b2xsYmFycygpCit7CisgICAgbV9zY3JvbGxiYXJzRGlzYWJsZWQgPSBmYWxzZTsKKyAgICB1cGRh dGVBZGp1c3RtZW50c0Zyb21TY3JvbGxiYXJzKCk7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYktp dAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9HdGtBZGp1 c3RtZW50V2F0Y2hlci5oIGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvR3RrQWRq dXN0bWVudFdhdGNoZXIuaAppbmRleCBhOGI1NGQ2Li4yZjdiZWUzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9HdGtBZGp1c3RtZW50V2F0Y2hlci5oCisrKyBi L1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0d0a0FkanVzdG1lbnRXYXRjaGVyLmgK QEAgLTM4LDExICszOCwxNSBAQCBwdWJsaWM6CiAgICAgdm9pZCBhZGp1c3RtZW50VmFsdWVDaGFu Z2VkKEd0a0FkanVzdG1lbnQqKTsKICAgICB2b2lkIHVwZGF0ZUFkanVzdG1lbnRzRnJvbVNjcm9s bGJhcnMoKTsKICAgICB2b2lkIHVwZGF0ZUFkanVzdG1lbnRzRnJvbVNjcm9sbGJhcnNMYXRlcigp IGNvbnN0OworICAgIHZvaWQgZGlzYWJsZUFsbFNjcm9sbGJhcnMoKTsKKyAgICB2b2lkIGVuYWJs ZUFsbFNjcm9sbGJhcnMoKTsKKyAgICBib29sIHNjcm9sbGJhcnNEaXNhYmxlZCgpIGNvbnN0IHsg cmV0dXJuIG1fc2Nyb2xsYmFyc0Rpc2FibGVkOyB9OwogCiBwcml2YXRlOgogICAgIFdlYktpdFdl YlZpZXcqIG1fd2ViVmlldzsKICAgICBHUmVmUHRyPEd0a0FkanVzdG1lbnQ+IG1faG9yaXpvbnRh bEFkanVzdG1lbnQ7CiAgICAgR1JlZlB0cjxHdGtBZGp1c3RtZW50PiBtX3ZlcnRpY2FsQWRqdXN0 bWVudDsKKyAgICBib29sIG1fc2Nyb2xsYmFyc0Rpc2FibGVkOwogICAgIGJvb2wgbV9oYW5kbGlu Z0d0a0FkanVzdG1lbnRDaGFuZ2U7CiAgICAgbXV0YWJsZSB1bnNpZ25lZCBtX3VwZGF0ZUFkanVz dG1lbnRDYWxsYmFja0lkOwogfTsKLS0gCjEuNy43LjM=