73576 2011-12-01 11:21:24 -0800 V8 bindings cleanup: V8WindowErrorHandler shouldn't be directly invoking script 2011-12-01 15:07:17 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rafaelw rafaelw abarth japhet webkit.review.bot oldest_to_newest 512924 0 rafaelw 2011-12-01 11:21:24 -0800 It should be calling through V8Proxy where appropriate checks are made. 512926 1 117449 rafaelw 2011-12-01 11:23:10 -0800 Created attachment 117449 Patch 512957 2 117449 abarth 2011-12-01 11:50:42 -0800 Comment on attachment 117449 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117449&action=review > Source/WebCore/ChangeLog:8 > + No tests needed. This patch is just bindings hygiene. It's too bad this stuff isn't testable. That means we'll probably continue to screw this up. 513167 3 117449 webkit.review.bot 2011-12-01 15:07:13 -0800 Comment on attachment 117449 Patch Clearing flags on attachment: 117449 Committed r101716: <http://trac.webkit.org/changeset/101716> 513168 4 webkit.review.bot 2011-12-01 15:07:17 -0800 All reviewed patches have been landed. Closing bug. 117449 2011-12-01 11:23:10 -0800 2011-12-01 15:07:13 -0800 Patch bug-73576-20111201112309.patch text/plain 1805 rafaelw U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxNjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGQwZTA1NTIwYWIyMmUz MWY5YTkyZDdmNWM1YTRjNTc4NmNmZTAxNS4uODUyN2NjYjE0YTI2YjdhOWU4MjlmYmZiYjkwMjNh NzE5YWFjMWE4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTEyLTAxICBSYWZh ZWwgV2VpbnN0ZWluICA8cmFmYWVsd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVjggYmluZGlu Z3MgY2xlYW51cDogVjhXaW5kb3dFcnJvckhhbmRsZXIgc2hvdWxkbid0IGJlIGRpcmVjdGx5IGlu dm9raW5nIHNjcmlwdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzM1NzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBObyB0ZXN0cyBuZWVkZWQuIFRoaXMgcGF0Y2ggaXMganVzdCBiaW5kaW5ncyBoeWdpZW5l LgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhXaW5kb3dFcnJvckhhbmRsZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6VjhXaW5kb3dFcnJvckhhbmRsZXI6OmNhbGxMaXN0ZW5lckZ1bmN0aW9u KToKKwogMjAxMS0xMS0zMCAgRG1pdHJ5IExvbW92ICA8ZHNsb21vdkBnb29nbGUuY29tPgogCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzUwMwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhXaW5kb3dFcnJvckhhbmRsZXIu Y3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhXaW5kb3dFcnJvckhhbmRsZXIuY3Bw CmluZGV4IDA3NjFiMGY2Njc1YWMxNDcwZjlhZmNjY2NhNmNhNmE0MWU4YTM5NjcuLjc5N2M2MjRl MGQxNmIzNGRmZjg0ODhlMjRkNzU1ZjgxZTJhNThkZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4V2luZG93RXJyb3JIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9WOFdpbmRvd0Vycm9ySGFuZGxlci5jcHAKQEAgLTM1LDYgKzM1LDcg QEAKICNpbmNsdWRlICJFdmVudE5hbWVzLmgiCiAjaW5jbHVkZSAiRXJyb3JFdmVudC5oIgogI2lu Y2x1ZGUgIlY4QmluZGluZy5oIgorI2luY2x1ZGUgIlY4UHJveHkuaCIKIAogbmFtZXNwYWNlIFdl YkNvcmUgewogCkBAIC01Nyw3ICs1OCw3IEBAIHY4OjpMb2NhbDx2ODo6VmFsdWU+IFY4V2luZG93 RXJyb3JIYW5kbGVyOjpjYWxsTGlzdGVuZXJGdW5jdGlvbihTY3JpcHRFeGVjdXRpb25DCiAgICAg ICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBwYXJhbWV0ZXJzWzNdID0geyB2OFN0cmluZyhlcnJv ckV2ZW50LT5tZXNzYWdlKCkpLCB2OFN0cmluZyhlcnJvckV2ZW50LT5maWxlbmFtZSgpKSwgdjg6 OkludGVnZXI6Ok5ldyhlcnJvckV2ZW50LT5saW5lbm8oKSkgfTsKICAgICAgICAgdjg6OlRyeUNh dGNoIHRyeUNhdGNoOwogICAgICAgICB0cnlDYXRjaC5TZXRWZXJib3NlKHRydWUpOwotICAgICAg ICByZXR1cm5WYWx1ZSA9IGNhbGxGdW5jdGlvbi0+Q2FsbCh0aGlzVmFsdWUsIDMsIHBhcmFtZXRl cnMpOworICAgICAgICByZXR1cm5WYWx1ZSA9IFY4UHJveHk6Omluc3RydW1lbnRlZENhbGxGdW5j dGlvbigwIC8qIHBhZ2UgKi8sIGNhbGxGdW5jdGlvbiwgdGhpc1ZhbHVlLCAzLCBwYXJhbWV0ZXJz KTsKICAgICB9CiAgICAgcmV0dXJuIHJldHVyblZhbHVlOwogfQo=