73571 2011-12-01 10:13:25 -0800 More void functions eager to return values in RenderObject & WebFrameImpl 2011-12-01 14:16:31 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 knorton knorton abarth webkit.review.bot oldest_to_newest 512875 0 knorton 2011-12-01 10:13:25 -0800 Found a couple more in my client last week, now I'm cleaning them out. 512877 1 117441 knorton 2011-12-01 10:16:44 -0800 Created attachment 117441 Patch 513095 2 117441 webkit.review.bot 2011-12-01 14:16:27 -0800 Comment on attachment 117441 Patch Clearing flags on attachment: 117441 Committed r101706: <http://trac.webkit.org/changeset/101706> 513097 3 webkit.review.bot 2011-12-01 14:16:31 -0800 All reviewed patches have been landed. Closing bug. 117441 2011-12-01 10:16:44 -0800 2011-12-01 14:16:27 -0800 Patch bug-73571-20111201131642.patch text/plain 2920 knorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxNTE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGI0NjAyZjc3Y2VmMGIy MjZmN2QxOGFmNTZkNWM0YjVhYzQ2OGVkNy4uN2RhODA3NzcwN2IxMDc5YWQ1YWYwNmY3MGI3ZTli OThkOGU5ZmJjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTEyLTAxICBLZWxs eSBOb3J0b24gIDxrbm9ydG9uQGdvb2dsZS5jb20+CisKKyAgICAgICAgTW9yZSB2b2lkIGZ1bmN0 aW9ucyBlYWdlciB0byByZXR1cm4gdmFsdWVzIGluIFJlbmRlck9iamVjdCAmIFdlYkZyYW1lSW1w bAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM1NzEK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJPYmplY3QuaDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdDo6Y29t cHV0ZUFic29sdXRlUmVwYWludFJlY3QpOgorCiAyMDExLTExLTMwICBBbmRyZXkgS29zeWFrb3Yg IDxjYXNlcUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogW3JlZmFjdG9y aW5nXSBkbyBub3QgY2xvbmUgbm9kZXMgdGhhdCBjb250YWluIGxpbmtpZmllZCBVUkxzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4IDA0MDU5ZmI1N2U4ZmZmZWI1Nzc5NjQxYzkxOGNjMmUy MzBlZmIyOTYuLjQwMmQ4ZWYyNTRhYWY5ODA1ZmNhNzJhZGFkZGRjNGFiNzg5NGI4N2MgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTItMDEgIEtlbGx5 IE5vcnRvbiAgPGtub3J0b25AZ29vZ2xlLmNvbT4KKworICAgICAgICBNb3JlIHZvaWQgZnVuY3Rp b25zIGVhZ2VyIHRvIHJldHVybiB2YWx1ZXMgaW4gUmVuZGVyT2JqZWN0ICYgV2ViRnJhbWVJbXBs CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzU3MQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3JjL1dl YkZyYW1lSW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNocm9tZVByaW50Q29udGV4dDo6Y29t cHV0ZVBhZ2VSZWN0cyk6CisKIDIwMTEtMTEtMzAgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBn b29nbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGdldCByaWQgb2YgZGVmZXJyZWQg YmFja2VuZC0+ZnJvbnQtZW5kIGNvbW1hbmRzIHByb2Nlc3NpbmcuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyT2JqZWN0LmgKaW5kZXggMGM1ZDNjNGEzZDU1Y2UzMTBkZGQ3Y2FkNTExNTIy NWZkZTU1OTliZi4uODY5NWYzNTgwODFjYzZhN2I4MzI3NWY1Y2UwMDNjZTc2MjgxYzRhMSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuaApAQCAtNzExLDcgKzcxMSw3IEBA IHB1YmxpYzoKICAgICAvLyB0aGF0IHJlY3QgaW4gdmlldyBjb29yZGluYXRlcy4KICAgICB2b2lk IGNvbXB1dGVBYnNvbHV0ZVJlcGFpbnRSZWN0KExheW91dFJlY3QmIHIsIGJvb2wgZml4ZWQgPSBm YWxzZSkgY29uc3QKICAgICB7Ci0gICAgICAgIHJldHVybiBjb21wdXRlUmVjdEZvclJlcGFpbnQo MCwgciwgZml4ZWQpOworICAgICAgICBjb21wdXRlUmVjdEZvclJlcGFpbnQoMCwgciwgZml4ZWQp OwogICAgIH0KICAgICAvLyBHaXZlbiBhIHJlY3QgaW4gdGhlIG9iamVjdCdzIGNvb3JkaW5hdGUg c3BhY2UsIGNvbXB1dGUgYSByZWN0IHN1aXRhYmxlIGZvciByZXBhaW50aW5nCiAgICAgLy8gdGhh dCByZWN0IGluIHRoZSBjb29yZGluYXRlIHNwYWNlIG9mIHJlcGFpbnRDb250YWluZXIuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAppbmRleCA3NTFkMmNiNjI0 NTM3YWZiYjFkZDViNzc0N2E1MDkyOWQ4MTY0MzlkLi5mNDE0YmZlNjQwM2FjYWViOWVmMGYxNDRk ZmQ1NTdiYmNiZGJmNzM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJGcmFtZUltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1l SW1wbC5jcHAKQEAgLTQxNSw3ICs0MTUsNyBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIHZvaWQg Y29tcHV0ZVBhZ2VSZWN0cyhjb25zdCBGbG9hdFJlY3QmIHByaW50UmVjdCwgZmxvYXQgaGVhZGVy SGVpZ2h0LCBmbG9hdCBmb290ZXJIZWlnaHQsIGZsb2F0IHVzZXJTY2FsZUZhY3RvciwgZmxvYXQm IG91dFBhZ2VIZWlnaHQpCiAgICAgewotICAgICAgICByZXR1cm4gUHJpbnRDb250ZXh0Ojpjb21w dXRlUGFnZVJlY3RzKHByaW50UmVjdCwgaGVhZGVySGVpZ2h0LCBmb290ZXJIZWlnaHQsIHVzZXJT Y2FsZUZhY3Rvciwgb3V0UGFnZUhlaWdodCk7CisgICAgICAgIFByaW50Q29udGV4dDo6Y29tcHV0 ZVBhZ2VSZWN0cyhwcmludFJlY3QsIGhlYWRlckhlaWdodCwgZm9vdGVySGVpZ2h0LCB1c2VyU2Nh bGVGYWN0b3IsIG91dFBhZ2VIZWlnaHQpOwogICAgIH0KIAogICAgIHZpcnR1YWwgaW50IHBhZ2VD b3VudCgpIGNvbnN0Cg==