73564 2011-12-01 08:08:37 -0800 CSSMutableStyleDeclaration: Unnecessary double hash lookup in construction. 2011-12-01 12:04:47 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling macpherson webkit.review.bot oldest_to_newest 512776 0 kling 2011-12-01 08:08:37 -0800 In this constructor: - CSSMutableStyleDeclaration(CSSRule* parent, const CSSProperty* const * properties, int numProperties) We do a hash lookup using contains(), followed by a get() if contains() returns true. This should be done with a single lookup. 512783 1 117424 kling 2011-12-01 08:16:39 -0800 Created attachment 117424 Patch 512901 2 117424 koivisto 2011-12-01 10:54:41 -0800 Comment on attachment 117424 Patch r=me 512973 3 117424 webkit.review.bot 2011-12-01 12:04:42 -0800 Comment on attachment 117424 Patch Clearing flags on attachment: 117424 Committed r101697: <http://trac.webkit.org/changeset/101697> 512974 4 webkit.review.bot 2011-12-01 12:04:47 -0800 All reviewed patches have been landed. Closing bug. 117424 2011-12-01 08:16:39 -0800 2011-12-01 12:04:42 -0800 Patch bug-73564.diff text/plain 1690 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1MzdlOGQwLi4xYThmMmZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMTItMDEgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIENTU011dGFibGVTdHlsZURlY2xhcmF0aW9uOiBVbm5lY2Vzc2FyeSBkb3VibGUgaGFzaCBs b29rdXAgaW4gY29uc3RydWN0aW9uLgorICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi83MzU2 ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2Ug SGFzaE1hcDo6ZmluZCgpIGluc3RlYWQgb2YgY29udGFpbnMoKSBmb2xsb3dlZCBieSBnZXQoKSBv bgorICAgICAgICBzdWNjZXNzZnVsIGxvb2t1cC4KKworICAgICAgICAqIGNzcy9DU1NNdXRhYmxl U3R5bGVEZWNsYXJhdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NNdXRhYmxlU3R5bGVE ZWNsYXJhdGlvbjo6Q1NTTXV0YWJsZVN0eWxlRGVjbGFyYXRpb24pOgorCiAyMDExLTExLTMwICBB bmRyZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBTdHlsZWRFbGVtZW50 OiBUaWR5IHVwIGNvcHlOb25BdHRyaWJ1dGVQcm9wZXJ0aWVzKCkuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9jc3MvQ1NTTXV0YWJsZVN0eWxlRGVjbGFyYXRpb24uY3BwIGIvU291cmNlL1dl YkNvcmUvY3NzL0NTU011dGFibGVTdHlsZURlY2xhcmF0aW9uLmNwcAppbmRleCA0NjUwOWEwLi45 ZmViOTc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTTXV0YWJsZVN0eWxlRGVj bGFyYXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NNdXRhYmxlU3R5bGVEZWNs YXJhdGlvbi5jcHAKQEAgLTEzNywxMSArMTM3LDE0IEBAIENTU011dGFibGVTdHlsZURlY2xhcmF0 aW9uOjpDU1NNdXRhYmxlU3R5bGVEZWNsYXJhdGlvbihDU1NSdWxlKiBwYXJlbnQsIGNvbnN0IENT CiAgICAgICAgIGNvbnN0IENTU1Byb3BlcnR5ICpwcm9wZXJ0eSA9IHByb3BlcnRpZXNbaV07CiAg ICAgICAgIEFTU0VSVChwcm9wZXJ0eSk7CiAgICAgICAgIGJvb2wgaW1wb3J0YW50ID0gcHJvcGVy dHktPmlzSW1wb3J0YW50KCk7Ci0gICAgICAgIGlmIChjYW5kaWRhdGVzLmNvbnRhaW5zKHByb3Bl cnR5LT5pZCgpKSkgewotICAgICAgICAgICAgaWYgKCFpbXBvcnRhbnQgJiYgY2FuZGlkYXRlcy5n ZXQocHJvcGVydHktPmlkKCkpKQorCisgICAgICAgIEhhc2hNYXA8aW50LCBib29sPjo6aXRlcmF0 b3IgaXQgPSBjYW5kaWRhdGVzLmZpbmQocHJvcGVydHktPmlkKCkpOworICAgICAgICBpZiAoaXQg IT0gY2FuZGlkYXRlcy5lbmQoKSkgeworICAgICAgICAgICAgaWYgKCFpbXBvcnRhbnQgJiYgaXQt PnNlY29uZCkKICAgICAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgICAgIHJlbW92ZVBy b3BlcnR5KHByb3BlcnR5LT5pZCgpLCBmYWxzZSwgZmFsc2UpOwogICAgICAgICB9CisKICAgICAg ICAgbV9wcm9wZXJ0aWVzLmFwcGVuZCgqcHJvcGVydHkpOwogICAgICAgICBjYW5kaWRhdGVzLnNl dChwcm9wZXJ0eS0+aWQoKSwgaW1wb3J0YW50KTsKICAgICB9Cg==