73529 2011-11-30 23:34:36 -0800 Get rid of the unused function nameForCursorType() 2011-12-01 12:21:31 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin sam webkit.review.bot oldest_to_newest 512531 0 117353 benjamin 2011-11-30 23:34:36 -0800 Created attachment 117353 Patch Reviewed by NOBODY (OOPS!). The function nameForCursorType was introduced in r63339 and has not been used anywhere since that commit. * WebCore.exp.in: * platform/Cursor.cpp: * platform/Cursor.h: --- 4 files changed, 13 insertions(+), 98 deletions(-) 512533 1 webkit.review.bot 2011-11-30 23:36:38 -0800 Attachment 117353 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style. 512975 2 117353 joepeck 2011-12-01 12:05:02 -0800 Comment on attachment 117353 Patch Looks good. r=me 512988 3 benjamin 2011-12-01 12:21:31 -0800 Committed r101698: <http://trac.webkit.org/changeset/101698> 117353 2011-11-30 23:34:36 -0800 2011-12-01 12:05:02 -0800 Patch 20111130233435.patch text/plain 5296 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxNTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmU0ZDhhYThhZjA5NWY2 YzVmNzhmMTBjZjc5YzBiMmZjNTNmZmY2YS4uYTNlMGQ5Mjg2ZDk3ZjEyMmIzMGFjMGJlNzUzZjlj YTY1MjcwN2NiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTExLTMwICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBHZXQgcmlkIG9m IHRoZSB1bnVzZWQgZnVuY3Rpb24gbmFtZUZvckN1cnNvclR5cGUoKQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBmdW5jdGlvbiBuYW1lRm9yQ3Vy c29yVHlwZSB3YXMgaW50cm9kdWNlZCBpbiByNjMzMzkgYW5kIGhhcyBub3QgYmVlbiB1c2VkIGFu eXdoZXJlCisgICAgICAgIHNpbmNlIHRoYXQgY29tbWl0LgorCisgICAgICAgICogV2ViQ29yZS5l eHAuaW46CisgICAgICAgICogcGxhdGZvcm0vQ3Vyc29yLmNwcDoKKyAgICAgICAgKiBwbGF0Zm9y bS9DdXJzb3IuaDoKKwogMjAxMS0xMS0zMCAgVnNldm9sb2QgVmxhc292ICA8dnNldmlrQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbnNwZWN0IGVsZW1lbnQgZG9lcyBu b3QgaGlnaGxpZ2h0IGVsZW1lbnQgaW4gZWxlbWVudHMgcGFuZWwgd2hlbiBpbnNwZWN0b3IgaXMg b3BlbmVkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4gYi9Tb3Vy Y2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgppbmRleCA5OWZkMWNjZTQxZjI4Zjk5MzQyMjJhMjJj YjY5NGM5NWNiZDIxZmFlLi43MDA0ZmNiMGQwMGM0NjhiODFkZTI3NTM3MmUzNjljOGE4MmIyMWM4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgorKysgYi9Tb3VyY2Uv V2ViQ29yZS9XZWJDb3JlLmV4cC5pbgpAQCAtNTM5LDcgKzUzOSw2IEBAIF9fWk43V2ViQ29yZTE3 SGlzdG9yeUNvbnRyb2xsZXIzM3Jlc3RvcmVTY3JvbGxQb3NpdGlvbkFuZFZpZXdTdGF0ZUV2CiBf X1pON1dlYkNvcmUxN1JlZ3VsYXJFeHByZXNzaW9uQzFFUktOM1dURjZTdHJpbmdFTlMxXzE5VGV4 dENhc2VTZW5zaXRpdml0eUUKIF9fWk43V2ViQ29yZTE3UmVndWxhckV4cHJlc3Npb25EMUV2CiBf X1pON1dlYkNvcmUxN2NhY2hlRE9NU3RydWN0dXJlRVBOU18xN0pTRE9NR2xvYmFsT2JqZWN0RVBO M0pTQzlTdHJ1Y3R1cmVFUEtOUzJfOUNsYXNzSW5mb0UKLV9fWk43V2ViQ29yZTE3bmFtZUZvckN1 cnNvclR5cGVFTlNfNkN1cnNvcjRUeXBlRQogX19aTjdXZWJDb3JlMTdvcGVuVGVtcG9yYXJ5Rmls ZUVSS04zV1RGNlN0cmluZ0VSaQogX19aTjdXZWJDb3JlMThQbGF0Zm9ybU1vdXNlRXZlbnRDMUVQ N05TRXZlbnRQNk5TVmlldwogX19aTjdXZWJDb3JlMThQbGF0Zm9ybVN0cmF0ZWdpZXMyNmNyZWF0 ZUxvY2FsaXphdGlvblN0cmF0ZWd5RXYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL0N1cnNvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9DdXJzb3IuY3BwCmluZGV4 IGQxYzVkMmVkZTJjY2EzMmFjODEyN2I3OTFmZDdiMDdhYzhhODY0MzUuLjZjNzk2Y2RmMjY5NGEx MDExY2ZlMjA5YjliMjY2MThlYmY5ZWVhNWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL0N1cnNvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vQ3Vyc29yLmNw cApAQCAtMTQ0LDEwMiArMTQ0LDYgQEAgY29uc3QgQ3Vyc29yJiBDdXJzb3I6OmZyb21UeXBlKEN1 cnNvcjo6VHlwZSB0eXBlKQogICAgIHJldHVybiBwb2ludGVyQ3Vyc29yKCk7CiB9CiAKLWNvbnN0 IGNoYXIqIG5hbWVGb3JDdXJzb3JUeXBlKEN1cnNvcjo6VHlwZSB0eXBlKQotewotICAgIHN3aXRj aCAodHlwZSkgewotICAgIGNhc2UgQ3Vyc29yOjpQb2ludGVyOgotICAgICAgICByZXR1cm4gIlBv aW50ZXIiOwotICAgIGNhc2UgQ3Vyc29yOjpDcm9zczoKLSAgICAgICAgcmV0dXJuICJDcm9zcyI7 Ci0gICAgY2FzZSBDdXJzb3I6OkhhbmQ6Ci0gICAgICAgIHJldHVybiAiSGFuZCI7Ci0gICAgY2Fz ZSBDdXJzb3I6OklCZWFtOgotICAgICAgICByZXR1cm4gIklCZWFtIjsKLSAgICBjYXNlIEN1cnNv cjo6V2FpdDoKLSAgICAgICAgcmV0dXJuICJXYWl0IjsKLSAgICBjYXNlIEN1cnNvcjo6SGVscDoK LSAgICAgICAgcmV0dXJuICJIZWxwIjsKLSAgICBjYXNlIEN1cnNvcjo6RWFzdFJlc2l6ZToKLSAg ICAgICAgcmV0dXJuICJFYXN0UmVzaXplIjsKLSAgICBjYXNlIEN1cnNvcjo6Tm9ydGhSZXNpemU6 Ci0gICAgICAgIHJldHVybiAiTm9ydGhSZXNpemUiOwotICAgIGNhc2UgQ3Vyc29yOjpOb3J0aEVh c3RSZXNpemU6Ci0gICAgICAgIHJldHVybiAiTm9ydGhFYXN0UmVzaXplIjsKLSAgICBjYXNlIEN1 cnNvcjo6Tm9ydGhXZXN0UmVzaXplOgotICAgICAgICByZXR1cm4gIk5vcnRoV2VzdFJlc2l6ZSI7 Ci0gICAgY2FzZSBDdXJzb3I6OlNvdXRoUmVzaXplOgotICAgICAgICByZXR1cm4gIlNvdXRoUmVz aXplIjsKLSAgICBjYXNlIEN1cnNvcjo6U291dGhFYXN0UmVzaXplOgotICAgICAgICByZXR1cm4g IlNvdXRoRWFzdFJlc2l6ZSI7Ci0gICAgY2FzZSBDdXJzb3I6OlNvdXRoV2VzdFJlc2l6ZToKLSAg ICAgICAgcmV0dXJuICJTb3V0aFdlc3RSZXNpemUiOwotICAgIGNhc2UgQ3Vyc29yOjpXZXN0UmVz aXplOgotICAgICAgICByZXR1cm4gIldlc3RSZXNpemUiOwotICAgIGNhc2UgQ3Vyc29yOjpOb3J0 aFNvdXRoUmVzaXplOgotICAgICAgICByZXR1cm4gIk5vcnRoU291dGhSZXNpemUiOwotICAgIGNh c2UgQ3Vyc29yOjpFYXN0V2VzdFJlc2l6ZToKLSAgICAgICAgcmV0dXJuICJFYXN0V2VzdFJlc2l6 ZSI7Ci0gICAgY2FzZSBDdXJzb3I6Ok5vcnRoRWFzdFNvdXRoV2VzdFJlc2l6ZToKLSAgICAgICAg cmV0dXJuICJOb3J0aEVhc3RTb3V0aFdlc3RSZXNpemUiOwotICAgIGNhc2UgQ3Vyc29yOjpOb3J0 aFdlc3RTb3V0aEVhc3RSZXNpemU6Ci0gICAgICAgIHJldHVybiAiTm9ydGhXZXN0U291dGhFYXN0 UmVzaXplIjsKLSAgICBjYXNlIEN1cnNvcjo6Q29sdW1uUmVzaXplOgotICAgICAgICByZXR1cm4g IkNvbHVtblJlc2l6ZSI7Ci0gICAgY2FzZSBDdXJzb3I6OlJvd1Jlc2l6ZToKLSAgICAgICAgcmV0 dXJuICJSb3dSZXNpemUiOwotICAgIGNhc2UgQ3Vyc29yOjpNaWRkbGVQYW5uaW5nOgotICAgICAg ICByZXR1cm4gIk1pZGRsZVBhbm5pbmciOwotICAgIGNhc2UgQ3Vyc29yOjpFYXN0UGFubmluZzoK LSAgICAgICAgcmV0dXJuICJFYXN0UGFubmluZyI7Ci0gICAgY2FzZSBDdXJzb3I6Ok5vcnRoUGFu bmluZzoKLSAgICAgICAgcmV0dXJuICJOb3J0aFBhbm5pbmciOwotICAgIGNhc2UgQ3Vyc29yOjpO b3J0aEVhc3RQYW5uaW5nOgotICAgICAgICByZXR1cm4gIk5vcnRoRWFzdFBhbm5pbmciOwotICAg IGNhc2UgQ3Vyc29yOjpOb3J0aFdlc3RQYW5uaW5nOgotICAgICAgICByZXR1cm4gIk5vcnRoV2Vz dFBhbm5pbmciOwotICAgIGNhc2UgQ3Vyc29yOjpTb3V0aFBhbm5pbmc6Ci0gICAgICAgIHJldHVy biAiU291dGhQYW5uaW5nIjsKLSAgICBjYXNlIEN1cnNvcjo6U291dGhFYXN0UGFubmluZzoKLSAg ICAgICAgcmV0dXJuICJTb3V0aEVhc3RQYW5uaW5nIjsKLSAgICBjYXNlIEN1cnNvcjo6U291dGhX ZXN0UGFubmluZzoKLSAgICAgICAgcmV0dXJuICJTb3V0aFdlc3RQYW5uaW5nIjsKLSAgICBjYXNl IEN1cnNvcjo6V2VzdFBhbm5pbmc6Ci0gICAgICAgIHJldHVybiAiV2VzdFBhbm5pbmciOwotICAg IGNhc2UgQ3Vyc29yOjpNb3ZlOgotICAgICAgICByZXR1cm4gIk1vdmUiOwotICAgIGNhc2UgQ3Vy c29yOjpWZXJ0aWNhbFRleHQ6Ci0gICAgICAgIHJldHVybiAiVmVydGljYWxUZXh0IjsKLSAgICBj YXNlIEN1cnNvcjo6Q2VsbDoKLSAgICAgICAgcmV0dXJuICJDZWxsIjsKLSAgICBjYXNlIEN1cnNv cjo6Q29udGV4dE1lbnU6Ci0gICAgICAgIHJldHVybiAiQ29udGV4dE1lbnUiOwotICAgIGNhc2Ug Q3Vyc29yOjpBbGlhczoKLSAgICAgICAgcmV0dXJuICJBbGlhcyI7Ci0gICAgY2FzZSBDdXJzb3I6 OlByb2dyZXNzOgotICAgICAgICByZXR1cm4gIlByb2dyZXNzIjsKLSAgICBjYXNlIEN1cnNvcjo6 Tm9Ecm9wOgotICAgICAgICByZXR1cm4gIk5vRHJvcCI7Ci0gICAgY2FzZSBDdXJzb3I6OkNvcHk6 Ci0gICAgICAgIHJldHVybiAiQ29weSI7Ci0gICAgY2FzZSBDdXJzb3I6Ok5vbmU6Ci0gICAgICAg IHJldHVybiAiTm9uZSI7Ci0gICAgY2FzZSBDdXJzb3I6Ok5vdEFsbG93ZWQ6Ci0gICAgICAgIHJl dHVybiAiTm90QWxsb3dlZCI7Ci0gICAgY2FzZSBDdXJzb3I6Olpvb21JbjoKLSAgICAgICAgcmV0 dXJuICJab29tSW4iOwotICAgIGNhc2UgQ3Vyc29yOjpab29tT3V0OgotICAgICAgICByZXR1cm4g Ilpvb21PdXQiOwotICAgIGNhc2UgQ3Vyc29yOjpHcmFiOgotICAgICAgICByZXR1cm4gIkdyYWIi OwotICAgIGNhc2UgQ3Vyc29yOjpHcmFiYmluZzoKLSAgICAgICAgcmV0dXJuICJHcmFiYmluZyI7 Ci0gICAgY2FzZSBDdXJzb3I6OkN1c3RvbToKLSAgICAgICAgcmV0dXJuICJDdXN0b20iOwotICAg IH0KLQotICAgIHJldHVybiAiRVJST1IiOwotfQotCiAjaWYgVVNFKExBWllfTkFUSVZFX0NVUlNP UikKIAogQ3Vyc29yOjpDdXJzb3IoSW1hZ2UqIGltYWdlLCBjb25zdCBJbnRQb2ludCYgaG90U3Bv dCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0N1cnNvci5oIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vQ3Vyc29yLmgKaW5kZXggNDFhYWEyMzFhZGNhOTk3YzBkYjIyY2Q4 NzM1YmNlMTRlOTczNTUzMy4uMTczMzdhMDEzNGM1OGI2NjgyMzZkZjBlMTM2ODlmMzIyNDM0ZGEx ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vQ3Vyc29yLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vQ3Vyc29yLmgKQEAgLTE4Nyw3ICsxODcsNiBAQCBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAgICAgfTsKIAogICAgIEludFBvaW50IGRldGVybWluZUhvdFNwb3QoSW1h Z2UqLCBjb25zdCBJbnRQb2ludCYgc3BlY2lmaWVkSG90U3BvdCk7Ci0gICAgY29uc3QgY2hhciog bmFtZUZvckN1cnNvclR5cGUoQ3Vyc29yOjpUeXBlKTsKICAgICAKICAgICBjb25zdCBDdXJzb3Im IHBvaW50ZXJDdXJzb3IoKTsKICAgICBjb25zdCBDdXJzb3ImIGNyb3NzQ3Vyc29yKCk7Cg==