73525 2011-11-30 22:53:41 -0800 [Chromium] Use contentBounds instead of bounds for invalidation. 2011-12-01 13:32:30 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 71872 1 reveman reveman cc-bugs enne jamesr webkit.review.bot oldest_to_newest 512497 0 reveman 2011-11-30 22:53:41 -0800 Use setNeedsDisplay() instead of setNeedsDisplayRect() when possible. 512508 1 117348 reveman 2011-11-30 23:02:40 -0800 Created attachment 117348 Patch 512829 2 enne 2011-12-01 09:18:01 -0800 This looks great. This needs a ChangeLog, or you could probably just wrap this into your other invalidation-changing patch if you wanted. 512852 3 enne 2011-12-01 09:41:42 -0800 (In reply to comment #2) > This looks great. > > This needs a ChangeLog, or you could probably just wrap this into your other invalidation-changing patch if you wanted. Oh, you already landed that, whoops. :) 512871 4 117440 reveman 2011-12-01 10:09:48 -0800 Created attachment 117440 Patch 513052 5 117440 webkit.review.bot 2011-12-01 13:32:26 -0800 Comment on attachment 117440 Patch Clearing flags on attachment: 117440 Committed r101701: <http://trac.webkit.org/changeset/101701> 513053 6 webkit.review.bot 2011-12-01 13:32:30 -0800 All reviewed patches have been landed. Closing bug. 117348 2011-11-30 23:02:40 -0800 2011-12-01 10:09:43 -0800 Patch use-contents-bounds.diff text/plain 1254 reveman ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xh eWVyQ2hyb21pdW0uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vTGF5ZXJDaHJvbWl1bS5jcHAKaW5kZXggZTFkOWJlOC4uMGQ3NWZkYiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJDaHJvbWl1bS5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJD aHJvbWl1bS5jcHAKQEAgLTIxNSw3ICsyMTUsNyBAQCB2b2lkIExheWVyQ2hyb21pdW06OnNldEJv dW5kcyhjb25zdCBJbnRTaXplJiBzaXplKQogICAgIG1fYm91bmRzID0gc2l6ZTsKIAogICAgIGlm IChmaXJzdFJlc2l6ZSB8fCBtX3BhZ2VTY2FsZURpcnR5KQotICAgICAgICBzZXROZWVkc0Rpc3Bs YXlSZWN0KEZsb2F0UmVjdCgwLCAwLCBib3VuZHMoKS53aWR0aCgpLCBib3VuZHMoKS5oZWlnaHQo KSkpOworICAgICAgICBzZXROZWVkc0Rpc3BsYXkoKTsKICAgICBlbHNlCiAgICAgICAgIHNldE5l ZWRzQ29tbWl0KCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl Yk1lZGlhUGxheWVyQ2xpZW50SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJNZWRpYVBsYXllckNsaWVudEltcGwuY3BwCmluZGV4IDk4ZTE2N2IuLjdlZjYzODIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1w bC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTWVkaWFQbGF5ZXJDbGll bnRJbXBsLmNwcApAQCAtMTQ4LDcgKzE0OCw3IEBAIHZvaWQgV2ViTWVkaWFQbGF5ZXJDbGllbnRJ bXBsOjpyZXBhaW50KCkKICAgICBBU1NFUlQobV9tZWRpYVBsYXllcik7CiAjaWYgVVNFKEFDQ0VM RVJBVEVEX0NPTVBPU0lUSU5HKQogICAgIGlmIChtX3ZpZGVvTGF5ZXIgJiYgc3VwcG9ydHNBY2Nl bGVyYXRlZFJlbmRlcmluZygpKQotICAgICAgICBtX3ZpZGVvTGF5ZXItPnNldE5lZWRzRGlzcGxh eVJlY3QoSW50UmVjdCgwLCAwLCBtX3ZpZGVvTGF5ZXItPmJvdW5kcygpLndpZHRoKCksIG1fdmlk ZW9MYXllci0+Ym91bmRzKCkuaGVpZ2h0KCkpKTsKKyAgICAgICAgbV92aWRlb0xheWVyLT5zZXRO ZWVkc0Rpc3BsYXkoKTsKICNlbmRpZgogICAgIG1fbWVkaWFQbGF5ZXItPnJlcGFpbnQoKTsKIH0K 117440 2011-12-01 10:09:48 -0800 2011-12-01 13:32:26 -0800 Patch bug-73525-20111201130946.patch text/plain 3078 reveman U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxNjczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjVhMDUwY2M1ZTkzMDI0 ZDc3MTY1ZGRjY2Y1ZmFjNWM0Yzg2MWZlNC4uNDY0NzI2NTJjNzE0NjdmZTQyMDkzMjNjYWJlNTAz ZjY3M2JmMmZlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDExLTEyLTAxICBEYXZp ZCBSZXZlbWFuICA8cmV2ZW1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBV c2UgY29udGVudEJvdW5kcyBpbnN0ZWFkIG9mIGJvdW5kcyBmb3IgaW52YWxpZGF0aW9uLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM1MjUKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2Ugc2V0TmVlZHNE aXNwbGF5KCkgaW5zdGVhZCBvZiBzZXROZWVkc0Rpc3BsYXlSZWN0KCkgd2hlbiBwb3NzaWJsZS4K KworICAgICAgICBObyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9MYXllckNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheWVyQ2hyb21p dW06OnNldEJvdW5kcyk6CisKIDIwMTEtMTItMDEgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNv bkBhcHBsZS5jb20+CiAKICAgICAgICAgSFRNTFRyYWNrRWxlbWVudC5yZWFkeVN0YXRlIHNob3Vs ZCByZXR1cm4gVGV4dFRyYWNrICJyZWFkaW5lc3Mgc3RhdGUiLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5n ZUxvZwppbmRleCA2YjU0ZDZhZGY3ZGI2NGVjODJiYzc5YTVmN2U4NmU2YTQ3YzZjYjk2Li4yNGJi YmNiNjBhM2E5MGU2NzNkNGE5ODYwOThlYzgzZTMxOGFiMDk3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0No YW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTEyLTAxICBEYXZpZCBSZXZlbWFuICA8cmV2 ZW1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBVc2UgY29udGVudEJvdW5k cyBpbnN0ZWFkIG9mIGJvdW5kcyBmb3IgaW52YWxpZGF0aW9uLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM1MjUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2Ugc2V0TmVlZHNEaXNwbGF5KCkgaW5zdGVh ZCBvZiBzZXROZWVkc0Rpc3BsYXlSZWN0KCkgd2hlbiBwb3NzaWJsZS4KKworICAgICAgICAqIHNy Yy9XZWJNZWRpYVBsYXllckNsaWVudEltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJNZWRp YVBsYXllckNsaWVudEltcGw6OnJlcGFpbnQpOgorCiAyMDExLTEyLTAxICBQYXZlbCBGZWxkbWFu ICA8cGZlbGRtYW5AZ29vZ2xlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBmdXJ0aGVy IGFsaWduIGZyb250LWVuZCBjb25maWd1cmF0aW9uczogZ2V0IHJpZCBvZiBzYXZlQXNBdmFpbGFi bGUgcHJlZmVyZW5jZSwgaW5saW5lIGRyYWcgZ2xhc3MgcGFuZS4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyQ2hyb21pdW0uY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJDaHJvbWl1bS5j cHAKaW5kZXggZTFkOWJlOGU0ZWEwOTA0YTllM2Y3NDkzMmIzYjUxMDc3OWNjYTU2Ny4uMGQ3NWZk YmYxYWQ2OTAyMmJjMWJmZDlmMmRkNWU3M2ZkNmVlMDUzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJDaHJvbWl1bS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJDaHJvbWl1bS5j cHAKQEAgLTIxNSw3ICsyMTUsNyBAQCB2b2lkIExheWVyQ2hyb21pdW06OnNldEJvdW5kcyhjb25z dCBJbnRTaXplJiBzaXplKQogICAgIG1fYm91bmRzID0gc2l6ZTsKIAogICAgIGlmIChmaXJzdFJl c2l6ZSB8fCBtX3BhZ2VTY2FsZURpcnR5KQotICAgICAgICBzZXROZWVkc0Rpc3BsYXlSZWN0KEZs b2F0UmVjdCgwLCAwLCBib3VuZHMoKS53aWR0aCgpLCBib3VuZHMoKS5oZWlnaHQoKSkpOworICAg ICAgICBzZXROZWVkc0Rpc3BsYXkoKTsKICAgICBlbHNlCiAgICAgICAgIHNldE5lZWRzQ29tbWl0 KCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYk1lZGlhUGxh eWVyQ2xpZW50SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVBs YXllckNsaWVudEltcGwuY3BwCmluZGV4IDk4ZTE2N2JhMWJmZTFlMWY5ZjE2Y2E0NGFmZjRhNjY1 MDQ0YTUzMzkuLjdlZjYzODI2MzcwYjM1YTY3YWVlN2FmMDA5N2M3NTk0ZDhjM2ExYTYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1w bC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTWVkaWFQbGF5ZXJDbGll bnRJbXBsLmNwcApAQCAtMTQ4LDcgKzE0OCw3IEBAIHZvaWQgV2ViTWVkaWFQbGF5ZXJDbGllbnRJ bXBsOjpyZXBhaW50KCkKICAgICBBU1NFUlQobV9tZWRpYVBsYXllcik7CiAjaWYgVVNFKEFDQ0VM RVJBVEVEX0NPTVBPU0lUSU5HKQogICAgIGlmIChtX3ZpZGVvTGF5ZXIgJiYgc3VwcG9ydHNBY2Nl bGVyYXRlZFJlbmRlcmluZygpKQotICAgICAgICBtX3ZpZGVvTGF5ZXItPnNldE5lZWRzRGlzcGxh eVJlY3QoSW50UmVjdCgwLCAwLCBtX3ZpZGVvTGF5ZXItPmJvdW5kcygpLndpZHRoKCksIG1fdmlk ZW9MYXllci0+Ym91bmRzKCkuaGVpZ2h0KCkpKTsKKyAgICAgICAgbV92aWRlb0xheWVyLT5zZXRO ZWVkc0Rpc3BsYXkoKTsKICNlbmRpZgogICAgIG1fbWVkaWFQbGF5ZXItPnJlcGFpbnQoKTsKIH0K