73506 2011-11-30 17:19:35 -0800 Add WebLayer::setRootLayer 2011-11-30 22:54:44 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sky sky fishd piman webkit.review.bot oldest_to_newest 512276 0 sky 2011-11-30 17:19:35 -0800 There's a cycle between LayerChromium (m_layerTreeHost) and CCLayerTreeHost (m_rootLayer). We need to ability to break this cycle so the objects can be deleted. Adding a setRootLayer would allow for breaking the cycle. 512288 1 117305 sky 2011-11-30 17:42:49 -0800 Created attachment 117305 Patch 1 512290 2 webkit.review.bot 2011-11-30 17:46:19 -0800 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 512303 3 piman 2011-11-30 18:12:35 -0800 LGTM 512308 4 117305 jamesr 2011-11-30 18:21:00 -0800 Comment on attachment 117305 Patch 1 R=me 512500 5 117305 webkit.review.bot 2011-11-30 22:54:40 -0800 Comment on attachment 117305 Patch 1 Clearing flags on attachment: 117305 Committed r101613: <http://trac.webkit.org/changeset/101613> 512501 6 webkit.review.bot 2011-11-30 22:54:44 -0800 All reviewed patches have been landed. Closing bug. 117305 2011-11-30 17:42:49 -0800 2011-11-30 22:54:39 -0800 Patch 1 patch text/plain 2460 sky SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMDE1NzcpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1 IEBACisyMDExLTExLTMwICBTY290dCBWaW9sZXQgIDxza3lAZ29vZ2xlLmNvbT4KKworICAgICAg ICBbY2hyb21pdW1dIEV4cG9zZSBXZWJMYXllclRyZWVWaWV3OjpzZXRSb290TGF5ZXIgYXMgYSBj YWxsIHRocm91Z2gKKyAgICAgICAgdG8gc2FtZSBtZXRob2Qgb24gQ0NMYXllclRyZWVIb3N0Lgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM1MDYKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHB1YmxpYy9X ZWJMYXllclRyZWVWaWV3Lmg6IEFkZHMgc2V0Um9vdExheWVyLgorICAgICAgICAqIHNyYy9XZWJM YXllclRyZWVWaWV3LmNwcDogRGl0dG8uCisgICAgICAgIChXZWJLaXQ6OldlYkxheWVyVHJlZVZp ZXc6OnNldFJvb3RMYXllcik6CisKIDIwMTEtMTEtMTggIE5hdCBEdWNhICA8bmR1Y2FAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gRW5hYmxlIHRocmVhZGVkIGNvbXBvc2l0aW5n IHZpYSBDQ1RocmVhZFByb3h5OjpoYXNUaHJlYWQgb25seQpJbmRleDogU291cmNlL1dlYktpdC9j aHJvbWl1bS9wdWJsaWMvV2ViTGF5ZXJUcmVlVmlldy5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkxheWVyVHJlZVZpZXcuaAkocmV2aXNpb24gMTAxNTcy KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTGF5ZXJUcmVlVmlldy5oCSh3 b3JraW5nIGNvcHkpCkBAIC05NCw2ICs5NCwxMSBAQCBwdWJsaWM6CiAgICAgLy8gVGhlIGJ1ZmZl ciBpcyBub3QgbW9kaWZpZWQgaWYgdGhlIGZhbHNlIGlzIHJldHVybmVkLgogICAgIFdFQktJVF9F WFBPUlQgYm9vbCBjb21wb3NpdGVBbmRSZWFkYmFjayh2b2lkICpwaXhlbHMsIGNvbnN0IFdlYlJl Y3QmKTsKIAorICAgIC8vIFNldHMgdGhlIHJvb3Qgb2YgdGhlIHRyZWUuIFRoZSByb290IGlzIHNl dCBieSB3YXkgb2YgdGhlIGNvbnN0cnVjdG9yLgorICAgIC8vIFRoaXMgaXMgdHlwaWNhbGx5IHVz ZWQgdG8gZXhwbGljaXRseSBzZXQgdGhlIHJvb3QgdG8gbnVsbCB0byBicmVhaworICAgIC8vIGN5 Y2xlcy4KKyAgICBXRUJLSVRfRVhQT1JUIHZvaWQgc2V0Um9vdExheWVyKFdlYkxheWVyKik7CisK ICNpZiBXRUJLSVRfSU1QTEVNRU5UQVRJT04KICAgICBXZWJMYXllclRyZWVWaWV3KGNvbnN0IFdU Rjo6UGFzc1JlZlB0cjxXZWJDb3JlOjpDQ0xheWVyVHJlZUhvc3Q+Jik7CiAgICAgV2ViTGF5ZXJU cmVlVmlldyYgb3BlcmF0b3I9KGNvbnN0IFdURjo6UGFzc1JlZlB0cjxXZWJDb3JlOjpDQ0xheWVy VHJlZUhvc3Q+Jik7CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJMYXllclRy ZWVWaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJM YXllclRyZWVWaWV3LmNwcAkocmV2aXNpb24gMTAxNTcyKQorKysgU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViTGF5ZXJUcmVlVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI2LDYgKzI2 LDcgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJXZWJMYXllclRyZWVWaWV3Lmgi CiAKKyNpbmNsdWRlICJXZWJMYXllci5oIgogI2luY2x1ZGUgIldlYkxheWVyVHJlZVZpZXdJbXBs LmgiCiAjaW5jbHVkZSAiV2ViUmVjdC5oIgogI2luY2x1ZGUgIldlYlNpemUuaCIKQEAgLTg4LDYg Kzg5LDE0IEBAIGJvb2wgV2ViTGF5ZXJUcmVlVmlldzo6Y29tcG9zaXRlQW5kUmVhZGIKICAgICBy ZXR1cm4gbV9wcml2YXRlLT5jb21wb3NpdGVBbmRSZWFkYmFjayhwaXhlbHMsIHJlY3QpOwogfQog Cit2b2lkIFdlYkxheWVyVHJlZVZpZXc6OnNldFJvb3RMYXllcihXZWJMYXllciAqcm9vdCkKK3sK KyAgICBpZiAocm9vdCkKKyAgICAgICAgbV9wcml2YXRlLT5zZXRSb290TGF5ZXIoKnJvb3QpOwor ICAgIGVsc2UKKyAgICAgICAgbV9wcml2YXRlLT5zZXRSb290TGF5ZXIoUGFzc1JlZlB0cjxMYXll ckNocm9taXVtPigpKTsKK30KKwogV2ViTGF5ZXJUcmVlVmlldzo6V2ViTGF5ZXJUcmVlVmlldyhj b25zdCBQYXNzUmVmUHRyPENDTGF5ZXJUcmVlSG9zdD4mIG5vZGUpCiAgICAgOiBtX3ByaXZhdGUo bm9kZSkKIHsK