73491 2011-11-30 14:09:55 -0800 Enable web audio by default on non-Mac POSIX platforms 2011-12-06 14:07:21 -0800 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 chromium webkit-unassigned abarth crogers tony webkit.review.bot oldest_to_newest 512123 0 chromium 2011-11-30 14:09:55 -0800 enable web audio by default on non-Mac POSIX platforms 512131 1 chromium 2011-11-30 14:26:07 -0800 Build web audio by default on new Unix platforms, this patch has been used to build web audio on FreeBSD, Solaris, OpenBSD, and NetBSD. I tested the Drum Machine web audio demo on FreeBSD and it appears to work fine. 512135 2 117275 chromium 2011-11-30 14:29:58 -0800 Created attachment 117275 enable web audio on unix 512138 3 chromium 2011-11-30 14:34:39 -0800 Please review: Chris - OK inclusion of other UNIX platforms for web audio Adam - Confirm Android exclusion Tony - Any additional input 512143 4 tony 2011-11-30 14:41:03 -0800 Seems fine to me. 512148 5 abarth 2011-11-30 14:47:44 -0800 Excluding android is fine. 516186 6 chromium 2011-12-06 13:15:13 -0800 It looks like Chris is on vacation and won't get to this soon, but I'd like this patch to get into Chromium before the final 17.0 branch. Perhaps Tony can commit this and Chris can revert later if he disagrees? I doubt Chris will care about these other POSIX platforms since nothing changes for the main platforms with this patch, just thought I'd get his stamp since he's the web audio guy. 516193 7 117275 tony 2011-12-06 13:20:50 -0800 Comment on attachment 117275 enable web audio on unix I agree, this seems harmless. 516235 8 117275 webkit.review.bot 2011-12-06 14:07:16 -0800 Comment on attachment 117275 enable web audio on unix Clearing flags on attachment: 117275 Committed r102178: <http://trac.webkit.org/changeset/102178> 516236 9 webkit.review.bot 2011-12-06 14:07:21 -0800 All reviewed patches have been landed. Closing bug. 117275 2011-11-30 14:29:58 -0800 2011-12-06 14:07:16 -0800 enable web audio on unix webaudio.patch text/plain 2570 chromium ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzOGU3ZjkwLi4wNDIzOGNhIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMTEtMzAgIFJ1YmVuICA8Y2hyb21pdW1AaHlicmlkc291cmNlLm9yZz4KKworICAg ICAgICBFbmFibGUgd2ViIGF1ZGlvIGJ5IGRlZmF1bHQgb24gbm9uLU1hYyBQT1NJWCBwbGF0Zm9y bXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczNDkx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLCBqdXN0IGNoYW5naW5nIGd5cCBpbmNsdWRlcy4KKworICAgICAgICAqIFdlYkNvcmUu Z3lwL1dlYkNvcmUuZ3lwOgorCiAyMDExLTExLTI4ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5 QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgc3VwcG9ydCBmb3Iga25vd2luZyB3aGVuIGEgVHJl ZUVsZW1lbnQgaXMgYWRkZWQgb3IgY2hhbmdlZCBhbnl3aGVyZSBpbiBhIFRyZWVPdXRsaW5lLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAgYi9Tb3Vy Y2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAppbmRleCA1ZmUwY2UxLi4yMDYxYjlh IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cApAQCAtMTA5NSw3ICsxMDk1 LDcgQEAKICAgICAgICAgICAgICdpbmNsdWRlX2RpcnMrKysnOiBbJy4uL2RvbSddLAogICAgICAg ICAgIH0sCiAgICAgICAgIH1dLAotICAgICAgICBbJyhPUz09ImxpbnV4IiBvciBPUz09IndpbiIp IGFuZCAiV1RGX1VTRV9XRUJBVURJT19GRlRXPTEiIGluIGZlYXR1cmVfZGVmaW5lcycsIHsKKyAg ICAgICAgWydPUyAhPSAibWFjIiBhbmQgT1MgIT0gImFuZHJvaWQiIGFuZCAiV1RGX1VTRV9XRUJB VURJT19GRlRXPTEiIGluIGZlYXR1cmVfZGVmaW5lcycsIHsKICAgICAgICAgICAnaW5jbHVkZV9k aXJzJzogWwogICAgICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2RpcikvdGhpcmRfcGFydHkvZmZ0 dy9hcGknLAogICAgICAgICAgIF0sCkBAIC0xMzA4LDcgKzEzMDgsNyBAQAogICAgICAgICAgICAg J2luY2x1ZGVfZGlycysrJzogWycuLi9kb20nXSwKICAgICAgICAgICB9LAogICAgICAgICB9XSwK LSAgICAgICAgWycoT1M9PSJsaW51eCIgb3IgT1M9PSJ3aW4iKSBhbmQgIldURl9VU0VfV0VCQVVE SU9fRkZUVz0xIiBpbiBmZWF0dXJlX2RlZmluZXMnLCB7CisgICAgICAgIFsnT1MgIT0gIm1hYyIg YW5kIE9TICE9ICJhbmRyb2lkIiBhbmQgIldURl9VU0VfV0VCQVVESU9fRkZUVz0xIiBpbiBmZWF0 dXJlX2RlZmluZXMnLCB7CiAgICAgICAgICAgIyBUaGlzIGRpcmVjdG9yeSBuZWVkcyB0byBiZSBv biB0aGUgaW5jbHVkZSBwYXRoIGZvciBtdWx0aXBsZSBzdWItdGFyZ2V0cyBvZiB3ZWJjb3JlLgog ICAgICAgICAgICdkaXJlY3RfZGVwZW5kZW50X3NldHRpbmdzJzogewogICAgICAgICAgICAgJ2lu Y2x1ZGVfZGlycyc6IFsKQEAgLTEzMTYsNyArMTMxNiw3IEBACiAgICAgICAgICAgICBdLAogICAg ICAgICAgIH0sCiAgICAgICAgIH1dLAotICAgICAgICBbJyhPUz09Im1hYyIgb3IgT1M9PSJsaW51 eCIgb3IgT1M9PSJ3aW4iKSBhbmQgIldURl9VU0VfV0VCQVVESU9fRkZNUEVHPTEiIGluIGZlYXR1 cmVfZGVmaW5lcycsIHsKKyAgICAgICAgWydPUyAhPSAiYW5kcm9pZCIgYW5kICJXVEZfVVNFX1dF QkFVRElPX0ZGTVBFRz0xIiBpbiBmZWF0dXJlX2RlZmluZXMnLCB7CiAgICAgICAgICAgIyBUaGlz IGRpcmVjdG9yeSBuZWVkcyB0byBiZSBvbiB0aGUgaW5jbHVkZSBwYXRoIGZvciBtdWx0aXBsZSBz dWItdGFyZ2V0cyBvZiB3ZWJjb3JlLgogICAgICAgICAgICdkaXJlY3RfZGVwZW5kZW50X3NldHRp bmdzJzogewogICAgICAgICAgICAgJ2luY2x1ZGVfZGlycyc6IFsKQEAgLTE5MjMsNyArMTkyMyw3 IEBACiAgICAgICAgICAgICAnaW5jbHVkZV9kaXJzKysrJzogWycuLi9kb20nXSwKICAgICAgICAg ICB9LAogICAgICAgICB9XSwKLSAgICAgICAgWydPUz09ImxpbnV4IiBhbmQgIldURl9VU0VfV0VC QVVESU9fRkZUVz0xIiBpbiBmZWF0dXJlX2RlZmluZXMnLCB7CisgICAgICAgIFsnb3NfcG9zaXgg PT0gMSBhbmQgT1MgIT0gIm1hYyIgYW5kIE9TICE9ICJhbmRyb2lkIiBhbmQgIldURl9VU0VfV0VC QVVESU9fRkZUVz0xIiBpbiBmZWF0dXJlX2RlZmluZXMnLCB7CiAgICAgICAgICAgIyBGSVhNRTog KGticikgZmlndXJlIG91dCBob3cgdG8gbWFrZSB0aGVzZSBkZXBlbmRlbmNpZXMKICAgICAgICAg ICAjIHdvcmsgaW4gYSBjcm9zcy1wbGF0Zm9ybSB3YXkuIEF0dGVtcHRzIHRvIHVzZQogICAgICAg ICAgICMgImxpbmtfc2V0dGluZ3MiIGFuZCAibGlicmFyaWVzIiBpbiBjb25qdW5jdGlvbiB3aXRo IHRoZQo=