73483 2011-11-30 13:37:17 -0800 [Chromium] GYP fix for Windows 2010 build 2011-12-02 13:49:33 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth dpranke tony webkit.review.bot oldest_to_newest 512077 0 abarth 2011-11-30 13:37:17 -0800 [Chromium] GYP fix for Windows 2010 build 512078 1 117262 abarth 2011-11-30 13:38:32 -0800 Created attachment 117262 Patch 512089 2 117262 tony 2011-11-30 13:45:19 -0800 Comment on attachment 117262 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117262&action=review > Source/WebKit/chromium/ChangeLog:8 > + Patch by Carlos Pizano. It would be nice to elaborate here. Looks like there are no more files matching the Android.cpp pattern and we added a .cpp in WebKit/chromium/src/android/WebInputEventFactory.cpp. > Source/WebKit/chromium/WebKit.gyp:1428 > + ['OS!="android"', { > + 'target_defaults': { > + 'sources/': [ > + ['exclude', '(^|/)android/'] > + ], > + }, > + }], I would move this up to be specific to the webkit target like the other exclude by directory rules. E.g., there's an OS=="android" condition that you could make this an 'else' branch of around line 777. 513884 3 117645 tony 2011-12-02 10:07:35 -0800 Created attachment 117645 Patch 514089 4 tony 2011-12-02 13:49:25 -0800 Committed r101846: <http://trac.webkit.org/changeset/101846> 117262 2011-11-30 13:38:32 -0800 2011-12-02 10:07:33 -0800 Patch bug-73483-20111130133831.patch text/plain 1554 abarth SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMDE1NDgpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0 IEBACisyMDExLTExLTMwICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW0Nocm9taXVtXSBHWVAgZml4IGZvciBXaW5kb3dzIDIwMTAgYnVpbGQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczNDgzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGF0Y2ggYnkgQ2FybG9zIFBpemFu by4KKworICAgICAgICAqIFdlYktpdC5neXA6CisKIDIwMTEtMTEtMzAgIFBhdmVsIEZlbGRtYW4g IDxwZmVsZG1hbkBnb29nbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGdldCByaWQg b2YgZGVmZXJyZWQgYmFja2VuZC0+ZnJvbnQtZW5kIGNvbW1hbmRzIHByb2Nlc3NpbmcuCkluZGV4 OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwCShyZXZpc2lvbiAxMDE1NDQpCisrKyBTb3VyY2Uv V2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAJKHdvcmtpbmcgY29weSkKQEAgLTEyMzIsOSArMTIz Miw2IEBACiAgICAgICAgICAgICAgICAgICAgICAgICAnSW1hZ2VEaWZmI2hvc3QnLAogICAgICAg ICAgICAgICAgICAgICBdLAogICAgICAgICAgICAgICAgIH0seyAjIE9TIT0iYW5kcm9pZCIKLSAg ICAgICAgICAgICAgICAgICAgJ3NvdXJjZXMvJzogWwotICAgICAgICAgICAgICAgICAgICAgICAg WydleGNsdWRlJywgJyhBbmRyb2lkKVxcLmNwcCQnXQotICAgICAgICAgICAgICAgICAgICBdLAog ICAgICAgICAgICAgICAgICAgICAnZGVwZW5kZW5jaWVzJzogWwogICAgICAgICAgICAgICAgICAg ICAgICAgJ0ltYWdlRGlmZicsCiAgICAgICAgICAgICAgICAgICAgICAgICAnY29weV9UZXN0TmV0 c2NhcGVQbHVnSW4nLApAQCAtMTQyMiw2ICsxNDE5LDEzIEBACiAgICAgICAgICAgICAgICAgfSwK ICAgICAgICAgICAgIF0sCiAgICAgICAgIH1dLAorICAgICAgICBbJ09TIT0iYW5kcm9pZCInLCB7 CisgICAgICAgICAgICAndGFyZ2V0X2RlZmF1bHRzJzogeworICAgICAgICAgICAgICAgICdzb3Vy Y2VzLyc6IFsKKyAgICAgICAgICAgICAgICAgICAgWydleGNsdWRlJywgJyhefC8pYW5kcm9pZC8n XQorICAgICAgICAgICAgICAgIF0sCisgICAgICAgICAgICB9LAorICAgICAgICB9XSwKICAgICAg ICAgWydkZWJ1Z19kZXZ0b29scz09MCcsIHsKICAgICAgICAgICAgICd0YXJnZXRzJzogWwogICAg ICAgICAgICAgICAgIHsK 117645 2011-12-02 10:07:35 -0800 2011-12-02 13:49:33 -0800 Patch bug-73483-20111202100742.patch text/plain 1754 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxODE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDA4Yjg3ZDhkMWY5MjdiMGI5ZDMyYmYzNzc2N2Q2OTBiNjg3M2NlOTIuLjAyNjY5MTJmNzAyYzdl OTY1NTExZDBiODM4MjU2ZGNhMzQ1OTY3ZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTEtMTItMDIgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9y Zz4KKworICAgICAgICBbQ2hyb21pdW1dIEdZUCBmaXggZm9yIFdpbmRvd3MgMjAxMCBidWlsZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM0ODMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQYXRjaCBieSBD YXJsb3MgUGl6YW5vLgorCisgICAgICAgICogV2ViS2l0Lmd5cDogRXhjbHVkZSB0aGUgYW5kcm9p ZCBkaXJlY3RvcnkgYW5kIHJlbW92ZSBhIGZpbGUgbWF0Y2ggdGhhdCBkb2Vzbid0IG1hdGNoIGFu eXRoaW5nLgorCiAyMDExLTEyLTAyICBTYW1pIEt5b3N0aWxhICA8c2t5b3N0aWxAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gTWFrZSBDQ0lucHV0SGFuZGxlciBzY3JvbGxpbmcg c3RhdGVmdWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cCBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cAppbmRleCBmOTk1MTJjNjVlNmU1NTMy NTA2NDQ3ODgxNDA5YmNmYTRkNGMzYmQ3Li4yMWU2OTU2YjUxMjRhZGE2YzUzMDU5YzljYTAzYjA3 NWE4MzkzOTQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwCkBAIC03ODEsNiArNzgxLDEw IEBACiAgICAgICAgICAgICAgICAgICAgICdpbmNsdWRlX2RpcnMnOiBbCiAgICAgICAgICAgICAg ICAgICAgICAgICAncHVibGljL2FuZHJvaWQnLAogICAgICAgICAgICAgICAgICAgICBdLAorICAg ICAgICAgICAgICAgIH0sIHsgIyBlbHNlOiBPUyE9ImFuZHJvaWQiCisgICAgICAgICAgICAgICAg ICAgICdzb3VyY2VzLyc6IFsKKyAgICAgICAgICAgICAgICAgICAgICAgIFsnZXhjbHVkZScsICcv YW5kcm9pZC8nXSwKKyAgICAgICAgICAgICAgICAgICAgXSwKICAgICAgICAgICAgICAgICB9XSwK ICAgICAgICAgICAgICAgICBbJ09TPT0ibWFjIicsIHsKICAgICAgICAgICAgICAgICAgICAgJ2lu Y2x1ZGVfZGlycyc6IFsKQEAgLTEyMzksOSArMTI0Myw2IEBACiAgICAgICAgICAgICAgICAgICAg ICAgICAnSW1hZ2VEaWZmI2hvc3QnLAogICAgICAgICAgICAgICAgICAgICBdLAogICAgICAgICAg ICAgICAgIH0seyAjIE9TIT0iYW5kcm9pZCIKLSAgICAgICAgICAgICAgICAgICAgJ3NvdXJjZXMv JzogWwotICAgICAgICAgICAgICAgICAgICAgICAgWydleGNsdWRlJywgJyhBbmRyb2lkKVxcLmNw cCQnXQotICAgICAgICAgICAgICAgICAgICBdLAogICAgICAgICAgICAgICAgICAgICAnZGVwZW5k ZW5jaWVzJzogWwogICAgICAgICAgICAgICAgICAgICAgICAgJ0ltYWdlRGlmZicsCiAgICAgICAg ICAgICAgICAgICAgICAgICAnY29weV9UZXN0TmV0c2NhcGVQbHVnSW4nLAo=