73480 2011-11-30 12:40:05 -0800 [MutationObservers] Need layout tests asserting that non-event async callbacks deliver mutations after completion 2011-11-30 21:42:49 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68729 1 rafaelw rafaelw adamk ojan rniwa sam webkit.review.bot oldest_to_newest 512023 0 rafaelw 2011-11-30 12:40:05 -0800 I'm not sure how to test non-event sync callbacks (e.g. for namespace resolution or node filtering), but we should add layout tests for Database, Filesystem at least. 512035 1 rniwa 2011-11-30 12:51:11 -0800 Do you mean sync or async? 512047 2 rafaelw 2011-11-30 13:01:28 -0800 I meant what I said and I said what I meant.... You know the rest =-). 512054 3 117259 rafaelw 2011-11-30 13:06:11 -0800 Created attachment 117259 Patch 512174 4 rniwa 2011-11-30 15:18:14 -0800 (In reply to comment #1) > Do you mean sync or async? The bug summary says non-event async callbacks but you seem to be talking about sync callbacks. 512175 5 rniwa 2011-11-30 15:21:55 -0800 Ah, I now I understand what you're saying. 512446 6 117259 webkit.review.bot 2011-11-30 21:42:44 -0800 Comment on attachment 117259 Patch Clearing flags on attachment: 117259 Committed r101605: <http://trac.webkit.org/changeset/101605> 512447 7 webkit.review.bot 2011-11-30 21:42:49 -0800 All reviewed patches have been landed. Closing bug. 117259 2011-11-30 13:06:11 -0800 2011-11-30 21:42:44 -0800 Patch bug-73480-20111130130610.patch text/plain 5325 rafaelw U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxNTM0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjQ3OWUwNGRhNDhiYjBjZDMwZTNj YTBmOGZmY2MwZGI3YTE0OTVhNC4uMTZkY2FkNGYzNzUwYTliZDIxNTdkNjZjMmZlZGVlZmVkNTc4 NjkzZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTExLTMwICBSYWZhZWwgV2VpbnN0ZWlu ICA8cmFmYWVsd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW011dGF0aW9uT2JzZXJ2ZXJzXSBO ZWVkIGxheW91dCB0ZXN0cyBhc3NlcnRpbmcgdGhhdCBub24tZXZlbnQgYXN5bmMgY2FsbGJhY2tz IGRlbGl2ZXIgbXV0YXRpb25zIGFmdGVyIGNvbXBsZXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczNDgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L211dGF0aW9uL25vbi1ldmVudC1kZWxp dmVyeS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvbXV0YXRpb24vbm9uLWV2 ZW50LWRlbGl2ZXJ5Lmh0bWw6IEFkZGVkLgorCiAyMDExLTExLTMwICBQaGlsaXBwZSBOb3JtYW5k ICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBza2lwIHRoZSBH VEsgdGVzdHMgZmFpbGluZyBzaW5jZSB0aGUgZm9udCBtZXRyaWNzIGNoYW5nZS4KZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3QvbXV0YXRpb24vbm9uLWV2ZW50LWRlbGl2ZXJ5LWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvbXV0YXRpb24vbm9uLWV2ZW50LWRlbGl2ZXJ5LWV4cGVj dGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi41NDk3NjRlZGQwMDY2NjM4N2NiZWFhNTc4YTkzYzkwYzFjZmFh NTI2Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9tdXRhdGlvbi9ub24tZXZl bnQtZGVsaXZlcnktZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMjIgQEAKK1Rlc3QgdGhhdCBNdXRh dGlvbiBSZWNvcmRzIGFyZSBkZWxpdmVyZWQgZm9sbG93aW5nIG5vbi1ldmVudCBhc3luYyBjYWxs YmFja3MuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVz c2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitUZXN0aW5nIG11dGF0aW9u cyBhcmUgZGVsaXZlcmVkIGZvbGxvd2luZyBEYXRhYmFzZSB0cmFuc2FjdGlvbiBjYWxsYmFja3Mu CitQQVNTIG11dGF0aW9ucy5sZW5ndGggaXMgMQorUEFTUyBtdXRhdGlvbnNbMF0udHlwZSBpcyAi YXR0cmlidXRlcyIKK1BBU1MgbXV0YXRpb25zWzBdLmF0dHJpYnV0ZU5hbWUgaXMgImZvbyIKKwor VGVzdGluZyBtdXRhdGlvbnMgYXJlIGRlbGl2ZXJlZCBmb2xsb3dpbmcgRmlsZXN5c3RlbSBjYWxs YmFja3MuCitQQVNTIG11dGF0aW9ucy5sZW5ndGggaXMgMQorUEFTUyBtdXRhdGlvbnNbMF0udHlw ZSBpcyAiYXR0cmlidXRlcyIKK1BBU1MgbXV0YXRpb25zWzBdLmF0dHJpYnV0ZU5hbWUgaXMgImZv byIKK1BBU1MgbXV0YXRpb25zLmxlbmd0aCBpcyAxCitQQVNTIG11dGF0aW9uc1swXS50eXBlIGlz ICJhdHRyaWJ1dGVzIgorUEFTUyBtdXRhdGlvbnNbMF0uYXR0cmlidXRlTmFtZSBpcyAiYmF6Igor CitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9tdXRhdGlvbi9ub24tZXZlbnQtZGVsaXZlcnkuaHRt bCBiL0xheW91dFRlc3RzL2Zhc3QvbXV0YXRpb24vbm9uLWV2ZW50LWRlbGl2ZXJ5Lmh0bWwKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uNDE3MGQwMmQ0NDc2MzVkNTYwN2IxMWU3ZDM1YTgwMTA4NWNjZDI4ZAotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvbXV0YXRpb24vbm9uLWV2ZW50LWRlbGl2ZXJ5 Lmh0bWwKQEAgLTAsMCArMSwxMjcgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4K KzxtZXRhIGNoYXJzZXQ9InV0Zi04Ij4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMt dGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cCBpZD1kZXNjcmlwdGlv bj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQ+CisKK3dpbmRvdy5qc1Rl c3RJc0FzeW5jID0gdHJ1ZTsKK3ZhciBtdXRhdGlvbnM7CisKK2Z1bmN0aW9uIHRlc3REYXRhYmFz ZSgpIHsKKyAgICB2YXIgZGl2OworICAgIHZhciBkYjsKKyAgICB2YXIgb2JzZXJ2ZXI7CisKKyAg ICBmdW5jdGlvbiBzdGFydCgpIHsKKyAgICAgICAgZGVidWcoJ1Rlc3RpbmcgbXV0YXRpb25zIGFy ZSBkZWxpdmVyZWQgZm9sbG93aW5nIERhdGFiYXNlIHRyYW5zYWN0aW9uIGNhbGxiYWNrcy4nKTsK KworICAgICAgICBtdXRhdGlvbnMgPSBudWxsOworICAgICAgICBkaXYgPSBkb2N1bWVudC5jcmVh dGVFbGVtZW50KCdkaXYnKTsKKyAgICAgICAgb2JzZXJ2ZXIgPSBuZXcgV2ViS2l0TXV0YXRpb25P YnNlcnZlcihmdW5jdGlvbihtKSB7CisgICAgICAgICAgICBtdXRhdGlvbnMgPSBtOworICAgICAg ICB9KTsKKworICAgICAgICBvYnNlcnZlci5vYnNlcnZlKGRpdiwgeyBhdHRyaWJ1dGVzOiB0cnVl LCBjaGFyYWN0ZXJEYXRhOiB0cnVlIH0pOworCisgICAgICAgIGRiID0gb3BlbkRhdGFiYXNlKCdE YXRhYmFzZU11dGF0aW9uRGVsaXZlcnknLCAnMS4wJywgJycsIDEpOworICAgICAgICBkYi50cmFu c2FjdGlvbihtdXRhdGUpOworICAgIH0KKworICAgIGZ1bmN0aW9uIG11dGF0ZSgpIHsKKyAgICAg ICAgZGl2LnNldEF0dHJpYnV0ZSgnZm9vJywgJ2JhcicpOworICAgICAgICBzZXRUaW1lb3V0KGZp bmlzaCwgMCk7CisgICAgfQorCisgICAgZnVuY3Rpb24gZmluaXNoKCkgeworICAgICAgICBzaG91 bGRCZSgnbXV0YXRpb25zLmxlbmd0aCcsICcxJyk7CisgICAgICAgIHNob3VsZEJlKCdtdXRhdGlv bnNbMF0udHlwZScsICciYXR0cmlidXRlcyInKTsKKyAgICAgICAgc2hvdWxkQmUoJ211dGF0aW9u c1swXS5hdHRyaWJ1dGVOYW1lJywgJyJmb28iJyk7CisgICAgICAgIG9ic2VydmVyLmRpc2Nvbm5l Y3QoKTsKKyAgICAgICAgZGVidWcoJycpOworICAgICAgICBydW5OZXh0VGVzdCgpOworICAgIH0K KworICAgIHN0YXJ0KCk7Cit9CisKK2Z1bmN0aW9uIHRlc3RGaWxlc3lzdGVtKCkgeworICAgIHZh ciBkaXY7CisgICAgdmFyIGZpbGVFbnRyeTsKKyAgICB2YXIgb2JzZXJ2ZXI7CisKKyAgICBmdW5j dGlvbiBzdGFydCgpIHsKKyAgICAgICAgZGVidWcoJ1Rlc3RpbmcgbXV0YXRpb25zIGFyZSBkZWxp dmVyZWQgZm9sbG93aW5nIEZpbGVzeXN0ZW0gY2FsbGJhY2tzLicpOworCisgICAgICAgIG11dGF0 aW9ucyA9IG51bGw7CisgICAgICAgIGRpdiA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2Rpdicp OworICAgICAgICBvYnNlcnZlciA9IG5ldyBXZWJLaXRNdXRhdGlvbk9ic2VydmVyKGZ1bmN0aW9u KG0pIHsKKyAgICAgICAgICAgIG11dGF0aW9ucyA9IG07CisgICAgICAgIH0pOworCisgICAgICAg IG9ic2VydmVyLm9ic2VydmUoZGl2LCB7IGF0dHJpYnV0ZXM6IHRydWUsIGNoYXJhY3RlckRhdGE6 IHRydWUgfSk7CisKKyAgICAgICAgd2Via2l0UmVxdWVzdEZpbGVTeXN0ZW0oVEVNUE9SQVJZLCA1 KjEwMjQqMTAyNCwgZnVuY3Rpb24oZnMpIHsKKyAgICAgICAgICAgIGZzLnJvb3QuZ2V0RmlsZSgn Zm9vLnR4dCcsIHtjcmVhdGU6IHRydWUsIGV4Y2x1c2U6IHRydWV9LCBmdW5jdGlvbihlbnRyeSkg eworICAgICAgICAgICAgICAgIGZpbGVFbnRyeSA9IGVudHJ5OworICAgICAgICAgICAgICAgIGZp bGVFbnRyeS5nZXRQYXJlbnQobXV0YXRlQWZ0ZXJHZXRQYXJlbnQpOworICAgICAgICAgICAgfSk7 CisgICAgICAgIH0pOworICAgIH0KKworICAgIGZ1bmN0aW9uIG11dGF0ZUFmdGVyR2V0UGFyZW50 KCkgeworICAgICAgICBkaXYuc2V0QXR0cmlidXRlKCdmb28nLCAnYmFyJyk7CisgICAgICAgIGZp bGVFbnRyeS5yZW1vdmUobXV0YXRlQWZ0ZXJSZW1vdmUpOworICAgIH0KKworICAgIGZ1bmN0aW9u IG11dGF0ZUFmdGVyUmVtb3ZlKCkgeworICAgICAgICBzaG91bGRCZSgnbXV0YXRpb25zLmxlbmd0 aCcsICcxJyk7CisgICAgICAgIHNob3VsZEJlKCdtdXRhdGlvbnNbMF0udHlwZScsICciYXR0cmli dXRlcyInKTsKKyAgICAgICAgc2hvdWxkQmUoJ211dGF0aW9uc1swXS5hdHRyaWJ1dGVOYW1lJywg JyJmb28iJyk7CisKKyAgICAgICAgbXV0YXRpb25zID0gbnVsbDsKKyAgICAgICAgZGl2LnNldEF0 dHJpYnV0ZSgnYmF6JywgJ2JhdCcpOworICAgICAgICBzZXRUaW1lb3V0KGZpbmlzaCwgMCk7Cisg ICAgfQorCisgICAgZnVuY3Rpb24gZmluaXNoKCkgeworICAgICAgICBzaG91bGRCZSgnbXV0YXRp b25zLmxlbmd0aCcsICcxJyk7CisgICAgICAgIHNob3VsZEJlKCdtdXRhdGlvbnNbMF0udHlwZScs ICciYXR0cmlidXRlcyInKTsKKyAgICAgICAgc2hvdWxkQmUoJ211dGF0aW9uc1swXS5hdHRyaWJ1 dGVOYW1lJywgJyJiYXoiJyk7CisKKyAgICAgICAgb2JzZXJ2ZXIuZGlzY29ubmVjdCgpOworICAg ICAgICBkZWJ1ZygnJyk7CisgICAgICAgIHJ1bk5leHRUZXN0KCk7CisgICAgfQorCisgICAgc3Rh cnQoKTsKK30KKwordmFyIHRlc3RzID0gWworICAgIHRlc3REYXRhYmFzZSwKKyAgICB0ZXN0Rmls ZXN5c3RlbQorXTsKK3ZhciB0ZXN0SW5kZXggPSAwOworCitmdW5jdGlvbiBydW5OZXh0VGVzdCgp IHsKKyAgICBpZiAodGVzdEluZGV4IDwgdGVzdHMubGVuZ3RoKQorICAgICAgICB0ZXN0c1t0ZXN0 SW5kZXgrK10oKTsKKyAgICBlbHNlCisgICAgICAgIGZpbmlzaEpTVGVzdCgpOworfQorCitkZXNj cmlwdGlvbignVGVzdCB0aGF0IE11dGF0aW9uIFJlY29yZHMgYXJlIGRlbGl2ZXJlZCBmb2xsb3dp bmcgbm9uLWV2ZW50IGFzeW5jIGNhbGxiYWNrcy4nKTsKKworaWYgKCF3aW5kb3cuV2ViS2l0TXV0 YXRpb25PYnNlcnZlcikKKyAgICB0ZXN0RmFpbGVkKCdUaGlzIHRlc3QgcmVxdWlyZXMgRU5BQkxF KE1VVEFUSU9OX09CU0VSVkVSUyknKTsKK2Vsc2UKKyAgICBydW5OZXh0VGVzdCgpOworCis8L3Nj cmlwdD4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3Nj cmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K