73472 2011-11-30 11:01:54 -0800 [MutationObservers] Make WebKitMutationObserver::deliverAllMutations() tolerant of re-entrant calls 2011-11-30 21:00:20 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68729 1 rafaelw rafaelw adamk ojan rniwa sam webkit.review.bot oldest_to_newest 511901 0 rafaelw 2011-11-30 11:01:54 -0800 In effect, deliverAllMutations() needs to prevent each delivery from, itself, causing deliverAllMutations(). The code happens to be structured right now in such a way that it's behavior is still semantically correct, but we should avoid having multiple calls on this static on the stack. 511907 1 117228 rafaelw 2011-11-30 11:06:27 -0800 Created attachment 117228 Patch 511915 2 117228 ojan 2011-11-30 11:10:15 -0800 Comment on attachment 117228 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117228&action=review > Source/WebCore/dom/WebKitMutationObserver.cpp:139 > + return; Should we have an ASSERT_NOT_REACHED() before the return here? It's a bug in the C++ code if we ever hit this, right? 511931 3 rafaelw 2011-11-30 11:19:35 -0800 No. We probably will reach it. deliveryAllMutations is likely going to invoke script for each observer. The easiest thing is for each embedder to simply hook ALL outer-most script invocations. This guard just means that for each delivery, the embedder will *try* and quietly fail to re-start delivery (which is already underway). 512409 4 117228 webkit.review.bot 2011-11-30 21:00:16 -0800 Comment on attachment 117228 Patch Clearing flags on attachment: 117228 Committed r101597: <http://trac.webkit.org/changeset/101597> 512410 5 webkit.review.bot 2011-11-30 21:00:20 -0800 All reviewed patches have been landed. Closing bug. 117228 2011-11-30 11:06:27 -0800 2011-11-30 21:00:16 -0800 Patch bug-73472-20111130110626.patch text/plain 1817 rafaelw U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxNTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzJhNzEzNDI4NDAyYWY1 ZjA3OTY0MWM3ZjgzZGYyYzAxNWFlZGFhMS4uNzE3MTBhN2NlMTRhYjQ1MzZmMzk4MDVjMTdmNTI4 MGRjNzM2NDJlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTExLTMwICBSYWZh ZWwgV2VpbnN0ZWluICA8cmFmYWVsd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW011dGF0aW9u T2JzZXJ2ZXJzXSBNYWtlIFdlYktpdE11dGF0aW9uT2JzZXJ2ZXI6OmRlbGl2ZXJBbGxNdXRhdGlv bnMoKSB0b2xlcmFudCBvZiByZS1lbnRyYW50IGNhbGxzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzQ3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhpcyBwYXRjaCBqdXN0IGFk ZHMgYSBzdGF0aWMgZ3VhcmQgd2hpY2ggbWFrZXMgbW9yZSBleHBsaWNpdCB0aGUgY3VycmVudCBz ZW1hbnRpY3MuCisKKyAgICAgICAgKiBkb20vV2ViS2l0TXV0YXRpb25PYnNlcnZlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpXZWJLaXRNdXRhdGlvbk9ic2VydmVyOjpkZWxpdmVyQWxsTXV0YXRp b25zKToKKwogMjAxMS0xMS0zMCAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJlbW92ZSBkZWFkIGZsZXhpYmxlIGJveCBjb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9kb20vV2ViS2l0TXV0YXRpb25PYnNlcnZlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9k b20vV2ViS2l0TXV0YXRpb25PYnNlcnZlci5jcHAKaW5kZXggNGU5ZTExYmYyYzRkNzYwODA5ZTY5 ZTg1YWI1OTgwYjdlZjU3MzgyOC4uYzhiYWYxMDMxMDQzMjQyNGY5YWNjMTI0YjMzMjYyYjFlNzA3 YjNlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1dlYktpdE11dGF0aW9uT2JzZXJ2 ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9XZWJLaXRNdXRhdGlvbk9ic2VydmVyLmNw cApAQCAtMTM0LDEyICsxMzQsMTkgQEAgdm9pZCBXZWJLaXRNdXRhdGlvbk9ic2VydmVyOjpkZWxp dmVyKCkKIAogdm9pZCBXZWJLaXRNdXRhdGlvbk9ic2VydmVyOjpkZWxpdmVyQWxsTXV0YXRpb25z KCkKIHsKKyAgICBzdGF0aWMgYm9vbCBkZWxpdmVyeUluUHJvZ3Jlc3MgPSBmYWxzZTsKKyAgICBp ZiAoZGVsaXZlcnlJblByb2dyZXNzKQorICAgICAgICByZXR1cm47CisgICAgZGVsaXZlcnlJblBy b2dyZXNzID0gdHJ1ZTsKKwogICAgIHdoaWxlICghYWN0aXZlTXV0YXRpb25PYnNlcnZlcnMoKS5p c0VtcHR5KCkpIHsKICAgICAgICAgTXV0YXRpb25PYnNlcnZlclNldDo6aXRlcmF0b3IgaXRlciA9 IGFjdGl2ZU11dGF0aW9uT2JzZXJ2ZXJzKCkuYmVnaW4oKTsKICAgICAgICAgUmVmUHRyPFdlYktp dE11dGF0aW9uT2JzZXJ2ZXI+IG9ic2VydmVyID0gKml0ZXI7CiAgICAgICAgIGFjdGl2ZU11dGF0 aW9uT2JzZXJ2ZXJzKCkucmVtb3ZlKGl0ZXIpOwogICAgICAgICBvYnNlcnZlci0+ZGVsaXZlcigp OwogICAgIH0KKworICAgIGRlbGl2ZXJ5SW5Qcm9ncmVzcyA9IGZhbHNlOwogfQogCiBQYXNzT3du UHRyPE11dGF0aW9uT2JzZXJ2ZXJJbnRlcmVzdEdyb3VwPiBNdXRhdGlvbk9ic2VydmVySW50ZXJl c3RHcm91cDo6Y3JlYXRlRm9yQ2hpbGRMaXN0TXV0YXRpb24oTm9kZSogdGFyZ2V0KQo=