73469 2011-11-30 10:57:06 -0800 OutputCapture can't be used to capture DEBUG messages 2011-11-30 11:13:07 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 71160 1 aroben aroben abarth eric ojan webkit.review.bot oldest_to_newest 511890 0 aroben 2011-11-30 10:57:06 -0800 OutputCapture can't be used to capture DEBUG messages 511891 1 117222 aroben 2011-11-30 10:57:37 -0800 Created attachment 117222 Patch 511903 2 117222 eric 2011-11-30 11:02:31 -0800 Comment on attachment 117222 Patch LGTM. 511920 3 aroben 2011-11-30 11:13:07 -0800 Committed r101533: <http://trac.webkit.org/changeset/101533> 117222 2011-11-30 10:57:37 -0800 2011-11-30 11:02:30 -0800 Patch bug-73469-20111130135735.patch text/plain 5863 aroben U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxNTIxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWMwNWU1NzczZTUzN2IxMWUxZjRlMTRiZGI2MThlYjE0 Zjc1YzExMi4uNWMxYmU4NTYyYzEwZDc0MDY0ODZjYjY1NmU4YTlhMjY0ZjBiODg4MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5 IEBACisyMDExLTExLTMwICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KKworICAgICAg ICBBZGQgYSB3YXkgdG8gc2V0IE91dHB1dENhcHR1cmUncyBsb2cgbGV2ZWwKKworICAgICAgICBU aGlzIHdpbGwgYmUgdXNlZCBieSBzb21lIHVuaXQgdGVzdHMgSSdtIHBsYW5uaW5nIHRvIGFkZC4K KworICAgICAgICBGaXhlcyA8aHR0cDovL3dlYmtpdC5vcmcvYi83MzQ2OT4gT3V0cHV0Q2FwdHVy ZSBjYW4ndCBiZSB1c2VkIHRvIGNhcHR1cmUgREVCVUcgbWVzc2FnZXMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29t bW9uL3N5c3RlbS9vdXRwdXRjYXB0dXJlLnB5OgorICAgICAgICAoT3V0cHV0Q2FwdHVyZS5fX2lu aXRfXyk6IEluaXRpYWxpemUgb3VyIGludGVybmFsIGxvZ2dpbmcgbGV2ZWwgdG8gSU5GTywgd2hp Y2ggd2FzIHRoZSBvbmx5CisgICAgICAgIGxldmVsIHdlIGV2ZXIgdXNlZCBiZWZvcmUgdGhpcyBw YXRjaC4KKyAgICAgICAgKE91dHB1dENhcHR1cmUuc2V0X2xvZ19sZXZlbCk6IEFkZGVkLiBUaGlz IGlzIHVzZWZ1bCBmb3IgdGVzdGluZyB3aGF0IGxvZyBsZXZlbCBjb2RlIHRoYXQgaXMKKyAgICAg ICAgYmVpbmcgdGVzdGVkIHVzZXMuIFNldHMgdGhlIGxvZyBsZXZlbCBmb3IgYW55IGN1cnJlbnQg b3IgZnV0dXJlIGxvZ2dpbmcgaGFuZGxlcnMuCisgICAgICAgIChPdXRwdXRDYXB0dXJlLmNhcHR1 cmVfb3V0cHV0KTogVXNlIG91ciBpbnRlcm5hbCBsb2dnaW5nIGxldmVsIGluc3RlYWQgb2YgYWx3 YXlzIHVzaW5nIElORk8uCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0 ZW0vb3V0cHV0Y2FwdHVyZV91bml0dGVzdC5weTogQWRkZWQuCisgICAgICAgIChPdXRwdXRDYXB0 dXJlVGVzdC5zZXRVcCk6IENyZWF0ZSBhbiBPdXRwdXRDYXB0dXJlIHRvIHRlc3QuCisgICAgICAg IChPdXRwdXRDYXB0dXJlVGVzdC5sb2dfYWxsX2xldmVscyk6IEhlbHBlciBtZXRob2QgdG8gbG9n IGEgbWVzc2FnZSBhdCBlYWNoIGxvZyBsZXZlbC4KKyAgICAgICAgKE91dHB1dENhcHR1cmVUZXN0 LmFzc2VydExvZ2dlZCk6IEhlbHBlciBtZXRob2QgdG8gYXNzZXJ0IHRoYXQgYSBwYXJ0aWN1bGFy IHNldCBvZiBzdHJpbmdzCisgICAgICAgIHdhcyBsb2dnZWQuCisgICAgICAgIChPdXRwdXRDYXB0 dXJlVGVzdC50ZXN0X2luaXRpYWxfbG9nX2xldmVsKTogVGVzdCB0aGF0IHdlIHN0YXJ0IG91dCBh dCB0aGUgSU5GTyBsZXZlbC4KKyAgICAgICAgKE91dHB1dENhcHR1cmVUZXN0LnRlc3Rfc2V0X2xv Z19sZXZlbCk6IFRlc3QgdGhhdCBzZXRfbG9nX2xldmVsIGNvcnJlY3RseSBtb2RpZmllcyB0aGUg bG9nCisgICAgICAgIGxldmVsLgorCiAyMDExLTExLTMwICBTaW1vbiBIYXVzbWFubiAgPHNpbW9u LmhhdXNtYW5uQG5va2lhLmNvbT4KIAogICAgICAgICBbUXRdIFJlbW92ZSBkZXBlbmRlbmN5IG9m IFF0IERSVCBvbiBKYXZhU2NyaXB0Q29yZS4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL3N5c3RlbS9vdXRwdXRjYXB0dXJlLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vc3lzdGVtL291dHB1dGNhcHR1cmUucHkKaW5kZXggN2ZiYzg1YzQ5NTViNjQz N2FmNzFmNDlkZDA0YTJjNGUxZGI0ZjU4Yi4uY2I2ZWRiZWM3NzlkOWFmYjc2YzhjOGM3MjU3Yzli YzY4NzQxNzNhMiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lz dGVtL291dHB1dGNhcHR1cmUucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24v c3lzdGVtL291dHB1dGNhcHR1cmUucHkKQEAgLTM3LDYgKzM3LDEyIEBAIGZyb20gU3RyaW5nSU8g aW1wb3J0IFN0cmluZ0lPCiBjbGFzcyBPdXRwdXRDYXB0dXJlKG9iamVjdCk6CiAgICAgZGVmIF9f aW5pdF9fKHNlbGYpOgogICAgICAgICBzZWxmLnNhdmVkX291dHB1dHMgPSBkaWN0KCkKKyAgICAg ICAgc2VsZi5fbG9nX2xldmVsID0gbG9nZ2luZy5JTkZPCisKKyAgICBkZWYgc2V0X2xvZ19sZXZl bChzZWxmLCBsb2dfbGV2ZWwpOgorICAgICAgICBzZWxmLl9sb2dfbGV2ZWwgPSBsb2dfbGV2ZWwK KyAgICAgICAgaWYgaGFzYXR0cihzZWxmLCAnX2xvZ3NfaGFuZGxlcicpOgorICAgICAgICAgICAg c2VsZi5fbG9nc19oYW5kbGVyLnNldExldmVsKHNlbGYuX2xvZ19sZXZlbCkKIAogICAgIGRlZiBf Y2FwdHVyZV9vdXRwdXRfd2l0aF9uYW1lKHNlbGYsIG91dHB1dF9uYW1lKToKICAgICAgICAgc2Vs Zi5zYXZlZF9vdXRwdXRzW291dHB1dF9uYW1lXSA9IGdldGF0dHIoc3lzLCBvdXRwdXRfbmFtZSkK QEAgLTUzLDcgKzU5LDcgQEAgY2xhc3MgT3V0cHV0Q2FwdHVyZShvYmplY3QpOgogICAgIGRlZiBj YXB0dXJlX291dHB1dChzZWxmKToKICAgICAgICAgc2VsZi5fbG9ncyA9IFN0cmluZ0lPKCkKICAg ICAgICAgc2VsZi5fbG9nc19oYW5kbGVyID0gbG9nZ2luZy5TdHJlYW1IYW5kbGVyKHNlbGYuX2xv Z3MpCi0gICAgICAgIHNlbGYuX2xvZ3NfaGFuZGxlci5zZXRMZXZlbChsb2dnaW5nLklORk8pCisg ICAgICAgIHNlbGYuX2xvZ3NfaGFuZGxlci5zZXRMZXZlbChzZWxmLl9sb2dfbGV2ZWwpCiAgICAg ICAgIGxvZ2dpbmcuZ2V0TG9nZ2VyKCkuYWRkSGFuZGxlcihzZWxmLl9sb2dzX2hhbmRsZXIpCiAg ICAgICAgIHJldHVybiAoc2VsZi5fY2FwdHVyZV9vdXRwdXRfd2l0aF9uYW1lKCJzdGRvdXQiKSwg c2VsZi5fY2FwdHVyZV9vdXRwdXRfd2l0aF9uYW1lKCJzdGRlcnIiKSkKIApkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL291dHB1dGNhcHR1cmVfdW5pdHRl c3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vb3V0cHV0Y2FwdHVy ZV91bml0dGVzdC5weQpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kYTQzNDdjOGQxMDhiMzU0NzA5ZmRiMmVjYzA3NTUw OTIyODUzMjg4Ci0tLSAvZGV2L251bGwKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21t b24vc3lzdGVtL291dHB1dGNhcHR1cmVfdW5pdHRlc3QucHkKQEAgLTAsMCArMSw1OSBAQAorIyBD b3B5cmlnaHQgKEMpIDIwMTEgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorIworIyBS ZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9y IHdpdGhvdXQKKyMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhl IGZvbGxvd2luZyBjb25kaXRpb25zCisjIGFyZSBtZXQ6CisjIDEuICBSZWRpc3RyaWJ1dGlvbnMg b2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorIyAgICAgbm90 aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVy LgorIyAyLiAgUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRo ZSBhYm92ZSBjb3B5cmlnaHQKKyMgICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMg YW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKKyMgICAgIGRvY3VtZW50YXRpb24g YW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisj CisjIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUgSU5DLiBBTkQgSVRTIENPTlRS SUJVVE9SUyBgYEFTIElTJycgQU5ECisjIEFOWSBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElF UywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFRIRSBJTVBMSUVECisjIFdBUlJBTlRJ RVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9T RSBBUkUKKyMgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgSU5DLiBPUiBJVFMg Q09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IKKyMgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lE RU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTAorIyBEQU1BR0VTIChJ TkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBH T09EUyBPUgorIyBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJV U0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUgorIyBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkg T0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLAorIyBP UiBUT1JUIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5Z IFdBWSBPVVQgT0YgVEhFIFVTRQorIyBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQg T0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorCitpbXBvcnQgbG9nZ2luZworaW1w b3J0IHVuaXR0ZXN0CisKK2Zyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5vdXRwdXRjYXB0dXJl IGltcG9ydCBPdXRwdXRDYXB0dXJlCisKKworX2xvZyA9IGxvZ2dpbmcuZ2V0TG9nZ2VyKF9fbmFt ZV9fKQorCisKK2NsYXNzIE91dHB1dENhcHR1cmVUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKKyAg ICBkZWYgc2V0VXAoc2VsZik6CisgICAgICAgIHNlbGYub3V0cHV0ID0gT3V0cHV0Q2FwdHVyZSgp CisKKyAgICBkZWYgbG9nX2FsbF9sZXZlbHMoc2VsZik6CisgICAgICAgIF9sb2cuaW5mbygnSU5G TycpCisgICAgICAgIF9sb2cud2FybmluZygnV0FSTicpCisgICAgICAgIF9sb2cuZXJyb3IoJ0VS Uk9SJykKKyAgICAgICAgX2xvZy5jcml0aWNhbCgnQ1JJVElDQUwnKQorCisgICAgZGVmIGFzc2Vy dExvZ2dlZChzZWxmLCBleHBlY3RlZF9sb2dzKToKKyAgICAgICAgYWN0dWFsX3N0ZG91dCwgYWN0 dWFsX3N0ZGVyciwgYWN0dWFsX2xvZ3MgPSBzZWxmLm91dHB1dC5yZXN0b3JlX291dHB1dCgpCisg ICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoJycsIGFjdHVhbF9zdGRvdXQpCisgICAgICAgIHNlbGYu YXNzZXJ0RXF1YWwoJycsIGFjdHVhbF9zdGRlcnIpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwo ZXhwZWN0ZWRfbG9ncywgYWN0dWFsX2xvZ3MpCisKKyAgICBkZWYgdGVzdF9pbml0aWFsX2xvZ19s ZXZlbChzZWxmKToKKyAgICAgICAgc2VsZi5vdXRwdXQuY2FwdHVyZV9vdXRwdXQoKQorICAgICAg ICBzZWxmLmxvZ19hbGxfbGV2ZWxzKCkKKyAgICAgICAgc2VsZi5hc3NlcnRMb2dnZWQoJ0lORk9c bldBUk5cbkVSUk9SXG5DUklUSUNBTFxuJykKKworICAgIGRlZiB0ZXN0X3NldF9sb2dfbGV2ZWwo c2VsZik6CisgICAgICAgIHNlbGYub3V0cHV0LnNldF9sb2dfbGV2ZWwobG9nZ2luZy5FUlJPUikK KyAgICAgICAgc2VsZi5vdXRwdXQuY2FwdHVyZV9vdXRwdXQoKQorICAgICAgICBzZWxmLmxvZ19h bGxfbGV2ZWxzKCkKKyAgICAgICAgc2VsZi5vdXRwdXQuc2V0X2xvZ19sZXZlbChsb2dnaW5nLldB Uk4pCisgICAgICAgIHNlbGYubG9nX2FsbF9sZXZlbHMoKQorICAgICAgICBzZWxmLmFzc2VydExv Z2dlZCgnRVJST1JcbkNSSVRJQ0FMXG5XQVJOXG5FUlJPUlxuQ1JJVElDQUxcbicpCg==