73464 2011-11-30 10:10:21 -0800 always notify for hidden popups 2011-11-30 11:35:18 -0800 1 1 1 Unclassified WebKit WebKit wx 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 robin webkit-unassigned kevino oldest_to_newest 511843 0 robin 2011-11-30 10:10:21 -0800 Ensure we always notify the popup client that the popup was hidden, and fix handling of empty menu items. 511863 1 117217 robin 2011-11-30 10:29:04 -0800 Created attachment 117217 popup notification patch 511954 2 kevino 2011-11-30 11:35:18 -0800 Landed in r101538, thanks! 117217 2011-11-30 10:29:04 -0800 2011-11-30 10:44:26 -0800 popup notification patch popup_fix.patch application/octet-stream 2434 robin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMTQ0NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDExLTExLTI5ICBSb2JpbiBE dW5uICA8cm9iaW5AYWxsZHVubi5jb20+CisKKyAgICAgICAgW3d4XSBFbnN1cmUgd2UgYWx3YXlz IG5vdGlmeSB0aGUgcG9wdXAgY2xpZW50IHRoYXQgdGhlIHBvcHVwCisgICAgICAgIHdhcyBoaWRk ZW4sIGFuZCBmaXggaGFuZGxpbmcgb2YgZW1wdHkgbWVudSBpdGVtcy4KKworICAgICAgICAqIHBs YXRmb3JtL3d4L1BvcHVwTWVudVd4LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBvcHVwTWVudUV2 ZW50SGFuZGxlcjo6T25NZW51SXRlbVNlbGVjdGVkKToKKyAgICAgICAgKFdlYkNvcmU6OlBvcHVw TWVudVd4OjpzaG93KToKKwogMjAxMS0xMS0yOSAgTGVvIFlhbmcgIDxsZW8ueWFuZ0B0b3JjaG1v YmlsZS5jb20uY24+CiAKICAgICAgICAgVXBzdHJlYW0gcGxhdGZvcm0vbmV0d29yay9ibGFja2Jl cnJ5L1Byb3h5U2VydmVyQmxhY2tCZXJyeS5jcHAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3d4L1BvcHVwTWVudVd4LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS93eC9Qb3B1cE1lbnVXeC5jcHAJKHJldmlzaW9uIDEwMTQyNSkKKysrIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL3d4L1BvcHVwTWVudVd4LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTAsMTEg KzUwLDggQEAKIAogICAgIHZvaWQgT25NZW51SXRlbVNlbGVjdGVkKHd4Q29tbWFuZEV2ZW50JiBl dmVudCkKICAgICB7Ci0gICAgICAgIGlmIChtX2NsaWVudCkgeworICAgICAgICBpZiAobV9jbGll bnQpCiAgICAgICAgICAgICBtX2NsaWVudC0+dmFsdWVDaGFuZ2VkKGV2ZW50LkdldElkKCkgLSBz X21lbnVTdGFydElkKTsKLSAgICAgICAgICAgIG1fY2xpZW50LT5wb3B1cERpZEhpZGUoKTsKLSAg ICAgICAgfQotICAgICAgICAvLyBUT0RPOiBEbyB3ZSBuZWVkIHRvIGNhbGwgRGlzY29ubmVjdCBo ZXJlPyBEbyB3ZSBoYXZlIGEgcmVmIHRvIHRoZSBuYXRpdmUgd2luZG93IHN0aWxsPwogICAgIH0K IAogcHJpdmF0ZToKQEAgLTEwMSwxNiArOTgsMTggQEAKICAgICAgICAgICAgICAgICBtX21lbnUt PkFwcGVuZFNlcGFyYXRvcigpOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgZWxzZSB7Ci0g ICAgICAgICAgICAgICAgLy8gRklYTUU6IGFwcGVuZGluZyBhIG1lbnUgaXRlbSB3aXRoIGFuIGVt cHR5IGxhYmVsIGFzc2VydHMgaW4KLSAgICAgICAgICAgICAgICAvLyB3eC4gVGhpcyBuZWVkcyB0 byBiZSBmaXhlZCBhdCB3eCBsZXZlbCBzbyB0aGF0IHdlIGNhbiBoYXZlCi0gICAgICAgICAgICAg ICAgLy8gdGhlIGNvbmNlcHQgb2YgIm5vIHNlbGVjdGlvbiIgaW4gY2hvaWNlIGJveGVzLCBldGMu CisgICAgICAgICAgICAgICAgLy8gTk9URTogYXBwZW5kaW5nIGEgbWVudSBpdGVtIHdpdGggYW4g ZW1wdHkgbGFiZWwgYXNzZXJ0cyBpbiB3eC4KICAgICAgICAgICAgICAgICBpZiAoIWNsaWVudCgp LT5pdGVtVGV4dChpKS5pc0VtcHR5KCkpCiAgICAgICAgICAgICAgICAgICAgIG1fbWVudS0+QXBw ZW5kKHNfbWVudVN0YXJ0SWQgKyBpLCBjbGllbnQoKS0+aXRlbVRleHQoaSkpOworICAgICAgICAg ICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICAgICAgbV9tZW51LT5BcHBlbmQoc19tZW51U3Rh cnRJZCArIGksICIgIik7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICAgICAgbmF0aXZl V2luLT5Db25uZWN0KHNfbWVudVN0YXJ0SWQsIHNfbWVudVN0YXJ0SWQgKyAoc2l6ZS0xKSwgd3hF VlRfQ09NTUFORF9NRU5VX1NFTEVDVEVELCB3eENvbW1hbmRFdmVudEhhbmRsZXIoUG9wdXBNZW51 RXZlbnRIYW5kbGVyOjpPbk1lbnVJdGVtU2VsZWN0ZWQpLCAwLCBtX3BvcHVwSGFuZGxlcik7CiAg ICAgICAgIG5hdGl2ZVdpbi0+UG9wdXBNZW51KG1fbWVudSwgci54KCkgLSB2LT5zY3JvbGxYKCks IHIueSgpIC0gdi0+c2Nyb2xsWSgpKTsKICAgICAgICAgbmF0aXZlV2luLT5EaXNjb25uZWN0KHNf bWVudVN0YXJ0SWQsIHNfbWVudVN0YXJ0SWQgKyAoc2l6ZS0xKSwgd3hFVlRfQ09NTUFORF9NRU5V X1NFTEVDVEVELCB3eENvbW1hbmRFdmVudEhhbmRsZXIoUG9wdXBNZW51RXZlbnRIYW5kbGVyOjpP bk1lbnVJdGVtU2VsZWN0ZWQpLCAwLCBtX3BvcHVwSGFuZGxlcik7CisgICAgICAgIAorICAgICAg ICBjbGllbnQoKS0+cG9wdXBEaWRIaWRlKCk7CiAgICAgfQogfQogCg==