<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>73461</bug_id>
          
          <creation_ts>2011-11-30 10:06:55 -0800</creation_ts>
          <short_desc>fix raw bitmap access bug</short_desc>
          <delta_ts>2011-11-30 11:25:49 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit wx</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Robin Dunn">robin</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>kevino</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>511834</commentid>
    <comment_count>0</comment_count>
      <attachid>117208</attachid>
    <who name="Robin Dunn">robin</who>
    <bug_when>2011-11-30 10:06:55 -0800</bug_when>
    <thetext>Created attachment 117208
raw bitmap access patch

Add a scope for the raw bitmap access so that wx will not make a copy when creating the wxMemoryDC.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>511938</commentid>
    <comment_count>1</comment_count>
    <who name="Kevin Ollivier">kevino</who>
    <bug_when>2011-11-30 11:25:49 -0800</bug_when>
    <thetext>Landed in r101535, thanks!</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>117208</attachid>
            <date>2011-11-30 10:06:55 -0800</date>
            <delta_ts>2011-11-30 10:25:48 -0800</delta_ts>
            <desc>raw bitmap access patch</desc>
            <filename>bitmap_scope.patch</filename>
            <type>text/plain</type>
            <size>2153</size>
            <attacher name="Robin Dunn">robin</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMTQzNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDExIEBACisyMDExLTExLTI5ICBSb2JpbiBE
dW5uICA8cm9iaW5AYWxsZHVubi5jb20+CisKKyAgICAgICAgW3d4XSBBZGQgYSBzY29wZSBmb3Ig
dGhlIHJhdyBiaXRtYXAgYWNjZXNzIHNvIHRoYXQgd3gKKyAgICAgICAgd2lsbCBub3QgbWFrZSBh
IGNvcHkgd2hlbiBjcmVhdGluZyB0aGUgd3hNZW1vcnlEQy4KKworICAgICAgICAqIHBsYXRmb3Jt
L3d4L0xvY2FsREMuaDoKKyAgICAgICAgKFdlYkNvcmU6OkxvY2FsREM6OkxvY2FsREMpOgorCiAy
MDExLTExLTI5ICBFcmlrIEFydmlkc3NvbiAgPGFydkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg
V2ViSURMOiBBZGQgc3VwcG9ydCBmb3Igc3RhdGljIGZvciBKU0MgYW5kIFY4CkluZGV4OiBTb3Vy
Y2UvV2ViQ29yZS9wbGF0Zm9ybS93eC9Mb2NhbERDLmgKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vd3gvTG9jYWxEQy5oCShyZXZpc2lvbiAxMDE0MjUpCisrKyBTb3VyY2Uv
V2ViQ29yZS9wbGF0Zm9ybS93eC9Mb2NhbERDLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ3LDE4ICs0
NywyMiBAQAogICAgICAgICBpbnQgd2lkdGggPSByLndpZHRoKCk7CiAgICAgICAgIGludCBoZWln
aHQgPSByLmhlaWdodCgpOwogICAgICAgICBtX2JpdG1hcCA9IG5ldyB3eEJpdG1hcCh3aWR0aCwg
aGVpZ2h0LCAzMik7Ci0gICAgICAgIHd4QWxwaGFQaXhlbERhdGEgcGl4RGF0YSgqbV9iaXRtYXAs
IHd4UG9pbnQoMCwwKSwgd3hTaXplKHdpZHRoLCBoZWlnaHQpKTsKLSAgICAgICAgQVNTRVJUKHBp
eERhdGEpOwotICAgICAgICBpZiAocGl4RGF0YSkgewotICAgICAgICAgICAgd3hBbHBoYVBpeGVs
RGF0YTo6SXRlcmF0b3IgcChwaXhEYXRhKTsKLSAgICAgICAgICAgIGZvciAoaW50IHk9MDsgeTxo
ZWlnaHQ7IHkrKykgewotICAgICAgICAgICAgICAgIHd4QWxwaGFQaXhlbERhdGE6Okl0ZXJhdG9y
IHJvd1N0YXJ0ID0gcDsKLSAgICAgICAgICAgICAgICBmb3IgKGludCB4PTA7IHg8d2lkdGg7IHgr
KykgewotICAgICAgICAgICAgICAgICAgICBwLkFscGhhKCkgPSAwOwotICAgICAgICAgICAgICAg
ICAgICArK3A7IAorICAgICAgICAvLyB3ZSBzY29wZSB0aGlzIHRvIG1ha2Ugc3VyZSB0aGF0IHd4
QWxwaGFQaXhlbERhdGEgaXNuJ3QgaG9sZGluZyBhIHJlZgorICAgICAgICAvLyB0byBtX2JpdG1h
cCB3aGVuIHdlIGNyZWF0ZSB0aGUgd3hNZW1vcnlEQywgYXMgdGhpcyB3aWxsIGludm9rZSBhIGNv
cHkgb3AuCisgICAgICAgIHsKKyAgICAgICAgICAgIHd4QWxwaGFQaXhlbERhdGEgcGl4RGF0YSgq
bV9iaXRtYXAsIHd4UG9pbnQoMCwwKSwgd3hTaXplKHdpZHRoLCBoZWlnaHQpKTsKKyAgICAgICAg
ICAgIEFTU0VSVChwaXhEYXRhKTsKKyAgICAgICAgICAgIGlmIChwaXhEYXRhKSB7CisgICAgICAg
ICAgICAgICAgd3hBbHBoYVBpeGVsRGF0YTo6SXRlcmF0b3IgcChwaXhEYXRhKTsKKyAgICAgICAg
ICAgICAgICBmb3IgKGludCB5PTA7IHk8aGVpZ2h0OyB5KyspIHsKKyAgICAgICAgICAgICAgICAg
ICAgd3hBbHBoYVBpeGVsRGF0YTo6SXRlcmF0b3Igcm93U3RhcnQgPSBwOworICAgICAgICAgICAg
ICAgICAgICBmb3IgKGludCB4PTA7IHg8d2lkdGg7IHgrKykgeworICAgICAgICAgICAgICAgICAg
ICAgICAgcC5BbHBoYSgpID0gMDsKKyAgICAgICAgICAgICAgICAgICAgICAgICsrcDsgCisgICAg
ICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICAgICAgcCA9IHJvd1N0YXJ0OworICAg
ICAgICAgICAgICAgICAgICBwLk9mZnNldFkocGl4RGF0YSwgMSk7CiAgICAgICAgICAgICAgICAg
fQotICAgICAgICAgICAgICAgIHAgPSByb3dTdGFydDsKLSAgICAgICAgICAgICAgICBwLk9mZnNl
dFkocGl4RGF0YSwgMSk7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KIAo=
</data>
<flag name="review"
          id="116582"
          type_id="1"
          status="+"
          setter="kevino"
    />
    <flag name="commit-queue"
          id="116583"
          type_id="3"
          status="-"
          setter="kevino"
    />
          </attachment>
      

    </bug>

</bugzilla>