73456 2011-11-30 09:15:40 -0800 [GTK] HTML5 Youtube video fullscreen button doesn't work 2011-11-30 10:03:30 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned oldest_to_newest 511801 0 pnormand 2011-11-30 09:15:40 -0800 Because ChromeClient::supportsFullScreenForElement returns false if the withKeyboard argument is set to true. Chrome's ChromeClient ignores this variable and always returns true. 511803 1 117205 pnormand 2011-11-30 09:17:08 -0800 Created attachment 117205 proposed patch 511828 2 pnormand 2011-11-30 10:03:30 -0800 Committed r101526: <http://trac.webkit.org/changeset/101526> 117205 2011-11-30 09:17:08 -0800 2011-11-30 09:17:57 -0800 proposed patch proposed-patch.patch text/plain 1630 pnormand RnJvbSA0M2U3NmE3MmQ3MjVjYjgzYjQwYzkzODg2YTcyNTFkYmE2ZDdjOWFmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDMwIE5vdiAyMDExIDE4OjE2OjQ2ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDExICsrKysrKysrKysrCiAuLi4vV2ViS2l0L2d0ay9XZWJDb3Jl U3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3BwICB8ICAgIDMgLS0tCiAyIGZpbGVzIGNoYW5nZWQs IDExIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9ndGsvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IGEw YTk4MWUuLjU5ZWU2N2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwor KysgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMS0x MS0zMCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAg W0dUS10gSFRNTDUgWW91dHViZSB2aWRlbyBmdWxsc2NyZWVuIGJ1dHRvbiBkb2Vzbid0IHdvcmsK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczNDU2CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJDb3Jl U3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpDaHJvbWVDbGll bnQ6OnN1cHBvcnRzRnVsbFNjcmVlbkZvckVsZW1lbnQpOiBJZ25vcmUKKyAgICAgICAgd2l0aEtl eWJvYXJkIGFyZ3VtZW50IHZhbHVlLCBsaWtlIENocm9tZSdzIGltcGxlbWVudGF0aW9uLgorCiAy MDExLTExLTI5ICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFtHVEtdIFNJR1NFViB3aGVuIGEgV2ViS2l0RG93bmxvYWQgZmFpbHMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEd0ay5jcHAg Yi9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3BwCmlu ZGV4IDMyMzkzZTkuLjM2NWFlZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNv cmVTdXBwb3J0L0Nocm9tZUNsaWVudEd0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ndGsvV2Vi Q29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNwcApAQCAtODgwLDkgKzg4MCw2IEBAIHZvaWQg Q2hyb21lQ2xpZW50OjpleGl0RnVsbHNjcmVlbkZvck5vZGUoTm9kZSogbm9kZSkKICNpZiBFTkFC TEUoRlVMTFNDUkVFTl9BUEkpCiBib29sIENocm9tZUNsaWVudDo6c3VwcG9ydHNGdWxsU2NyZWVu Rm9yRWxlbWVudChjb25zdCBXZWJDb3JlOjpFbGVtZW50KiBlbGVtZW50LCBib29sIHdpdGhLZXli b2FyZCkKIHsKLSAgICBpZiAod2l0aEtleWJvYXJkKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0K ICAgICByZXR1cm4gdHJ1ZTsKIH0KIAotLSAKMS43LjcuMw==