73446 2011-11-30 07:51:28 -0800 [Qt] Buildfix for generating forwarding headers 2011-11-30 19:10:30 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Critical --- 1 ossy ossy hausmann ossy vestbo webkit.review.bot zoltan oldest_to_newest 511748 0 ossy 2011-11-30 07:51:28 -0800 I got the following error with WK2 clean build: echo '#include "../WebCore/generated/HTMLNames.h"' > /storage/WebKit/WebKitBuild/Release/Source/include/WebCore/HTMLNames.h echo '#include "../WebCore/generated/JSCSSStyleDeclaration.h"' > /storage/WebKit/WebKitBuild/Release/Source/include/WebCore/JSCSSStyleDeclara tion.h /bin/sh: cannot create /storage/WebKit/WebKitBuild/Release/Source/include/WebCore/HTMLNames.h: Directory nonexistent make[3]: *** [/storage/WebKit/WebKitBuild/Release/Source/include/WebCore/HTMLNames.h] Error 2 make[3]: *** Waiting for unfinished jobs.... /bin/sh: cannot create /storage/WebKit/WebKitBuild/Release/Source/include/WebCore/JSCSSStyleDeclaration.h: Directory nonexistent make[3]: *** [/storage/WebKit/WebKitBuild/Release/Source/include/WebCore/JSCSSStyleDeclaration.h] Error 2 ------------------------- The problem is that nobody creates the directory previously. Fix is coming soon. 511749 1 117194 ossy 2011-11-30 07:56:10 -0800 Created attachment 117194 Patch 511772 2 ossy 2011-11-30 08:32:08 -0800 Unfortunately it won't work on Windows :-/ Because QMAKE_MKDIR == mkdir for windows cmd, but it returns with error if the directory exists. I thought I should use QMAKE_CHK_DIR_EXISTS, but it is absolutely incompatible on Windows and on Linux: win: QMAKE_CHK_DIR_EXISTS = if not exist linux: QMAKE_CHK_DIR_EXISTS = test -d 512346 3 117194 webkit.review.bot 2011-11-30 19:10:25 -0800 Comment on attachment 117194 Patch Clearing flags on attachment: 117194 Committed r101589: <http://trac.webkit.org/changeset/101589> 512347 4 webkit.review.bot 2011-11-30 19:10:30 -0800 All reviewed patches have been landed. Closing bug. 117194 2011-11-30 07:56:10 -0800 2011-11-30 19:10:25 -0800 Patch bug-73446-20111130165608.patch text/plain 1565 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxNTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTU1ZTRmYjE2OGIxODE2 N2RhZmUwZTAxZWQ5YmRhMzU4ODcyOTRmZS4uNTFmZTk3MTEzNmUyYzU3MmI1MGM5NjQ5MzU1MzRi N2Y3Yjg5ZjliZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDExLTExLTMwICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1F0XSBCdWlsZGZp eCBmb3IgZ2VuZXJhdGluZyBmb3J3YXJkaW5nIGhlYWRlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczNDQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEZXJpdmVkU291cmNlcy5wcmk6IEFsd2F5cyBj cmVhdGUgdGhlIHBhcmVudCBkaXJlY3RvcnkgYmVmb3JlIGdlbmVyYXRpbmcgYSBmb3J3YXJkaW5n IGhlYWRlci4KKwogMjAxMS0xMS0zMCAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGln YWxpYS5jb20+CiAKICAgICAgICAgW0d0a10gTGlua3Mgc2hvdWxkIGJlIFRhYi1mb2N1c2FibGUg YnkgZGVmYXVsdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvRGVyaXZlZFNvdXJjZXMucHJp IGIvU291cmNlL1dlYktpdDIvRGVyaXZlZFNvdXJjZXMucHJpCmluZGV4IDgxYmQzMjFlMTlhYmE2 YmRkNzc5NGNlYTRhNzFkMTFiNDgzZjJhMjkuLmNhZTYwMjAxZTMyNjBlM2U2OGQyZTQzNGJlZDJl MmQ5YTExMzRiNGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0Rlcml2ZWRTb3VyY2VzLnBy aQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9EZXJpdmVkU291cmNlcy5wcmkKQEAgLTEzMyw3ICsxMzMs NyBAQCBmb3IoaGVhZGVyLCBXRUJDT1JFX0dFTkVSQVRFRF9IRUFERVJTX0ZPUl9XRUJLSVQyKSB7 CiAKICAgICBldmFsKCQke2hlYWRlcl90YXJnZXR9LnRhcmdldCA9ICQkZGVzdF9kaXIvJCRoZWFk ZXJfbmFtZSkKICAgICBldmFsKCQke2hlYWRlcl90YXJnZXR9LmRlcGVuZHMgPSAkJGhlYWRlcl9w YXRoKQotICAgIGV2YWwoJCR7aGVhZGVyX3RhcmdldH0uY29tbWFuZHMgPSBlY2hvICQke0RPVUJM RV9FU0NBUEVEX1FVT1RFfVwkJHtMSVRFUkFMX0hBU0h9aW5jbHVkZSBcXFwiJCRoZWFkZXJfcGF0 aFxcXCIkJHtET1VCTEVfRVNDQVBFRF9RVU9URX0gPiAkJGV2YWwoJCR7aGVhZGVyX3RhcmdldH0u dGFyZ2V0KSkKKyAgICBldmFsKCQke2hlYWRlcl90YXJnZXR9LmNvbW1hbmRzID0gJCR7UU1BS0Vf TUtESVJ9ICQkZGVzdF9kaXIgJiYgZWNobyAkJHtET1VCTEVfRVNDQVBFRF9RVU9URX1cJCR7TElU RVJBTF9IQVNIfWluY2x1ZGUgXFxcIiQkaGVhZGVyX3BhdGhcXFwiJCR7RE9VQkxFX0VTQ0FQRURf UVVPVEV9ID4gJCRldmFsKCQke2hlYWRlcl90YXJnZXR9LnRhcmdldCkpCiAKICAgICBHRU5FUkFU T1JTICs9ICQkaGVhZGVyX3RhcmdldAogfQo=