73443 2011-11-30 07:02:38 -0800 Web Inspector: totalOffsetLeft and totalOffsetTop should take scroll into account. 2011-12-01 04:11:05 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 511717 0 vsevik 2011-11-30 07:02:38 -0800 totalOffsetLeft and totalOffsetTop should take scroll into account. 511732 1 117190 vsevik 2011-11-30 07:24:55 -0800 Created attachment 117190 Patch 512676 2 vsevik 2011-12-01 04:11:05 -0800 Committed r101656: <http://trac.webkit.org/changeset/101656> 117190 2011-11-30 07:24:55 -0800 2011-12-01 01:47:53 -0800 Patch bug-73443-20111130192453.patch text/plain 5932 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxNTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDViNDQ1ZDY3MWY0MDk5 MDBkOThlMzAzYzFjYmQ2NWQzMDUwNzE1Ni4uNDg2OGExMDM2MGM2NzFmNTU2M2JhZmZmMWRmMDU5 YzZkMWQ5YmUzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDExLTExLTMwICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHRvdGFsT2Zmc2V0TGVmdCBhbmQgdG90YWxPZmZzZXRUb3Agc2hvdWxkIHRha2Ugc2Nyb2xs IGludG8gYWNjb3VudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTczNDQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuVGV4dFByb21wdC5wcm90b3R5cGUuX2JveEZvckFuY2hvckF0U3RhcnQpOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLlRleHRQcm9tcHQuU3VnZ2VzdEJveCk6CisgICAgICAgICogaW5z cGVjdG9yL2Zyb250LWVuZC91dGlsaXRpZXMuanM6CisgICAgICAgIChFbGVtZW50LnByb3RvdHlw ZS50b3RhbE9mZnNldExlZnQpOgorICAgICAgICAoRWxlbWVudC5wcm90b3R5cGUudG90YWxPZmZz ZXRUb3ApOgorICAgICAgICAoRWxlbWVudC5wcm90b3R5cGUuYm94SW5XaW5kb3cpOgorCiAyMDEx LTExLTI4ICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IFRyZWVPdXRsaW5lIGVsZW1lbnRzIHNob3VsZCBiZSBmb3JtYXR0ZWQg dXNpbmcgbWFyZ2luLWxlZnQgaW5zdGVhZCBvZiB0ZXh0LWluZGVudC4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGV4dFByb21wdC5qcyBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGV4dFByb21wdC5qcwppbmRleCBlNDQwOGNkZWQ4 YWRjODEwMTVkNDcwMmRhYTU0M2M5NGQzNDNmNDgxLi4wOTE2OWUyOWM3MTBkYTU3NTE5NWIyZmQ1 OWQ4MDJmYzYyMWRjNzA3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1RleHRQcm9tcHQuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9UZXh0UHJvbXB0LmpzCkBAIC0zNzQsNyArMzc0LDcgQEAgV2ViSW5zcGVjdG9yLlRleHRQ cm9tcHQucHJvdG90eXBlID0gewogICAgICAgICB2YXIgYW5jaG9yRWxlbWVudCA9IGRvY3VtZW50 LmNyZWF0ZUVsZW1lbnQoInNwYW4iKTsKICAgICAgICAgYW5jaG9yRWxlbWVudC50ZXh0Q29udGVu dCA9ICJcdTIwMEIiOwogICAgICAgICB0ZXh0UmFuZ2UuaW5zZXJ0Tm9kZShhbmNob3JFbGVtZW50 KTsKLSAgICAgICAgdmFyIGJveCA9IGFuY2hvckVsZW1lbnQuYm94SW5XaW5kb3cod2luZG93LCB0 aGlzLl9zdWdnZXN0Qm94Ll9wYXJlbnRFbGVtZW50KTsKKyAgICAgICAgdmFyIGJveCA9IGFuY2hv ckVsZW1lbnQuYm94SW5XaW5kb3cod2luZG93KTsKICAgICAgICAgYW5jaG9yRWxlbWVudC5wYXJl bnRFbGVtZW50LnJlbW92ZUNoaWxkKGFuY2hvckVsZW1lbnQpOwogICAgICAgICBzZWxlY3Rpb24u cmVtb3ZlQWxsUmFuZ2VzKCk7CiAgICAgICAgIHNlbGVjdGlvbi5hZGRSYW5nZShyYW5nZUNvcHkp OwpAQCAtODQ0LDcgKzg0NCw2IEBAIFdlYkluc3BlY3Rvci5UZXh0UHJvbXB0V2l0aEhpc3Rvcnku cHJvdG90eXBlLl9fcHJvdG9fXyA9IFdlYkluc3BlY3Rvci5UZXh0UHJvbXB0CiBXZWJJbnNwZWN0 b3IuVGV4dFByb21wdC5TdWdnZXN0Qm94ID0gZnVuY3Rpb24odGV4dFByb21wdCwgaW5wdXRFbGVt ZW50LCBjbGFzc05hbWUpCiB7CiAgICAgdGhpcy5fdGV4dFByb21wdCA9IHRleHRQcm9tcHQ7Ci0g ICAgdGhpcy5fcGFyZW50RWxlbWVudCA9IGlucHV0RWxlbWVudC5vd25lckRvY3VtZW50LmJvZHk7 CiAgICAgdGhpcy5faW5wdXRFbGVtZW50ID0gaW5wdXRFbGVtZW50OwogICAgIHRoaXMuX3NlbGVj dGVkRWxlbWVudCA9IG51bGw7CiAgICAgdGhpcy5fYm91bmRPblNjcm9sbCA9IHRoaXMuX29uc2Ny b2xscmVzaXplLmJpbmQodGhpcywgdHJ1ZSk7CkBAIC04NTIsNyArODUxLDggQEAgV2ViSW5zcGVj dG9yLlRleHRQcm9tcHQuU3VnZ2VzdEJveCA9IGZ1bmN0aW9uKHRleHRQcm9tcHQsIGlucHV0RWxl bWVudCwgY2xhc3NOYW0KICAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcigic2Nyb2xsIiwgdGhp cy5fYm91bmRPblNjcm9sbCwgdHJ1ZSk7CiAgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoInJl c2l6ZSIsIHRoaXMuX2JvdW5kT25SZXNpemUsIHRydWUpOwogCi0gICAgdGhpcy5fZWxlbWVudCA9 IHRoaXMuX3BhcmVudEVsZW1lbnQuY3JlYXRlQ2hpbGQoImRpdiIsICJzdWdnZXN0LWJveCAiICsg KGNsYXNzTmFtZSB8fCAiIikpOworICAgIHZhciBib2R5RWxlbWVudCA9IGlucHV0RWxlbWVudC5v d25lckRvY3VtZW50LmJvZHk7CisgICAgdGhpcy5fZWxlbWVudCA9IGJvZHlFbGVtZW50LmNyZWF0 ZUNoaWxkKCJkaXYiLCAic3VnZ2VzdC1ib3ggIiArIChjbGFzc05hbWUgfHwgIiIpKTsKICAgICB0 aGlzLl9lbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNlZG93biIsIHRoaXMuX29uYm94bW91 c2Vkb3duLmJpbmQodGhpcyksIHRydWUpOwogICAgIHRoaXMuY29udGFpbmVyRWxlbWVudCA9IHRo aXMuX2VsZW1lbnQuY3JlYXRlQ2hpbGQoImRpdiIsICJjb250YWluZXIiKTsKICAgICB0aGlzLmNv bnRlbnRFbGVtZW50ID0gdGhpcy5jb250YWluZXJFbGVtZW50LmNyZWF0ZUNoaWxkKCJkaXYiLCAi Y29udGVudCIpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC91dGlsaXRpZXMuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3V0aWxp dGllcy5qcwppbmRleCA0NGU1ZjUyNjRjYTBlNjJjMGQ1MzgyZDBhYzdlMjBhMzE4NTE5YjMzLi5l MjJmNzAyMDc0ZGEyNjE4NTE5ODM1OTEwOTk1MTZlM2M2ZjMwZTk2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3V0aWxpdGllcy5qcworKysgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3V0aWxpdGllcy5qcwpAQCAtMjY1LDE5ICsyNjUs MzMgQEAgRWxlbWVudC5wcm90b3R5cGUuY3JlYXRlQ2hpbGQgPSBmdW5jdGlvbihlbGVtZW50TmFt ZSwgY2xhc3NOYW1lKQogCiBEb2N1bWVudEZyYWdtZW50LnByb3RvdHlwZS5jcmVhdGVDaGlsZCA9 IEVsZW1lbnQucHJvdG90eXBlLmNyZWF0ZUNoaWxkOwogCisvKioKKyAqIEByZXR1cm4ge251bWJl cn0KKyAqLwogRWxlbWVudC5wcm90b3R5cGUudG90YWxPZmZzZXRMZWZ0ID0gZnVuY3Rpb24oKQog ewogICAgIHZhciB0b3RhbCA9IDA7Ci0gICAgZm9yICh2YXIgZWxlbWVudCA9IHRoaXM7IGVsZW1l bnQ7IGVsZW1lbnQgPSBlbGVtZW50Lm9mZnNldFBhcmVudCkKLSAgICAgICAgdG90YWwgKz0gZWxl bWVudC5vZmZzZXRMZWZ0ICsgKHRoaXMgIT09IGVsZW1lbnQgPyBlbGVtZW50LmNsaWVudExlZnQg OiAwKTsKKyAgICBmb3IgKHZhciBlbGVtZW50ID0gdGhpczsgZWxlbWVudDsgZWxlbWVudCA9IGVs ZW1lbnQub2Zmc2V0UGFyZW50KSB7CisgICAgICAgIHRvdGFsICs9IGVsZW1lbnQub2Zmc2V0TGVm dCAKKyAgICAgICAgaWYgKHRoaXMgIT09IGVsZW1lbnQpCisgICAgICAgICAgICB0b3RhbCArPSBl bGVtZW50LmNsaWVudExlZnQgLSBlbGVtZW50LnNjcm9sbExlZnQ7CisgICAgfQorICAgICAgICAK ICAgICByZXR1cm4gdG90YWw7CiB9CiAKKy8qKgorICogQHJldHVybiB7bnVtYmVyfQorICovCiBF bGVtZW50LnByb3RvdHlwZS50b3RhbE9mZnNldFRvcCA9IGZ1bmN0aW9uKCkKIHsKICAgICB2YXIg dG90YWwgPSAwOwotICAgIGZvciAodmFyIGVsZW1lbnQgPSB0aGlzOyBlbGVtZW50OyBlbGVtZW50 ID0gZWxlbWVudC5vZmZzZXRQYXJlbnQpCi0gICAgICAgIHRvdGFsICs9IGVsZW1lbnQub2Zmc2V0 VG9wICsgKHRoaXMgIT09IGVsZW1lbnQgPyBlbGVtZW50LmNsaWVudFRvcCA6IDApOworICAgIGZv ciAodmFyIGVsZW1lbnQgPSB0aGlzOyBlbGVtZW50OyBlbGVtZW50ID0gZWxlbWVudC5vZmZzZXRQ YXJlbnQpIHsKKyAgICAgICAgdG90YWwgKz0gZWxlbWVudC5vZmZzZXRUb3AgCisgICAgICAgIGlm ICh0aGlzICE9PSBlbGVtZW50KQorICAgICAgICAgICAgdG90YWwgKz0gZWxlbWVudC5jbGllbnRU b3AgLSBlbGVtZW50LnNjcm9sbFRvcDsKKyAgICB9CisgICAgICAgIAogICAgIHJldHVybiB0b3Rh bDsKIH0KIApAQCAtMjk3LDYgKzMxMSw3IEBAIGZ1bmN0aW9uIEFuY2hvckJveCh4LCB5LCB3aWR0 aCwgaGVpZ2h0KQogfQogCiAvKioKKyAqIEBwYXJhbSB7RE9NV2luZG93fSB0YXJnZXRXaW5kb3cK ICAqIEByZXR1cm4ge0FuY2hvckJveH0KICAqLwogRWxlbWVudC5wcm90b3R5cGUub2Zmc2V0UmVs YXRpdmVUb1dpbmRvdyA9IGZ1bmN0aW9uKHRhcmdldFdpbmRvdykKQEAgLTMxOCwzMyArMzMzLDIz IEBAIEVsZW1lbnQucHJvdG90eXBlLm9mZnNldFJlbGF0aXZlVG9XaW5kb3cgPSBmdW5jdGlvbih0 YXJnZXRXaW5kb3cpCiB9CiAKIC8qKgorICogQHBhcmFtIHtET01XaW5kb3d9IHRhcmdldFdpbmRv dwogICogQHJldHVybiB7QW5jaG9yQm94fQogICovCi1FbGVtZW50LnByb3RvdHlwZS5ib3hJbldp bmRvdyA9IGZ1bmN0aW9uKHRhcmdldFdpbmRvdywgcmVsYXRpdmVQYXJlbnQpCitFbGVtZW50LnBy b3RvdHlwZS5ib3hJbldpbmRvdyA9IGZ1bmN0aW9uKHRhcmdldFdpbmRvdykKIHsKICAgICB0YXJn ZXRXaW5kb3cgPSB0YXJnZXRXaW5kb3cgfHwgdGhpcy5vd25lckRvY3VtZW50LmRlZmF1bHRWaWV3 OwotICAgIHZhciBib2R5RWxlbWVudCA9IHRoaXMub3duZXJEb2N1bWVudC5ib2R5OwotICAgIHJl bGF0aXZlUGFyZW50ID0gcmVsYXRpdmVQYXJlbnQgfHwgYm9keUVsZW1lbnQ7CiAKICAgICB2YXIg YW5jaG9yQm94ID0gdGhpcy5vZmZzZXRSZWxhdGl2ZVRvV2luZG93KHdpbmRvdyk7CiAgICAgYW5j aG9yQm94LndpZHRoID0gdGhpcy5vZmZzZXRXaWR0aDsKICAgICBhbmNob3JCb3guaGVpZ2h0ID0g dGhpcy5vZmZzZXRIZWlnaHQ7CiAKLSAgICB2YXIgYW5jaG9yRWxlbWVudCA9IHRoaXM7Ci0gICAg d2hpbGUgKGFuY2hvckVsZW1lbnQgJiYgYW5jaG9yRWxlbWVudCAhPT0gcmVsYXRpdmVQYXJlbnQg JiYgYW5jaG9yRWxlbWVudCAhPT0gYm9keUVsZW1lbnQpIHsKLSAgICAgICAgaWYgKGFuY2hvckVs ZW1lbnQuc2Nyb2xsTGVmdCkKLSAgICAgICAgICAgIGFuY2hvckJveC54IC09IGFuY2hvckVsZW1l bnQuc2Nyb2xsTGVmdDsKLSAgICAgICAgaWYgKGFuY2hvckVsZW1lbnQuc2Nyb2xsVG9wKQotICAg ICAgICAgICAgYW5jaG9yQm94LnkgLT0gYW5jaG9yRWxlbWVudC5zY3JvbGxUb3A7Ci0gICAgICAg IGFuY2hvckVsZW1lbnQgPSBhbmNob3JFbGVtZW50LnBhcmVudEVsZW1lbnQ7Ci0gICAgfQotCi0g ICAgdmFyIHBhcmVudE9mZnNldCA9IHJlbGF0aXZlUGFyZW50Lm9mZnNldFJlbGF0aXZlVG9XaW5k b3cod2luZG93KTsKLSAgICBhbmNob3JCb3gueCAtPSBwYXJlbnRPZmZzZXQueDsKLSAgICBhbmNo b3JCb3gueSAtPSBwYXJlbnRPZmZzZXQueTsKICAgICByZXR1cm4gYW5jaG9yQm94OwogfQogCisv KioKKyAqIEBwYXJhbSB7c3RyaW5nfSB0ZXh0CisgKi8KIEVsZW1lbnQucHJvdG90eXBlLnNldFRl eHRBbmRUaXRsZSA9IGZ1bmN0aW9uKHRleHQpCiB7CiAgICAgdGhpcy50ZXh0Q29udGVudCA9IHRl eHQ7Cg==