73441 2011-11-30 06:38:13 -0800 [Qt][WK2] ASSERT at QQuickWebViewPrivate::computeViewportConstraints() when API test is exercising zero sized views. 2011-12-02 01:15:37 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zalan zalan hausmann kenneth webkit.review.bot zoltan oldest_to_newest 511708 0 zalan 2011-11-30 06:38:13 -0800 [Qt][WK2] ASSERT at QQuickWebViewPrivate::computeViewportConstraints() when API test is exercising zero sized views. 511709 1 117184 zalan 2011-11-30 06:39:55 -0800 Created attachment 117184 Patch 511712 2 zalan 2011-11-30 06:52:41 -0800 Kenneth, we've discussed marking the constraints with invalid flag, but it got me thinking whether it is different from the default value. Some constraints need to be applied no matter what and probably that should be the default constrains values. If we mark an instance with invalid flag, what values would the interaction engine be using across the code? The previously set or the default? The default values would fit perfectly with the current code which is exactly the same situation, when no values set yet on the interaction engine instance. I am all for introducing the isValid flag, when the interaction engine code is ready/capable to use it. Let me know If i missed something 512647 3 117184 kenneth 2011-12-01 02:28:47 -0800 Comment on attachment 117184 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117184&action=review > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:211 > + // Return default values for zero sized viewport. Maybe add a comment that this will be ignored, ie. not applied 513608 4 117184 webkit.review.bot 2011-12-02 01:15:32 -0800 Comment on attachment 117184 Patch Clearing flags on attachment: 117184 Committed r101763: <http://trac.webkit.org/changeset/101763> 513609 5 webkit.review.bot 2011-12-02 01:15:37 -0800 All reviewed patches have been landed. Closing bug. 117184 2011-11-30 06:39:55 -0800 2011-12-02 01:15:32 -0800 Patch bug-73441-20111130153953.patch text/plain 3015 zalan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMTUwNikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDExLTExLTMwICBaYWxhbiBC dWp0YXMgIDx6YnVqdGFzQGdtYWlsLmNvbT4KKworICAgICAgICBbUXRdW1dLMl0gQVNTRVJUIGF0 IFFRdWlja1dlYlZpZXdQcml2YXRlOjpjb21wdXRlVmlld3BvcnRDb25zdHJhaW50cygpIHdoZW4g QVBJIHRlc3QgaXMgZXhlcmNpc2luZyB6ZXJvIHNpemVkIHZpZXdzLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM0NDEKKworICAgICAgICBEbyBub3Qg YXNzZXJ0IG9uIGVtcHR5IGF2YWlsYWJsZSBzaXplLCBidXQgcmV0dXJuIGRlZmF1bHQgY29uc3Ry YWluIHZhbHVlcyBpbnN0ZWFkLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcDoKKyAgICAg ICAgKFFRdWlja1dlYlZpZXdQcml2YXRlOjpjb21wdXRlVmlld3BvcnRDb25zdHJhaW50cyk6Cisg ICAgICAgICogV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQuY3BwOgor ICAgICAgICAoV2ViS2l0OjpXZWJDaHJvbWVDbGllbnQ6OmRpc3BhdGNoVmlld3BvcnRQcm9wZXJ0 aWVzRGlkQ2hhbmdlKToKKwogMjAxMS0xMS0zMCAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFw cGxlLmNvbT4KIAogICAgICAgICBEb3dubG9hZCBwYWdlIFVSTCBzaG91bGQgYmUgc2V0IGJ5IFdl YkNvcmUKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmll dy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVp Y2t3ZWJ2aWV3LmNwcAkocmV2aXNpb24gMTAxNDk2KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjA1LDkgKzIw NSwxMiBAQCBRdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmU6OkNvbnN0cmFpbnRzCiB7CiAgICAg UV9RKFFRdWlja1dlYlZpZXcpOwogCisgICAgUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lOjpD b25zdHJhaW50cyBuZXdDb25zdHJhaW50czsKICAgICBRU2l6ZSBhdmFpbGFibGVTaXplID0gcS0+ Ym91bmRpbmdSZWN0KCkuc2l6ZSgpLnRvU2l6ZSgpOwogCi0gICAgUV9BU1NFUlQoIWF2YWlsYWJs ZVNpemUuaXNFbXB0eSgpKTsKKyAgICAvLyBSZXR1cm4gZGVmYXVsdCB2YWx1ZXMgZm9yIHplcm8g c2l6ZWQgdmlld3BvcnQuCisgICAgaWYgKGF2YWlsYWJsZVNpemUuaXNFbXB0eSgpKQorICAgICAg ICByZXR1cm4gbmV3Q29uc3RyYWludHM7CiAKICAgICBXZWJQYWdlUHJveHkqIHdrUGFnZSA9IHRv SW1wbChwYWdlUHJveHktPnBhZ2VSZWYoKSk7CiAgICAgV2ViUHJlZmVyZW5jZXMqIHdrUHJlZnMg PSB3a1BhZ2UtPnBhZ2VHcm91cCgpLT5wcmVmZXJlbmNlcygpOwpAQCAtMjIzLDggKzIyNiw2IEBA IFF0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZTo6Q29uc3RyYWludHMKICAgICBXZWJDb3JlOjpy ZXN0cmljdE1pbmltdW1TY2FsZUZhY3RvclRvVmlld3BvcnRTaXplKGF0dHIsIGF2YWlsYWJsZVNp emUpOwogICAgIFdlYkNvcmU6OnJlc3RyaWN0U2NhbGVGYWN0b3JUb0luaXRpYWxTY2FsZUlmTm90 VXNlclNjYWxhYmxlKGF0dHIpOwogCi0gICAgUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lOjpD b25zdHJhaW50cyBuZXdDb25zdHJhaW50czsKLQogICAgIG5ld0NvbnN0cmFpbnRzLmluaXRpYWxT Y2FsZSA9IGF0dHIuaW5pdGlhbFNjYWxlOwogICAgIG5ld0NvbnN0cmFpbnRzLm1pbmltdW1TY2Fs ZSA9IGF0dHIubWluaW11bVNjYWxlOwogICAgIG5ld0NvbnN0cmFpbnRzLm1heGltdW1TY2FsZSA9 IGF0dHIubWF4aW11bVNjYWxlOwpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJD b3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmNwcAkocmV2aXNp b24gMTAxNDk2KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9X ZWJDaHJvbWVDbGllbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MzUsNyArNzM1LDggQEAgdm9p ZCBXZWJDaHJvbWVDbGllbnQ6OmRpc3BhdGNoVmlld3BvcnRQcgogCiAjaWYgVVNFKFRJTEVEX0JB Q0tJTkdfU1RPUkUpCiAgICAgLy8gV2hlbiB2aWV3cG9ydCBwcm9wZXJ0aWVzIGNoYW5nZSwgcmVj YWxjdWxhdGUgYW5kIHNldCB0aGUgbmV3IHJlY29tbWVuZGVkIGxheW91dCBzaXplIGluIGNhc2Ug b2YgZml4ZWQgbGF5b3V0IHJlbmRlcmluZy4KLSAgICBpZiAobV9wYWdlLT51c2VGaXhlZExheW91 dCgpKSB7CisgICAgLy8gVmlld3BvcnQgcHJvcGVydGllcyBoYXZlIG5vIGltcGFjdCBvbiB6ZXJv IHNpemVkIGZpeGVkIHZpZXdwb3J0cy4KKyAgICBpZiAobV9wYWdlLT51c2VGaXhlZExheW91dCgp ICYmICFtX3BhZ2UtPnZpZXdwb3J0U2l6ZSgpLmlzRW1wdHkoKSkgewogICAgICAgICBTZXR0aW5n cyogc2V0dGluZ3MgPSBtX3BhZ2UtPmNvcmVQYWdlKCktPnNldHRpbmdzKCk7CiAKICAgICAgICAg aW50IG1pbmltdW1MYXlvdXRGYWxsYmFja1dpZHRoID0gc3RkOjptYXgoc2V0dGluZ3MtPmxheW91 dEZhbGxiYWNrV2lkdGgoKSwgbV9wYWdlLT52aWV3cG9ydFNpemUoKS53aWR0aCgpKTsK