73434 2011-11-30 05:00:38 -0800 MacroAssemblerSH4 does not implement readCallTarget 2011-12-05 01:41:24 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P1 Blocker --- 73667 1 ossy webkit-unassigned barraclough eric fpizlo loki ossy thouraya.andolsi webkit.review.bot zecke zherczeg oldest_to_newest 511647 0 ossy 2011-11-30 05:00:38 -0800 It is blocker bug, beacuse after http://trac.webkit.org/changeset/101457 Qt-SH4 build is broken. (and all other MIPS build of course) 512672 1 117392 zherczeg 2011-12-01 04:00:36 -0800 Created attachment 117392 speculative patch Could someone who has such machine try this fix first? 513591 2 thouraya.andolsi 2011-12-02 00:44:53 -0800 Hi, I'll try it today. Regards, Thouraya. (In reply to comment #1) > Created an attachment (id=117392) [details] > speculative patch > > Could someone who has such machine try this fix first? 513721 3 thouraya.andolsi 2011-12-02 06:41:00 -0800 Hi, 1509 static FunctionPtr readCallTarget(CodeLocationCall call) >> CodeLocationCall not defined in SH4Assembler.h 1510 { 1511 uint16_t* instructionPtr = call.dataLocation(); 1512 instructionPtr -= 3; 1513 uint32_t addr = readPCrelativeAddress((*instructionPtr & 0xff), instructionPtr) >> missed ; 1514 return FunctionPtr(reinterpret_cast<void(*)()>(addr); >> missed ) 1515 } Regard, Thouraya. 513732 4 zherczeg 2011-12-02 07:08:05 -0800 Does it work (except the typos)? 513735 5 thouraya.andolsi 2011-12-02 07:09:38 -0800 Yes it works. (In reply to comment #4) > Does it work (except the typos)? 513781 6 117392 ossy 2011-12-02 08:28:03 -0800 Comment on attachment 117392 speculative patch r=me with fixing typos mentioned in Comment #3 513785 7 117392 ossy 2011-12-02 08:31:14 -0800 Comment on attachment 117392 speculative patch Landed with typo fixes in http://trac.webkit.org/changeset/101801 513816 8 ossy 2011-12-02 09:03:33 -0800 Reopen, because build is still broken: ../../../../Source/JavaScriptCore/assembler/SH4Assembler.h:1509:39: error: 'CodeLocationCall' has not been declared../../../../Source/JavaScriptCore/assembler/SH4Assembler.h: In static member function 'static JSC::FunctionPtr JSC::SH4Assembler::readCallTarget(int)': ../../../../Source/JavaScriptCore/assembler/SH4Assembler.h:1511:41: error: request for member 'dataLocation' in 'call', which is of non-class type 'int' It would be better if we make a similar change to ARM and MIPS: - http://trac.webkit.org/changeset/101658 - http://trac.webkit.org/changeset/101473 513845 9 zherczeg 2011-12-02 09:38:30 -0800 CodeLocationCall is an int??? 514218 10 eric 2011-12-02 15:17:01 -0800 Does not appear to have fixed things: http://build.webkit.org/builders/Qt%20Linux%20SH4%20Release/builds/2703/steps/compile-webkit/logs/stdio 514429 11 zherczeg 2011-12-02 22:30:10 -0800 ../../../../Source/JavaScriptCore/jit/JITPropertyAccess.cpp: In static member function 'static bool JSC::JIT::isDirectPutById(JSC::StructureStubInfo*)': ../../../../Source/JavaScriptCore/jit/JITPropertyAccess.cpp:1160:25: error: 'readCallTarget' is not a member of 'JSC::MacroAssembler' So I put it into a wrong file. We should move it to MacroAssemblerSH4. 514958 12 117853 zherczeg 2011-12-05 00:39:47 -0800 Created attachment 117853 another attempt 514959 13 117853 ossy 2011-12-05 00:41:39 -0800 Comment on attachment 117853 another attempt Let's see, r=me. 514975 14 117853 ossy 2011-12-05 01:41:15 -0800 Comment on attachment 117853 another attempt Clearing flags on attachment: 117853 Committed r101980: <http://trac.webkit.org/changeset/101980> 514976 15 ossy 2011-12-05 01:41:24 -0800 All reviewed patches have been landed. Closing bug. 117392 2011-12-01 04:00:36 -0800 2011-12-05 00:39:47 -0800 speculative patch 0001-sh4.patch text/plain 1873 zherczeg RnJvbSBhN2VjYzAwMmM0YThhNDgyZjk2MWM4NjI3NmY2YTk2NzIxNGRkMGEwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAd2Via2l0Lm9yZz4K RGF0ZTogVGh1LCAxIERlYyAyMDExIDAzOjU0OjA4IC0wODAwClN1YmplY3Q6IFtQQVRDSF0gc2g0 CgotLS0KIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgfCAg IDEwICsrKysrKysrKysKIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvU0g0QXNzZW1i bGVyLmggfCAgICA4ICsrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKyks IDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggYzRjNzE3Yi4uY2Yy YzY4MyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTIt MDEgIFpvbHRhbiBIZXJjemVnICA8emhlcmN6ZWdAd2Via2l0Lm9yZz4KKworICAgICAgICBNYWNy b0Fzc2VtYmxlclNINCBkb2VzIG5vdCBpbXBsZW1lbnQgcmVhZENhbGxUYXJnZXQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczNDM0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBhc3NlbWJsZXIvU0g0QXNz ZW1ibGVyLmg6CisgICAgICAgIChKU0M6OlNINEFzc2VtYmxlcjo6cmVhZENhbGxUYXJnZXQpOiBT dXBwb3J0IGZvciBTSDQuCisKIDIwMTEtMTEtMzAgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxl LmNvbT4KIAogICAgICAgICBERkcgc2hvdWxkIG1ha2UgaXQgZWFzaWVyIHRvIG5vdGljZSBub2Rl IGJvdW5kYXJpZXMgaW4gZGlzYXNzZW1ibHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9hc3NlbWJsZXIvU0g0QXNzZW1ibGVyLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNz ZW1ibGVyL1NINEFzc2VtYmxlci5oCmluZGV4IGU2NmQwOWYuLmM1NDYwYmIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvU0g0QXNzZW1ibGVyLmgKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9TSDRBc3NlbWJsZXIuaApAQCAtMTUwNiw2ICsx NTA2LDE0IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIHJlYWRQQ3JlbGF0aXZlQWRkcmVzcygo KihyZWludGVycHJldF9jYXN0PHVpbnQxNl90Kj4oY29kZSkpICYgMHhmZiksIHJlaW50ZXJwcmV0 X2Nhc3Q8dWludDE2X3QqPihjb2RlKSk7CiAgICAgfQogCisgICAgc3RhdGljIEZ1bmN0aW9uUHRy IHJlYWRDYWxsVGFyZ2V0KENvZGVMb2NhdGlvbkNhbGwgY2FsbCkKKyAgICB7CisgICAgICAgIHVp bnQxNl90KiBpbnN0cnVjdGlvblB0ciA9IGNhbGwuZGF0YUxvY2F0aW9uKCk7CisgICAgICAgIGlu c3RydWN0aW9uUHRyIC09IDM7CisgICAgICAgIHVpbnQzMl90IGFkZHIgPSByZWFkUENyZWxhdGl2 ZUFkZHJlc3MoKCppbnN0cnVjdGlvblB0ciAmIDB4ZmYpLCBpbnN0cnVjdGlvblB0cikKKyAgICAg ICAgcmV0dXJuIEZ1bmN0aW9uUHRyKHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCgqKSgpPihhZGRyKTsK KyAgICB9CisKICAgICBQYXNzUmVmUHRyPEV4ZWN1dGFibGVNZW1vcnlIYW5kbGU+IGV4ZWN1dGFi bGVDb3B5KEpTR2xvYmFsRGF0YSYgZ2xvYmFsRGF0YSkKICAgICB7CiAgICAgICAgIHJldHVybiBt X2J1ZmZlci5leGVjdXRhYmxlQ29weShnbG9iYWxEYXRhKTsKLS0gCjEuNy4yLjUKCg== 117853 2011-12-05 00:39:47 -0800 2011-12-05 01:41:15 -0800 another attempt 0001-sh4.patch text/plain 2562 zherczeg RnJvbSA5OWQ4ZGRmZGZkYjdmMTEzYzY4MWEwZjQ0MWFjYjM5MDczMmExZGYzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAd2Via2l0Lm9yZz4K RGF0ZTogTW9uLCA1IERlYyAyMDExIDAwOjM3OjQ0IC0wODAwClN1YmplY3Q6IFtQQVRDSF0gc2g0 CgotLS0KIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg IHwgICAxMiArKysrKysrKysrKysKIC4uLi9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9B c3NlbWJsZXJTSDQuaCAgIHwgICAgNSArKysrKwogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2Vt Ymxlci9TSDRBc3NlbWJsZXIuaCAgICAgfCAgICA3ICsrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwg MjQgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpp bmRleCA2YzY3MWZhLi45ZjAyYjJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNSBAQAorMjAxMS0xMi0wNSAgWm9sdGFuIEhlcmN6ZWcgIDx6aGVyY3plZ0B3ZWJraXQub3Jn PgorCisgICAgICAgIE1hY3JvQXNzZW1ibGVyU0g0IGRvZXMgbm90IGltcGxlbWVudCByZWFkQ2Fs bFRhcmdldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzM0MzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclNINC5oOiBTdXBwb3J0IGZvciBTSDQuCisgICAgICAg IChKU0M6Ok1hY3JvQXNzZW1ibGVyU0g0OjpyZWFkQ2FsbFRhcmdldCk6CisgICAgICAgICogYXNz ZW1ibGVyL1NINEFzc2VtYmxlci5oOgorICAgICAgICAoSlNDOjpTSDRBc3NlbWJsZXI6OnJlYWRD YWxsVGFyZ2V0KToKKwogMjAxMS0xMi0wNCAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29t PgogCiAgICAgICAgIERGRyBzaG91bGQgb3B0aW1pemUgc3RyaWN0IGVxdWFsaXR5CmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyU0g0Lmgg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyU0g0LmgKaW5k ZXggYWUzOTc0Mi4uNTkyMjRhYyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fz c2VtYmxlci9NYWNyb0Fzc2VtYmxlclNINC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9h c3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJTSDQuaApAQCAtMTc1OCw2ICsxNzU4LDExIEBAIHB1Ymxp YzoKICAgICAgICAgbV9hc3NlbWJsZXIubm9wKCk7CiAgICAgfQogCisgICAgc3RhdGljIEZ1bmN0 aW9uUHRyIHJlYWRDYWxsVGFyZ2V0KENvZGVMb2NhdGlvbkNhbGwgY2FsbCkKKyAgICB7CisgICAg ICAgIHJldHVybiBGdW5jdGlvblB0cihyZWludGVycHJldF9jYXN0PHZvaWQoKikoKT4oU0g0QXNz ZW1ibGVyOjpyZWFkQ2FsbFRhcmdldChjYWxsLmRhdGFMb2NhdGlvbigpKSkpOworICAgIH0KKwog cHJvdGVjdGVkOgogICAgIFNINEFzc2VtYmxlcjo6Q29uZGl0aW9uIFNINENvbmRpdGlvbihSZWxh dGlvbmFsQ29uZGl0aW9uIGNvbmQpCiAgICAgewpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2Fzc2VtYmxlci9TSDRBc3NlbWJsZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9h c3NlbWJsZXIvU0g0QXNzZW1ibGVyLmgKaW5kZXggZTY2ZDA5Zi4uOTBlMjMyYSAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9TSDRBc3NlbWJsZXIuaAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL1NINEFzc2VtYmxlci5oCkBAIC0xNTA2LDYg KzE1MDYsMTMgQEAgcHVibGljOgogICAgICAgICByZXR1cm4gcmVhZFBDcmVsYXRpdmVBZGRyZXNz KCgqKHJlaW50ZXJwcmV0X2Nhc3Q8dWludDE2X3QqPihjb2RlKSkgJiAweGZmKSwgcmVpbnRlcnBy ZXRfY2FzdDx1aW50MTZfdCo+KGNvZGUpKTsKICAgICB9CiAKKyAgICBzdGF0aWMgdm9pZCogcmVh ZENhbGxUYXJnZXQodm9pZCogZnJvbSkKKyAgICB7CisgICAgICAgIHVpbnQxNl90KiBpbnN0cnVj dGlvblB0ciA9IHN0YXRpY19jYXN0PHVpbnQxNl90Kj4oZnJvbSk7CisgICAgICAgIGluc3RydWN0 aW9uUHRyIC09IDM7CisgICAgICAgIHJldHVybiByZWludGVycHJldF9jYXN0PHZvaWQqPihyZWFk UENyZWxhdGl2ZUFkZHJlc3MoKCppbnN0cnVjdGlvblB0ciAmIDB4ZmYpLCBpbnN0cnVjdGlvblB0 cikpOworICAgIH0KKwogICAgIFBhc3NSZWZQdHI8RXhlY3V0YWJsZU1lbW9yeUhhbmRsZT4gZXhl Y3V0YWJsZUNvcHkoSlNHbG9iYWxEYXRhJiBnbG9iYWxEYXRhKQogICAgIHsKICAgICAgICAgcmV0 dXJuIG1fYnVmZmVyLmV4ZWN1dGFibGVDb3B5KGdsb2JhbERhdGEpOwotLSAKMS43LjIuNQoK