7343 2006-02-18 10:41:21 -0800 REGRESSION: fast/js/toString-overrides.html fails when run multiple times 2006-02-20 08:31:55 -0800 1 1 1 Unclassified WebKit JavaScriptCore 420+ Mac OS X 10.4 VERIFIED FIXED P1 Normal --- 1 mitz webkit-unassigned ggaren oliver oldest_to_newest 33264 0 mitz 2006-02-18 10:41:21 -0800 % run-webkit-tests fast/jstoString-overrides.html fast/js/toString-overrides.html fast/js/toString-overrides.html fast/js/toString-overrides.html fast/js/toString-overrides.html fast/js/toString-overrides.html fast/js/toString-overrides.html fast/js/toString-overrides.html [...] Testing 7 test cases. fast/js ..... fast/js/toString-overrides.html -> failed . fast/js/toString-overrides.html -> failed . fast/js/toString-overrides.html -> failed 4 test cases (57%) succeeded 3 test cases (42%) had incorrect layout A failure looks like this: This test checks for regression against 4147: Array.toString() and toLocaleString() improvements from KDE KJS. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". PASS [1].toString() is '1' PASS [1].toLocaleString() is 'toLocaleString' PASS [1].toLocaleString() is '1' PASS [/r/].toString() is 'toString2' PASS [/r/].toLocaleString() is 'toLocaleString2' PASS [/r/].toLocaleString() is 'toString2' FAIL caught should be true. Was false PASS successfullyParsed is true TEST COMPLETE 33266 1 mitz 2006-02-18 10:45:17 -0800 I can also reproduce this by reloading the test in Safari repeatedly. Eventually it will display FAIL in that line. 33275 2 mitz 2006-02-18 11:23:45 -0800 Undoing the fix for bug 3539 fixes this bug. 33289 3 6590 mitz 2006-02-18 13:09:29 -0800 Created attachment 6590 Remove object from visited elements set before returning an error 33290 4 6590 mjs 2006-02-18 13:30:35 -0800 Comment on attachment 6590 Remove object from visited elements set before returning an error r=me 6590 2006-02-18 13:09:29 -0800 2006-02-18 13:30:35 -0800 Remove object from visited elements set before returning an error 7343_r1.patch text/plain 4071 mitz SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyODg1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDYtMDItIyMgIE1pdHogUGV0 dGVsICA8b3BlbmRhcndpbi5vcmdAbWl0enBldHRlbC5jb20+CisKKyAgICAgICAgVGVzdDogZmFz dC9qcy90b1N0cmluZy1leGNlcHRpb24uaHRtbAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIC0gZml4IGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzM0MworICAgICAgICAgIFJFR1JFU1NJT046IGZhc3QvanMvdG9T dHJpbmctb3ZlcnJpZGVzLmh0bWwgZmFpbHMgd2hlbiBydW4gbXVsdGlwbGUgdGltZXMKKworICAg ICAgICAqIGtqcy9hcnJheV9vYmplY3QuY3BwOgorICAgICAgICAoQXJyYXlQcm90b0Z1bmM6OmNh bGxBc0Z1bmN0aW9uKTogUmVtb3ZlIHRoZSBvYmplY3QgZnJvbSB0aGUgdmlzaXRlZCBlbGVtZW50 cyBzZXQgYmVmb3JlCisgICAgICAgIHJldHVybmluZyBhbiBlcnJvci4KKwogMjAwNi0wMi0xNiAg R2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEpvaG4uCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ranMvYXJyYXlfb2JqZWN0LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ranMvYXJyYXlfb2JqZWN0LmNwcAkocmV2aXNpb24gMTI4 ODQpCisrKyBKYXZhU2NyaXB0Q29yZS9ranMvYXJyYXlfb2JqZWN0LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNTA2LDYgKzUwNiw3IEBAIEpTVmFsdWUgKkFycmF5UHJvdG9GdW5jOjpjYWxsQXNGdW5j dGlvbigKICAgICAgICAgICBpZiAoY29udmVyc2lvbkZ1bmN0aW9uLT5pc09iamVjdCgpICYmIHN0 YXRpY19jYXN0PEpTT2JqZWN0ICo+KGNvbnZlcnNpb25GdW5jdGlvbiktPmltcGxlbWVudHNDYWxs KCkpIHsKICAgICAgICAgICAgIHN0ciArPSBzdGF0aWNfY2FzdDxKU09iamVjdCAqPihjb252ZXJz aW9uRnVuY3Rpb24pLT5jYWxsKGV4ZWMsIG8sIExpc3QoKSktPnRvU3RyaW5nKGV4ZWMpOwogICAg ICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICB2aXNpdGVkRWxlbXMucmVtb3ZlKHRoaXNPYmop OwogICAgICAgICAgICAgcmV0dXJuIHRocm93RXJyb3IoZXhlYywgUmFuZ2VFcnJvciwgIkNhbid0 IGNvbnZlcnQgIiArIG8tPmNsYXNzTmFtZSgpICsgIiBvYmplY3QgdG8gc3RyaW5nIik7CiAgICAg ICAgICAgfQogICAgICAgICB9IGVsc2UgewpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTI4ODUpCisrKyBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAw Ni0wMi0jIyAgTWl0eiBQZXR0ZWwgIDxvcGVuZGFyd2luLm9yZ0BtaXR6cGV0dGVsLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIHRlc3QgZm9y IGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzM0MworICAg ICAgICAgIFJFR1JFU1NJT046IGZhc3QvanMvdG9TdHJpbmctb3ZlcnJpZGVzLmh0bWwgZmFpbHMg d2hlbiBydW4gbXVsdGlwbGUgdGltZXMKKworICAgICAgICAqIGZhc3QvanMvcmVzb3VyY2VzL3Rv U3RyaW5nLWV4Y2VwdGlvbi5qczogQWRkZWQuCisgICAgICAgICogZmFzdC9qcy90b1N0cmluZy1l eGNlcHRpb24tZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2pzL3RvU3RyaW5n LWV4Y2VwdGlvbi5odG1sOiBBZGRlZC4KKwogMjAwNi0wMi0xNyAgTWl0eiBQZXR0ZWwgIDxvcGVu ZGFyd2luLm9yZ0BtaXR6cGV0dGVsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbi4K SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvanMvdG9TdHJpbmctZXhjZXB0aW9uLWV4cGVjdGVkLnR4 dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL3RvU3RyaW5nLWV4Y2VwdGlvbi1l eHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL3RvU3RyaW5n LWV4Y2VwdGlvbi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTAgQEAKK1Ro aXMgdGVzdCBjaGVja3MgZm9yIHJlZ3Jlc3Npb24gYWdhaW5zdCA3MzQzOiBSRUdSRVNTSU9OOiBm YXN0L2pzL3RvU3RyaW5nLW92ZXJyaWRlcy5odG1sIGZhaWxzIHdoZW4gcnVuIG11bHRpcGxlIHRp bWVzLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3Nh Z2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBjYXVnaHQgaXMgdHJ1 ZQorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5k ZXg6IExheW91dFRlc3RzL2Zhc3QvanMvdG9TdHJpbmctZXhjZXB0aW9uLmh0bWwKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9qcy90b1N0cmluZy1leGNlcHRpb24uaHRtbAkocmV2aXNp b24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvanMvdG9TdHJpbmctZXhjZXB0aW9uLmh0bWwJKHJl dmlzaW9uIDApCkBAIC0wLDAgKzEsMTMgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVU Ri8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQi IGhyZWY9InJlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0icmVzb3Vy Y2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRl c2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQgc3JjPSJy ZXNvdXJjZXMvdG9TdHJpbmctZXhjZXB0aW9uLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSJy ZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KSW5k ZXg6IExheW91dFRlc3RzL2Zhc3QvanMvcmVzb3VyY2VzL3RvU3RyaW5nLWV4Y2VwdGlvbi5qcwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL3Jlc291cmNlcy90b1N0cmluZy1leGNl cHRpb24uanMJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL3Jlc291cmNlcy90 b1N0cmluZy1leGNlcHRpb24uanMJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjIgQEAKK2Rlc2Ny aXB0aW9uKAorJ1RoaXMgdGVzdCBjaGVja3MgZm9yIHJlZ3Jlc3Npb24gYWdhaW5zdCA8YSBocmVm PSJodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTczNDMiPjcz NDM6IFJFR1JFU1NJT046IGZhc3QvanMvdG9TdHJpbmctb3ZlcnJpZGVzLmh0bWwgZmFpbHMgd2hl biBydW4gbXVsdGlwbGUgdGltZXM8L2E+LicKKyk7CisKK3ZhciBhID0gW3sgdG9TdHJpbmcgOiAw IH1dOworCit0cnkgeworICAgIGEudG9TdHJpbmcoKTsKK30gY2F0Y2ggKGUpIHsKK30KKwordmFy IGNhdWdodCA9IGZhbHNlOworCit0cnkgeworICBhLnRvU3RyaW5nKCk7Cit9IGNhdGNoIChlKSB7 CitjYXVnaHQgPSB0cnVlOworfQorCitzaG91bGRCZVRydWUoImNhdWdodCIpOworCit2YXIgc3Vj Y2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsK