73427 2011-11-30 04:06:31 -0800 [Gtk] Links should be Tab-focusable by default 2011-11-30 07:32:23 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jdiggs mario cgarcia mario webkit.review.bot oldest_to_newest 511618 0 jdiggs 2011-11-30 04:06:31 -0800 WK2 has a setting to enable/disable the Tab-focusability of links. As discussed via IRC, this should be enabled by default. < xc0ffee> joanie: probably you need to set this property to true, if you want to navigate to links pressing tab.. < xc0ffee> joanie: its false by default.. [...] < xc0ffee> joanie: we can change it to true, if required.. Martin? < joanie> in other words, I think the "normal/expected" behavior is that links are tab-focusable < msanchez> joanie: agreed, at least in the gtk port that was the expected behaviour so far, so I would keep it [...] < msanchez> other option is just to make sure that browsers using wk2 take care of enabling this feature, but that would not be consistent with what browsers WK2 do < msanchez> mrobinson, xc0ffee: what do you think? < joanie> so what shipping browsers lack tab-focusable links? < xc0ffee> joanie: msanchez: makes sense to turn this property true by default for me.. <+mrobinson> joanie: No, it's a switch that they make sure to flip. [...] <+mrobinson> xc0ffee: Seems reasonable to add it to WebKitSettings and have it flipped on by default. 511631 1 117168 mario 2011-11-30 04:36:37 -0800 Created attachment 117168 Patch 511637 2 webkit.review.bot 2011-11-30 04:52:54 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 511663 3 117168 mrobinson 2011-11-30 05:39:01 -0800 Comment on attachment 117168 Patch You need to update the unit test as well. 511690 4 117181 mario 2011-11-30 06:08:53 -0800 Created attachment 117181 Patch 511691 5 mario 2011-11-30 06:09:51 -0800 (In reply to comment #3) > (From update of attachment 117168 [details]) > You need to update the unit test as well. Done. Please feel free to set cq+ too if it's ok this time :-) Thanks 511738 6 117181 webkit.review.bot 2011-11-30 07:32:19 -0800 Comment on attachment 117181 Patch Clearing flags on attachment: 117181 Committed r101514: <http://trac.webkit.org/changeset/101514> 511739 7 webkit.review.bot 2011-11-30 07:32:23 -0800 All reviewed patches have been landed. Closing bug. 117168 2011-11-30 04:36:37 -0800 2011-11-30 06:08:46 -0800 Patch bug-73427-20111130133635.patch text/plain 1687 mario U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzg2ZjM4NWJiMDY4MWY2 ZGFhNTY0M2VhNjIzMjYyZGU3ODdiOGUwOC4uMTJlMjdkMmZjZTI3Nzk5Y2M3ZGQ2NzM5MGM1MWY0 MGZlYzM1N2NiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDExLTExLTMwICBNYXJp byBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR3RrXSBM aW5rcyBzaG91bGQgYmUgVGFiLWZvY3VzYWJsZSBieSBkZWZhdWx0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzQyNworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0 U2V0dGluZ3MuY3BwOgorICAgICAgICAod2Via2l0X3NldHRpbmdzX2NsYXNzX2luaXQpOiBTd2l0 Y2ggdGhlIGRlZmF1bHQgdmFsdWUgZm9yCisgICAgICAgICdlbmFibGUtdGFicy10by1saW5rcycg cHJvcGVydHkgZnJvbSBGQUxTRSB0byBUUlVFLgorCiAyMDExLTExLTI5ICBDYXJsb3MgR2FyY2lh IENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBGaXgg dGhlIEdUSysgcG9ydCBidWlsZCBhZnRlciByMTAxMzA3LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0U2V0dGluZ3MuY3BwIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0U2V0dGluZ3MuY3BwCmluZGV4IDk2MmJhZTRiMDAy YTE1YjEwMDIzNzU0NTU5YTg2YWQzNDJlOWQxZTEuLjA2MGFhYjVhYzZhODcxMTFmMTU1ZDVlMWUx ODZjZDVlM2IwODUxZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Z3RrL1dlYktpdFNldHRpbmdzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2d0ay9XZWJLaXRTZXR0aW5ncy5jcHAKQEAgLTY5MSw3ICs2OTEsNyBAQCBzdGF0aWMgdm9pZCB3 ZWJraXRfc2V0dGluZ3NfY2xhc3NfaW5pdChXZWJLaXRTZXR0aW5nc0NsYXNzKiBrbGFzcykKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdfcGFyYW1fc3BlY19ib29sZWFuKCJl bmFibGUtdGFicy10by1saW5rcyIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBfKCJFbmFibGUgdGFicyB0byBsaW5rcyIpLAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXygiV2hl dGhlciB0byBlbmFibGUgdGFicyB0byBsaW5rcyIpLAotICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRkFMU0UsCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBUUlVFLAogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVhZFdyaXRl Q29uc3RydWN0UGFyYW1GbGFncykpOwogCiAgICAgLyoqCg== 117181 2011-11-30 06:08:53 -0800 2011-11-30 07:32:19 -0800 Patch bug-73427-20111130150851.patch text/plain 2836 mario U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzg2ZjM4NWJiMDY4MWY2 ZGFhNTY0M2VhNjIzMjYyZGU3ODdiOGUwOC4uY2E2MDRkNjc1YmY5MWZmZTdmMTUxMjIwMzQxNDEx NGJkY2ZmM2I2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTExLTMwICBNYXJp byBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR3RrXSBM aW5rcyBzaG91bGQgYmUgVGFiLWZvY3VzYWJsZSBieSBkZWZhdWx0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzQyNworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0 U2V0dGluZ3MuY3BwOgorICAgICAgICAod2Via2l0X3NldHRpbmdzX2NsYXNzX2luaXQpOiBTd2l0 Y2ggdGhlIGRlZmF1bHQgdmFsdWUgZm9yCisgICAgICAgICdlbmFibGUtdGFicy10by1saW5rcycg cHJvcGVydHkgZnJvbSBGQUxTRSB0byBUUlVFLgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3Rr L3Rlc3RzL1Rlc3RXZWJLaXRTZXR0aW5ncy5jcHA6CisgICAgICAgICh0ZXN0V2ViS2l0U2V0dGlu Z3MpOiBVcGRhdGVkIHVuaXQgdGVzdC4KKwogMjAxMS0xMS0yOSAgQ2FybG9zIEdhcmNpYSBDYW1w b3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gRml4IHRoZSBH VEsrIHBvcnQgYnVpbGQgYWZ0ZXIgcjEwMTMwNy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFNldHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFNldHRpbmdzLmNwcAppbmRleCA5NjJiYWU0YjAwMmExNWIx MDAyMzc1NDU1OWE4NmFkMzQyZTlkMWUxLi4wNjBhYWI1YWM2YTg3MTExZjE1NWQ1ZTFlMTg2Y2Q1 ZTNiMDg1MWRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRTZXR0aW5ncy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsv V2ViS2l0U2V0dGluZ3MuY3BwCkBAIC02OTEsNyArNjkxLDcgQEAgc3RhdGljIHZvaWQgd2Via2l0 X3NldHRpbmdzX2NsYXNzX2luaXQoV2ViS2l0U2V0dGluZ3NDbGFzcyoga2xhc3MpCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnX3BhcmFtX3NwZWNfYm9vbGVhbigiZW5hYmxl LXRhYnMtdG8tbGlua3MiLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgXygiRW5hYmxlIHRhYnMgdG8gbGlua3MiKSwKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF8oIldoZXRoZXIg dG8gZW5hYmxlIHRhYnMgdG8gbGlua3MiKSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIEZBTFNFLAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgVFJVRSwKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlYWRXcml0ZUNvbnN0 cnVjdFBhcmFtRmxhZ3MpKTsKIAogICAgIC8qKgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdFdlYktpdFNldHRpbmdzLmNwcCBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RXZWJLaXRTZXR0aW5ncy5jcHAKaW5k ZXggNzVmMjg2YmFjYWI3NDNiZmUxOWE3NjY4ZWMxZmY2YzRlNDQ4MDVmNS4uMTA3ODgwNzA0YzJk MmEzNjgxNmQ4NjZlZDhiM2FkMTRhNzM1MjM5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdFdlYktpdFNldHRpbmdzLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0V2ViS2l0U2V0dGluZ3MuY3Bw CkBAIC0xNjksOSArMTY5LDkgQEAgc3RhdGljIHZvaWQgdGVzdFdlYktpdFNldHRpbmdzKFRlc3Qq LCBnY29uc3Rwb2ludGVyKQogICAgIHdlYmtpdF9zZXR0aW5nc19zZXRfZW5hYmxlX3Jlc2l6YWJs ZV90ZXh0X2FyZWFzKHNldHRpbmdzLCBGQUxTRSk7CiAgICAgZ19hc3NlcnQoIXdlYmtpdF9zZXR0 aW5nc19nZXRfZW5hYmxlX3Jlc2l6YWJsZV90ZXh0X2FyZWFzKHNldHRpbmdzKSk7CiAKLSAgICBn X2Fzc2VydCghd2Via2l0X3NldHRpbmdzX2dldF9lbmFibGVfdGFic190b19saW5rcyhzZXR0aW5n cykpOwotICAgIHdlYmtpdF9zZXR0aW5nc19zZXRfZW5hYmxlX3RhYnNfdG9fbGlua3Moc2V0dGlu Z3MsIFRSVUUpOwogICAgIGdfYXNzZXJ0KHdlYmtpdF9zZXR0aW5nc19nZXRfZW5hYmxlX3RhYnNf dG9fbGlua3Moc2V0dGluZ3MpKTsKKyAgICB3ZWJraXRfc2V0dGluZ3Nfc2V0X2VuYWJsZV90YWJz X3RvX2xpbmtzKHNldHRpbmdzLCBGQUxTRSk7CisgICAgZ19hc3NlcnQoIXdlYmtpdF9zZXR0aW5n c19nZXRfZW5hYmxlX3RhYnNfdG9fbGlua3Moc2V0dGluZ3MpKTsKIAogICAgIC8vIENhcmV0IGJy b3dzaW5nIGlzIGRpc2FibGVkIGJ5IGRlZmF1bHQuCiAgICAgZ19hc3NlcnQoIXdlYmtpdF9zZXR0 aW5nc19nZXRfZW5hYmxlX2NhcmV0X2Jyb3dzaW5nKHNldHRpbmdzKSk7Cg==