73413 2011-11-30 01:42:01 -0800 MacroAssemblerARM does not implement readCallTarget 2011-11-30 11:09:34 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo ossy loki ossy zherczeg oldest_to_newest 511519 0 fpizlo 2011-11-30 01:42:01 -0800 Patch forthcoming 511520 1 117141 fpizlo 2011-11-30 01:43:34 -0800 Created attachment 117141 the patch 511527 2 117141 fpizlo 2011-11-30 01:51:22 -0800 Comment on attachment 117141 the patch Marking cq? because I'm going to bed. 511555 3 117141 ossy 2011-11-30 02:23:51 -0800 Comment on attachment 117141 the patch r- now, because it doesn't build. I'm going to fix it ASAP. 511556 4 117150 ossy 2011-11-30 02:31:48 -0800 Created attachment 117150 Patch 511571 5 117150 loki 2011-11-30 02:50:35 -0800 Comment on attachment 117150 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117150&action=review > Source/JavaScriptCore/assembler/ARMAssembler.h:800 > + return reinterpret_cast<void*>(readPointer(reinterpret_cast<void*>(getAbsoluteJumpAddress(from)))); No need for that outer reinterpret_cast, the readPointer return with void*. The patch runs without any js regression, rs=me ;) 511591 6 117150 ossy 2011-11-30 03:09:21 -0800 Comment on attachment 117150 Patch Landed in http://trac.webkit.org/changeset/101473 511914 7 fpizlo 2011-11-30 11:09:34 -0800 (In reply to comment #6) > (From update of attachment 117150 [details]) > Landed in http://trac.webkit.org/changeset/101473 Thanks for fixing this! 117141 2011-11-30 01:43:34 -0800 2011-11-30 02:31:36 -0800 the patch fixarm_patch_1.diff text/plain 1872 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTAxNDY1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDExLTExLTMwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg TWFjcm9Bc3NlbWJsZXJBUk0gZG9lcyBub3QgaW1wbGVtZW50IHJlYWRDYWxsVGFyZ2V0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzQxMworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYXNzZW1ibGVyL0FS TUFzc2VtYmxlci5oOgorICAgICAgICAoSlNDOjpBUk1Bc3NlbWJsZXI6OnJlYWRDYWxsVGFyZ2V0 KToKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaDoKKyAgICAgICAgKEpT Qzo6TWFjcm9Bc3NlbWJsZXJBUk06OnJlYWRDYWxsVGFyZ2V0KToKKwogMjAxMS0xMS0yOSAgRmls aXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFJlc2V0dGluZyBhIHB1dF9i eV9pZCBpbmxpbmUgY2FjaGUgc2hvdWxkIHByZXNlcnZlIHRoZSAiaXNEaXJlY3QiIGJpdApJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk1Bc3NlbWJsZXIuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTUFzc2VtYmxlci5oCShy ZXZpc2lvbiAxMDE0NTUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTUFz c2VtYmxlci5oCSh3b3JraW5nIGNvcHkpCkBAIC03OTQsNiArNzk0LDExIEBAIG5hbWVzcGFjZSBK U0MgewogICAgICAgICB7CiAgICAgICAgICAgICBwYXRjaFBvaW50ZXJJbnRlcm5hbChnZXRBYnNv bHV0ZUp1bXBBZGRyZXNzKGZyb20pLCB0byk7CiAgICAgICAgIH0KKyAgICAgICAgCisgICAgICAg IHN0YXRpYyB2b2lkIHJlYWRDYWxsVGFyZ2V0KHZvaWQqIGZyb20pCisgICAgICAgIHsKKyAgICAg ICAgICAgIHJldHVybiByZWFkUG9pbnRlcihnZXRBYnNvbHV0ZUp1bXBBZGRyZXNzKGZyb20pKTsK KyAgICAgICAgfQogCiAgICAgICAgIC8vIEFkZHJlc3Mgb3BlcmF0aW9ucwogCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5o CShyZXZpc2lvbiAxMDE0NTUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01h Y3JvQXNzZW1ibGVyQVJNLmgJKHdvcmtpbmcgY29weSkKQEAgLTk0Nyw2ICs5NDcsMTEgQEAgcHVi bGljOgogICAgICAgICBtX2Fzc2VtYmxlci5ub3AoKTsKICAgICB9CiAKKyAgICBzdGF0aWMgRnVu Y3Rpb25QdHIgcmVhZENhbGxUYXJnZXQoQ29kZUxvY2F0aW9uQ2FsbCBjYWxsKQorICAgIHsKKyAg ICAgICAgcmV0dXJuIEFSTXY3QXNzZW1ibGVyOjpyZWFkQ2FsbFRhcmdldChjYWxsLmRhdGFMb2Nh dGlvbigpKTsKKyAgICB9CisKIHByb3RlY3RlZDoKICAgICBBUk1Bc3NlbWJsZXI6OkNvbmRpdGlv biBBUk1Db25kaXRpb24oUmVsYXRpb25hbENvbmRpdGlvbiBjb25kKQogICAgIHsK 117150 2011-11-30 02:31:48 -0800 2011-11-30 03:09:20 -0800 Patch bug-73413-20111130103146.patch text/plain 2247 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxNDY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy NDY5YzJhMGM1OTFmZDVhMmU5NmVmYTY4MGU5NzcwZjhkYzViMGM2Li45NzZiZDZiMmRkYjBlOTQ3 MjhkMGMxOTdiM2Y1OTU3OGYzMmM2NTE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxMS0xMS0zMCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIE1hY3JvQXNzZW1ibGVyQVJNIGRvZXMgbm90IGltcGxlbWVudCByZWFk Q2FsbFRhcmdldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzM0MTMKKworICAgICAgICBCYXNlZCBvbiBGaWxpcCBQaXpsbydzIHBhdGNoLgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYXNzZW1ibGVyL0FS TUFzc2VtYmxlci5oOgorICAgICAgICAoSlNDOjpBUk1Bc3NlbWJsZXI6OnJlYWRDYWxsVGFyZ2V0 KToKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaDoKKyAgICAgICAgKEpT Qzo6TWFjcm9Bc3NlbWJsZXJBUk06OnJlYWRDYWxsVGFyZ2V0KToKKwogMjAxMS0xMS0yOSAgRmls aXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFJlc2V0dGluZyBhIHB1dF9i eV9pZCBpbmxpbmUgY2FjaGUgc2hvdWxkIHByZXNlcnZlIHRoZSAiaXNEaXJlY3QiIGJpdApkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk1Bc3NlbWJsZXIuaCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNQXNzZW1ibGVyLmgKaW5kZXggMDY2 NzNkMDcyOWNkYjUwMjQ1Y2Q3Mjk5Yzc3OGQ0M2ZhYTZmNzllZS4uNTc5MmQyYzBmMmQ2YTVjMWQw MDI1ODE2NmVjZDdkZjE2NjY0NGM0OCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2Fzc2VtYmxlci9BUk1Bc3NlbWJsZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNz ZW1ibGVyL0FSTUFzc2VtYmxlci5oCkBAIC03OTUsNiArNzk1LDExIEBAIG5hbWVzcGFjZSBKU0Mg ewogICAgICAgICAgICAgcGF0Y2hQb2ludGVySW50ZXJuYWwoZ2V0QWJzb2x1dGVKdW1wQWRkcmVz cyhmcm9tKSwgdG8pOwogICAgICAgICB9CiAKKyAgICAgICAgc3RhdGljIHZvaWQqIHJlYWRDYWxs VGFyZ2V0KHZvaWQqIGZyb20pCisgICAgICAgIHsKKyAgICAgICAgICAgIHJldHVybiByZWludGVy cHJldF9jYXN0PHZvaWQqPihyZWFkUG9pbnRlcihyZWludGVycHJldF9jYXN0PHZvaWQqPihnZXRB YnNvbHV0ZUp1bXBBZGRyZXNzKGZyb20pKSkpOworICAgICAgICB9CisKICAgICAgICAgLy8gQWRk cmVzcyBvcGVyYXRpb25zCiAKICAgICAgICAgc3RhdGljIHZvaWQqIGdldFJlbG9jYXRlZEFkZHJl c3Modm9pZCogY29kZSwgQXNzZW1ibGVyTGFiZWwgbGFiZWwpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmggYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgKaW5kZXggZWRiZGU1ZTA3 MWFjNmY2MjZiZWRkZDEwZjNhNjlmYWM1MzZjMGI4OC4uYzMxZTEyOGYxZDA2NzUwYjYyODZlMDNh NDA5YjAwYTlmYTcyN2ZjOCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2Vt Ymxlci9NYWNyb0Fzc2VtYmxlckFSTS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3Nl bWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaApAQCAtOTQ3LDYgKzk0NywxMSBAQCBwdWJsaWM6CiAg ICAgICAgIG1fYXNzZW1ibGVyLm5vcCgpOwogICAgIH0KIAorICAgIHN0YXRpYyBGdW5jdGlvblB0 ciByZWFkQ2FsbFRhcmdldChDb2RlTG9jYXRpb25DYWxsIGNhbGwpCisgICAgeworICAgICAgICBy ZXR1cm4gRnVuY3Rpb25QdHIocmVpbnRlcnByZXRfY2FzdDx2b2lkKCopKCk+KEFSTUFzc2VtYmxl cjo6cmVhZENhbGxUYXJnZXQoY2FsbC5kYXRhTG9jYXRpb24oKSkpKTsKKyAgICB9CisKIHByb3Rl Y3RlZDoKICAgICBBUk1Bc3NlbWJsZXI6OkNvbmRpdGlvbiBBUk1Db25kaXRpb24oUmVsYXRpb25h bENvbmRpdGlvbiBjb25kKQogICAgIHsK