<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>73405</bug_id>
          
          <creation_ts>2011-11-30 00:06:11 -0800</creation_ts>
          <short_desc>When playing audio in &lt;video&gt;, the poster is hidden on play</short_desc>
          <delta_ts>2011-12-01 09:01:56 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Media</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://goo.gl/0g77d</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jeroen Wijering">mail</reporter>
          <assigned_to name="Eric Carlson">eric.carlson</assigned_to>
          <cc>eric.carlson</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>511448</commentid>
    <comment_count>0</comment_count>
    <who name="Jeroen Wijering">mail</who>
    <bug_when>2011-11-30 00:06:11 -0800</bug_when>
    <thetext>Playing an audio file in &lt;video&gt; is allowed and works fine. However, when the audio starts playing, the poster image is removed. 

Per the spec, the poster image should stay visible:

&quot;When no video data is available (... the media resource does not have a video channel), the video element represents the poster frame.&quot;

This also provides a better experience. A poster image is nicer than a white screen.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>512048</commentid>
    <comment_count>1</comment_count>
    <who name="Eric Carlson">eric.carlson</who>
    <bug_when>2011-11-30 13:01:56 -0800</bug_when>
    <thetext>Safari on 10.7.2 behaves correctly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>512050</commentid>
    <comment_count>2</comment_count>
    <who name="Eric Carlson">eric.carlson</who>
    <bug_when>2011-11-30 13:04:38 -0800</bug_when>
    <thetext>But Safari 5.1 on 10.6.8 does not, so it apparently depends on the media engine.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>512057</commentid>
    <comment_count>3</comment_count>
    <who name="Eric Carlson">eric.carlson</who>
    <bug_when>2011-11-30 13:08:38 -0800</bug_when>
    <thetext>We display the poster until HTMLVideoElement::hasAvailableVideoFrame returns true. That method asks the media engine if has video to display. The QTKit based method (MediaPlayerPrivateQTKit::hasAvailableVideoFrame) can&apos;t tell if a QTMovieLayer actually has frames ready to display, but it also doesn&apos;t check to see if the movie has video at all.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>512100</commentid>
    <comment_count>4</comment_count>
    <who name="Eric Carlson">eric.carlson</who>
    <bug_when>2011-11-30 13:53:09 -0800</bug_when>
    <thetext>This could be fixed in each of the media engines that have a problem (at least QTKit, QuickTime, and Chrome), or by adding one test to HTMLVideoElement. I am going to go with the later.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>512102</commentid>
    <comment_count>5</comment_count>
      <attachid>117265</attachid>
    <who name="Eric Carlson">eric.carlson</who>
    <bug_when>2011-11-30 13:53:53 -0800</bug_when>
    <thetext>Created attachment 117265
Proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>512361</commentid>
    <comment_count>6</comment_count>
      <attachid>117265</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2011-11-30 19:35:14 -0800</bug_when>
    <thetext>Comment on attachment 117265
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117265&amp;action=review

&gt; Source/WebCore/ChangeLog:8
&gt; +        No new tests. (OOPS!)

Bad to not have tests.

Also can’t land the patch without removing the OOPS ;-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>512813</commentid>
    <comment_count>7</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2011-12-01 09:01:07 -0800</bug_when>
    <thetext>&lt;rdar://problem/10511668&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>512815</commentid>
    <comment_count>8</comment_count>
    <who name="Eric Carlson">eric.carlson</who>
    <bug_when>2011-12-01 09:01:56 -0800</bug_when>
    <thetext>http://trac.webkit.org/changeset/101675</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>117265</attachid>
            <date>2011-11-30 13:53:53 -0800</date>
            <delta_ts>2011-11-30 19:35:14 -0800</delta_ts>
            <desc>Proposed patch</desc>
            <filename>patch_poster_no_video.txt</filename>
            <type>text/plain</type>
            <size>1276</size>
            <attacher name="Eric Carlson">eric.carlson</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMTU1MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDExLTExLTMwICBFcmljIENh
cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFdoZW4gcGxheWluZyBh
dWRpbyBpbiA8dmlkZW8+LCB0aGUgcG9zdGVyIGlzIGhpZGRlbiBvbiBwbGF5CisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzQwNQorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMh
KQorCisgICAgICAgICogaHRtbC9IVE1MVmlkZW9FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNv
cmU6OkhUTUxWaWRlb0VsZW1lbnQ6Omhhc0F2YWlsYWJsZVZpZGVvRnJhbWUpOiBEb24ndCByZXR1
cm4gdHJ1ZSBpZiB0aGUgZmlsZQorICAgICAgICAgICAgZG9lc24ndCBoYXZlIHZpZGVvLgorCiAy
MDExLTExLTMwICBEYXZpZCBMZXZpbiAgPGxldmluQGNocm9taXVtLm9yZz4KIAogICAgICAgICBN
YWtlIEZyYW1lVmlldyB1c2UgVGVtcG9yYXJpbHlDaGFuZ2UgaW4gYSBmZXcgcGxhY2VzLgpJbmRl
eDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVmlkZW9FbGVtZW50LmNwcAo9PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t
LSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxWaWRlb0VsZW1lbnQuY3BwCShyZXZpc2lvbiAxMDEy
NjMpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxWaWRlb0VsZW1lbnQuY3BwCSh3b3JraW5n
IGNvcHkpCkBAIC0yMzcsNyArMjM3LDcgQEAgYm9vbCBIVE1MVmlkZW9FbGVtZW50OjpoYXNBdmFp
bGFibGVWaWRlbwogICAgIGlmICghcGxheWVyKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAg
ICAKLSAgICByZXR1cm4gcGxheWVyKCktPmhhc0F2YWlsYWJsZVZpZGVvRnJhbWUoKTsKKyAgICBy
ZXR1cm4gcGxheWVyKCktPmhhc1ZpZGVvKCkgJiYgcGxheWVyKCktPmhhc0F2YWlsYWJsZVZpZGVv
RnJhbWUoKTsKIH0KIAogdm9pZCBIVE1MVmlkZW9FbGVtZW50Ojp3ZWJraXRFbnRlckZ1bGxzY3Jl
ZW4oRXhjZXB0aW9uQ29kZSYgZWMpCg==
</data>
<flag name="review"
          id="116649"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>