73401 2011-11-29 22:30:33 -0800 [EFL] Revise ewk_view_fixed_layout_size_set 2011-12-03 15:32:34 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 kevin.cs.oh webkit-unassigned gyuyoung.kim lucas.de.marchi webkit.review.bot oldest_to_newest 511402 0 kevin.cs.oh 2011-11-29 22:30:33 -0800 Improve readability and replace forceLayout to setNeedsLayout since it sometimes causes double drawing. 513625 1 117592 kevin.cs.oh 2011-12-02 02:11:46 -0800 Created attachment 117592 Proposed patch 513627 2 webkit.review.bot 2011-12-02 02:14:28 -0800 Attachment 117592 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource RA layer request failed: OPTIONS of 'http://svn.webkit.org/repository/webkit': could not connect to server (http://svn.webkit.org) at /usr/lib/git-core/git-svn line 2295 Died at Tools/Scripts/update-webkit line 158. If any of these errors are false positives, please file a bug against check-webkit-style. 514581 3 117592 eric 2011-12-03 14:18:27 -0800 Comment on attachment 117592 Proposed patch OK. 514589 4 117592 webkit.review.bot 2011-12-03 15:32:30 -0800 Comment on attachment 117592 Proposed patch Clearing flags on attachment: 117592 Committed r101937: <http://trac.webkit.org/changeset/101937> 514590 5 webkit.review.bot 2011-12-03 15:32:34 -0800 All reviewed patches have been landed. Closing bug. 117592 2011-12-02 02:11:46 -0800 2011-12-03 15:32:30 -0800 Proposed patch P73401.patch text/plain 2122 kevin.cs.oh SW5kZXg6IFNvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMTU5MikKKysrIFNvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDExLTExLTMw ICBDaGFuZ1Nlb2sgT2ggIDxzaGl2YW1pZG93QGdtYWlsLmNvbT4KKworICAgICAgICBbRUZMXSBS ZXZpc2UgZXdrX3ZpZXdfZml4ZWRfbGF5b3V0X3NpemVfc2V0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzQwMQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcHJvdmUgcmVhZGFiaWxpdHkgYW5kIHJlcGxh Y2UgZm9yY2VMYXlvdXQgdG8gc2V0TmVlZHNMYXlvdXQsCisgICAgICAgIHNpbmNlIGl0IHNvbWV0 aW1lcyBjYXVzZXMgZG91YmxlIGRyYXdpbmcuCisKKyAgICAgICAgKiBld2svZXdrX3ZpZXcuY3Bw OgorICAgICAgICAoZXdrX3ZpZXdfZml4ZWRfbGF5b3V0X3NpemVfc2V0KToKKwogMjAxMS0xMS0z MCAgSnVuZ0ppayBMZWUgIDxqdW5namlrLmxlZUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZM XSBBcHBseSBhbHBoYSBjaGFubmVsIGludG8gZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmUncyB0aWxl IG9iamVjdHMuCkluZGV4OiBTb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAJKHJldmlzaW9uIDEw MTQ0OSkKKysrIFNvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTExNjQsMjIgKzExNjQsMjMgQEAgdm9pZCBld2tfdmlld19maXhlZF9sYXlvdXRfc2l6 ZV9zZXQoRXZhcwogICAgIEVXS19WSUVXX1BSSVZfR0VUX09SX1JFVFVSTihzbWFydERhdGEsIHBy aXYpOwogCiAgICAgV2ViQ29yZTo6RnJhbWVWaWV3KiB2aWV3ID0gcHJpdi0+bWFpbkZyYW1lLT52 aWV3KCk7Ci0gICAgaWYgKHdpZHRoIDw9IDAgJiYgaGVpZ2h0IDw9IDApIHsKKyAgICBpZiAoIXZp ZXcpCisgICAgICAgIHJldHVybjsKKworICAgIFdlYkNvcmU6OkludFNpemUgbGF5b3V0U2l6ZSh3 aWR0aCwgaGVpZ2h0KTsKKyAgICBpZiAobGF5b3V0U2l6ZS53aWR0aCgpIDw9IDAgJiYgbGF5b3V0 U2l6ZS5oZWlnaHQoKSA8PSAwKSB7CiAgICAgICAgIGlmICghdmlldy0+dXNlRml4ZWRMYXlvdXQo KSkKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgdmlldy0+c2V0VXNlRml4ZWRMYXlvdXQo ZmFsc2UpOwogICAgIH0gZWxzZSB7Ci0gICAgICAgIFdlYkNvcmU6OkludFNpemUgc2l6ZSA9IHZp ZXctPmZpeGVkTGF5b3V0U2l6ZSgpOwotICAgICAgICBpZiAoc2l6ZS53aWR0aCgpID09IHdpZHRo ICYmIHNpemUuaGVpZ2h0KCkgPT0gaGVpZ2h0KQorICAgICAgICBXZWJDb3JlOjpJbnRTaXplIGZp eGVkTGF5b3V0U2l6ZSA9IHZpZXctPmZpeGVkTGF5b3V0U2l6ZSgpOworICAgICAgICBpZiAoZml4 ZWRMYXlvdXRTaXplID09IGxheW91dFNpemUpCiAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAg IGlmICh2aWV3KQotICAgICAgICAgICAgdmlldy0+c2V0Rml4ZWRMYXlvdXRTaXplKFdlYkNvcmU6 OkludFNpemUod2lkdGgsIGhlaWdodCkpOworICAgICAgICB2aWV3LT5zZXRGaXhlZExheW91dFNp emUobGF5b3V0U2l6ZSk7CisgICAgICAgIHZpZXctPnNldFVzZUZpeGVkTGF5b3V0KHRydWUpOwog ICAgIH0KIAotICAgIGlmICghdmlldykKLSAgICAgICAgcmV0dXJuOwotICAgIHZpZXctPnNldFVz ZUZpeGVkTGF5b3V0KHRydWUpOwotICAgIHZpZXctPmZvcmNlTGF5b3V0KCk7CisgICAgdmlldy0+ c2V0TmVlZHNMYXlvdXQoKTsKIH0KIAogdm9pZCBld2tfdmlld19maXhlZF9sYXlvdXRfc2l6ZV9n ZXQoY29uc3QgRXZhc19PYmplY3QqIGV3a1ZpZXcsIEV2YXNfQ29vcmQqIHdpZHRoLCBFdmFzX0Nv b3JkKiBoZWlnaHQpCg==