73399 2011-11-29 22:14:39 -0800 Add adoptCF and adoptNS convenience functions to RetainPtr.h 2011-11-30 10:25:54 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam oldest_to_newest 511392 0 sam 2011-11-29 22:14:39 -0800 Add adoptCF and adoptNS convenience functions to RetainPtr.h 511393 1 117124 sam 2011-11-29 22:15:37 -0800 Created attachment 117124 Patch 511842 2 117124 andersca 2011-11-30 10:09:16 -0800 Comment on attachment 117124 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117124&action=review > Source/JavaScriptCore/wtf/RetainPtr.h:267 > + template<typename T> inline RetainPtr<T> adoptCF(T o) > + { > + return RetainPtr<T>(AdoptCF, o); > + } > + > + template<typename T> inline RetainPtr<T> adoptNS(T o) > + { > + return RetainPtr<T>(AdoptNS, o); > + } > + Please decorate these with WARN_UNUSED_RESULT. 511859 3 sam 2011-11-30 10:25:54 -0800 Committed r101528: <http://trac.webkit.org/changeset/101528> 117124 2011-11-29 22:15:37 -0800 2011-11-30 10:09:16 -0800 Patch bug-73399-20111129221536.patch text/plain 1625 sam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTAxNDUwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDExLTExLTI5ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWRk IGFkb3B0Q0YgYW5kIGFkb3B0TlMgY29udmVuaWVuY2UgZnVuY3Rpb25zIHRvIFJldGFpblB0ci5o CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzM5OQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1Jl dGFpblB0ci5oOgorICAgICAgICAoV1RGOjphZG9wdENGKToKKyAgICAgICAgKFdURjo6YWRvcHRO Uyk6CisgICAgICAgIFRoZXNlIGFkb3B0aW9uIGZ1bmN0aW9ucyBtYXRjaCB0aGUgcGF0dGVybiB3 ZSB1c2UgaW4gb3RoZXIKKyAgICAgICAgc21hcnQgcG9pbnRlciBjbGFzc2VzLgorCiAyMDExLTEx LTI5ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVtb3ZlIFJldGFp blB0cjo6cmVsZWFzZVJlZgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9SZXRhaW5Q dHIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1JldGFpblB0ci5o CShyZXZpc2lvbiAxMDE0NTApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1JldGFpblB0 ci5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNTUsNiArMjU1LDE2IEBAIG5hbWVzcGFjZSBXVEYgewog ICAgICAgICByZXR1cm4gYSAhPSBiLmdldCgpOyAKICAgICB9CiAKKyAgICB0ZW1wbGF0ZTx0eXBl bmFtZSBUPiBpbmxpbmUgUmV0YWluUHRyPFQ+IGFkb3B0Q0YoVCBvKQorICAgIHsKKyAgICAgICAg cmV0dXJuIFJldGFpblB0cjxUPihBZG9wdENGLCBvKTsKKyAgICB9CisKKyAgICB0ZW1wbGF0ZTx0 eXBlbmFtZSBUPiBpbmxpbmUgUmV0YWluUHRyPFQ+IGFkb3B0TlMoVCBvKQorICAgIHsKKyAgICAg ICAgcmV0dXJuIFJldGFpblB0cjxUPihBZG9wdE5TLCBvKTsKKyAgICB9CisKICAgICB0ZW1wbGF0 ZTx0eXBlbmFtZSBQPiBzdHJ1Y3QgSGFzaFRyYWl0czxSZXRhaW5QdHI8UD4gPiA6IFNpbXBsZUNs YXNzSGFzaFRyYWl0czxSZXRhaW5QdHI8UD4gPiB7IH07CiAgICAgCiAgICAgdGVtcGxhdGU8dHlw ZW5hbWUgUD4gc3RydWN0IFB0ckhhc2g8UmV0YWluUHRyPFA+ID4gOiBQdHJIYXNoPHR5cGVuYW1l IFJldGFpblB0cjxQPjo6UHRyVHlwZT4gewpAQCAtMjcyLDYgKzI4Miw4IEBAIG5hbWVzcGFjZSBX VEYgewogCiB1c2luZyBXVEY6OkFkb3B0Q0Y7CiB1c2luZyBXVEY6OkFkb3B0TlM7Cit1c2luZyBX VEY6OmFkb3B0Q0Y7Cit1c2luZyBXVEY6OmFkb3B0TlM7CiB1c2luZyBXVEY6OlJldGFpblB0cjsK IAogI2VuZGlmIC8vIFdURl9SZXRhaW5QdHJfaAo=