73393 2011-11-29 21:20:51 -0800 Add move semantics to RetainPtr 2011-11-29 21:42:18 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam webkit.review.bot oldest_to_newest 511357 0 sam 2011-11-29 21:20:51 -0800 Add move semantics to RetainPtr 511360 1 117116 sam 2011-11-29 21:24:18 -0800 Created attachment 117116 Patch 511361 2 webkit.review.bot 2011-11-29 21:25:50 -0800 Attachment 117116 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/RetainPtr.h:99: Missing spaces around && [whitespace/operators] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 511364 3 sam 2011-11-29 21:29:09 -0800 I filed https://bugs.webkit.org/show_bug.cgi?id=73395 about the style violation. The style checker does not seem to understand rvalue references. 511374 4 sam 2011-11-29 21:42:18 -0800 Committed r101448: <http://trac.webkit.org/changeset/101448> 117116 2011-11-29 21:24:18 -0800 2011-11-29 21:40:08 -0800 Patch bug-73393-20111129212417.patch text/plain 4221 sam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTAxNDQ1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDExLTExLTI5ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWRk IG1vdmUgc2VtYW50aWNzIHRvIFJldGFpblB0cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzMzOTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9SZXRhaW5QdHIuaDoKKyAgICAgICAgKFdURjo6UmV0 YWluUHRyOjpSZXRhaW5QdHIpOgorICAgICAgICBBZGQgYSBtb3ZlIGNvbnN0cnVjdG9yIGFuZCBt b3ZlIGVuYWJsZWQgYXNzaWdubWVudCBvcGVyYXRvcnMKKyAgICAgICAgdG8gUmV0YWluUHRyIGlm IHRoZSBjb21waWxlciBiZWluZyB1c2VkIHN1cHBvcnRzIHJ2YWx1ZQorICAgICAgICByZWZlcmVu Y2VzLiBJZiB0aGUgY29tcGlsZXIgZG9lcyBub3Qgc3VwcG9ydCBpdCwgd2UgZmFsbGJhY2sKKyAg ICAgICAgdG8gdGhlIGNvcHkgc2VtYW50aWNzIHdlIGhhdmUgYWx3YXlzIGhhZC4KKwogMjAxMS0x MS0yOSAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBDT01QSUxF Ul9TVVBQT1JUUyBtYWNybyB0byBhbGxvdyBmb3IgY29tcGlsZXIgZmVhdHVyZSB0ZXN0aW5nCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1JldGFpblB0ci5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUmV0YWluUHRyLmgJKHJldmlzaW9uIDEwMTQwMSkK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUmV0YWluUHRyLmgJKHdvcmtpbmcgY29weSkK QEAgLTY1LDYgKzY1LDEwIEBAIG5hbWVzcGFjZSBXVEYgewogICAgICAgICAKICAgICAgICAgUmV0 YWluUHRyKGNvbnN0IFJldGFpblB0ciYgbykgOiBtX3B0cihvLm1fcHRyKSB7IGlmIChQdHJUeXBl IHB0ciA9IG1fcHRyKSBDRlJldGFpbihwdHIpOyB9CiAKKyNpZiBDT01QSUxFUl9TVVBQT1JUUyhD WFhfUlZBTFVFX1JFRkVSRU5DRVMpCisgICAgICAgIFJldGFpblB0cihSZXRhaW5QdHImJiBvKSA6 IG1fcHRyKG8ubGVha1JlZigpKSB7IH0KKyNlbmRpZgorCiAgICAgICAgIC8vIEhhc2ggdGFibGUg ZGVsZXRlZCB2YWx1ZXMsIHdoaWNoIGFyZSBvbmx5IGNvbnN0cnVjdGVkIGFuZCBuZXZlciBjb3Bp ZWQgb3IgZGVzdHJveWVkLgogICAgICAgICBSZXRhaW5QdHIoSGFzaFRhYmxlRGVsZXRlZFZhbHVl VHlwZSkgOiBtX3B0cihoYXNoVGFibGVEZWxldGVkVmFsdWUoKSkgeyB9CiAgICAgICAgIGJvb2wg aXNIYXNoVGFibGVEZWxldGVkVmFsdWUoKSBjb25zdCB7IHJldHVybiBtX3B0ciA9PSBoYXNoVGFi bGVEZWxldGVkVmFsdWUoKTsgfQpAQCAtOTAsNiArOTQsMTIgQEAgbmFtZXNwYWNlIFdURiB7CiAg ICAgICAgIHRlbXBsYXRlPHR5cGVuYW1lIFU+IFJldGFpblB0ciYgb3BlcmF0b3I9KGNvbnN0IFJl dGFpblB0cjxVPiYpOwogICAgICAgICBSZXRhaW5QdHImIG9wZXJhdG9yPShQdHJUeXBlKTsKICAg ICAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVT4gUmV0YWluUHRyJiBvcGVyYXRvcj0oVSopOworCisj aWYgQ09NUElMRVJfU1VQUE9SVFMoQ1hYX1JWQUxVRV9SRUZFUkVOQ0VTKQorICAgICAgICBSZXRh aW5QdHImIG9wZXJhdG9yPShSZXRhaW5QdHImJik7CisgICAgICAgIHRlbXBsYXRlPHR5cGVuYW1l IFU+IFJldGFpblB0ciYgb3BlcmF0b3I9KFJldGFpblB0cjxVPiYmKTsKKyNlbmRpZgorCiAjaWYg IUhBVkUoTlVMTFBUUikKICAgICAgICAgUmV0YWluUHRyJiBvcGVyYXRvcj0oc3RkOjpudWxscHRy X3QpIHsgY2xlYXIoKTsgcmV0dXJuICp0aGlzOyB9CiAjZW5kaWYKQEAgLTE1Myw3ICsxNjMsNyBA QCBuYW1lc3BhY2UgV1RGIHsKICAgICAgICAgICAgIENGUmVsZWFzZShwdHIpOwogICAgICAgICBy ZXR1cm4gKnRoaXM7CiAgICAgfQotICAgIAorCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5s aW5lIFJldGFpblB0cjxUPiYgUmV0YWluUHRyPFQ+OjpvcGVyYXRvcj0oUHRyVHlwZSBvcHRyKQog ICAgIHsKICAgICAgICAgaWYgKG9wdHIpCkBAIC0xNjUsMzMgKzE3NSw0NyBAQCBuYW1lc3BhY2Ug V1RGIHsKICAgICAgICAgcmV0dXJuICp0aGlzOwogICAgIH0KIAotICAgIHRlbXBsYXRlPHR5cGVu YW1lIFQ+IGlubGluZSB2b2lkIFJldGFpblB0cjxUPjo6YWRvcHRDRihQdHJUeXBlIG9wdHIpCisg ICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gdGVtcGxhdGU8dHlwZW5hbWUgVT4gaW5saW5lIFJldGFp blB0cjxUPiYgUmV0YWluUHRyPFQ+OjpvcGVyYXRvcj0oVSogb3B0cikKICAgICB7CisgICAgICAg IGlmIChvcHRyKQorICAgICAgICAgICAgQ0ZSZXRhaW4ob3B0cik7CiAgICAgICAgIFB0clR5cGUg cHRyID0gbV9wdHI7CiAgICAgICAgIG1fcHRyID0gb3B0cjsKICAgICAgICAgaWYgKHB0cikKICAg ICAgICAgICAgIENGUmVsZWFzZShwdHIpOworICAgICAgICByZXR1cm4gKnRoaXM7CiAgICAgfQog Ci0gICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIHZvaWQgUmV0YWluUHRyPFQ+OjphZG9w dE5TKFB0clR5cGUgb3B0cikKKyNpZiBDT01QSUxFUl9TVVBQT1JUUyhDWFhfUlZBTFVFX1JFRkVS RU5DRVMpCisgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIFJldGFpblB0cjxUPiYgUmV0 YWluUHRyPFQ+OjpvcGVyYXRvcj0oUmV0YWluUHRyPFQ+JiYgbykKKyAgICB7CisgICAgICAgIGFk b3B0Q0YobGVha1JlZigpKTsKKyAgICAgICAgcmV0dXJuICp0aGlzOworICAgIH0KKyAgICAKKyAg ICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiB0ZW1wbGF0ZTx0eXBlbmFtZSBVPiBpbmxpbmUgUmV0YWlu UHRyPFQ+JiBSZXRhaW5QdHI8VD46Om9wZXJhdG9yPShSZXRhaW5QdHI8VT4mJiBvKQorICAgIHsK KyAgICAgICAgYWRvcHRDRihsZWFrUmVmKCkpOworICAgICAgICByZXR1cm4gKnRoaXM7CisgICAg fQorI2VuZGlmCisKKyAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBpbmxpbmUgdm9pZCBSZXRhaW5Q dHI8VD46OmFkb3B0Q0YoUHRyVHlwZSBvcHRyKQogICAgIHsKLSAgICAgICAgYWRvcHROU1JlZmVy ZW5jZShvcHRyKTsKLSAgICAgICAgCiAgICAgICAgIFB0clR5cGUgcHRyID0gbV9wdHI7CiAgICAg ICAgIG1fcHRyID0gb3B0cjsKICAgICAgICAgaWYgKHB0cikKICAgICAgICAgICAgIENGUmVsZWFz ZShwdHIpOwogICAgIH0KLSAgICAKLSAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiB0ZW1wbGF0ZTx0 eXBlbmFtZSBVPiBpbmxpbmUgUmV0YWluUHRyPFQ+JiBSZXRhaW5QdHI8VD46Om9wZXJhdG9yPShV KiBvcHRyKQorCisgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIHZvaWQgUmV0YWluUHRy PFQ+OjphZG9wdE5TKFB0clR5cGUgb3B0cikKICAgICB7Ci0gICAgICAgIGlmIChvcHRyKQotICAg ICAgICAgICAgQ0ZSZXRhaW4ob3B0cik7CisgICAgICAgIGFkb3B0TlNSZWZlcmVuY2Uob3B0cik7 CisgICAgICAgIAogICAgICAgICBQdHJUeXBlIHB0ciA9IG1fcHRyOwogICAgICAgICBtX3B0ciA9 IG9wdHI7CiAgICAgICAgIGlmIChwdHIpCiAgICAgICAgICAgICBDRlJlbGVhc2UocHRyKTsKLSAg ICAgICAgcmV0dXJuICp0aGlzOwogICAgIH0KIAogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGlu bGluZSB2b2lkIFJldGFpblB0cjxUPjo6c3dhcChSZXRhaW5QdHI8VD4mIG8pCkBAIC0yMzMsNyAr MjU3LDcgQEAgbmFtZXNwYWNlIFdURiB7CiAgICAgeyAKICAgICAgICAgcmV0dXJuIGEgIT0gYi5n ZXQoKTsgCiAgICAgfQotICAgIAorCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgUD4gc3RydWN0IEhh c2hUcmFpdHM8UmV0YWluUHRyPFA+ID4gOiBTaW1wbGVDbGFzc0hhc2hUcmFpdHM8UmV0YWluUHRy PFA+ID4geyB9OwogICAgIAogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFA+IHN0cnVjdCBQdHJIYXNo PFJldGFpblB0cjxQPiA+IDogUHRySGFzaDx0eXBlbmFtZSBSZXRhaW5QdHI8UD46OlB0clR5cGU+ IHsK