73383 2011-11-29 18:23:34 -0800 Add Settings for text track types 2011-12-01 08:53:43 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson webkit-bug-importer oldest_to_newest 511281 0 eric.carlson 2011-11-29 18:23:34 -0800 Subtitle, caption, and description text tracks are only shown when "the user has indicated an interest" in having them enabled. Add settings for each so WebCore can know when it is appropriate to enable these track types. http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#sourcing-out-of-band-text-tracks 511282 1 webkit-bug-importer 2011-11-29 18:23:48 -0800 <rdar://problem/10501513> 511295 2 117095 eric.carlson 2011-11-29 18:38:11 -0800 Created attachment 117095 Proposed patch 512805 3 eric.carlson 2011-12-01 08:53:43 -0800 http://trac.webkit.org/changeset/101674 117095 2011-11-29 18:38:11 -0800 2011-11-30 18:31:46 -0800 Proposed patch patch_settings_2.txt text/plain 3341 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMTQ0MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDExLTExLTI5ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBTZXR0aW5ncyBm b3IgdGV4dCB0cmFjayB0eXBlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzMzODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBObyBuZXcgdGVzdHMsIHNldHRpbmdzIGFyZSBub3QgdXNlZCB5ZXQuCisKKyAg ICAgICAgKiBwYWdlL1NldHRpbmdzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNldHRpbmdzOjpT ZXR0aW5ncyk6IEluaXRpYWxpemUgbmV3IHNldHRpbmdzLgorICAgICAgICAqIHBhZ2UvU2V0dGlu Z3MuaDoKKyAgICAgICAgKFdlYkNvcmU6OlNldHRpbmdzOjpzZXRTaG91bGREaXNwbGF5U3VidGl0 bGVzKTogTmV3LgorICAgICAgICAoV2ViQ29yZTo6U2V0dGluZ3M6OnNob3VsZERpc3BsYXlTdWJ0 aXRsZXMpOiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OlNldHRpbmdzOjpzZXRTaG91bGREaXNw bGF5Q2FwdGlvbnMpOiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OlNldHRpbmdzOjpzaG91bGRE aXNwbGF5Q2FwdGlvbnMpOiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OlNldHRpbmdzOjpzZXRT aG91bGREaXNwbGF5VGV4dERlc2NyaXB0aW9ucyk6IERpdHRvLgorICAgICAgICAoV2ViQ29yZTo6 U2V0dGluZ3M6OnNob3VsZERpc3BsYXlUZXh0RGVzY3JpcHRpb25zKTogRGl0dG8uCisKIDIwMTEt MTEtMjkgIEplc3NpZSBCZXJsaW4gIDxqYmVybGluQGFwcGxlLmNvbT4KIAogICAgICAgICBXS0tl eVZhbHVlU3RvcmFnZU1hbmFnZXJHZXRLZXlWYWx1ZVN0b3JhZ2VPcmlnaW5zIG1heSBub3QgcmVw b3J0IHRoZSBjb3JyZWN0IGxpc3Qgb2Ygb3JpZ2lucwpJbmRleDogU291cmNlL1dlYkNvcmUvcGFn ZS9TZXR0aW5ncy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5n cy5jcHAJKHJldmlzaW9uIDEwMTI2MykKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3Mu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMjksNiArMjI5LDExIEBAIFNldHRpbmdzOjpTZXR0aW5n cyhQYWdlKiBwYWdlKQogICAgICwgbV9zdXBwcmVzc0luY3JlbWVudGFsUmVuZGVyaW5nKGZhbHNl KQogICAgICwgbV9iYWNrc3BhY2VLZXlOYXZpZ2F0aW9uRW5hYmxlZCh0cnVlKQogICAgICwgbV92 aXN1YWxXb3JkTW92ZW1lbnRFbmFibGVkKGZhbHNlKQorI2lmIEVOQUJMRShWSURFT19UUkFDSykK KyAgICAsIG1fc2hvdWxkRGlzcGxheVN1YnRpdGxlcyhmYWxzZSkKKyAgICAsIG1fc2hvdWxkRGlz cGxheUNhcHRpb25zKGZhbHNlKQorICAgICwgbV9zaG91bGREaXNwbGF5VGV4dERlc2NyaXB0aW9u cyhmYWxzZSkKKyNlbmRpZgogICAgICwgbV9sb2Fkc0ltYWdlc0F1dG9tYXRpY2FsbHlUaW1lcih0 aGlzLCAmU2V0dGluZ3M6OmxvYWRzSW1hZ2VzQXV0b21hdGljYWxseVRpbWVyRmlyZWQpCiB7CiAg ICAgLy8gQSBGcmFtZSBtYXkgbm90IGhhdmUgYmVlbiBjcmVhdGVkIHlldCwgc28gd2UgaW5pdGlh bGl6ZSB0aGUgQXRvbWljU3RyaW5nIApJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5n cy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MuaAkocmV2aXNp b24gMTAxMjYzKQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5oCSh3b3JraW5nIGNv cHkpCkBAIC00ODYsNiArNDg2LDE3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdm9p ZCBzZXRWaXN1YWxXb3JkTW92ZW1lbnRFbmFibGVkKGJvb2wgZW5hYmxlZCkgeyBtX3Zpc3VhbFdv cmRNb3ZlbWVudEVuYWJsZWQgPSBlbmFibGVkOyB9CiAgICAgICAgIGJvb2wgdmlzdWFsV29yZE1v dmVtZW50RW5hYmxlZCgpIGNvbnN0IHsgcmV0dXJuIG1fdmlzdWFsV29yZE1vdmVtZW50RW5hYmxl ZDsgfQogCisjaWYgRU5BQkxFKFZJREVPX1RSQUNLKQorICAgICAgICB2b2lkIHNldFNob3VsZERp c3BsYXlTdWJ0aXRsZXMoYm9vbCBmbGFnKSB7IG1fc2hvdWxkRGlzcGxheVN1YnRpdGxlcyA9IGZs YWc7IH0KKyAgICAgICAgYm9vbCBzaG91bGREaXNwbGF5U3VidGl0bGVzKCkgY29uc3QgeyByZXR1 cm4gbV9zaG91bGREaXNwbGF5U3VidGl0bGVzOyB9CisKKyAgICAgICAgdm9pZCBzZXRTaG91bGRE aXNwbGF5Q2FwdGlvbnMoYm9vbCBmbGFnKSB7IG1fc2hvdWxkRGlzcGxheUNhcHRpb25zID0gZmxh ZzsgfQorICAgICAgICBib29sIHNob3VsZERpc3BsYXlDYXB0aW9ucygpIGNvbnN0IHsgcmV0dXJu IG1fc2hvdWxkRGlzcGxheUNhcHRpb25zOyB9CisKKyAgICAgICAgdm9pZCBzZXRTaG91bGREaXNw bGF5VGV4dERlc2NyaXB0aW9ucyhib29sIGZsYWcpIHsgbV9zaG91bGREaXNwbGF5VGV4dERlc2Ny aXB0aW9ucyA9IGZsYWc7IH0KKyAgICAgICAgYm9vbCBzaG91bGREaXNwbGF5VGV4dERlc2NyaXB0 aW9ucygpIGNvbnN0IHsgcmV0dXJuIG1fc2hvdWxkRGlzcGxheVRleHREZXNjcmlwdGlvbnM7IH0K KyNlbmRpZgorCiAgICAgcHJpdmF0ZToKICAgICAgICAgUGFnZSogbV9wYWdlOwogCkBAIC02MTIs NiArNjIzLDEyIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgYm9vbCBtX2JhY2tzcGFj ZUtleU5hdmlnYXRpb25FbmFibGVkIDogMTsKICAgICAgICAgYm9vbCBtX3Zpc3VhbFdvcmRNb3Zl bWVudEVuYWJsZWQgOiAxOwogCisjaWYgRU5BQkxFKFZJREVPX1RSQUNLKQorICAgICAgICBib29s IG1fc2hvdWxkRGlzcGxheVN1YnRpdGxlcyA6IDE7CisgICAgICAgIGJvb2wgbV9zaG91bGREaXNw bGF5Q2FwdGlvbnMgOiAxOworICAgICAgICBib29sIG1fc2hvdWxkRGlzcGxheVRleHREZXNjcmlw dGlvbnMgOiAxOworI2VuZGlmCisKICAgICAgICAgVGltZXI8U2V0dGluZ3M+IG1fbG9hZHNJbWFn ZXNBdXRvbWF0aWNhbGx5VGltZXI7CiAgICAgICAgIHZvaWQgbG9hZHNJbWFnZXNBdXRvbWF0aWNh bGx5VGltZXJGaXJlZChUaW1lcjxTZXR0aW5ncz4qKTsKIAo=