73379 2011-11-29 17:28:35 -0800 [chromium] add setOpener method to WebFrame 2011-12-02 16:54:07 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 73337 1 supersat supersat creis fishd webkit.review.bot oldest_to_newest 511243 0 117080 supersat 2011-11-29 17:28:35 -0800 Created attachment 117080 Patch To get cross-process postMessage working in Chromium (bug 73337), we need to be able to give frames the ability to send messages to their openers. This requires a chain of opener proxies. Chromium will create new WebViews for the proxies but needs a way to point a frame to its proxy opener. Adding a setOpener to WebFrame allows Chromium to do so. 511244 1 webkit.review.bot 2011-11-29 17:30:19 -0800 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 511369 2 117080 fishd 2011-11-29 21:38:53 -0800 Comment on attachment 117080 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117080&action=review > Source/WebKit/chromium/public/WebFrame.h:221 > + virtual void setOpener(const WebFrame*) = 0; nit: please preserve two new lines above section header note: we already have opener() and clearOpener(). it seems like setOpener() should be listed next to those. also, perhaps we should delete clearOpener() in favor of setOpener(0). you could at least implement clearOpener() as an inline call to setOpener(0). > Source/WebKit/chromium/src/WebFrameImpl.cpp:768 > + static_cast<const WebFrameImpl *>(frame)->m_frame : 0); nit: no space after "WebFrameImpl" 513060 3 117478 supersat 2011-12-01 13:43:08 -0800 Created attachment 117478 Patch update (In reply to comment #2) > (From update of attachment 117080 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=117080&action=review > > > Source/WebKit/chromium/public/WebFrame.h:221 > > + virtual void setOpener(const WebFrame*) = 0; > > nit: please preserve two new lines above section header Fixed. > note: we already have opener() and clearOpener(). it seems like setOpener() should be > listed next to those. also, perhaps we should delete clearOpener() in favor of setOpener(0). > you could at least implement clearOpener() as an inline call to setOpener(0). I have no idea why I put setOpener there. I moved it and made clearOpener an inline call to setOpener(0). > > Source/WebKit/chromium/src/WebFrameImpl.cpp:768 > > + static_cast<const WebFrameImpl *>(frame)->m_frame : 0); > > nit: no space after "WebFrameImpl" Oops. Old habits. :) Fixed. 513546 4 117478 webkit.review.bot 2011-12-01 23:18:09 -0800 Comment on attachment 117478 Patch update Rejecting attachment 117478 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: -queue/Source/WebKit/chromium/tools/xdisplaycheck --revision 112463 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 46>At revision 112463. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/10693949 513928 5 117655 supersat 2011-12-02 10:57:26 -0800 Created attachment 117655 Same patch, now with the missing ChangeLog webkit-patch was pulling in unrelated changes, so I created this patch manually and forgot to update ChangeLog. This patch is the same as the previous one, just with a ChangeLog entry. 514191 6 117655 webkit.review.bot 2011-12-02 14:52:01 -0800 Comment on attachment 117655 Same patch, now with the missing ChangeLog Rejecting attachment 117655 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: line 32, in <module> from webkitpy.common.checkout.changelog import ChangeLog, parse_bug_id_from_changelog File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 36, in <module> from webkitpy.common.config.committers import CommitterList File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 135 Contributor("Pierre Rossi", "pierre.rossi@gmail.com", "elproxy"), ^ SyntaxError: invalid syntax Full output: http://queues.webkit.org/results/10725551 514278 7 117655 webkit.review.bot 2011-12-02 16:54:02 -0800 Comment on attachment 117655 Same patch, now with the missing ChangeLog Clearing flags on attachment: 117655 Committed r101879: <http://trac.webkit.org/changeset/101879> 514279 8 webkit.review.bot 2011-12-02 16:54:07 -0800 All reviewed patches have been landed. Closing bug. 117080 2011-11-29 17:28:35 -0800 2011-12-01 14:24:24 -0800 Patch setopener-patch text/plain 1890 supersat ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lLmggYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oCmluZGV4IDVkNmMxNzcuLjRl ZmExOGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1l LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWUuaApAQCAtMjE3 LDYgKzIxNyw4IEBAIHB1YmxpYzoKICAgICAvLyBSZXR1cm5zIHRoZSBjaGlsZCBmcmFtZSBpZGVu dGlmaWVkIGJ5IHRoZSBnaXZlbiB4cGF0aCBleHByZXNzaW9uLgogICAgIHZpcnR1YWwgV2ViRnJh bWUqIGZpbmRDaGlsZEJ5RXhwcmVzc2lvbihjb25zdCBXZWJTdHJpbmcmIHhwYXRoKSBjb25zdCA9 IDA7CiAKKyAgICAvLyBTZXRzIHRoZSBmcmFtZSB0aGF0IG9wZW5lZCB0aGlzIG9uZSBvciAwIGlm IHRoZXJlIGlzIG5vbmUuCisgICAgdmlydHVhbCB2b2lkIHNldE9wZW5lcihjb25zdCBXZWJGcmFt ZSopID0gMDsKIAogICAgIC8vIENvbnRlbnQgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJGcmFtZUltcGwuY3BwCmluZGV4IDc1MWQyY2IuLjkzYjQ5OGMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcApAQCAtNzYyLDYgKzc2MiwxMiBA QCBXZWJGcmFtZSogV2ViRnJhbWVJbXBsOjpmaW5kQ2hpbGRCeUV4cHJlc3Npb24oY29uc3QgV2Vi U3RyaW5nJiB4cGF0aCkgY29uc3QKICAgICByZXR1cm4gZnJvbUZyYW1lKGZyYW1lRWxlbWVudC0+ Y29udGVudEZyYW1lKCkpOwogfQogCit2b2lkIFdlYkZyYW1lSW1wbDo6c2V0T3BlbmVyKGNvbnN0 IFdlYkZyYW1lKiBmcmFtZSkKK3sKKyAgICBtX2ZyYW1lLT5sb2FkZXIoKS0+c2V0T3BlbmVyKGZy YW1lID8KKyAgICAgICAgc3RhdGljX2Nhc3Q8Y29uc3QgV2ViRnJhbWVJbXBsICo+KGZyYW1lKS0+ bV9mcmFtZSA6IDApOworfQorCiBXZWJEb2N1bWVudCBXZWJGcmFtZUltcGw6OmRvY3VtZW50KCkg Y29uc3QKIHsKICAgICBpZiAoIW1fZnJhbWUgfHwgIW1fZnJhbWUtPmRvY3VtZW50KCkpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaCBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oCmluZGV4IDllN2I5NDcuLjUwZjNi MGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5o CisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oCkBAIC05NCw2 ICs5NCw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIFdlYkZyYW1lKiB0cmF2ZXJzZVByZXZpb3Vz KGJvb2wgd3JhcCkgY29uc3Q7CiAgICAgdmlydHVhbCBXZWJGcmFtZSogZmluZENoaWxkQnlOYW1l KGNvbnN0IFdlYlN0cmluZyYpIGNvbnN0OwogICAgIHZpcnR1YWwgV2ViRnJhbWUqIGZpbmRDaGls ZEJ5RXhwcmVzc2lvbihjb25zdCBXZWJTdHJpbmcmKSBjb25zdDsKKyAgICB2aXJ0dWFsIHZvaWQg c2V0T3BlbmVyKGNvbnN0IFdlYkZyYW1lKik7CiAgICAgdmlydHVhbCBXZWJEb2N1bWVudCBkb2N1 bWVudCgpIGNvbnN0OwogICAgIHZpcnR1YWwgV2ViQW5pbWF0aW9uQ29udHJvbGxlciogYW5pbWF0 aW9uQ29udHJvbGxlcigpOwogICAgIHZpcnR1YWwgV2ViUGVyZm9ybWFuY2UgcGVyZm9ybWFuY2Uo KSBjb25zdDsK 117478 2011-12-01 13:43:08 -0800 2011-12-02 10:57:26 -0800 Patch update setopener-patch text/plain 2148 supersat ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lLmggYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oCmluZGV4IDVkNmMxNzcuLmMw ZDNjYmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1l LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWUuaApAQCAtMTg4 LDkgKzE4OCwxMiBAQCBwdWJsaWM6CiAgICAgLy8gUmV0dXJucyB0aGUgZnJhbWUgdGhhdCBvcGVu ZWQgdGhpcyBmcmFtZSBvciAwIGlmIHRoZXJlIGlzIG5vbmUuCiAgICAgdmlydHVhbCBXZWJGcmFt ZSogb3BlbmVyKCkgY29uc3QgPSAwOwogCisgICAgLy8gU2V0cyB0aGUgZnJhbWUgdGhhdCBvcGVu ZWQgdGhpcyBvbmUgb3IgMCBpZiB0aGVyZSBpcyBub25lLgorICAgIHZpcnR1YWwgdm9pZCBzZXRP cGVuZXIoY29uc3QgV2ViRnJhbWUqKSA9IDA7CisKICAgICAvLyBSZXNldCB0aGUgZnJhbWUgdGhh dCBvcGVuZWQgdGhpcyBmcmFtZSB0byAwLgogICAgIC8vIFRoaXMgaXMgZXhlY3V0ZWQgYmV0d2Vl biBsYXlvdXQgdGVzdHMgcnVucwotICAgIHZpcnR1YWwgdm9pZCBjbGVhck9wZW5lcigpID0gMDsK KyAgICB2b2lkIGNsZWFyT3BlbmVyKCkgeyBzZXRPcGVuZXIoMCk7IH0KIAogICAgIC8vIFJldHVy bnMgdGhlIHBhcmVudCBmcmFtZSBvciAwIGlmIHRoaXMgaXMgYSB0b3AtbW9zdCBmcmFtZS4KICAg ICB2aXJ0dWFsIFdlYkZyYW1lKiBwYXJlbnQoKSBjb25zdCA9IDA7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAppbmRleCA3NTFkMmNiLi5lMDA4ZTNkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKQEAgLTY3MSwxMSAr NjcxLDYgQEAgV2ViVmlldyogV2ViRnJhbWVJbXBsOjp2aWV3KCkgY29uc3QKICAgICByZXR1cm4g dmlld0ltcGwoKTsKIH0KIAotdm9pZCBXZWJGcmFtZUltcGw6OmNsZWFyT3BlbmVyKCkKLXsKLSAg ICBtX2ZyYW1lLT5sb2FkZXIoKS0+c2V0T3BlbmVyKDApOwotfQotCiBXZWJGcmFtZSogV2ViRnJh bWVJbXBsOjpvcGVuZXIoKSBjb25zdAogewogICAgIEZyYW1lKiBvcGVuZXIgPSAwOwpAQCAtNjg0 LDYgKzY3OSwxMiBAQCBXZWJGcmFtZSogV2ViRnJhbWVJbXBsOjpvcGVuZXIoKSBjb25zdAogICAg IHJldHVybiBmcm9tRnJhbWUob3BlbmVyKTsKIH0KIAordm9pZCBXZWJGcmFtZUltcGw6OnNldE9w ZW5lcihjb25zdCBXZWJGcmFtZSogZnJhbWUpCit7CisgICAgbV9mcmFtZS0+bG9hZGVyKCktPnNl dE9wZW5lcihmcmFtZSA/CisgICAgICAgIHN0YXRpY19jYXN0PGNvbnN0IFdlYkZyYW1lSW1wbCo+ KGZyYW1lKS0+bV9mcmFtZSA6IDApOworfQorCiBXZWJGcmFtZSogV2ViRnJhbWVJbXBsOjpwYXJl bnQoKSBjb25zdAogewogICAgIEZyYW1lKiBwYXJlbnQgPSAwOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJGcmFtZUltcGwuaAppbmRleCA5ZTdiOTQ3Li5iOTM3MDU5IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaAorKysgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaApAQCAtODMsNyArODMsNyBAQCBwdWJs aWM6CiAgICAgdmlydHVhbCBib29sIGhhc1ZlcnRpY2FsU2Nyb2xsYmFyKCkgY29uc3Q7CiAgICAg dmlydHVhbCBXZWJWaWV3KiB2aWV3KCkgY29uc3Q7CiAgICAgdmlydHVhbCBXZWJGcmFtZSogb3Bl bmVyKCkgY29uc3Q7Ci0gICAgdmlydHVhbCB2b2lkIGNsZWFyT3BlbmVyKCk7CisgICAgdmlydHVh bCB2b2lkIHNldE9wZW5lcihjb25zdCBXZWJGcmFtZSopOwogICAgIHZpcnR1YWwgV2ViRnJhbWUq IHBhcmVudCgpIGNvbnN0OwogICAgIHZpcnR1YWwgV2ViRnJhbWUqIHRvcCgpIGNvbnN0OwogICAg IHZpcnR1YWwgV2ViRnJhbWUqIGZpcnN0Q2hpbGQoKSBjb25zdDsK 117655 2011-12-02 10:57:26 -0800 2011-12-02 16:54:02 -0800 Same patch, now with the missing ChangeLog setopener-patch text/plain 2887 supersat ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggNzQxMzM3Mi4uMDA3Zjk1MSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMS0xMi0wMiAgS2FybCBLb3Nj aGVyICA8c3VwZXJzYXRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gYWRkIHNl dE9wZW5lciBtZXRob2QgdG8gV2ViRnJhbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTczMzc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViRnJhbWUuaDoKKyAgICAgICAgKFdlYktpdDo6 V2ViRnJhbWU6OmNsZWFyT3BlbmVyKTogbm93IGFuIGlubGluZSBjYWxsIHRvIHNldE9wZW5lcigw KQorICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJG cmFtZUltcGw6OnNldE9wZW5lcik6IHNldHMgd2luZG93Lm9wZW5lcgorICAgICAgICAqIHNyYy9X ZWJGcmFtZUltcGwuaDoKKwogMjAxMS0xMS0yOCAgSm9uIExlZSAgPGpvbmxlZUBhcHBsZS5jb20+ CiAKICAgICAgICAgUG9zc2libGUgZml4IGZvciB0ZXN0IGZhaWx1cmVzIGluIHIxMDEzMDcuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWUuaAppbmRleCA1ZDZjMTc3Li5jMGQz Y2JiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5o CisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lLmgKQEAgLTE4OCw5 ICsxODgsMTIgQEAgcHVibGljOgogICAgIC8vIFJldHVybnMgdGhlIGZyYW1lIHRoYXQgb3BlbmVk IHRoaXMgZnJhbWUgb3IgMCBpZiB0aGVyZSBpcyBub25lLgogICAgIHZpcnR1YWwgV2ViRnJhbWUq IG9wZW5lcigpIGNvbnN0ID0gMDsKIAorICAgIC8vIFNldHMgdGhlIGZyYW1lIHRoYXQgb3BlbmVk IHRoaXMgb25lIG9yIDAgaWYgdGhlcmUgaXMgbm9uZS4KKyAgICB2aXJ0dWFsIHZvaWQgc2V0T3Bl bmVyKGNvbnN0IFdlYkZyYW1lKikgPSAwOworCiAgICAgLy8gUmVzZXQgdGhlIGZyYW1lIHRoYXQg b3BlbmVkIHRoaXMgZnJhbWUgdG8gMC4KICAgICAvLyBUaGlzIGlzIGV4ZWN1dGVkIGJldHdlZW4g bGF5b3V0IHRlc3RzIHJ1bnMKLSAgICB2aXJ0dWFsIHZvaWQgY2xlYXJPcGVuZXIoKSA9IDA7Cisg ICAgdm9pZCBjbGVhck9wZW5lcigpIHsgc2V0T3BlbmVyKDApOyB9CiAKICAgICAvLyBSZXR1cm5z IHRoZSBwYXJlbnQgZnJhbWUgb3IgMCBpZiB0aGlzIGlzIGEgdG9wLW1vc3QgZnJhbWUuCiAgICAg dmlydHVhbCBXZWJGcmFtZSogcGFyZW50KCkgY29uc3QgPSAwOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKaW5kZXggNzUxZDJjYi4uZTAwOGUzZCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCkBAIC02NzEsMTEgKzY3 MSw2IEBAIFdlYlZpZXcqIFdlYkZyYW1lSW1wbDo6dmlldygpIGNvbnN0CiAgICAgcmV0dXJuIHZp ZXdJbXBsKCk7CiB9CiAKLXZvaWQgV2ViRnJhbWVJbXBsOjpjbGVhck9wZW5lcigpCi17Ci0gICAg bV9mcmFtZS0+bG9hZGVyKCktPnNldE9wZW5lcigwKTsKLX0KLQogV2ViRnJhbWUqIFdlYkZyYW1l SW1wbDo6b3BlbmVyKCkgY29uc3QKIHsKICAgICBGcmFtZSogb3BlbmVyID0gMDsKQEAgLTY4NCw2 ICs2NzksMTIgQEAgV2ViRnJhbWUqIFdlYkZyYW1lSW1wbDo6b3BlbmVyKCkgY29uc3QKICAgICBy ZXR1cm4gZnJvbUZyYW1lKG9wZW5lcik7CiB9CiAKK3ZvaWQgV2ViRnJhbWVJbXBsOjpzZXRPcGVu ZXIoY29uc3QgV2ViRnJhbWUqIGZyYW1lKQoreworICAgIG1fZnJhbWUtPmxvYWRlcigpLT5zZXRP cGVuZXIoZnJhbWUgPworICAgICAgICBzdGF0aWNfY2FzdDxjb25zdCBXZWJGcmFtZUltcGwqPihm cmFtZSktPm1fZnJhbWUgOiAwKTsKK30KKwogV2ViRnJhbWUqIFdlYkZyYW1lSW1wbDo6cGFyZW50 KCkgY29uc3QKIHsKICAgICBGcmFtZSogcGFyZW50ID0gMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViRnJhbWVJbXBsLmgKaW5kZXggOWU3Yjk0Ny4uYjkzNzA1OSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmgKKysrIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmgKQEAgLTgzLDcgKzgzLDcgQEAgcHVibGlj OgogICAgIHZpcnR1YWwgYm9vbCBoYXNWZXJ0aWNhbFNjcm9sbGJhcigpIGNvbnN0OwogICAgIHZp cnR1YWwgV2ViVmlldyogdmlldygpIGNvbnN0OwogICAgIHZpcnR1YWwgV2ViRnJhbWUqIG9wZW5l cigpIGNvbnN0OwotICAgIHZpcnR1YWwgdm9pZCBjbGVhck9wZW5lcigpOworICAgIHZpcnR1YWwg dm9pZCBzZXRPcGVuZXIoY29uc3QgV2ViRnJhbWUqKTsKICAgICB2aXJ0dWFsIFdlYkZyYW1lKiBw YXJlbnQoKSBjb25zdDsKICAgICB2aXJ0dWFsIFdlYkZyYW1lKiB0b3AoKSBjb25zdDsKICAgICB2 aXJ0dWFsIFdlYkZyYW1lKiBmaXJzdENoaWxkKCkgY29uc3Q7Cg==