73378 2011-11-29 17:20:39 -0800 Accessibility: WebKitTestRunner compile warnings with XCode 3.2 2011-12-01 13:13:27 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dmazzoni dmazzoni webkit.review.bot oldest_to_newest 511239 0 dmazzoni 2011-11-29 17:20:39 -0800 These are tiny and should be easy to fix: Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: In copy constructor 'WTR::AccessibilityUIElement::AccessibilityUIElement(const WTR::AccessibilityUIElement&)': Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:171: warning: base class 'class WTR::JSWrappable' should be explicitly initialized in the copy constructor Tools/WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: In copy constructor 'WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange(const WTR::AccessibilityTextMarkerRange&)': Tools/WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:51: warning: base class 'class WTR::JSWrappable' should be explicitly initialized in the copy constructor Tools/WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: In copy constructor 'WTR::AccessibilityTextMarker::AccessibilityTextMarker(const WTR::AccessibilityTextMarker&)': Tools/WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:51: warning: base class 'class WTR::JSWrappable' should be explicitly initialized in the copy constructor Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: In member function 'WTF::PassRefPtr<WTR::AccessibilityUIElement> WTR::AccessibilityUIElement::verticalScrollbar() const': Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:1154: warning: control reaches end of non-void function 511242 1 117079 dmazzoni 2011-11-29 17:25:08 -0800 Created attachment 117079 Patch 513033 2 117079 webkit.review.bot 2011-12-01 13:13:23 -0800 Comment on attachment 117079 Patch Clearing flags on attachment: 117079 Committed r101700: <http://trac.webkit.org/changeset/101700> 513035 3 webkit.review.bot 2011-12-01 13:13:27 -0800 All reviewed patches have been landed. Closing bug. 117079 2011-11-29 17:25:08 -0800 2011-12-01 13:13:23 -0800 Patch bug-73378-20111129172502.patch text/plain 3231 dmazzoni SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwMTQzNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDExLTExLTI5ICBEb21pbmljIE1henpvbmkgIDxkbWF6em9uaUBnb29nbGUu Y29tPgorCisgICAgICAgIEZpeCBXZWJLaXRUZXN0UnVubmVyIGNvbXBpbGUgd2FybmluZ3Mgd2l0 aCBYQ29kZSAzLjIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTczMzc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0FjY2Vzc2liaWxpdHlUZXh0TWFy a2VyLmNwcDoKKyAgICAgICAgKFdUUjo6QWNjZXNzaWJpbGl0eVRleHRNYXJrZXI6OkFjY2Vzc2li aWxpdHlUZXh0TWFya2VyKToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVu ZGxlL0FjY2Vzc2liaWxpdHlUZXh0TWFya2VyUmFuZ2UuY3BwOgorICAgICAgICAoV1RSOjpBY2Nl c3NpYmlsaXR5VGV4dE1hcmtlclJhbmdlOjpBY2Nlc3NpYmlsaXR5VGV4dE1hcmtlclJhbmdlKToK KyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL21hYy9BY2Nlc3NpYmls aXR5VUlFbGVtZW50TWFjLm1tOgorICAgICAgICAoV1RSOjpBY2Nlc3NpYmlsaXR5VUlFbGVtZW50 OjpBY2Nlc3NpYmlsaXR5VUlFbGVtZW50KToKKyAgICAgICAgKFdUUjo6QWNjZXNzaWJpbGl0eVVJ RWxlbWVudDo6dmVydGljYWxTY3JvbGxiYXIpOgorCiAyMDExLTExLTI5ICBPamFuIFZhZmFpICA8 b2phbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTGlzdCBvZiBidWlsZGVycyBpbiB0aGUgZmxh a2luZXNzIGRhc2hib2FyZCBpcyBvdXQgb2YgZGF0ZQpJbmRleDogVG9vbHMvV2ViS2l0VGVzdFJ1 bm5lci9JbmplY3RlZEJ1bmRsZS9BY2Nlc3NpYmlsaXR5VGV4dE1hcmtlci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9BY2Nlc3NpYmlsaXR5 VGV4dE1hcmtlci5jcHAJKHJldmlzaW9uIDEwMTQwMSkKKysrIFRvb2xzL1dlYktpdFRlc3RSdW5u ZXIvSW5qZWN0ZWRCdW5kbGUvQWNjZXNzaWJpbGl0eVRleHRNYXJrZXIuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC00OSw3ICs0OSw4IEBAIEFjY2Vzc2liaWxpdHlUZXh0TWFya2VyOjpBY2Nlc3NpYmls aXR5VGUKIH0KIAogQWNjZXNzaWJpbGl0eVRleHRNYXJrZXI6OkFjY2Vzc2liaWxpdHlUZXh0TWFy a2VyKGNvbnN0IEFjY2Vzc2liaWxpdHlUZXh0TWFya2VyJiBtYXJrZXIpCi0gICAgOiBtX3RleHRN YXJrZXIobWFya2VyLnBsYXRmb3JtVGV4dE1hcmtlcigpKQorICAgIDogSlNXcmFwcGFibGUoKQor ICAgICwgbV90ZXh0TWFya2VyKG1hcmtlci5wbGF0Zm9ybVRleHRNYXJrZXIoKSkKIHsKIH0KIApJ bmRleDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9BY2Nlc3NpYmlsaXR5 VGV4dE1hcmtlclJhbmdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9XZWJLaXRUZXN0UnVubmVy L0luamVjdGVkQnVuZGxlL0FjY2Vzc2liaWxpdHlUZXh0TWFya2VyUmFuZ2UuY3BwCShyZXZpc2lv biAxMDE0MDEpCisrKyBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0FjY2Vz c2liaWxpdHlUZXh0TWFya2VyUmFuZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00OSw3ICs0OSw4 IEBAIEFjY2Vzc2liaWxpdHlUZXh0TWFya2VyUmFuZ2U6OkFjY2Vzc2liaWwKIH0KIAogQWNjZXNz aWJpbGl0eVRleHRNYXJrZXJSYW5nZTo6QWNjZXNzaWJpbGl0eVRleHRNYXJrZXJSYW5nZShjb25z dCBBY2Nlc3NpYmlsaXR5VGV4dE1hcmtlclJhbmdlJiBtYXJrZXJSYW5nZSkKLSAgICA6IG1fdGV4 dE1hcmtlclJhbmdlKG1hcmtlclJhbmdlLnBsYXRmb3JtVGV4dE1hcmtlclJhbmdlKCkpCisgICAg OiBKU1dyYXBwYWJsZSgpCisgICAgLCBtX3RleHRNYXJrZXJSYW5nZShtYXJrZXJSYW5nZS5wbGF0 Zm9ybVRleHRNYXJrZXJSYW5nZSgpKQogewogfQogCkluZGV4OiBUb29scy9XZWJLaXRUZXN0UnVu bmVyL0luamVjdGVkQnVuZGxlL21hYy9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50TWFjLm1tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvbWFjL0FjY2Vz c2liaWxpdHlVSUVsZW1lbnRNYWMubW0JKHJldmlzaW9uIDEwMTQwMSkKKysrIFRvb2xzL1dlYktp dFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvbWFjL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRNYWMu bW0JKHdvcmtpbmcgY29weSkKQEAgLTE2OSw3ICsxNjksOCBAQCBBY2Nlc3NpYmlsaXR5VUlFbGVt ZW50OjpBY2Nlc3NpYmlsaXR5VUlFCiB9CiAKIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OkFjY2Vz c2liaWxpdHlVSUVsZW1lbnQoY29uc3QgQWNjZXNzaWJpbGl0eVVJRWxlbWVudCYgb3RoZXIpCi0g ICAgOiBtX2VsZW1lbnQob3RoZXIubV9lbGVtZW50KQorICAgIDogSlNXcmFwcGFibGUoKQorICAg ICwgbV9lbGVtZW50KG90aGVyLm1fZWxlbWVudCkKICAgICAsIG1fbm90aWZpY2F0aW9uSGFuZGxl cigwKQogewogICAgIFttX2VsZW1lbnQgcmV0YWluXTsKQEAgLTExNDgsNiArMTE0OSw4IEBAIFBh c3NSZWZQdHI8QWNjZXNzaWJpbGl0eVVJRWxlbWVudD4gQWNjZXMKICAgICBCRUdJTl9BWF9PQkpD X0VYQ0VQVElPTlMKICAgICByZXR1cm4gQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6Y3JlYXRlKFtt X2VsZW1lbnQgYWNjZXNzaWJpbGl0eUF0dHJpYnV0ZVZhbHVlOk5TQWNjZXNzaWJpbGl0eVZlcnRp Y2FsU2Nyb2xsQmFyQXR0cmlidXRlXSk7CiAgICAgRU5EX0FYX09CSkNfRVhDRVBUSU9OUyAgICAg ICAgCisKKyAgICByZXR1cm4gMDsKIH0KIAogSlNSZXRhaW5QdHI8SlNTdHJpbmdSZWY+IEFjY2Vz c2liaWxpdHlVSUVsZW1lbnQ6OnNlbGVjdGVkVGV4dFJhbmdlKCkK