73377 2011-11-29 17:13:00 -0800 Remove dead flexible box code 2011-11-30 10:44:54 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony tony darin dglazkov ojan webkit.review.bot oldest_to_newest 511236 0 tony 2011-11-29 17:13:00 -0800 Remove dead flexible box code 511237 1 117077 tony 2011-11-29 17:13:44 -0800 Created attachment 117077 Patch 511238 2 tony 2011-11-29 17:14:05 -0800 Another easy review. 511624 3 117077 webkit.review.bot 2011-11-30 04:18:24 -0800 Comment on attachment 117077 Patch Attachment 117077 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10709142 New failing tests: svg/transforms/text-with-pattern-with-svg-transform.svg 511876 4 tony 2011-11-30 10:44:54 -0800 Committed r101530: <http://trac.webkit.org/changeset/101530> 117077 2011-11-29 17:13:44 -0800 2011-11-30 04:18:24 -0800 Patch bug-73377-20111129171348.patch text/plain 4584 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxNDM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzYyMWMzYTk2MzVhOTg3 Nzk4YTQ5MTM1Y2QxNTVlN2JhMGQ4ZjY5MS4uMzczMjAwZWEyYmRlN2Y3Nzg5YTlmMTE5YTU4OTNj YmJhYTQ5Yjk2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDExLTExLTI5ICBUb255 IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVtb3ZlIGRlYWQgZmxleGli bGUgYm94IGNvZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTczMzc3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2UgdXNlZCB0byB1c2UgdGhlc2Ugd2l0aCBhbiBlYXJsaWVyIHZlcnNpb24gb2YgdGhlIHNw ZWMgd2hlcmUgbWFyZ2lucworICAgICAgICBzZXQgdG8gYXV0byB3ZXJlIHRyZWF0ZWQgYXMgZmxl eCgxKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGp1c3QgcmVtb3Zpbmcgc29tZSB1bmNhbGxl ZCBtZXRob2RzLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcDoK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guaDoKKwogMjAxMS0xMS0yOSAg RXJpayBBcnZpZHNzb24gIDxhcnZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYklETDogQWRk IHN1cHBvcnQgZm9yIHN0YXRpYyBmb3IgSlNDIGFuZCBWOApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5jcHAKaW5kZXggNmY1MjU1ZjE5ZDE4MDY2MDQzNzIx ZmVhYzg4YWEwNmVkNjBlNGI2OS4uZTM0Y2QwZjhjMDQ4ODg0Y2JiMzg4ZWVlMmY0ZGU0NzNmNjA0 YzJlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxl Qm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3gu Y3BwCkBAIC00MjUsMzYgKzQyNSw2IEBAIExheW91dFBvaW50IFJlbmRlckZsZXhpYmxlQm94Ojpm bG93QXdhcmVMb2NhdGlvbkZvckNoaWxkKFJlbmRlckJveCogY2hpbGQpIGNvbnN0CiAgICAgcmV0 dXJuIGlzSG9yaXpvbnRhbEZsb3coKSA/IGNoaWxkLT5sb2NhdGlvbigpIDogY2hpbGQtPmxvY2F0 aW9uKCkudHJhbnNwb3NlZFBvaW50KCk7CiB9CiAKLXZvaWQgUmVuZGVyRmxleGlibGVCb3g6OnNl dEZsb3dBd2FyZU1hcmdpblN0YXJ0Rm9yQ2hpbGQoUmVuZGVyQm94KiBjaGlsZCwgTGF5b3V0VW5p dCBtYXJnaW4pCi17Ci0gICAgaWYgKGlzSG9yaXpvbnRhbEZsb3coKSkgewotICAgICAgICBpZiAo aXNMZWZ0VG9SaWdodEZsb3coKSkKLSAgICAgICAgICAgIGNoaWxkLT5zZXRNYXJnaW5MZWZ0KG1h cmdpbik7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIGNoaWxkLT5zZXRNYXJnaW5SaWdodCht YXJnaW4pOwotICAgIH0gZWxzZSB7Ci0gICAgICAgIGlmIChpc0xlZnRUb1JpZ2h0RmxvdygpKQot ICAgICAgICAgICAgY2hpbGQtPnNldE1hcmdpblRvcChtYXJnaW4pOwotICAgICAgICBlbHNlCi0g ICAgICAgICAgICBjaGlsZC0+c2V0TWFyZ2luQm90dG9tKG1hcmdpbik7Ci0gICAgfQotfQotCi12 b2lkIFJlbmRlckZsZXhpYmxlQm94OjpzZXRGbG93QXdhcmVNYXJnaW5FbmRGb3JDaGlsZChSZW5k ZXJCb3gqIGNoaWxkLCBMYXlvdXRVbml0IG1hcmdpbikKLXsKLSAgICBpZiAoaXNIb3Jpem9udGFs RmxvdygpKSB7Ci0gICAgICAgIGlmIChpc0xlZnRUb1JpZ2h0RmxvdygpKQotICAgICAgICAgICAg Y2hpbGQtPnNldE1hcmdpblJpZ2h0KG1hcmdpbik7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAg IGNoaWxkLT5zZXRNYXJnaW5MZWZ0KG1hcmdpbik7Ci0gICAgfSBlbHNlIHsKLSAgICAgICAgaWYg KGlzTGVmdFRvUmlnaHRGbG93KCkpCi0gICAgICAgICAgICBjaGlsZC0+c2V0TWFyZ2luQm90dG9t KG1hcmdpbik7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIGNoaWxkLT5zZXRNYXJnaW5Ub3Ao bWFyZ2luKTsKLSAgICB9Ci19Ci0KIHZvaWQgUmVuZGVyRmxleGlibGVCb3g6OnNldEZsb3dBd2Fy ZUxvY2F0aW9uRm9yQ2hpbGQoUmVuZGVyQm94KiBjaGlsZCwgY29uc3QgTGF5b3V0UG9pbnQmIGxv Y2F0aW9uKQogewogICAgIGlmIChpc0hvcml6b250YWxGbG93KCkpCkBAIC00NzMsMjAgKzQ0Myw2 IEBAIExheW91dFVuaXQgUmVuZGVyRmxleGlibGVCb3g6Om1haW5BeGlzU2Nyb2xsYmFyRXh0ZW50 Rm9yQ2hpbGQoUmVuZGVyQm94KiBjaGlsZCkKICAgICByZXR1cm4gaXNIb3Jpem9udGFsRmxvdygp ID8gY2hpbGQtPnZlcnRpY2FsU2Nyb2xsYmFyV2lkdGgoKSA6IGNoaWxkLT5ob3Jpem9udGFsU2Ny b2xsYmFySGVpZ2h0KCk7CiB9CiAKLUxlbmd0aCBSZW5kZXJGbGV4aWJsZUJveDo6bWFyZ2luU3Rh cnRTdHlsZUZvckNoaWxkKFJlbmRlckJveCogY2hpbGQpIGNvbnN0Ci17Ci0gICAgaWYgKGlzSG9y aXpvbnRhbEZsb3coKSkKLSAgICAgICAgcmV0dXJuIGlzTGVmdFRvUmlnaHRGbG93KCkgPyBjaGls ZC0+c3R5bGUoKS0+bWFyZ2luTGVmdCgpIDogY2hpbGQtPnN0eWxlKCktPm1hcmdpblJpZ2h0KCk7 Ci0gICAgcmV0dXJuIGlzTGVmdFRvUmlnaHRGbG93KCkgPyBjaGlsZC0+c3R5bGUoKS0+bWFyZ2lu VG9wKCkgOiBjaGlsZC0+c3R5bGUoKS0+bWFyZ2luQm90dG9tKCk7Ci19Ci0KLUxlbmd0aCBSZW5k ZXJGbGV4aWJsZUJveDo6bWFyZ2luRW5kU3R5bGVGb3JDaGlsZChSZW5kZXJCb3gqIGNoaWxkKSBj b25zdAotewotICAgIGlmIChpc0hvcml6b250YWxGbG93KCkpCi0gICAgICAgIHJldHVybiBpc0xl ZnRUb1JpZ2h0RmxvdygpID8gY2hpbGQtPnN0eWxlKCktPm1hcmdpblJpZ2h0KCkgOiBjaGlsZC0+ c3R5bGUoKS0+bWFyZ2luTGVmdCgpOwotICAgIHJldHVybiBpc0xlZnRUb1JpZ2h0RmxvdygpID8g Y2hpbGQtPnN0eWxlKCktPm1hcmdpbkJvdHRvbSgpIDogY2hpbGQtPnN0eWxlKCktPm1hcmdpblRv cCgpOwotfQotCiBMYXlvdXRVbml0IFJlbmRlckZsZXhpYmxlQm94OjpwcmVmZXJyZWRNYWluQXhp c0NvbnRlbnRFeHRlbnRGb3JGbGV4SXRlbShSZW5kZXJCb3gqIGNoaWxkKSBjb25zdAogewogICAg IExlbmd0aCBtYWluQXhpc0xlbmd0aCA9IG1haW5BeGlzTGVuZ3RoRm9yQ2hpbGQoY2hpbGQpOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94Lmgg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guaAppbmRleCA0YzA3 NDgzMGI3ZWUzOWZmOWVhOTVhNDIzMTIwYjk1M2U0YzBlMTg5Li42NmQ4MjYwYjA1NjZmNmQ2N2Qw ZWNmOTUzNGFjMmYwZDZkNDI1ZjQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyRmxleGlibGVCb3guaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyRmxleGlibGVCb3guaApAQCAtNzgsMTUgKzc4LDExIEBAIHByaXZhdGU6CiAgICAgTGF5b3V0 VW5pdCBmbG93QXdhcmVNYXJnaW5BZnRlckZvckNoaWxkKFJlbmRlckJveCogY2hpbGQpIGNvbnN0 OwogICAgIExheW91dFVuaXQgY3Jvc3NBeGlzTWFyZ2luRXh0ZW50Rm9yQ2hpbGQoUmVuZGVyQm94 KiBjaGlsZCkgY29uc3Q7CiAgICAgTGF5b3V0UG9pbnQgZmxvd0F3YXJlTG9jYXRpb25Gb3JDaGls ZChSZW5kZXJCb3gqIGNoaWxkKSBjb25zdDsKLSAgICB2b2lkIHNldEZsb3dBd2FyZU1hcmdpblN0 YXJ0Rm9yQ2hpbGQoUmVuZGVyQm94KiBjaGlsZCwgTGF5b3V0VW5pdCk7Ci0gICAgdm9pZCBzZXRG bG93QXdhcmVNYXJnaW5FbmRGb3JDaGlsZChSZW5kZXJCb3gqIGNoaWxkLCBMYXlvdXRVbml0KTsK ICAgICAvLyBGSVhNRTogU3VwcG9ydGluZyBsYXlvdXQgZGVsdGFzLgogICAgIHZvaWQgc2V0Rmxv d0F3YXJlTG9jYXRpb25Gb3JDaGlsZChSZW5kZXJCb3gqIGNoaWxkLCBjb25zdCBMYXlvdXRQb2lu dCYpOwogICAgIHZvaWQgYWRqdXN0QWxpZ25tZW50Rm9yQ2hpbGQoUmVuZGVyQm94KiBjaGlsZCwg TGF5b3V0VW5pdCk7CiAgICAgTGF5b3V0VW5pdCBtYWluQXhpc0JvcmRlckFuZFBhZGRpbmdFeHRl bnRGb3JDaGlsZChSZW5kZXJCb3gqIGNoaWxkKSBjb25zdDsKICAgICBMYXlvdXRVbml0IG1haW5B eGlzU2Nyb2xsYmFyRXh0ZW50Rm9yQ2hpbGQoUmVuZGVyQm94KiBjaGlsZCkgY29uc3Q7Ci0gICAg TGVuZ3RoIG1hcmdpblN0YXJ0U3R5bGVGb3JDaGlsZChSZW5kZXJCb3gqIGNoaWxkKSBjb25zdDsK LSAgICBMZW5ndGggbWFyZ2luRW5kU3R5bGVGb3JDaGlsZChSZW5kZXJCb3gqIGNoaWxkKSBjb25z dDsKICAgICBMYXlvdXRVbml0IHByZWZlcnJlZE1haW5BeGlzQ29udGVudEV4dGVudEZvckZsZXhJ dGVtKFJlbmRlckJveCogY2hpbGQpIGNvbnN0OwogCiAgICAgdm9pZCBsYXlvdXRGbGV4SXRlbXMo Ym9vbCByZWxheW91dENoaWxkcmVuKTsK