73352 2011-11-29 12:52:29 -0800 Use contentsToRootView when converting the mouse coordinates for the context menu key event 2011-11-29 13:30:35 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 71945 1 andersca andersca aroben oldest_to_newest 511024 0 andersca 2011-11-29 12:52:29 -0800 Use contentsToRootView when converting the mouse coordinate for the context menu key event 511025 1 117026 andersca 2011-11-29 12:53:21 -0800 Created attachment 117026 Patch 511026 2 117026 aroben 2011-11-29 12:53:48 -0800 Comment on attachment 117026 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117026&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) Why not? 511027 3 aroben 2011-11-29 12:54:14 -0800 What is the symptom this patch fixes? Your bug title should describe it. 511035 4 andersca 2011-11-29 13:07:50 -0800 (In reply to comment #2) > (From update of attachment 117026 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=117026&action=review > > > Source/WebCore/ChangeLog:8 > > + No new tests. (OOPS!) > > Why not? This should already be covered by existing tests. (In reply to comment #3) > What is the symptom this patch fixes? Your bug title should describe it. Another part of https://bugs.webkit.org/show_bug.cgi?id=71945 - I'll relate the bugs and put the info in the change log. 511052 5 117033 andersca 2011-11-29 13:23:00 -0800 Created attachment 117033 Patch 511053 6 117033 aroben 2011-11-29 13:23:48 -0800 Comment on attachment 117033 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117033&action=review > Source/WebCore/ChangeLog:12 > + Use contentsToRootView when converting the mouse coordinates for the context menu key event > + https://bugs.webkit.org/show_bug.cgi?id=73352 > + > + Reviewed by NOBODY (OOPS!). > + > + This is another step towards fixing https://bugs.webkit.org/show_bug.cgi?id=71945, by getting > + rid of a call to ScrollView::contentsToWindow. > + > + * page/EventHandler.cpp: > + (WebCore::EventHandler::sendContextMenuEventForKey): You should mention why you haven't modified/added any tests. 511066 7 andersca 2011-11-29 13:30:35 -0800 Committed r101416: <http://trac.webkit.org/changeset/101416> 117026 2011-11-29 12:53:21 -0800 2011-11-29 13:22:57 -0800 Patch bug-73352-20111129125423.patch text/plain 1574 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxNDAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2VlMmJjMzBkOWVmOTI2 MjUxZDVmMGI5MWExMzBlNTIzNmYxMjI0MS4uYzIzMzY1YzBiNGY2MTZlOWE1MzU2NTIzZGU3YjE3 ZmExMDM2NzFmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTExLTI5ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIGNvbnRlbnRz VG9Sb290VmlldyB3aGVuIGNvbnZlcnRpbmcgdGhlIG1vdXNlIGNvb3JkaW5hdGVzIGZvciB0aGUg Y29udGV4dCBtZW51IGtleSBldmVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NzMzNTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAgICAqIHBhZ2UvRXZl bnRIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6c2VuZENvbnRl eHRNZW51RXZlbnRGb3JLZXkpOgorCiAyMDExLTExLTE1ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRl cnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgRHJhZ0NsaWVudDo6ZHJhZ1NvdXJjZUFjdGlvbk1h c2tGb3JQb2ludCBzaG91bGQgdXNlIHJvb3QgdmlldyBjb29yZGluYXRlcwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9FdmVudEhhbmRsZXIuY3BwCmluZGV4IDUwOTBmYWE1ZmNmMTdmMzM4MTdkZDE4YjA5OTY4OTdm ODM4NjE0MWQuLjIxMzg1MTUxMWE1ZjhmZGVlMWE3NzU3MjBlN2NkODg4YzBkMWI3YzkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKQEAgLTIzNDMsOCArMjM0Myw4IEBAIGJvb2wg RXZlbnRIYW5kbGVyOjpzZW5kQ29udGV4dE1lbnVFdmVudEZvcktleSgpCiAKICAgICBtX2ZyYW1l LT52aWV3KCktPnNldEN1cnNvcihwb2ludGVyQ3Vyc29yKCkpOwogCi0gICAgSW50UG9pbnQgcG9z aXRpb24gPSB2aWV3LT5jb250ZW50c1RvV2luZG93KGxvY2F0aW9uKTsKLSAgICBJbnRQb2ludCBn bG9iYWxQb3NpdGlvbiA9IHZpZXctPmNvbnRlbnRzVG9TY3JlZW4oSW50UmVjdChsb2NhdGlvbiwg SW50U2l6ZSgpKSkubG9jYXRpb24oKTsKKyAgICBJbnRQb2ludCBwb3NpdGlvbiA9IHZpZXctPmNv bnRlbnRzVG9Sb290Vmlldyhsb2NhdGlvbik7CisgICAgSW50UG9pbnQgZ2xvYmFsUG9zaXRpb24g PSB2aWV3LT5ob3N0V2luZG93KCktPnJvb3RWaWV3VG9TY3JlZW4oSW50UmVjdChwb3NpdGlvbiwg SW50U2l6ZSgpKSkubG9jYXRpb24oKTsKIAogICAgIE5vZGUqIHRhcmdldE5vZGUgPSBkb2MtPmZv Y3VzZWROb2RlKCk7CiAgICAgaWYgKCF0YXJnZXROb2RlKQo= 117033 2011-11-29 13:23:00 -0800 2011-11-29 13:23:48 -0800 Patch bug-73352-20111129132402.patch text/plain 1702 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxNDAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2VlMmJjMzBkOWVmOTI2 MjUxZDVmMGI5MWExMzBlNTIzNmYxMjI0MS4uNDA5ZTRiN2Y3NjNmZTgwZTRiNjc4MGEzMjU1MmJh NzhkMjk3NTk0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTExLTI5ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIGNvbnRlbnRz VG9Sb290VmlldyB3aGVuIGNvbnZlcnRpbmcgdGhlIG1vdXNlIGNvb3JkaW5hdGVzIGZvciB0aGUg Y29udGV4dCBtZW51IGtleSBldmVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NzMzNTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGlzIGlzIGFub3RoZXIgc3RlcCB0b3dhcmRzIGZpeGluZyBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE5NDUsIGJ5IGdldHRpbmcKKyAgICAg ICAgcmlkIG9mIGEgY2FsbCB0byBTY3JvbGxWaWV3Ojpjb250ZW50c1RvV2luZG93LgorCisgICAg ICAgICogcGFnZS9FdmVudEhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5k bGVyOjpzZW5kQ29udGV4dE1lbnVFdmVudEZvcktleSk6CisKIDIwMTEtMTEtMTUgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBEcmFnQ2xpZW50OjpkcmFn U291cmNlQWN0aW9uTWFza0ZvclBvaW50IHNob3VsZCB1c2Ugcm9vdCB2aWV3IGNvb3JkaW5hdGVz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKaW5kZXggNTA5MGZhYTVmY2YxN2YzMzgx N2RkMThiMDk5Njg5N2Y4Mzg2MTQxZC4uMjEzODUxNTExYTVmOGZkZWUxYTc3NTcyMGU3Y2Q4ODhj MGQxYjdjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcApAQCAtMjM0Myw4ICsy MzQzLDggQEAgYm9vbCBFdmVudEhhbmRsZXI6OnNlbmRDb250ZXh0TWVudUV2ZW50Rm9yS2V5KCkK IAogICAgIG1fZnJhbWUtPnZpZXcoKS0+c2V0Q3Vyc29yKHBvaW50ZXJDdXJzb3IoKSk7CiAKLSAg ICBJbnRQb2ludCBwb3NpdGlvbiA9IHZpZXctPmNvbnRlbnRzVG9XaW5kb3cobG9jYXRpb24pOwot ICAgIEludFBvaW50IGdsb2JhbFBvc2l0aW9uID0gdmlldy0+Y29udGVudHNUb1NjcmVlbihJbnRS ZWN0KGxvY2F0aW9uLCBJbnRTaXplKCkpKS5sb2NhdGlvbigpOworICAgIEludFBvaW50IHBvc2l0 aW9uID0gdmlldy0+Y29udGVudHNUb1Jvb3RWaWV3KGxvY2F0aW9uKTsKKyAgICBJbnRQb2ludCBn bG9iYWxQb3NpdGlvbiA9IHZpZXctPmhvc3RXaW5kb3coKS0+cm9vdFZpZXdUb1NjcmVlbihJbnRS ZWN0KHBvc2l0aW9uLCBJbnRTaXplKCkpKS5sb2NhdGlvbigpOwogCiAgICAgTm9kZSogdGFyZ2V0 Tm9kZSA9IGRvYy0+Zm9jdXNlZE5vZGUoKTsKICAgICBpZiAoIXRhcmdldE5vZGUpCg==