73344 2011-11-29 11:28:01 -0800 [chromium] TextureManager LRU list is not fully honor the order tiles are used 2011-11-30 18:49:10 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 klobag klobag cc-bugs enne jamesr vangelis webkit.review.bot oldest_to_newest 510946 0 klobag 2011-11-29 11:28:01 -0800 Currently TextureManager moves a texture to the end of the list if hasTexture() is called. In the threaded compositing mode, TiledLayerChromium maintains a HashMap of tiles. In TiledLayerChromium::pushPropertiesTo(), it walks through all the tiles in the HashMap and check whether they are valid which calls hasTexture(). This means the order in the TextureManager's LRU list is affected by the order of the tile in the TiledLayerChromium's HashMap. e.g. when a page is scrolled down, we expect the furthest from the new revealed tiles will be reclaimed. Currently some tile in the middle can be reclaimed. The proposed fix is to only move a texture to the end of the list if protectTexture() is called. 511137 1 117052 klobag 2011-11-29 15:03:17 -0800 Created attachment 117052 Patch 511220 2 117052 jamesr 2011-11-29 16:50:18 -0800 Comment on attachment 117052 Patch Looks reasonable, although a test would be nice. Enne? 511966 3 enne 2011-11-30 11:42:07 -0800 This seems like a great change. That would certainly explain the "MRU"-like behavior that we've sometimes seen when scrolling. 512224 4 117052 jamesr 2011-11-30 16:34:08 -0800 Comment on attachment 117052 Patch R=me then 512226 5 jamesr 2011-11-30 16:34:59 -0800 Also if someone is feeling really ambitious and wants to write some unit tests for TextureManager's LRU-ness that would be awesome. I probably should have done this ages ago, but haven't got around to it :/ 512328 6 117052 webkit.review.bot 2011-11-30 18:49:05 -0800 Comment on attachment 117052 Patch Clearing flags on attachment: 117052 Committed r101586: <http://trac.webkit.org/changeset/101586> 512329 7 webkit.review.bot 2011-11-30 18:49:10 -0800 All reviewed patches have been landed. Closing bug. 117052 2011-11-29 15:03:17 -0800 2011-11-30 18:49:05 -0800 Patch bug-73344-20111129150316.patch text/plain 2147 klobag U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxNDA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTU5ODgwMGEyOWFkMjI5 YjNkYWZjODRhNzdiNmQ4ZTJiZjgyMTlhYi4uODJiZmY0YzU1M2IwMTQ4MjA2ZmIzNTE3MmU0M2M1 OWUxM2UxZjY2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTExLTI5ICBHcmFj ZSBLbG9iYSAgPGtsb2JhZ0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBUZXh0 dXJlTWFuYWdlciBMUlUgbGlzdCBpcyBub3QgZnVsbHkgaG9ub3IgdGhlIG9yZGVyIHRpbGVzIGFy ZSB1c2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03 MzM0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJl b3JkZXIgdGhlIHRleHR1cmUgaW4gdGhlIExSVSBsaXN0IG9ubHkgd2hlbiBwcm90ZWN0VGV4dHVy ZSgpIGlzIGNhbGxlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1Rl eHR1cmVNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHR1cmVNYW5hZ2VyOjpoYXNU ZXh0dXJlKToKKyAgICAgICAgKFdlYkNvcmU6OlRleHR1cmVNYW5hZ2VyOjpwcm90ZWN0VGV4dHVy ZSk6CisKIDIwMTEtMTEtMjggIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgQ3Jhc2ggaW4gSXNvbGF0ZVRyYWNrZXI6OmFkZEZha2VSdW5JZk5lY2Vzc2FyeSgpLCBw cmVjZWRlZCBieSBhc3NlcnRpb24gZmFpbHVyZSAobV9uZXN0ZWRJc29sYXRlQ291bnQgPj0gMSkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1Rl eHR1cmVNYW5hZ2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL1RleHR1cmVNYW5hZ2VyLmNwcAppbmRleCBjNjAwZDllNjQ5MWQ3ZDFlNzU3MjIyMTRlMzE5 ZGE3ZjBjMTg4NGNlLi5hZWI2ODY2OTYxYjliYTQ0ZDc3NTJjNWQ0YjM5Y2MxNjA3YTdiODIxIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9UZXh0 dXJlTWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hy b21pdW0vVGV4dHVyZU1hbmFnZXIuY3BwCkBAIC04OSwxMyArODksNyBAQCB2b2lkIFRleHR1cmVN YW5hZ2VyOjpyZWxlYXNlVG9rZW4oVGV4dHVyZVRva2VuIHRva2VuKQogCiBib29sIFRleHR1cmVN YW5hZ2VyOjpoYXNUZXh0dXJlKFRleHR1cmVUb2tlbiB0b2tlbikKIHsKLSAgICBpZiAobV90ZXh0 dXJlcy5jb250YWlucyh0b2tlbikpIHsKLSAgICAgICAgLy8gSWYgc29tZW9uZSBhc2tzIGFib3V0 IGEgdGV4dHVyZSBwdXQgaXQgYXQgdGhlIGVuZCBvZiB0aGUgTFJVIGxpc3QuCi0gICAgICAgIG1f dGV4dHVyZUxSVVNldC5yZW1vdmUodG9rZW4pOwotICAgICAgICBtX3RleHR1cmVMUlVTZXQuYWRk KHRva2VuKTsKLSAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgfQotICAgIHJldHVybiBmYWxzZTsK KyAgICByZXR1cm4gbV90ZXh0dXJlcy5jb250YWlucyh0b2tlbik7CiB9CiAKIGJvb2wgVGV4dHVy ZU1hbmFnZXI6OmlzUHJvdGVjdGVkKFRleHR1cmVUb2tlbiB0b2tlbikKQEAgLTExMCw2ICsxMDQs OSBAQCB2b2lkIFRleHR1cmVNYW5hZ2VyOjpwcm90ZWN0VGV4dHVyZShUZXh0dXJlVG9rZW4gdG9r ZW4pCiAgICAgVGV4dHVyZUluZm8gaW5mbyA9IG1fdGV4dHVyZXMudGFrZSh0b2tlbik7CiAgICAg aW5mby5pc1Byb3RlY3RlZCA9IHRydWU7CiAgICAgbV90ZXh0dXJlcy5hZGQodG9rZW4sIGluZm8p OworICAgIC8vIElmIHNvbWVvbmUgcHJvdGVjdHMgYSB0ZXh0dXJlLCBwdXQgaXQgYXQgdGhlIGVu ZCBvZiB0aGUgTFJVIGxpc3QuCisgICAgbV90ZXh0dXJlTFJVU2V0LnJlbW92ZSh0b2tlbik7Cisg ICAgbV90ZXh0dXJlTFJVU2V0LmFkZCh0b2tlbik7CiB9CiAKIHZvaWQgVGV4dHVyZU1hbmFnZXI6 OnVucHJvdGVjdFRleHR1cmUoVGV4dHVyZVRva2VuIHRva2VuKQo=