73343 2011-11-29 11:26:34 -0800 Clean up fast/regions/no-split-line-box.html test 2011-11-29 13:31:54 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Minor --- 1 stearns stearns tony oldest_to_newest 510945 0 stearns 2011-11-29 11:26:34 -0800 There are two errors in the test. The first is extra lines of text (which became an issue after the region-overflow property was added) and the second is that pixel snapshotting was erroneously turned on. 510990 1 117019 stearns 2011-11-29 12:19:00 -0800 Created attachment 117019 modify test, delete .pngs 510995 2 117019 tony 2011-11-29 12:22:20 -0800 Comment on attachment 117019 modify test, delete .pngs The -expected.txt file doesn't change from the deleted text? 510998 3 stearns 2011-11-29 12:27:09 -0800 Nope - when the test runs in the test harness, all the content gets replaced with "PASS" if the javascript check succeeds. You only see the layout and test description if you run outside of the test harness. 511041 4 tony 2011-11-29 13:12:02 -0800 The patch doesn't apply (click on the purple boxes) so we can't cq the patch. I'll land manually for you. 511068 5 tony 2011-11-29 13:31:54 -0800 Committed r101417: <http://trac.webkit.org/changeset/101417> 117019 2011-11-29 12:19:00 -0800 2011-11-29 13:27:55 -0800 modify test, delete .pngs 73343.patch text/plain 2242 stearns ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4YmY1M2MyLi4zZDhhNWEwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMTEt MjkgIEFsYW4gU3RlYXJucyAgPHN0ZWFybnNAYWRvYmUuY29tPgorCisgICAgICAgIENsZWFuIHVw IGZhc3QvcmVnaW9ucy9uby1zcGxpdC1saW5lLWJveC5odG1sIHRlc3QKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczMzQzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L3JlZ2lvbnMvbm8tc3BsaXQt bGluZS1ib3guaHRtbDoKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvZmFzdC9yZWdpb25zL25vLXNw bGl0LWxpbmUtYm94LWV4cGVjdGVkLnBuZzogUmVtb3ZlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9t YWMvZmFzdC9yZWdpb25zL25vLXNwbGl0LWxpbmUtYm94LWV4cGVjdGVkLnBuZzogUmVtb3ZlZC4K KwogMjAxMS0xMS0yOSAgWGlhb21laSBKaSAgPHhqaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmViYXNlIGFmdGVyIHIxMDA4MTkuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lv bnMvbm8tc3BsaXQtbGluZS1ib3guaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9uby1z cGxpdC1saW5lLWJveC5odG1sCmluZGV4IDc0NzJjZmIuLjY5Mzg0ODcgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9uby1zcGxpdC1saW5lLWJveC5odG1sCisrKyBiL0xheW91 dFRlc3RzL2Zhc3QvcmVnaW9ucy9uby1zcGxpdC1saW5lLWJveC5odG1sCkBAIC0yOSw3ICsyOSw3 IEBACiAgIDxkaXYgY2xhc3M9ImRpdmlkZXIiPjwvZGl2PiAKICAgPGRpdiBpZD0ic2Vjb25kUmVn aW9uIiBjbGFzcz0icmVnaW9uIj48L2Rpdj4gCiAgIDxkaXYgY2xhc3M9ImFydGljbGUiPiAKLSAg ICBtbm9wcXIgbW5vcHFyIDxzcGFuIGlkPSJ0ZXN0U3BhbiI+bTwvc3Bhbj5ub3BxciBtbm9wcXIg bW5vcHFyIG1ub3BxcgorICAgIG1ub3BxciBtbm9wcXIgPHNwYW4gaWQ9InRlc3RTcGFuIj5tPC9z cGFuPm5vcHFyIG1ub3BxcgogICA8L2Rpdj4KICAgPHAgY2xhc3M9ImRlc2NyaXB0aW9uIj5UaGUg dHdvIHJlZ2lvbnMgb24gZWl0aGVyIHNpZGUgb2YgdGhlIGRpdmlkZXIgc2hvdWxkIGVhY2ggaGF2 ZSB0d28gdGV4dCBsaW5lcy48L3A+CiAgIDxwIGNsYXNzPSJkZXNjcmlwdGlvbiI+VGhlcmUgc2hv dWxkIGJlIG5vIHRleHQgbGluZSBzcGxpdCBiZXR3ZWVuIHRoZSByZWdpb25zLjwvcD4KQEAgLTM5 LDcgKzM5LDcgQEAKIAogPHNjcmlwdD4KICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxl cikKLSAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KHRydWUpOworICAgIGxheW91 dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKICAgICAKICAgdmFyIHRlc3RFbGVtZW50ID0g ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3RTcGFuIikKICAgdmFyIHRlc3RSZWN0ID0gdGVz dEVsZW1lbnQuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9lZmwvZmFzdC9yZWdpb25zL25vLXNwbGl0LWxpbmUtYm94LWV4cGVjdGVkLnBu ZyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9mYXN0L3JlZ2lvbnMvbm8tc3BsaXQtbGluZS1i b3gtZXhwZWN0ZWQucG5nCmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCA2MjI2MmEzLi4w MDAwMDAwCkJpbmFyeSBmaWxlcyBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9mYXN0L3JlZ2lv bnMvbm8tc3BsaXQtbGluZS1ib3gtZXhwZWN0ZWQucG5nIGFuZCAvZGV2L251bGwgZGlmZmVyCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9yZWdpb25zL25vLXNwbGl0 LWxpbmUtYm94LWV4cGVjdGVkLnBuZyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3Jl Z2lvbnMvbm8tc3BsaXQtbGluZS1ib3gtZXhwZWN0ZWQucG5nCmRlbGV0ZWQgZmlsZSBtb2RlIDEw MDY0NAppbmRleCA4MTFmNzA1Li4wMDAwMDAwCkJpbmFyeSBmaWxlcyBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL21hYy9mYXN0L3JlZ2lvbnMvbm8tc3BsaXQtbGluZS1ib3gtZXhwZWN0ZWQucG5nIGFu ZCAvZGV2L251bGwgZGlmZmVyCg==